[{"id":35087,"web_url":"https://patchwork.libcamera.org/comment/35087/","msgid":"","date":"2025-07-24T09:08:42","subject":"Re: [PATCH 0/3] Add vd56g3 support for rpi and libipa","submitter":{"id":227,"url":"https://patchwork.libcamera.org/api/people/227/","name":"Benjamin Mugnier","email":"benjamin.mugnier@foss.st.com"},"content":"Hi everyone,\n\nOn 6/20/25 15:49, Benjamin Mugnier wrote:\n> Following our discussion with Kieran and Naushir at the libcamera\n> workshop, here is the vd56g3 support for libcamera.\n> \n> This series has been developed originally on the Raspberry Pi libcamera\n> fork and tested on rpi4 and rpi5. Then rebased on mainline and tested\n> again on rpi4 and rpi5 with the mainline rp1-cfe driver.\n> \n> The libipa part has not been tested yet, but changes are rather trivial.\n> If you see any issues with that, please don't hesitate to remove the\n> patch from the series.\n> \n> To: libcamera-devel@lists.libcamera.org\n> CC: Naushir Patuck \n> CC: Kieran Bingham \n> CC: Sylvain Petinot \n> CC: Cyril Liotard \n> CC: Jean Poire \n> \n> Signed-off-by: Benjamin Mugnier \n\nIs everything okay with this patch set ?\n\n> ---\n> Benjamin Mugnier (3):\n> libcamera: camera_sensor_properties: Add vd56g3 camera sensor\n> ipa: rpi: Add vd56g3 support for rpi\n> libcamera: libipa: Add vd56g3 support for libipa\n> \n> src/ipa/libipa/camera_sensor_helper.cpp | 12 +\n> src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp | 54 +\n> src/ipa/rpi/cam_helper/meson.build | 1 +\n> src/ipa/rpi/pisp/data/meson.build | 2 +\n> src/ipa/rpi/pisp/data/vd56g3.json | 1293 +++++++++++++++++++++\n> src/ipa/rpi/pisp/data/vd56g3_mono.json | 1155 ++++++++++++++++++\n> src/ipa/rpi/vc4/data/meson.build | 2 +\n> src/ipa/rpi/vc4/data/vd56g3.json | 417 +++++++\n> src/ipa/rpi/vc4/data/vd56g3_mono.json | 290 +++++\n> src/libcamera/sensor/camera_sensor_properties.cpp | 21 +\n> 10 files changed, 3247 insertions(+)\n> ---\n> base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316\n> change-id: 20250620-vd56g3_support-029e40405468\n> \n> Best regards,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2026C3237\n\tfor ;\n\tThu, 24 Jul 2025 09:09:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D43B690C1;\n\tThu, 24 Jul 2025 11:09:31 +0200 (CEST)","from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com\n\t[185.132.182.106])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB578690BC\n\tfor ;\n\tThu, 24 Jul 2025 11:09:29 +0200 (CEST)","from pps.filterd (m0241204.ppops.net [127.0.0.1])\n\tby mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n\t56O98Qoc008806; Thu, 24 Jul 2025 11:09:29 +0200","from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35])\n\tby mx07-00178001.pphosted.com (PPS) with ESMTPS id 4802q2gjse-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Thu, 24 Jul 2025 11:09:28 +0200 (MEST)","from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20])\n\tby beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 164C640064; \n\tThu, 24 Jul 2025 11:08:45 +0200 (CEST)","from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69])\n\tby euls16034.sgp.st.com (STMicroelectronics) with ESMTP id\n\t08C3C768F4A; Thu, 24 Jul 2025 11:08:44 +0200 (CEST)","from [10.252.19.89] (10.252.19.89) by SHFDAG1NODE1.st.com\n\t(10.75.129.69) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39;\n\tThu, 24 Jul 2025 11:08:43 +0200"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=foss.st.com header.i=@foss.st.com\n\theader.b=\"DZH8oJX3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=selector1; bh=\n\tzUAzYna6+yPGX4Wsa2DZGuA2G0Bm51Ct7x0cWNjax/8=; b=DZH8oJX3e9hVzXqD\n\txbhLRJ5nXV5m5pE2qbNEnjAP28HF1B2EkP5Ru9KMoyrniXNWa8Evkj/lFBVfGZqE\n\tdypOy2j0n1S5QKNNrS8h87rBrmhGxFVkdXdQrYNgu7EmJ9jgX89BuRLv2I18QH2t\n\tDkclwhsPBVMm90oMvNuE8qXZUz3epzlbV6kBJGAPV4QXcF/c/S5uwgSKVbvfzvW3\n\txWwb0lcCxV1DtfhqePTPTajK41xhaX7/ygYHfndRIMdq0P137xrCrYmMEMI67uAH\n\tBj3aXfhLWeF0TWoq7Sa1cToJKKFY33QklNLlz30aqdaWulqVfvm1CEmeGySy3mH/\n\tO1fI9A==","Message-ID":"","Date":"Thu, 24 Jul 2025 11:08:42 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 0/3] Add vd56g3 support for rpi and libipa","To":"","CC":"Naushir Patuck , Kieran Bingham\n\t, Sylvain Petinot\n\t, Cyril Liotard ,\n\t\"Jean Poire\" ","References":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>","Content-Language":"en-US","From":"Benjamin Mugnier ","In-Reply-To":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.252.19.89]","X-ClientProxiedBy":"SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com\n\t(10.75.129.69)","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1099, Hydra:6.1.9,\n\tFMLib:17.12.80.40\n\tdefinitions=2025-07-24_01,2025-07-23_01,2025-03-28_01","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35091,"web_url":"https://patchwork.libcamera.org/comment/35091/","msgid":"","date":"2025-07-24T09:22:38","subject":"Re: [PATCH 0/3] Add vd56g3 support for rpi and libipa","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Benjamin,\n\nOn Thu, 24 Jul 2025 at 10:09, Benjamin Mugnier\n wrote:\n>\n> Hi everyone,\n>\n> On 6/20/25 15:49, Benjamin Mugnier wrote:\n> > Following our discussion with Kieran and Naushir at the libcamera\n> > workshop, here is the vd56g3 support for libcamera.\n> >\n> > This series has been developed originally on the Raspberry Pi libcamera\n> > fork and tested on rpi4 and rpi5. Then rebased on mainline and tested\n> > again on rpi4 and rpi5 with the mainline rp1-cfe driver.\n> >\n> > The libipa part has not been tested yet, but changes are rather trivial.\n> > If you see any issues with that, please don't hesitate to remove the\n> > patch from the series.\n> >\n> > To: libcamera-devel@lists.libcamera.org\n> > CC: Naushir Patuck \n> > CC: Kieran Bingham \n> > CC: Sylvain Petinot \n> > CC: Cyril Liotard \n> > CC: Jean Poire \n> >\n> > Signed-off-by: Benjamin Mugnier \n>\n> Is everything okay with this patch set ?\n\nSorry - this slipped off my radar. I'll add some tags today!\n\nNaush\n\n\n>\n> > ---\n> > Benjamin Mugnier (3):\n> > libcamera: camera_sensor_properties: Add vd56g3 camera sensor\n> > ipa: rpi: Add vd56g3 support for rpi\n> > libcamera: libipa: Add vd56g3 support for libipa\n> >\n> > src/ipa/libipa/camera_sensor_helper.cpp | 12 +\n> > src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp | 54 +\n> > src/ipa/rpi/cam_helper/meson.build | 1 +\n> > src/ipa/rpi/pisp/data/meson.build | 2 +\n> > src/ipa/rpi/pisp/data/vd56g3.json | 1293 +++++++++++++++++++++\n> > src/ipa/rpi/pisp/data/vd56g3_mono.json | 1155 ++++++++++++++++++\n> > src/ipa/rpi/vc4/data/meson.build | 2 +\n> > src/ipa/rpi/vc4/data/vd56g3.json | 417 +++++++\n> > src/ipa/rpi/vc4/data/vd56g3_mono.json | 290 +++++\n> > src/libcamera/sensor/camera_sensor_properties.cpp | 21 +\n> > 10 files changed, 3247 insertions(+)\n> > ---\n> > base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316\n> > change-id: 20250620-vd56g3_support-029e40405468\n> >\n> > Best regards,\n>\n> --\n> Regards,\n> Benjamin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0777C3237\n\tfor ;\n\tThu, 24 Jul 2025 09:23:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E01F690CF;\n\tThu, 24 Jul 2025 11:23:18 +0200 (CEST)","from mail-ua1-x933.google.com (mail-ua1-x933.google.com\n\t[IPv6:2607:f8b0:4864:20::933])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54690690BC\n\tfor ;\n\tThu, 24 Jul 2025 11:23:16 +0200 (CEST)","by mail-ua1-x933.google.com with SMTP id\n\ta1e0cc1a2514c-87ed6d59f9aso39436241.0\n\tfor ;\n\tThu, 24 Jul 2025 02:23:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"TJocr0hS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1753348995; x=1753953795;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=WQgw6gljBKAP/h/f+5M6x52e3zm8Q6mRUJb0433Xflc=;\n\tb=TJocr0hSpDOtgEhieLKvxmnesI+5OA+4ieeqIkQ31ZQyBy3NPZZeHW77APPvpQwYkq\n\tPj9PVzzDj0zyEZZ7uLWYLMPNYTxSPjx5hNBo2BWjY40c4fV84n+69d5ZMxuiJrjKhNPp\n\tnLYlzEDz8R7scYiUl9NYg8snywef3R5sKZ2yjgAgQso7U7EiCer5WsPY7You78FZm0Yv\n\tn1tyul9YUAuvUv538c/HnGlDcmT4n0be/IRYmpmAs70EMwBkct3+2MixEsO1Be8jR8Op\n\tQ1m7kzzWzAwkhMnDscZmr8JFh2iI9kR0t/eFJvaILa3goJfIxEjjnAxz1xTChzBOSqFQ\n\t0EDA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1753348995; x=1753953795;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=WQgw6gljBKAP/h/f+5M6x52e3zm8Q6mRUJb0433Xflc=;\n\tb=rbND+ZedVKv3HRhI8A8mLWHFu7uwf7ZS0OpsKxia6BN3Q40HcsNaZKsNozHvIDkuHz\n\tAWOpMZnGiqQ3AwrpZtNq6t6M+WVgMBScgFw7WYB+0sitqatT6I3oviwDQKtSWs20CNMz\n\tRPkhaPcm2pdanerx0iAxF1hbj8yRPI2CF1s940BmwTED0/nTxq3QmX+FQRyDFVk+uY3/\n\tc618ArDDk6ZLjvcFSUlxIq97wRLDPfFpsArklqBdsCKdkn06PzaaEuusibEVIT6Yd0fS\n\twapfGZ1lbfeP2mngV+kH9KU8hYacTo7WQMJcvIRvM4OlN2SxzJEgkFo/dOcUGe4BugCl\n\tvEcw==","X-Gm-Message-State":"AOJu0YxICVcMEshex7JbbFyc2YMh3aMHQkoWrHhD6sSDOYdmKs1vVcCa\n\tHl79Bae5YqlCaayILD5LMcCv0VZuONVvLaHDy9Ar5+sk5LrzQZVkqcCha3FJqtg+LRL2vCaeoV9\n\tUP3EKUhCjcxA06PwLqj5cjMla47JVFFUGaD19qfB+nw==","X-Gm-Gg":"ASbGncuMlM0GeNS+t9TpTCjC5gYi/RgBYE6b0CaXwq7pXkgWIr2KqTHwtoPQacUK4wP\n\tWG8wZqAZDK4/WaPbaDqJVEuDpxLHW+kEhd0gNtD0j5FjWPhYJg+dBx5Y2Cc42ktn6PUxCjv7d7X\n\ty8u3gNAhU0ElA/VFhTYWDgevjqe+1+HDfC5JDLO/U4U9XldoCspWJQ1++Ppi6lBNzYNx5x8Dr5q\n\tO2ZpYU=","X-Google-Smtp-Source":"AGHT+IHT6f06bVndW0BhtwC2PUyEwhBHOSX/JQk4U2FtE+Kbnb2zZ0SMLuy959U0IiaYCVAoqnMbTetIfJbSu7oTWco=","X-Received":"by 2002:a05:6102:5985:b0:4de:ec93:edde with SMTP id\n\tada2fe7eead31-4fa14fbd4d1mr1018671137.2.1753348994917;\n\tThu, 24 Jul 2025 02:23:14 -0700 (PDT)","MIME-Version":"1.0","References":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Thu, 24 Jul 2025 10:22:38 +0100","X-Gm-Features":"Ac12FXzfuMzlk81j489mlFUBmLfG6npXMwkCId5RDKzGu_CaJkT1_6xyiABxebo","Message-ID":"","Subject":"Re: [PATCH 0/3] Add vd56g3 support for rpi and libipa","To":"Benjamin Mugnier ","Cc":"libcamera-devel@lists.libcamera.org, \n\tKieran Bingham , \n\tSylvain Petinot ,\n\tCyril Liotard , Jean Poire ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35098,"web_url":"https://patchwork.libcamera.org/comment/35098/","msgid":"<20250724102435.GI11202@pendragon.ideasonboard.com>","date":"2025-07-24T10:24:35","subject":"Re: [PATCH 0/3] Add vd56g3 support for rpi and libipa","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Benjamin,\n\nOn Fri, Jun 20, 2025 at 03:49:15PM +0200, Benjamin Mugnier wrote:\n> Following our discussion with Kieran and Naushir at the libcamera\n> workshop, here is the vd56g3 support for libcamera.\n> \n> This series has been developed originally on the Raspberry Pi libcamera\n> fork and tested on rpi4 and rpi5. Then rebased on mainline and tested\n> again on rpi4 and rpi5 with the mainline rp1-cfe driver.\n> \n> The libipa part has not been tested yet, but changes are rather trivial.\n> If you see any issues with that, please don't hesitate to remove the\n> patch from the series.\n\nThe series looks good overall. There are a few small review comments,\ncould you send a v2 ? I think we can then merge it right away.\n\n> To: libcamera-devel@lists.libcamera.org\n> CC: Naushir Patuck \n> CC: Kieran Bingham \n> CC: Sylvain Petinot \n> CC: Cyril Liotard \n> CC: Jean Poire \n> \n> Signed-off-by: Benjamin Mugnier \n> ---\n> Benjamin Mugnier (3):\n> libcamera: camera_sensor_properties: Add vd56g3 camera sensor\n> ipa: rpi: Add vd56g3 support for rpi\n> libcamera: libipa: Add vd56g3 support for libipa\n> \n> src/ipa/libipa/camera_sensor_helper.cpp | 12 +\n> src/ipa/rpi/cam_helper/cam_helper_vd56g3.cpp | 54 +\n> src/ipa/rpi/cam_helper/meson.build | 1 +\n> src/ipa/rpi/pisp/data/meson.build | 2 +\n> src/ipa/rpi/pisp/data/vd56g3.json | 1293 +++++++++++++++++++++\n> src/ipa/rpi/pisp/data/vd56g3_mono.json | 1155 ++++++++++++++++++\n> src/ipa/rpi/vc4/data/meson.build | 2 +\n> src/ipa/rpi/vc4/data/vd56g3.json | 417 +++++++\n> src/ipa/rpi/vc4/data/vd56g3_mono.json | 290 +++++\n> src/libcamera/sensor/camera_sensor_properties.cpp | 21 +\n> 10 files changed, 3247 insertions(+)\n> ---\n> base-commit: b3ff75d7589a263412ad63008b3c8518d40e6316\n> change-id: 20250620-vd56g3_support-029e40405468","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1430DC3237\n\tfor ;\n\tThu, 24 Jul 2025 10:24:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3F23690DE;\n\tThu, 24 Jul 2025 12:24:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77975690CF\n\tfor ;\n\tThu, 24 Jul 2025 12:24:39 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 62D72C79;\n\tThu, 24 Jul 2025 12:24:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s/NMgbwn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1753352640;\n\tbh=RyetZI/9xNnCIco0p0eE81Ig/zkvvlsmqHmS7+ugYyE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=s/NMgbwnYQc8Mb3+A0sxxg9+EgTfkkIhwr4+37lWXrtH9xUGdNdS9c1CUk5BwLITf\n\tvzLSKTp08N3xJdbuLaaqcmHFgYpFONdtRdV/sXb9W16Z/2svXIq+obDdGzsubtpA+p\n\t8+7tWTONDTJq/VpXOcBMTFlBqD8QyVAwAhcNFk6A=","Date":"Thu, 24 Jul 2025 13:24:35 +0300","From":"Laurent Pinchart ","To":"Benjamin Mugnier ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ,\n\tKieran Bingham ,\n\tSylvain Petinot ,\n\tCyril Liotard , Jean Poire ","Subject":"Re: [PATCH 0/3] Add vd56g3 support for rpi and libipa","Message-ID":"<20250724102435.GI11202@pendragon.ideasonboard.com>","References":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]