[{"id":34426,"web_url":"https://patchwork.libcamera.org/comment/34426/","msgid":"<20250605085210.GB20387@pendragon.ideasonboard.com>","date":"2025-06-05T08:52:10","subject":"Re: [PATCH v2 0/7] gstreamer: Miscellaneous cleanups + two fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jun 04, 2025 at 04:07:34PM +0300, Laurent Pinchart wrote:\n> Hello everybody,\n> \n> Here's a set of miscellaneous cleanups for libcamerasrc that follow the\n> recently added GstVideoMeta support. They mostly improve readability,\n> but patches 5/7 and 6/7 also fix two leaks and a use-after-free\n> respectively.\n> \n> Compared to v1, I've addressed review comments, reordered the patches,\n> added more leak and use-after-free fixes, added patch 7/7, and performed\n> other small changes as detailed in the per-patch changelogs.\n> \n> The code has still been compile-tested only as I haven't managed to\n> exercize the video pool creation code path yet. Hou, would you be able\n> to test this series ?\n\nPending a review of patch 7/7, this series is ready to be merged. Hou,\ncould you please let me know if you plan to test it ? If so I'll wait\nfor your test report before merging.\n\n> Laurent Pinchart (7):\n> gstreamer: Document improvements when updating minimum GStreamer\n> version\n> gstreamer: Factor out video pool creation\n> gstreamer: Reduce indentation in gst_libcamera_create_video_pool()\n> gstreamer: Rename variable in gst_libcamera_create_video_pool()\n> gstreamer: Fix leak of GstQuery and GstBufferPool in error path\n> gstreamer: Drop incorrect unref on caps\n> gstreamer: Replace NULL with nullptr\n> \n> src/gstreamer/gstlibcamera-controls.cpp.in | 2 +-\n> src/gstreamer/gstlibcamerapad.cpp | 2 +-\n> src/gstreamer/gstlibcamerasrc.cpp | 146 ++++++++++++++-------\n> 3 files changed, 98 insertions(+), 52 deletions(-)\n> \n> \n> base-commit: 290d3f82e3e3e313932a201308813c75131d16f1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02B7AC31E9\n\tfor ;\n\tThu, 5 Jun 2025 08:52:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD35468DB2;\n\tThu, 5 Jun 2025 10:52:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17F7768DB2\n\tfor ;\n\tThu, 5 Jun 2025 10:52:20 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43123593;\n\tThu, 5 Jun 2025 10:52:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k6ltlgbx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749113536;\n\tbh=ujAXpb5mxLFCXQgbCLSwmqBaq+OaAjPbW3EVUSxCosA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k6ltlgbx9EA0/Qy5AqoFUU/nXkXSJww8D/9gQ5PEFHE1lQE9rCkoIaiBLkbFhkHTv\n\tw+n7FkTaAvlHpr1nDzP0V95cJ9HHc2xocV/+BMSRuoDsxBn4J8PWmTS+aINPdgYvbz\n\tkMnmPv90Q4Sq33jO6yjLEfrJaCer+W6rouGHXl3o=","Date":"Thu, 5 Jun 2025 11:52:10 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Hou Qi ,\n\tNicolas Dufresne ","Subject":"Re: [PATCH v2 0/7] gstreamer: Miscellaneous cleanups + two fixes","Message-ID":"<20250605085210.GB20387@pendragon.ideasonboard.com>","References":"<20250604130741.9228-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250604130741.9228-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]