[{"id":34396,"web_url":"https://patchwork.libcamera.org/comment/34396/","msgid":"","date":"2025-06-02T07:37:57","subject":"Re: [PATCH v2 0/6] Eliminating startup frames","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nAny further thoughts on this series?\n\nThanks!\nNaush\n\n\nOn Thu, 22 May 2025 at 08:52, Naushir Patuck wrote:\n\n> Hi,\n>\n> Minor changes in version 2:\n>\n> - In patch 1, wording changes for the FrameMetadata::Status description.\n> - In patch 3, reflow some changes to look neater, and fix a bug when\n> decrementing the invalidFrameCount_ and startupFrameCount_ together.\n>\n> Thanks,\n> Naush\n>\n> Naushir Patuck (6):\n> libcamera: framebuffer: Add FrameMetadata::Status::FrameStartup\n> ipa: rpi: Replace dropFrameCount in the IPA -> PH interface\n> pipeline: ipa: rpi: Split RPiCameraData::dropFrameCount_\n> pipeline: rpi: Remove disable_startup_frame_drops config option\n> pipeline: rpi: Remove ispOutputCount_ and ispOutputTotal_\n> ipa: rpi: Rename dropFrameCount_ to startupCount_\n>\n> include/libcamera/framebuffer.h | 1 +\n> include/libcamera/ipa/raspberrypi.mojom | 3 +-\n> src/ipa/rpi/common/ipa_base.cpp | 20 ++--\n> src/ipa/rpi/common/ipa_base.h | 4 +-\n> src/libcamera/framebuffer.cpp | 13 ++-\n> .../pipeline/rpi/common/pipeline_base.cpp | 105 +++++++-----------\n> .../pipeline/rpi/common/pipeline_base.h | 14 +--\n> .../pipeline/rpi/pisp/data/example.yaml | 5 -\n> src/libcamera/pipeline/rpi/pisp/pisp.cpp | 12 --\n> .../pipeline/rpi/vc4/data/example.yaml | 5 -\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 15 ---\n> 11 files changed, 72 insertions(+), 125 deletions(-)\n>\n> --\n> 2.43.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B037C3237\n\tfor ;\n\tMon, 2 Jun 2025 07:38:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C85C615F5;\n\tMon, 2 Jun 2025 09:38:31 +0200 (CEST)","from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com\n\t[IPv6:2607:f8b0:4864:20::e33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 361EC615F5\n\tfor ;\n\tMon, 2 Jun 2025 09:38:29 +0200 (CEST)","by mail-vs1-xe33.google.com with SMTP id\n\tada2fe7eead31-4e589c2ac3cso115976137.0\n\tfor ;\n\tMon, 02 Jun 2025 00:38:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"fGnRD3+p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1748849908; x=1749454708;\n\tdarn=lists.libcamera.org; \n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=bMNIoUC2Zcjt9ur2KSvxaQEKpmeTj1AOKYchJErOj80=;\n\tb=fGnRD3+pHDHMb/6QbkkIBfJ3s15Rjcp3tigMbNsC/rMEeYkD1R1RdEgoBrF7TNf+M6\n\t+SsjEcbh4s1hCzo9lxxAT0rbCiVu1yTph/4+3D9GgZ+O/qQllUKg+e19RUUby3z8MQgc\n\t+NIZ5OQr01aJU2O/azA/eGJGyMCcshTBg6V2OIkMEDmR+YENQDh28DXeJMrGxxtC5eE5\n\tWWTwQ3J95uf0bPTfrwzgeVYEQrpeogaiW3XhWkUCCZ2D4qe8sIKz0/87E2RHxFFYPP+m\n\tBiVup+BK+hYd7E9OCittHkrNz3BUdQHOFRKMBfNwc7N6OobeaHvEArJZObBnV23N1n6D\n\txAnQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1748849908; x=1749454708;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=bMNIoUC2Zcjt9ur2KSvxaQEKpmeTj1AOKYchJErOj80=;\n\tb=OVIprvqr2Gw4yo5qoQxUKLgaMqn9Q7Vz7tcepdu7vYJnl4g9e9/WHcmZOxDGeVymY4\n\twie+/+eueT1MdXK/lvUkKBcveip6ByuJn8s3PUvyYJ6bXOR58Gxt8JrGLAu/0SnmKAIq\n\t/jqjMxgwEj0Cm5O3HbZjPNC5HTdBjb+PHDXWrFyI9FMNDCkXM5A6Rl4LfAJvfJOZ+251\n\tOkagUWs0tDl7zvpNTcIFAzIxEq/DJ4jWkiZczGIuju3wSaStOraGCuxDEKdCySU6JrE3\n\tqG/qUMFk7Z6gCMCQWlYuSbrNmWcZdu/hrAWfWMZ6AZID2o54kMMrmNpcp4PKJPoH6Mds\n\tffdw==","X-Gm-Message-State":"AOJu0Yw/l4VwbwvyRMdUtzdYoykNZ+DkCz5SMlqfQ7rXQALoJ53NBD3A\n\tSMsLHQLWPc3NVfp1L+SmlKfXx8s+Lqr5dtbtCeN56KrvAjDU/7kiCAz1IZ0IDNf3bUls5xC3LlB\n\tgu7jlhjO8DjiWzVeqO5qR/7XdzvA2i4hrnmRRJAULoFOr94gmfyb1","X-Gm-Gg":"ASbGncuDrlTjFznLw2Mhr6Zi5aVW9mObMsXwUo282/y94CqOgMTLjepuQbHOnERmLmV\n\t/gx3OCqZ9Bmiu5qpRFg5nh1lCx5Llz2o5iELSleGV7QuybSUaZZuG4cxt7fysQOTJdGFK6ty3bj\n\tqN5Nw19XB72CMjk+Ec5k7N1d4lqknj6AHJ","X-Google-Smtp-Source":"AGHT+IErw0o3AoxgoggbdBdvHt3swMZIGyMxmLGGyr5y3cKmWjrYoBzuJsjJXG0yhKpQOoJq52mmJO6OLIZ5oMKUeU8=","X-Received":"by 2002:a05:6102:2acf:b0:4e5:ac99:e4ae with SMTP id\n\tada2fe7eead31-4e6e77879a0mr2828762137.0.1748849907551;\n\tMon, 02 Jun 2025 00:38:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20250522075244.1198110-1-naush@raspberrypi.com>","In-Reply-To":"<20250522075244.1198110-1-naush@raspberrypi.com>","From":"Naushir Patuck ","Date":"Mon, 2 Jun 2025 08:37:57 +0100","X-Gm-Features":"AX0GCFt6jo8EXCDKOHJqz61GQC760KQ2fvmI3ow0k0sl1viGryHvotqhJp0P5uM","Message-ID":"","Subject":"Re: [PATCH v2 0/6] Eliminating startup frames","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"0000000000008167f9063691d95a\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]