{"id":23410,"url":"https://patchwork.libcamera.org/api/covers/23410/?format=json","web_url":"https://patchwork.libcamera.org/cover/23410/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250521125327.6378-1-david.plowman@raspberrypi.com>","date":"2025-05-21T12:53:26","name":"[0/1] Fix AeEnable when camera starts","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/23410/mbox/","series":[{"id":5186,"url":"https://patchwork.libcamera.org/api/series/5186/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5186","date":"2025-05-21T12:53:26","name":"Fix AeEnable when camera starts","version":1,"mbox":"https://patchwork.libcamera.org/series/5186/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/23410/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1CC1C31E9\n\tfor ;\n\tWed, 21 May 2025 12:53:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BFA0468D94;\n\tWed, 21 May 2025 14:53:33 +0200 (CEST)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F150868C91\n\tfor ;\n\tWed, 21 May 2025 14:53:30 +0200 (CEST)","by mail-wr1-x435.google.com with SMTP id\n\tffacd0b85a97d-3a365a6804eso2662920f8f.3\n\tfor ;\n\tWed, 21 May 2025 05:53:30 -0700 (PDT)","from raspberrypi.pitowers.org\n\t([2a00:1098:3142:1f:ffc9:aff6:7f7f:893b])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-447f6f0556bsm67938395e9.12.2025.05.21.05.53.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 May 2025 05:53:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QhZnYZA/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1747832010; x=1748436810;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=M3QoAdOlM/W8YOyXRP6oBRewxj7wKzbiTjsS8D7ee7c=;\n\tb=QhZnYZA/Lo9UmWfheNaJn8jq1SJRssniPxG5b6sy1cT7HPFgk8I1YKKjXExqvyFYdE\n\tQojbVlxQXWpcgWo4Pzk5nYsHSBuA5R2lR5p76+ZQMx/pt/YIAIzMEOpXBNJNT1txROkx\n\t7kdjLOs8RvFmvTJA3jTsTjXpZdmNJW3ILs9yq4x3tkRMULMq9DO8h8X37xaCU2Ng7XNr\n\tLeOk0WvgO/FTYt6TffVL+xYxX7FWVRdt557Z++oIPqb1sXgRQrSB583ThuADAyQ/tE+P\n\tzYt/o+LTA2Vrq4uLv1myM/4cKRh2Q0xXzettz+P3pzndK7AqD1nYg7LzSGPBv5K7CHWz\n\tztFA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1747832010; x=1748436810;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=M3QoAdOlM/W8YOyXRP6oBRewxj7wKzbiTjsS8D7ee7c=;\n\tb=gRFuSbrLMC0hJsSyyKYaD6kVKEF+bqOByKoKXVECZP9SY82YodIfVJMZgx28G2mtrd\n\tf9yJeHThboLJIvlfEHBVOM9+LaSfE4JlZ3eABiSE9x/bGXrv5S1kXuJ9Vdfa9lyweopT\n\tgCHP5V7ALmpKynNFN6aTScxOFWm5ZZGbEyCGJ+tk8ItXIg6WWJ3a8LbmhfOTeWfQXAl5\n\tMUP9QX49LuLdTnRu/s1TfAn9DldO7/esUhAsdLLZtpWpXYpywMcFgzQH0zm8w24PYPfy\n\tpjZqI3e3G7ydkAre+TPxheulB0uH+qs4ZLazNdeA2pThLg3Vw1PtR21/7i0Ns0JKEZMT\n\tAT4w==","X-Gm-Message-State":"AOJu0Yykm4BewEbxYbt7kzzzUO8nh6LDvtfkbxhoh1cJI06VT1DKuE+m\n\ttgZm8HetSU35wbLmm7cq8b7DSyzlr19P0EsKHctqqvdtiIHBByxzRFJ8PEGS0oeEEyLVlY83Ah1\n\thjslZpMg=","X-Gm-Gg":"ASbGncv3U5ZmBXD5yiOXDHKYbeEBfSD4D0obJXunOlMnQ1bfy4JESuswMxYDVJYhFb6\n\tKRzwOi1/MVkuomXVo+YNwuAMaZu+tbNSLeRL+gQaK5NvxWCPI3JHEVzugPy+WZyJwzo7EX+87pg\n\t3Ss6DmQ973FspPAMhY6BcxeHT0xwWA43lmt7rGJku0nWaAotEzXJJMGCPT4gZyTRuIgZBx/bsWy\n\txtlXLxI80H/XQGXw6c8NuIz0MyYZl9hbCdeMTbTyQyBEr4xlx52aMGBjzJw8a7mNv6BCL/8VHHI\n\ta3ko+BQEY0wSPQX3cJCo8eEGoYcZteheC2i663Q0kMkHN6n0EKV+6FE9byf0Tky0cnXV1mZNTQp\n\tMXuoPuvo=","X-Google-Smtp-Source":"AGHT+IE1NwdQoqQgbfAY1JEAXk9KRTDRbEZx5QUwzRgH1GVnZHf4zvUOH8UxYRwMZTE9C3tN3eoidA==","X-Received":"by 2002:a05:6000:2903:b0:3a3:6e62:d8e8 with SMTP id\n\tffacd0b85a97d-3a36e62db92mr11285984f8f.55.1747832009938; \n\tWed, 21 May 2025 05:53:29 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Cc":"David Plowman ","Subject":"[PATCH 0/1] Fix AeEnable when camera starts","Date":"Wed, 21 May 2025 13:53:26 +0100","Message-Id":"<20250521125327.6378-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.39.5","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi everyone\n\nNot a big patch, but also not a lovely one, so folks might have some\nopinions on how it should look.\n\nThe problem is that we patch up control lists for the \"AeEnable\"\ncontrol when we queue a request, but not when the camera starts -\nleading to different behaviour depending on when you send your\ncontrols.\n\nThis patch fixes that, by factoring the patch-up code into a separate\nmethod, and then, in Camera::start(), we copy the control list because\nthe one passed in is const.\n\nAnyway, opinions on how this should look gratefully received, and I'll\ndo another version once things seem clear.\n\nThanks!\nDavid\n\nDavid Plowman (1):\n libcamera: camera: Fix up the AeEnable control during Camera::start()\n\n include/libcamera/camera.h | 2 ++\n src/libcamera/camera.cpp | 57 +++++++++++++++++++++++++-------------\n 2 files changed, 40 insertions(+), 19 deletions(-)"}