{"id":23365,"url":"https://patchwork.libcamera.org/api/covers/23365/?format=json","web_url":"https://patchwork.libcamera.org/cover/23365/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>","date":"2025-05-15T12:00:04","name":"[RFC,v1,0/8] utils: codegen: ipc: Simplify deserialization","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/23365/mbox/","series":[{"id":5173,"url":"https://patchwork.libcamera.org/api/series/5173/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5173","date":"2025-05-15T12:00:04","name":"utils: codegen: ipc: Simplify deserialization","version":1,"mbox":"https://patchwork.libcamera.org/series/5173/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/23365/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CAE9C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 May 2025 12:00:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6A0668D6C;\n\tThu, 15 May 2025 14:00:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89E3268B5D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 May 2025 14:00:16 +0200 (CEST)","from pb-laptop.local (185.221.142.248.nat.pool.zt.hu\n\t[185.221.142.248])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37727886;\n\tThu, 15 May 2025 13:59:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T0h93Vg5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747310399;\n\tbh=uyfrQs4ZREwfz5rgrXMMY4jHUZ5TwPQuKun/dVpd1Hc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=T0h93Vg5ICSjpyAHvk8DCBERj5jT7Fh+quLm1afN1uAVIoaDLG+mtxg31WA2fSu7Q\n\tiG1HeVCsys6OTj/F3P4HsNWJr3ILaD/KddGmIjQ2GgwsxoDvBF1vxXo89pzrF1KBJZ\n\thR23i/34R5+2JDe79dpzwHrAgqh4GNjb7UFislQw=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder <paul.elder@ideasonboard.com>","Subject":"[RFC PATCH v1 0/8] utils: codegen: ipc: Simplify deserialization","Date":"Thu, 15 May 2025 14:00:04 +0200","Message-ID":"<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Proof of concept to fix https://bugs.libcamera.org/show_bug.cgi?id=269.\n\nThe first 7 are essentially non-functional changes, the main changes are\nin the 8th patch. See that patch for the details.\n\nBarnabás Pőcze (8):\n  utils: codegen: ipc: Use `any()` instead of `len([]) > 0`\n  utils: codegen: ipc: Remove `namespace` argument\n  utils: codegen: ipc: Add `deserializer()` function\n  utils: codegen: ipc: Log error code when remote call fails\n  utils: codegen: ipc: Simplify `return` statements\n  libcamera: ipa_data_serializer: Remove some vector `reserve()` calls\n  libcamera: ipa_data_serializer: Add specialization for enums\n  utils: codegen: ipc: Simplify deserialization\n\n .../libcamera/internal/ipa_data_serializer.h  | 215 +++--------\n include/libcamera/internal/ipc_pipe.h         |   3 +\n include/libcamera/internal/serialization.h    |  91 +++++\n src/libcamera/ipa_data_serializer.cpp         | 357 ++++--------------\n src/libcamera/ipc_pipe.cpp                    |   5 +\n test/ipc/unixsocket_ipc.cpp                   |  18 +-\n .../generated_serializer_test.cpp             |  17 +-\n .../ipa_data_serializer_test.cpp              |  32 +-\n .../core_ipa_serializer.h.tmpl                |   9 +-\n .../module_ipa_proxy.cpp.tmpl                 |  42 +--\n .../module_ipa_proxy.h.tmpl                   |   5 +-\n .../module_ipa_proxy_worker.cpp.tmpl          |   5 +-\n .../module_ipa_serializer.h.tmpl              |   9 +-\n .../libcamera_templates/proxy_functions.tmpl  | 128 +------\n .../libcamera_templates/serializer.tmpl       | 244 +-----------\n .../generators/mojom_libcamera_generator.py   |  14 +-\n 16 files changed, 351 insertions(+), 843 deletions(-)\n create mode 100644 include/libcamera/internal/serialization.h\n\n--\n2.49.0"}