{"id":23324,"url":"https://patchwork.libcamera.org/api/covers/23324/?format=json","web_url":"https://patchwork.libcamera.org/cover/23324/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250501095818.3996419-1-barnabas.pocze@ideasonboard.com>","date":"2025-05-01T09:58:15","name":"[v2,0/3] libcamera: controls: String controls as `std::string_view`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/23324/mbox/","series":[{"id":5157,"url":"https://patchwork.libcamera.org/api/series/5157/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5157","date":"2025-05-01T09:58:15","name":"libcamera: controls: String controls as `std::string_view`","version":2,"mbox":"https://patchwork.libcamera.org/series/5157/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/23324/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E549BE08B\n\tfor ;\n\tThu, 1 May 2025 09:58:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7B2268ADC;\n\tThu, 1 May 2025 11:58:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6216068ACC\n\tfor ;\n\tThu, 1 May 2025 11:58:22 +0200 (CEST)","from pb-laptop.local (185.221.143.50.nat.pool.zt.hu\n\t[185.221.143.50])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 450AA2E0\n\tfor ;\n\tThu, 1 May 2025 11:58:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UK+2opQ8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746093495;\n\tbh=INfHlWHcmHZmmKqtY4vUpLGgUUwXbuYzrAgms6ycLOc=;\n\th=From:To:Subject:Date:From;\n\tb=UK+2opQ89d0thN1aRrZxsr55ZssVBLmiGdavncpSzIq2mukJAwWBHM8HOaKsVAHI1\n\ta95UjCbDCYnf6U4uALoYd8Pb3WYKpYYOobmFMUg/hq+iLABqZQU92aFZRvXwJ1NOjz\n\t8NGsfNrz9KK42FtTQqRHYFDrlCcyFXFJtvKlT4c4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 0/3] libcamera: controls: String controls as\n\t`std::string_view`","Date":"Thu, 1 May 2025 11:58:15 +0200","Message-ID":"<20250501095818.3996419-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This change brings string controls in line with other controls in that\nno non-trivial copies will be made when a value is retrieved from a\n`ControlValue` instance.\n\nhttps://bugs.libcamera.org/show_bug.cgi?id=256\n\nchanges in v2:\n * fix rebuilding when controls.py is modified\n\nv1: https://patchwork.libcamera.org/cover/23204/\n\nBarnabás Pőcze (3):\n apps: cam: capture_script: Disallow arrays of strings\n utils: codegen: Make users depend on `controls.py` in meson\n libcamera: controls: Expose string controls as `std::string_view`\n\n include/libcamera/control_ids.h.in | 1 +\n include/libcamera/controls.h | 15 ++++++++-------\n include/libcamera/meson.build | 1 +\n src/apps/cam/capture_script.cpp | 6 +-----\n src/apps/cam/main.cpp | 2 +-\n src/apps/common/dng_writer.cpp | 2 +-\n src/apps/qcam/cam_select_dialog.cpp | 6 +++---\n src/gstreamer/meson.build | 1 +\n src/libcamera/meson.build | 1 +\n src/py/libcamera/meson.build | 2 ++\n src/py/libcamera/py_helpers.cpp | 4 ++--\n test/controls/control_value.cpp | 4 ++--\n utils/codegen/controls.py | 2 +-\n utils/codegen/meson.build | 2 ++\n 14 files changed, 27 insertions(+), 22 deletions(-)\n\n--\n2.49.0"}