[{"id":3119,"web_url":"https://patchwork.libcamera.org/comment/3119/","msgid":"<20191120162546.GB27453@bigcity.dyn.berto.se>","date":"2019-11-20T16:25:46","subject":"Re: [libcamera-devel] [PATCH v2 00/10] libcamera: Fixes found while\n\tworking on new","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nI have now pushed all fixes but 8/10.\n\nOn 2019-11-20 02:54:56 +0100, Niklas Söderlund wrote:\n> Hi,\n> \n> This series is a random collection of small fixes I encountered while\n> working on the new buffer API. They could hopefully be merged without\n> much controversy opposed to the real buffer API change.\n> \n> * Changes since v2\n> - Fixed HAL build which was not consider in v1.\n> - Replaced 8/10 with a new version taking a new approach to solving the \n> same problem. See v2 8/10 for more info.\n> - Collected tags.\n> \n> Niklas Söderlund (10):\n> libcamera: buffer: Drop forward declaration of BufferPool\n> libcamera: buffer: Plane: Drop friend statement\n> libcamera: buffer: Drop friend statement\n> libcamera: camera: Remove explicit stream to buffer map in\n> requestCompleted signal\n> cam: BufferWriter: Use the libcamera namespace\n> libcamera: v4l2_videodevice: Simplify error checking for\n> requestBuffers()\n> libcamera: pipeline_handler: Do not use argument as local variable\n> libcamera: pipeline: Rework PipelineHandler::queueRequest()\n> cam: Store camera as shared pointer everywhere\n> libcamera: pipeline: Drop forward declaration of BufferPool\n> \n> include/libcamera/buffer.h | 4 ---\n> include/libcamera/camera.h | 3 +-\n> src/android/camera_device.cpp | 4 +--\n> src/android/camera_device.h | 3 +-\n> src/cam/buffer_writer.cpp | 8 +++--\n> src/cam/capture.cpp | 6 ++--\n> src/cam/capture.h | 7 ++--\n> src/cam/main.cpp | 2 +-\n> src/libcamera/camera.cpp | 2 +-\n> src/libcamera/include/pipeline_handler.h | 5 +--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 6 ++--\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 ++--\n> src/libcamera/pipeline/uvcvideo.cpp | 6 ++--\n> src/libcamera/pipeline/vimc.cpp | 6 ++--\n> src/libcamera/pipeline_handler.cpp | 43 ++++++++++++++++--------\n> src/libcamera/v4l2_videodevice.cpp | 31 ++++++-----------\n> src/qcam/main_window.cpp | 5 +--\n> src/qcam/main_window.h | 4 +--\n> test/camera/capture.cpp | 4 ++-\n> 19 files changed, 76 insertions(+), 80 deletions(-)\n> \n> -- \n> 2.24.0\n>","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1121660C21\n\tfor ;\n\tWed, 20 Nov 2019 17:25:48 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id q28so51879lfp.2\n\tfor ;\n\tWed, 20 Nov 2019 08:25:48 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tv21sm11999667ljh.53.2019.11.20.08.25.46\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 20 Nov 2019 08:25:46 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=l+1nN1TsCMZHQSBzWd6y9s/6ChyQX4JFX+psqj3dhkA=;\n\tb=b3lUFKy0JmeCTbZgtaJvE6m+NzBW+qJjX8fy0h7yMXp3AZsEX5sTe3tjzhykGVqDIB\n\tYfSWHh7aq+wKRiI6LCZSpYER/GQn/YUOaoS1ZEUnLMsf8NPOVopl4bGrBb27zeiSBJV0\n\t4yxRqFWFZyFuAHkGCAmcM2vJCEVFhHsgaHVSDzyCrfvWnkXpdx1hXpzQpnSmyOR5qJFr\n\tLneYSv/W6WBDQpCQ4lxOxSbYOOM+6YKmBY/peN/yn48Er88uv7FWVtdh6P5NUDYlsoBf\n\tnm1PnXm7df3DDA4qP4WasdgslcVm2sFUdXyrmDdbIW814C/YosE1gZJHwunmsBtVn6uV\n\tevUQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=l+1nN1TsCMZHQSBzWd6y9s/6ChyQX4JFX+psqj3dhkA=;\n\tb=CQv8LhdhjN9JdLn/fWKnaV0mZtD+r7buTVnuW7t3u+Czxh07hvruNW+jCXQNCje9bP\n\tu7PeTQdWw/Zrk6xtPpUIL/WS4YCbbCtClYKy0toXvhDUqMktfOoJXHwiWpt5B5fxQKoS\n\txOeIiuQ5TCmb3+aU1pjlyyrQIP+YjDF16qDapqn+NUYjLCzo0md67w5mPbCF8LpafhFG\n\tnDg361BEI4ap93vMLCFfKj6Dxvq//bBMxCNxME63vXD8jRkJcsNhvEGU2yHtubFsl5PS\n\tCDfWb3Ifw39R+KqIFh2YozJRygwhy2Jy/wIG+jIFWmgR4T0rZwdmCzmJp3/4TIyjz967\n\tZ6Zg==","X-Gm-Message-State":"APjAAAUQZhdonQyeis8CrkJwfWB1fSCFvNhLi4HcTuOwW5bQEMIyNGPj\n\tiYS+JLr81OwlHfcxTp9jqBNM0Ta9FdM=","X-Google-Smtp-Source":"APXvYqzaycC2ym4jOYPNIl6JBYfPQDFHBCc9hmmKjDTsSY2Bk20d9Z7cnLTtsaVHiaMfu2jCQcLhdw==","X-Received":"by 2002:ac2:5193:: with SMTP id u19mr3603100lfi.83.1574267147090;\n\tWed, 20 Nov 2019 08:25:47 -0800 (PST)","Date":"Wed, 20 Nov 2019 17:25:46 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191120162546.GB27453@bigcity.dyn.berto.se>","References":"<20191120015506.362440-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191120015506.362440-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 00/10] libcamera: Fixes found while\n\tworking on new","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 20 Nov 2019 16:25:48 -0000"}}]