{"id":23167,"url":"https://patchwork.libcamera.org/api/covers/23167/?format=json","web_url":"https://patchwork.libcamera.org/cover/23167/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250411130423.2164577-1-stefan.klug@ideasonboard.com>","date":"2025-04-11T13:04:07","name":"[0/8] Implement WDR algorithm","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/23167/mbox/","series":[{"id":5122,"url":"https://patchwork.libcamera.org/api/series/5122/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5122","date":"2025-04-11T13:04:07","name":"Implement WDR algorithm","version":1,"mbox":"https://patchwork.libcamera.org/series/5122/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/23167/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4758C3213\n\tfor ;\n\tFri, 11 Apr 2025 13:04:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D01C68A4C;\n\tFri, 11 Apr 2025 15:04:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 578C1689A5\n\tfor ;\n\tFri, 11 Apr 2025 15:04:28 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:5b21:2ad5:1023:7179])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA70B667;\n\tFri, 11 Apr 2025 15:02:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PaXH7igI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744376548;\n\tbh=WLTlcLXRkYE3eeuLYLYnk2l6uU1coK047dKicdENd2Y=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=PaXH7igIyZoBe2Znyrbstg+FfnVvSY8y4BhpRHUJrZew+CaVvMTzwptIKZrdUwmp0\n\tQqdNJJC8TQ8y9ZLRVpA3omEdr1kskuf0wSYtYBBSBoxdPZlt6cMWcznd6yBqRJjyRx\n\topg2YGHNiGUn685qdDVwsLNS5/22ncEqTlPrbL9M=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 0/8] Implement WDR algorithm","Date":"Fri, 11 Apr 2025 15:04:07 +0200","Message-ID":"<20250411130423.2164577-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi all,\n\nThis series implements a global tone mapping algorithm for rkisp1. The\nresults are pretty nice and I still need to prepare a few slides with\nactual images.\n\nIf you want to test this, it depends on a few other patches:\n\n- [PATCH v3 0/2] media: rockchip: rkisp1: Add support for WDR and AWB64\nhttps://lore.kernel.org/linux-media/20250225-awb64-v3-0-af29b1201e48@ideasonboard.com/\n\n- [PATCH v3 00/16] Some rkisp1 awb improvements\nhttps://patchwork.libcamera.org/project/libcamera/list/?series=5111\n\n- [PATCH v2 0/9] Wdr preparations\nhttps://patchwork.libcamera.org/project/libcamera/list/?series=5121\n\nTo enable the WDR algorithm the following entry needs to be present in\nthe tuning file:\n\nalgorithms:\n - WideDynamicRange:\n ExposureConstraint:\n MaxBrightPixels: 0.02\n yTarget: 0.95\n MinExposureValue: -4.0\n\n\nThe details of the algorithms are explained in patch 6/8, so I won't\nrepeat them here. The last two patches add debug metadata that is useful\nfor development. I'm still a bit undecided, if that should be mainlined.\nIf anyone is curious, there is a camshark branch available that\nvisualizes the curves and metadata:\nhttps://gitlab.freedesktop.org/camera/camshark/-/tree/sklug/next?ref_type=heads\n\nBest regards,\nStefan\n\n\nJai Luthra (1):\n include: linux: Add Wdr to rkisp1-config.h\n\nStefan Klug (7):\n tuning: rksip1: Add a static WideDynamicRange entry\n libcamera: Add PID controller class\n ipa: rkisp1: Add correction for exposure quantization\n ipa: rkisp1: Switch histogram to RGB combined mode\n ipa: rkisp1: Add WDR algorithm\n libcamera: vector: Add explicit cast and data accessor\n ipa: rkisp1: agc: Add debug controls for statistic values\n\n include/libcamera/internal/meson.build | 1 +\n include/libcamera/internal/pid_controller.h | 46 ++\n include/libcamera/internal/vector.h | 11 +\n include/linux/rkisp1-config.h | 72 +++\n src/ipa/rkisp1/algorithms/agc.cpp | 20 +-\n src/ipa/rkisp1/algorithms/awb.cpp | 15 +-\n src/ipa/rkisp1/algorithms/meson.build | 1 +\n src/ipa/rkisp1/algorithms/wdr.cpp | 502 ++++++++++++++++++++\n src/ipa/rkisp1/algorithms/wdr.h | 63 +++\n src/ipa/rkisp1/ipa_context.h | 12 +\n src/ipa/rkisp1/params.cpp | 1 +\n src/ipa/rkisp1/params.h | 2 +\n src/libcamera/control_ids_debug.yaml | 36 +-\n src/libcamera/control_ids_draft.yaml | 67 +++\n src/libcamera/meson.build | 1 +\n src/libcamera/pid_controller.cpp | 169 +++++++\n src/libcamera/vector.cpp | 18 +\n utils/tuning/rkisp1.py | 7 +-\n 18 files changed, 1036 insertions(+), 8 deletions(-)\n create mode 100644 include/libcamera/internal/pid_controller.h\n create mode 100644 src/ipa/rkisp1/algorithms/wdr.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/wdr.h\n create mode 100644 src/libcamera/pid_controller.cpp"}