[{"id":34215,"web_url":"https://patchwork.libcamera.org/comment/34215/","msgid":"<174712454101.257238.14111384158561624158@localhost>","date":"2025-05-13T08:22:21","subject":"Re: [PATCH v2 0/9] Wdr preparations","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-04-11 14:36:28)\n> Hi all,\n> \n> This v2 fixes a few minor errors found in v1. The main reason for the\n> repost is to create a basis for the upcoming WDR series.\n> \n> The rest of the text here is unmodified (the changelogs are in the\n> patches).\n> \n> This patch series does a bit of preparatory work for the upcoming WDR\n> support. The patches are a mix of topics but as they are all quite\n> small, I thought that a small series might be the best fit.\n> \n> Patches 1-3 are tiny improvements in gen-debug-controls that ease the\n> day to day work.\n> \n> Patches 4 and 7 add a bit of debug logging.\n> \n> Patches 5-6 fix a bug in the rkisp1 parameters handling.\n> \n> Patches 8-9 add support for exposure compensation in rkisp1.\n> \n> I hope you all like it :-)\n> \n> Best regards,\n> Stefan\n> \n> Stefan Klug (9):\n>   utils: gen-debug-controls: Remove line number from control description\n>   utils: gen-debug-controls: Fix handling of controls that appear\n>     multiple times\n>   utils: gen-debug-controls: Improve log output\n>   libipa: agc_mean_luminance: Add debug logging\n>   ipa: rkisp1: params: Check for empty parameters\n>   pipeline: rkisp1: Add more info when parameter queue fails\n>   pipeline: rkisp1: Add color space information to debug log\n>   libipa: agc_mean_luminance: Add exposure compensation support\n>   ipa: rkisp1: agc: Implement ExposureValue control\n> \n>  src/ipa/libipa/agc_mean_luminance.cpp    | 31 +++++++++++++++++++++---\n>  src/ipa/libipa/agc_mean_luminance.h      |  6 +++++\n>  src/ipa/rkisp1/algorithms/agc.cpp        | 10 ++++++++\n>  src/ipa/rkisp1/ipa_context.h             |  2 ++\n>  src/ipa/rkisp1/params.cpp                |  3 +++\n>  src/ipa/rkisp1/params.h                  |  3 +++\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 ++++++++--\n>  utils/gen-debug-controls.py              | 28 ++++++++++++++++++---\n>  8 files changed, 86 insertions(+), 10 deletions(-)\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F96DC3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 May 2025 08:22:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CB0B68B52;\n\tTue, 13 May 2025 10:22:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D291468B51\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 May 2025 10:22:24 +0200 (CEST)","from ideasonboard.com (unknown [146.0.27.152])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34A1F7E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 May 2025 10:22:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oMk989aJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747124529;\n\tbh=8OFZ9qHRt+i2zdP8LeYqGh9S2zZoPVb5bYdGWR2tZ9w=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=oMk989aJfipW3gXF0D3Y9QVavUVqjki8ZIoQl6DC8xwQcI/HgEP7OubPepRLcKxVR\n\tCkASCFogfh1T4d7RRT6K9wkn2K7yr4821lldoqj2cQ7EIf7I8AY8utT61H1WA6rO8I\n\tre34whkBzvrVJ0zj1Hg1njN3+8OLH+rGidnWAjmk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","References":"<20250411123641.2144530-1-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 0/9] Wdr preparations","From":"Stefan Klug <stefan.klug@ideasonboard.com>","Cc":"","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 May 2025 10:22:21 +0200","Message-ID":"<174712454101.257238.14111384158561624158@localhost>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]