{"id":23054,"url":"https://patchwork.libcamera.org/api/covers/23054/?format=json","web_url":"https://patchwork.libcamera.org/cover/23054/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250326134727.279393-1-stefan.klug@ideasonboard.com>","date":"2025-03-26T13:47:19","name":"[v2,0/3] rkisp1: Reduce oscillations on startup","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/23054/mbox/","series":[{"id":5086,"url":"https://patchwork.libcamera.org/api/series/5086/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5086","date":"2025-03-26T13:47:19","name":"rkisp1: Reduce oscillations on startup","version":2,"mbox":"https://patchwork.libcamera.org/series/5086/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/23054/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 040F6C323E\n\tfor ;\n\tWed, 26 Mar 2025 13:48:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A47C768969;\n\tWed, 26 Mar 2025 14:48:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1FB968950\n\tfor ;\n\tWed, 26 Mar 2025 14:48:01 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b21a:42f4:9f3:1df6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B5FE3A4;\n\tWed, 26 Mar 2025 14:46:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"me3eQhpF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742996773;\n\tbh=R4vb4SbSonixNEI6uFq49WpwamWzRe8aMaESrtPvIYw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=me3eQhpFE6GeacQb39pjNvnk3IPm0Mn/TQ6PfA0ilp0KpHF7fpAh42qMzxluDupkd\n\trzgkWJhI8pGWNdkWirbly79P1Exh574ncY+Lov9x9hsrreqlEqQbl9ldVLg9jBkfU6\n\tJ10mDh88QZWVudsHYtfOfEKEH6tnY4y5RrvRU0qM=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 0/3] rkisp1: Reduce oscillations on startup","Date":"Wed, 26 Mar 2025 14:47:19 +0100","Message-ID":"<20250326134727.279393-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi all,\n\nThis tiny series further reduces startup AE oscillations on rkisp1.\nWhile analyzing the issue it got clear that the regulation had to cope\nwith images that had an exposure value of 0 which should not happen in\nfirst place.\n\nPatch 1 adds a log message that could help debug such ill behavior.\nPatch 2 add error handling for the exposurevalue == 0 case.\nPatch 3 fixes it for rkisp1.\n\nPlease see the individual patches for the technical details.\n\nBest regards,\nStefan\n\nChanges in v2:\n- Some fixes from review (see individual changelogs)\n\nStefan Klug (3):\n ipa: rkisp1: Add debug log for the sensor controls being set\n ipa: libipa: agc_mean_luminance: Error out when effectiveExposureValue\n is zero\n ipa: rksip1: Remove setControls(0) to reduce startup oscillations\n\n src/ipa/libipa/agc_mean_luminance.cpp | 12 ++++++++++++\n src/ipa/rkisp1/rkisp1.cpp | 7 +++++--\n 2 files changed, 17 insertions(+), 2 deletions(-)"}