{"id":22896,"url":"https://patchwork.libcamera.org/api/covers/22896/?format=json","web_url":"https://patchwork.libcamera.org/cover/22896/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250228125600.3241397-1-stefan.klug@ideasonboard.com>","date":"2025-02-28T12:55:52","name":"[0/3] rkisp1: Reduce oscillations on startup","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/22896/mbox/","series":[{"id":5029,"url":"https://patchwork.libcamera.org/api/series/5029/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5029","date":"2025-02-28T12:55:52","name":"rkisp1: Reduce oscillations on startup","version":1,"mbox":"https://patchwork.libcamera.org/series/5029/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/22896/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CF2DC3259\n\tfor ;\n\tFri, 28 Feb 2025 12:56:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7E6B68775;\n\tFri, 28 Feb 2025 13:56:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D81D161853\n\tfor ;\n\tFri, 28 Feb 2025 13:56:05 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:a7e:b81b:5754:579])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 74A34606;\n\tFri, 28 Feb 2025 13:54:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dbm3rzXU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740747276;\n\tbh=jWn9X9awEk1Fp1gGtAHf2JFzduoGI/fYlwvNx4EtB+o=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=dbm3rzXUvYaSQfKmG9l1SUQ1FTEZ8gpL2ay4J3Tj0ACD7hyQLqeVDbO06wcelL8p1\n\tqq1aBl0YmaveNPwrePWGST6BfBaV4laxf+vrh+NZo4ZTyDYD4rPcJTMVGHnz/oKVYO\n\t72NdAUk3C2xHhX/LjDAhXhuYlrndhFbAdow8CgyA=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 0/3] rkisp1: Reduce oscillations on startup","Date":"Fri, 28 Feb 2025 13:55:52 +0100","Message-ID":"<20250228125600.3241397-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi all,\n\nThis tiny series further reduces startup AE oscillations on rkisp1.\nWhile analyzing the issue it got clear that the regulation had to cope\nwith images that had an exposure value of 0 which should not happen in\nfirst place.\n\nPatch 1 adds a log message that could help debug such ill behavior.\nPatch 2 add error handling for the exposurevalue == 0 case.\nPatch 3 fixes it for rkisp1.\n\nPlease see the individual patches for the technical details.\n\nBest regards,\nStefan\n\nStefan Klug (3):\n ipa: rkisp1: Add debug log for the sensor controls being set\n ipa: libipa: agc_mean_luminance: Error out when effectiveExposureValue\n is zero\n ipa: rksip1: Remove setControls(0) to reduce startup oscillations\n\n src/ipa/libipa/agc_mean_luminance.cpp | 7 +++++++\n src/ipa/rkisp1/rkisp1.cpp | 7 +++++--\n 2 files changed, 12 insertions(+), 2 deletions(-)"}