[{"id":33477,"web_url":"https://patchwork.libcamera.org/comment/33477/","msgid":"","date":"2025-02-25T15:37:57","subject":"Re: [PATCH v3 0/6] Fix occasional software ISP assertion error on\n\tstop","submitter":{"id":211,"url":"https://patchwork.libcamera.org/api/people/211/","name":"Stanislaw Gruszka","email":"stanislaw.gruszka@linux.intel.com"},"content":"Hi Milan,\n\nOn Tue, Feb 25, 2025 at 04:06:06PM +0100, Milan Zamazal wrote:\n> When software ISP is stopped, there can be pending messages in the\n> message queue that will attempt to call the already stopped IPA,\n> resulting in an assertion error like this:\n> \n> FATAL default soft_ipa_proxy.cpp:456 assertion \"state_ == ProxyRunning\" failed in processStatsThread()\n> \n> This patch series fixes the problem and also attempts to prevent other\n> problems related to message handling when or after software ISP is\n> stopped.\n\n> Changes in v3:\n> - Missing include added.\n> - I/O buffers are popped from the deque’s of queued buffers rather than\n> searched there + assertion to check it’s the intended buffer added.\n> - Returned pending input buffers are canceled.\n> - The thread.cpp formatting patch dropped.\n> - The dispatching modifications patch split to several patches as\n> suggested by Laurent.\n> - Thread::removeMessages() documentation improved as suggested by\n> Laurent.\n> - SoftwareIsp::running_ dropped in the patch adding explicit SoftwareIsp\n> messages removal.\n> - Formatting fixes suggested by Laurent.\n\n\nTested with:\n[PATCH] libcamera: delayed_controls: Inherit from Object class\n\nThe assertion is fixed and I do not see any other issues with\nthe set.\n\nFor the series:\nTested-by: Stanislaw Gruszka \n\nRegards\nStanislaw","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CA2BBDB1C\n\tfor ;\n\tTue, 25 Feb 2025 15:38:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E0536871E;\n\tTue, 25 Feb 2025 16:38:07 +0100 (CET)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C908F68715\n\tfor ;\n\tTue, 25 Feb 2025 16:38:04 +0100 (CET)","from fmviesa009.fm.intel.com ([10.60.135.149])\n\tby orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t25 Feb 2025 07:38:02 -0800","from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.115.185]) by fmviesa009-auth.fm.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 07:37:59 -0800"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"fTtRRnvP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1740497886; x=1772033886;\n\th=date:from:to:cc:subject:message-id:references:\n\tmime-version:content-transfer-encoding:in-reply-to;\n\tbh=FqOXtmXHyNimRjxuu4SKz6OWPoFvl7hunCu4OWLcRuY=;\n\tb=fTtRRnvP+rqk+38P1ON+UqPr2zPiGWLsN8L5TUG0uciXweKBwdnMKVOc\n\tu6yOYy9R9u+Yd/wuCo2TIJea2+jCvB7wUHy7iHP8Owayiz8+NvhNEeddD\n\t15NKAunIPmzxe6CM8hzlSayjKLQl6012UKm6ouBjuWBV+43G9Q20pYJ5y\n\tFzXbxYad3PEP4VdliegxzQrI4rwykbt4B0Pt8py11o3DoIMM9x43HQB8Q\n\tiGYSlqCIIKzN9VO8doUdeo7UP/ZisTXtAXGG/W7yGDjLAJOZHBcgsQUJg\n\tetNQlTAVAHzqWPpUIKFhqac0h1ApYWnZNiV4XorI56Eo+Sn4ummeME72W A==;","X-CSE-ConnectionGUID":["+6N7dO9aTiyHVM2gKUU0WA==","XkSJvZmxR2OIYYxAXamsfQ=="],"X-CSE-MsgGUID":["uKEoPo0LSkWYmyMMfClV9A==","98YtsLnfR+Cx9L0sQnN3EA=="],"X-IronPort-AV":["E=McAfee;i=\"6700,10204,11356\"; a=\"52307423\"","E=Sophos;i=\"6.13,314,1732608000\"; d=\"scan'208\";a=\"52307423\"","E=Sophos;i=\"6.13,314,1732608000\"; d=\"scan'208\";a=\"117033374\""],"X-ExtLoop1":"1","Date":"Tue, 25 Feb 2025 16:37:57 +0100","From":"Stanislaw Gruszka ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"Re: [PATCH v3 0/6] Fix occasional software ISP assertion error on\n\tstop","Message-ID":"","References":"<20250225150614.20195-1-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250225150614.20195-1-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33478,"web_url":"https://patchwork.libcamera.org/comment/33478/","msgid":"<85h64if203.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-02-25T16:00:28","subject":"Re: [PATCH v3 0/6] Fix occasional software ISP assertion error on\n\tstop","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Stanislaw,\n\nStanislaw Gruszka writes:\n\n> Hi Milan,\n>\n> On Tue, Feb 25, 2025 at 04:06:06PM +0100, Milan Zamazal wrote:\n>> When software ISP is stopped, there can be pending messages in the\n>> message queue that will attempt to call the already stopped IPA,\n>> resulting in an assertion error like this:\n>> \n>> FATAL default soft_ipa_proxy.cpp:456 assertion \"state_ == ProxyRunning\" failed in processStatsThread()\n>> \n>> This patch series fixes the problem and also attempts to prevent other\n>> problems related to message handling when or after software ISP is\n>> stopped.\n>\n>> Changes in v3:\n>> - Missing include added.\n>> - I/O buffers are popped from the deque’s of queued buffers rather than\n>> searched there + assertion to check it’s the intended buffer added.\n>> - Returned pending input buffers are canceled.\n>> - The thread.cpp formatting patch dropped.\n>> - The dispatching modifications patch split to several patches as\n>> suggested by Laurent.\n>> - Thread::removeMessages() documentation improved as suggested by\n>> Laurent.\n>> - SoftwareIsp::running_ dropped in the patch adding explicit SoftwareIsp\n>> messages removal.\n>> - Formatting fixes suggested by Laurent.\n>\n>\n> Tested with:\n> [PATCH] libcamera: delayed_controls: Inherit from Object class\n>\n> The assertion is fixed and I do not see any other issues with\n> the set.\n>\n> For the series:\n> Tested-by: Stanislaw Gruszka \n\nGood news, thank you for testing.\n\n> Regards\n> Stanislaw","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8BE8BF415\n\tfor ;\n\tTue, 25 Feb 2025 16:00:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A75B86871E;\n\tTue, 25 Feb 2025 17:00:40 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DED06686D6\n\tfor ;\n\tTue, 25 Feb 2025 17:00:38 +0100 (CET)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-576-lGpBzA_2OAmZBId4C2nqDg-1; Tue, 25 Feb 2025 11:00:36 -0500","by mail-wm1-f70.google.com with SMTP id\n\t5b1f17b1804b1-43941ad86d4so29681985e9.2\n\tfor ;\n\tTue, 25 Feb 2025 08:00:35 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-43ab155ebbfsm30312335e9.28.2025.02.25.08.00.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 25 Feb 2025 08:00:30 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"PpsCTg5N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1740499237;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=s/NogRjQIeyRFVwrvQ80fp1QZB3lmOM9PaHSrn0Gu20=;\n\tb=PpsCTg5NNk2/CJwI0AJlFQJkTFbQfz2mR8H7Wis+AFhBkPP/NXwt67OWxenV3oj//MLu4s\n\taOq9ZlusHZnEoiSeDxK8/jCEu2qy8WelCa/sFSMh7nCCVmcpe56Oye0iJqZWtDgOOLpPZD\n\td5XRTvJb4ofYmW/PKKtAfDjFB8RYii4=","X-MC-Unique":"lGpBzA_2OAmZBId4C2nqDg-1","X-Mimecast-MFC-AGG-ID":"lGpBzA_2OAmZBId4C2nqDg_1740499234","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1740499234; x=1741104034;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=s/NogRjQIeyRFVwrvQ80fp1QZB3lmOM9PaHSrn0Gu20=;\n\tb=omrAmZYFHfD2X04FM4elZROkW++wIggq6vbAzMBTyxISYMXF2KhuOHWTqRlWVFCyRt\n\tYtdY7XMh+nYjXGWexsG4RtTqPX42XwGIjTI5Rld4/lXEPnygtR8fuIBHGr5WrTGuib4p\n\t4PqCg2Rul7bTLMD/9YJSkasvE+vU5DwcUsXHiZVrxW6iK3Y3K3rUg8nZNdOIwwM5qGT+\n\tyrt9/1CHlGn4F8uUJAmIW18kJ/3T9yXwFAlFEbQFLBv1toM8145nCK6hCEbjZfqChhes\n\tvY2yRJOYR1AHklQm+k1OqmBi8VWMDgSmYiexCyfUlBZIEuU4bc6Ji9uNgzF1wH0iKN4p\n\to56A==","X-Gm-Message-State":"AOJu0YwQLF+oApFUR8oDqvNUZCsEBibiiCmMX+DTL8SO3B6GgHTJmYpP\n\tdAIijJHY8OENGfQXUOvggQrbzN4ZQz87ml76vn2SyUoaWltYlA4XWmDqUcWtcqfToq819tBy4FB\n\tRrNeoEPxdHyJ8bIysogEhUyp274DYhkoX7FRD717YBkfjVW/caF0gOsJRCOWgF1Z7EUOkubg=","X-Gm-Gg":"ASbGncsg+NXiz7Gt8zqQsCKHQb9ibl2tLyZGmoJu7iYz/zWjR7CgRjO7ghYXozD6bBN\n\tjxvhLAJq6TnhU2OlROnYLmaxjudlHsoFousmZNohpMydx/xEOjocIvfU7f50d3MH/97j4TJidpa\n\tjl+3JikokxxMsTeNgpivuNQlF0RvcMIGsQEtjczCy0W6V5kpBtrswsdZQhKrai3foG2Y4TxJthz\n\tmmnzOxNV/BdnhYH2R7mSrienTfl+tuEFEFstJd4r5jb8nxZo3fxxFozawrtq3oVbQxXvtks5Jq1\n\t63fh1+/mlBYm6Svd86LltPWir/iDcZIqDfp4cQwo+AakjuAy5KWh314Z4iFFR6HTkaA4","X-Received":["by 2002:a05:600c:3c95:b0:439:a88f:8523 with SMTP id\n\t5b1f17b1804b1-439aebc2d5fmr120295145e9.21.1740499233067; \n\tTue, 25 Feb 2025 08:00:33 -0800 (PST)","by 2002:a05:600c:3c95:b0:439:a88f:8523 with SMTP id\n\t5b1f17b1804b1-439aebc2d5fmr120293705e9.21.1740499230741; \n\tTue, 25 Feb 2025 08:00:30 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IF1vUTLxSb/niXJWxFA8XgjAoxnGt1rDlfYu1Ec3WzPB50ep82n57zqY/olHiQKdkTIZhex3g==","From":"Milan Zamazal ","To":"Stanislaw Gruszka ","Cc":"libcamera-devel@lists.libcamera.org, Laurent Pinchart\n\t, Kieran Bingham\n\t","Subject":"Re: [PATCH v3 0/6] Fix occasional software ISP assertion error on\n\tstop","In-Reply-To":" (Stanislaw Gruszka's message\n\tof \"Tue, 25 Feb 2025 16:37:57 +0100\")","References":"<20250225150614.20195-1-mzamazal@redhat.com>\n\t","Date":"Tue, 25 Feb 2025 17:00:28 +0100","Message-ID":"<85h64if203.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"Jcim5eG1Mf0mXKRgqFh4iK4zRcIGjFJFo3xBPt41xaU_1740499234","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]