{"id":22690,"url":"https://patchwork.libcamera.org/api/covers/22690/?format=json","web_url":"https://patchwork.libcamera.org/cover/22690/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250130173254.112895-1-mzamazal@redhat.com>","date":"2025-01-30T17:32:47","name":"[v4,0/6] ipa: simple: Introduce metadata reporting","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"mbox":"https://patchwork.libcamera.org/cover/22690/mbox/","series":[{"id":4979,"url":"https://patchwork.libcamera.org/api/series/4979/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4979","date":"2025-01-30T17:32:47","name":"ipa: simple: Introduce metadata reporting","version":4,"mbox":"https://patchwork.libcamera.org/series/4979/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/22690/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53D90C324C\n\tfor ;\n\tThu, 30 Jan 2025 17:33:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CAD368563;\n\tThu, 30 Jan 2025 18:33:07 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E4386034C\n\tfor ;\n\tThu, 30 Jan 2025 18:33:05 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-279-NHlxv99COHWW05mdrv4NgA-1;\n\tThu, 30 Jan 2025 12:33:00 -0500","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 832DC19560BB; Thu, 30 Jan 2025 17:32:59 +0000 (UTC)","from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.122])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 788EF1956094; Thu, 30 Jan 2025 17:32:57 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"afeES0D3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738258384;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=FUQnZ8uiCc/Zg901dUEmLflPzFF791i7E+KeGJTuAk4=;\n\tb=afeES0D31X1FjCDEmqgzaq8qIEzMs4+BQX9IoAkRSSCkwDGaW9o2jlt15Lq1AqKFi8/c8d\n\t6enQyCvR1O3NLhRqbUoc7mvcK9INTNleR2Q2rTYjH4M9Z78KV4p0oI80F6sK0AG433Rhwi\n\tM/RmZ7g39uIieNGQF3gyDGVskMnZGe0=","X-MC-Unique":"NHlxv99COHWW05mdrv4NgA-1","X-Mimecast-MFC-AGG-ID":"NHlxv99COHWW05mdrv4NgA","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"[PATCH v4 0/6] ipa: simple: Introduce metadata reporting","Date":"Thu, 30 Jan 2025 18:32:47 +0100","Message-ID":"<20250130173254.112895-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"lyjS6rsLvrHhNxzezp4q2_DoBkvctJoe4b6INAtSB0U_1738258379","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide metadata reporting for the software ISP. This means reporting\nmetadata itself from software ISP and adding relevant values to the\nmetadata.\n\nRunning ‘cam’ with --metadata now produces something like the following:\n\n SensorBlackLevels = [ 4096, 4096, 4096, 4096 ]\n ColourGains = [ 0.001153, 0.001145 ]\n ExposureTime = 66578\n AnalogueGain = 10.666667\n SensorTimestamp = 5466162537000\n\nChanges in v4:\n- SimpleCameraData::completeRequest just returns if frame info is not\n found.\n- SimpleCameraData::completeRequest split to completeRequest and\n tryCompleteRequest and checkCompleted argument removed.\n- SoftwareIsp::saveMetadata replaced by a lambda function.\n- blackLevels array initialization reflowed to 72 columns.\n- exposureTime converted to the right unit.\n- maybe_unused removed from a used argument.\n- Metadata is taken from frame contexts rather than from active states.\n\nChanges in v3:\n- Don't use dynamic allocation for SimpleFrames entries.\n- A tentative patch to add exposure/gain to metadata.\n\nChanges in v2:\n- Taken over from Kieran.\n- Updated for master.\n- Black level is reported as uint16_t, according to the control\n documentation.\n- Contrast value is reported in metadata.\n- The metadata used to proces the image is reported rather than the\n metadata determined from the image.\n- Metadata is reported using a new signal rather than (ab)using\n setIspParams; this change is less or more needed due to changed simple\n IPA structure since v1.\n- Frame -> request mapping is introduced to make sure the metadata is\n assigned to the right request.\n\nKieran Bingham (3):\n ipa: simple: softisp: Extend to pass metadata\n ipa: simple: Report the ColourGains in metadata\n ipa: simple: Report black levels in metadata\n\nMilan Zamazal (3):\n libcamera: software_isp: Track frames and requests\n ipa: simple: Report contrast in metadata\n ipa: simple: Report exposure in metadata\n\n .../internal/software_isp/software_isp.h | 2 +\n include/libcamera/ipa/soft.mojom | 4 +-\n src/ipa/simple/algorithms/agc.cpp | 11 +-\n src/ipa/simple/algorithms/awb.cpp | 23 +++-\n src/ipa/simple/algorithms/awb.h | 6 +-\n src/ipa/simple/algorithms/blc.cpp | 11 +-\n src/ipa/simple/algorithms/lut.cpp | 17 ++-\n src/ipa/simple/algorithms/lut.h | 5 +\n src/ipa/simple/ipa_context.h | 11 +-\n src/ipa/simple/soft_simple.cpp | 24 ++--\n src/libcamera/pipeline/simple/simple.cpp | 116 +++++++++++++++++-\n src/libcamera/software_isp/software_isp.cpp | 27 +++-\n 12 files changed, 227 insertions(+), 30 deletions(-)"}