[{"id":33110,"web_url":"https://patchwork.libcamera.org/comment/33110/","msgid":"","date":"2025-01-21T08:59:34","subject":"Re: [PATCH v9 00/12] AEGC controls","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Mon, 20 Jan 2025 at 20:45, Laurent Pinchart\n wrote:\n>\n> Hello,\n>\n> I was about to merge Paul's v8 of this series when I noticed it failed\n> to compile in v8.1 of 05/12. So close, yet so far.\n>\n> I've fixed the issue, and I'm sending a v9 to avoid another time\n> zone-induced large round-trip. The only change compared to v8 is in\n> 05/12. Naush, David, could you please have a look ?\n\nThe patch looks fine to me!\n\nNaush\n\n\n>\n> Jacopo Mondi (4):\n> libcamera: uvcvideo: Register ExposureTimeMode control\n> test: ipa_data_serialization: Use DebugMetadataEnable\n> ipa: raspberry: Port to the new AEGC controls\n> controls: Remove AeLocked\n>\n> Paul Elder (8):\n> controls: Introduce AEGC-related controls\n> Documentation: design: ae: Document the design for AE controls\n> ipa: rkisp1: Port to the new AEGC controls\n> gstreamer: Generate the new AEGC controls\n> controls: Redefine AeEnable\n> libcamera: camera: Pre-process AeEnable control\n> ipa: rkisp1: agc: Report new AeEnable control as available\n> ipa: raspberry: Report new AeEnable control as available\n>\n> Documentation/design/ae.rst | 331 ++++++++++++++++++\n> Documentation/index.rst | 4 +-\n> Documentation/meson.build | 1 +\n> src/ipa/rkisp1/algorithms/agc.cpp | 133 +++++--\n> src/ipa/rkisp1/ipa_context.cpp | 24 +-\n> src/ipa/rkisp1/ipa_context.h | 8 +-\n> src/ipa/rpi/common/ipa_base.cpp | 104 ++++--\n> src/ipa/rpi/controller/agc_algorithm.h | 8 +-\n> src/ipa/rpi/controller/rpi/agc.cpp | 52 ++-\n> src/ipa/rpi/controller/rpi/agc.h | 8 +-\n> src/ipa/rpi/controller/rpi/agc_channel.cpp | 24 +-\n> src/ipa/rpi/controller/rpi/agc_channel.h | 8 +-\n> src/libcamera/camera.cpp | 20 ++\n> src/libcamera/control_ids_core.yaml | 279 +++++++++++++--\n> src/libcamera/control_ids_draft.yaml | 30 --\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 53 ++-\n> .../ipa_data_serializer_test.cpp | 2 +-\n> utils/codegen/gen-gst-controls.py | 5 +-\n> 18 files changed, 960 insertions(+), 134 deletions(-)\n> create mode 100644 Documentation/design/ae.rst\n>\n>\n> base-commit: b01918978c8281d344d5408b3a13aab9e5af4b5d\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78F5DBD16B\n\tfor ;\n\tTue, 21 Jan 2025 09:00:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B39D68543;\n\tTue, 21 Jan 2025 10:00:10 +0100 (CET)","from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com\n\t[IPv6:2607:f8b0:4864:20::b36])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 131C468516\n\tfor ;\n\tTue, 21 Jan 2025 10:00:08 +0100 (CET)","by mail-yb1-xb36.google.com with SMTP id\n\t3f1490d57ef6-e57fc494364so91899276.0\n\tfor ;\n\tTue, 21 Jan 2025 01:00:07 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"oU/gRR9h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1737450007; x=1738054807;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=YC0wLNdZvZtTc3584COARh0MCTAcugJUxOmbIKXjvdw=;\n\tb=oU/gRR9hr1B1vsw43msrFTEx6gJTTDoH9hnqhv9oZUewS22wTYGTNynuagDrTbjeqN\n\trjZeFuLwhiqUvi+SXtlLGDxIHuPA7/U/ODgIKc7UoHEMT8AIUFyHNJAAozI0NVUKBzyl\n\taOjQ/FWE1JjnIZfiGB9L67Vbsojskxydg+Mff2K1IMGu4vBE3+H3+6t7DPb/LwVCIv2P\n\tYGmLTbtrML+zGDqugsnoQ6niafrPikRFJRusydEG8eWeZ1ImWeDMRAz24hMWCW6vQ22n\n\tFgOIQTGSnqLpCiv3Kw92w9BJ4iz6bpSgSGRrqUh+8Pu2OOumNjTLSdcmARoE0EQQa5nX\n\tkr2w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1737450007; x=1738054807;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=YC0wLNdZvZtTc3584COARh0MCTAcugJUxOmbIKXjvdw=;\n\tb=BQN8eTKnUs7zzGKnm4PEjlDXqIOHdjlEqtHbb5tS3//5CDAlfaIpzKjd4uoX58/Acw\n\tGF0syBWhTcb0CUuEwb7pTSej1r54NI0dPymKwztugKu3EaktuWTKkncrYSYhHA6Rp+Wy\n\tThJ4AyTcMSgruBnodue0P+koF7rq8YDqC1s79ogyfpPNM+ZLi3OcJdzt62gdCVseMnW3\n\tGMWCynF5+xIh4jyi/G1lbmTwMl6uhJvEFU96/rHaaa1SUthRl/+VMWiqhHAqvu0lWDll\n\tEXcZ0yywHgLiVrRCYdXjquPGDt/zfTUSTuoazo4vUQB4AdyindfsqB9Fst7cNvfw0cPr\n\teJKg==","X-Gm-Message-State":"AOJu0YykPp5wVLlM4qBkJ04EFSh1SKKF/wC/n44jTajd9W7Ay5aNdR8Y\n\tf0eUSOjp8us+RArr6uE8KeNA1pqTq226SvvhsbVhEogKxX1AOybjlQLlodO+rm1suc3kJwjA17O\n\tztSB8ImOI2LtX7qJrDrhhi+ZAtLiKUnEV2t2TPg==","X-Gm-Gg":"ASbGncuilvxWGPnS57NqBhh4y7SB9tVhjb58hAy6foBlT+tfGzb2gHU424aP3jDITO2\n\tpFD5aDH9JxyfOEaNQTfwwA+mUP5LxMUJRq7b7OT93/wMGmnSPvjiirh2zrsOZcanCVbf0J8P22C\n\tIiu4jq6g==","X-Google-Smtp-Source":"AGHT+IHIKxg2GR7Sfq1VvYYAsairtJMXcvESS+kmd/vsHlGbE0omqRVCDccM0jequ6MIyIs94uOiInlxXQqHYmOOCHM=","X-Received":"by 2002:a05:690c:4808:b0:6ef:5754:49e5 with SMTP id\n\t00721157ae682-6f6eb660bc4mr53174177b3.2.1737450006741;\n\tTue, 21 Jan 2025 01:00:06 -0800 (PST)","MIME-Version":"1.0","References":"<20250120204515.24096-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20250120204515.24096-1-laurent.pinchart@ideasonboard.com>","From":"Naushir Patuck ","Date":"Tue, 21 Jan 2025 08:59:34 +0000","X-Gm-Features":"AbW1kvYavwsSprFs9QbWF7c2cXqPxHIIMShktJRpTbBxs8EnHb2TrnLQFc6MWBw","Message-ID":"","Subject":"Re: [PATCH v9 00/12] AEGC controls","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tDavid Plowman ,\n\tPaul Elder ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]