{"id":22580,"url":"https://patchwork.libcamera.org/api/covers/22580/?format=json","web_url":"https://patchwork.libcamera.org/cover/22580/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250117143410.20363-1-dan.scally@ideasonboard.com>","date":"2025-01-17T14:34:07","name":"[0/3] Add flicker mitigation controls to AgcMeanLuminance","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/22580/mbox/","series":[{"id":4954,"url":"https://patchwork.libcamera.org/api/series/4954/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4954","date":"2025-01-17T14:34:07","name":"Add flicker mitigation controls to AgcMeanLuminance","version":1,"mbox":"https://patchwork.libcamera.org/series/4954/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/22580/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EF7BBD7D8\n\tfor ;\n\tFri, 17 Jan 2025 14:34:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A82568546;\n\tFri, 17 Jan 2025 15:34:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5126068516\n\tfor ;\n\tFri, 17 Jan 2025 15:34:21 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9BE86DE;\n\tFri, 17 Jan 2025 15:33:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XbN6NraI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737124401;\n\tbh=TVx6jVKA+RlxoKR2/KpTfZ/FnSQ5P67JGUwiFHq29DU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=XbN6NraIpw25XXcQZAf4rNccYmEysgmYHK7nwiebPpyLpIdHJp5raDD52zK7wIpZc\n\tiPFd6c1TgRZ8HTFpHtbsUBBvqVN1eQkYiWrjVS2AmCfqwU6FGopZwJu9zxD00JcfHU\n\twXFW2WnbkkyWMEV5ps/bTE3sFgOk7vxqgYb941AA=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ","Subject":"[PATCH 0/3] Add flicker mitigation controls to AgcMeanLuminance","Date":"Fri, 17 Jan 2025 14:34:07 +0000","Message-Id":"<20250117143410.20363-1-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello all\n\nThis short series adds flicker mitigation controls to each IPA that derives its\nAGC algorithm from AgcMeanLuminance. The mitigation works by adding\nAeFlickerMode and AeFlickerPeriod controls to AgcMeanLuminance - with the mode\nset to FlickerManual exposure time is capped at a multiple of AeFlickerPeriod,\nwith the reduction in exposure time offset by increases to analogue and digital\ngain.\n\nThe first patch is purely to make patch #3 slightly tidier; we have to add the\nnew function call to the algorithms queueRequest() function in the same commit\nas introducing the new controls or we end up with a commit where the IPAs are\nadvertising a control they don't actually support.\n\nThanks\nDan\n\nDaniel Scally (3):\n ipa: ipu3: Add skeleton Agc::queueRequest() function\n ipa: libipa: Adjust for flicker in ExposureModeHelper\n ipa: libipa: Add flicker controls to AgcMeanLuminance\n\n src/ipa/ipu3/algorithms/agc.cpp | 11 ++++++\n src/ipa/ipu3/algorithms/agc.h | 3 ++\n src/ipa/libipa/agc_mean_luminance.cpp | 47 ++++++++++++++++++++++++-\n src/ipa/libipa/agc_mean_luminance.h | 5 +++\n src/ipa/libipa/exposure_mode_helper.cpp | 20 ++++++++++-\n src/ipa/libipa/exposure_mode_helper.h | 2 +-\n src/ipa/mali-c55/algorithms/agc.cpp | 2 ++\n src/ipa/rkisp1/algorithms/agc.cpp | 2 ++\n 8 files changed, 89 insertions(+), 3 deletions(-)"}