[{"id":33044,"web_url":"https://patchwork.libcamera.org/comment/33044/","msgid":"<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>","date":"2025-01-13T12:12:48","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Naushir Patuck (2025-01-13 09:24:42)\n> Hi,\n> \n> A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> unchanged from the Raspberry Pi downstream libcamera tree:\n> https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> available in this series since we have yet to attempt to upstream the kernel\n> changes.\n> \n> IMPORTANT NOTE\n> --------------\n> The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> drivers with this pipeline handler. When futher upstreaming development for\n> embedded data is completed, RPi will backport the upstream kernel drives to our\n> tree and this pipeline handler will then begin to work with both upstream and\n> downstream kernel trees.\n\nThanks for posting this!\n\nThe first issue we face is the dependency in libpisp in the CI loops it\nseems:\n\nhttps://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1344547\n\nhas many failed jobs, which I believe are all going to be more or less\ninstances of:\n\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/69247972\n\n src/libcamera/pipeline/rpi/pisp/meson.build:8:14: ERROR: Dependency 'libpisp' is required but not found.\n\nI think we disable subprojects in the CI build maybe ?\n\nAny thoughts anyone?\n\nDo we need to build in libpisp into the CI as a dependency directly? Do\nwe need to manage keeping libcamera in sync with specific versions/API\ncompatibility of libpisp ?\n\n--\nKieran\n\n> \n> Thanks,\n> Naush\n> \n> Naushir Patuck (4):\n> meson: Add libpisp.wrap\n> ipa: rpi: Add support for Raspberry Pi 5\n> pipeline: rpi: Add new stream flags for PiSP\n> pipeline: rpi: Add support for Raspberry Pi 5\n> \n> Documentation/guides/pipeline-handler.rst | 2 +-\n> include/libcamera/ipa/meson.build | 1 +\n> include/libcamera/meson.build | 1 +\n> meson.build | 1 +\n> meson_options.txt | 4 +-\n> src/ipa/rpi/pisp/data/imx219.json | 1187 +++++++++\n> src/ipa/rpi/pisp/data/imx219_noir.json | 1112 ++++++++\n> src/ipa/rpi/pisp/data/imx290.json | 341 +++\n> src/ipa/rpi/pisp/data/imx296.json | 1194 +++++++++\n> src/ipa/rpi/pisp/data/imx296_16mm.json | 1247 +++++++++\n> src/ipa/rpi/pisp/data/imx296_6mm.json | 1247 +++++++++\n> src/ipa/rpi/pisp/data/imx296_mono.json | 960 +++++++\n> src/ipa/rpi/pisp/data/imx378.json | 634 +++++\n> src/ipa/rpi/pisp/data/imx415.json | 1159 ++++++++\n> src/ipa/rpi/pisp/data/imx462.json | 342 +++\n> src/ipa/rpi/pisp/data/imx477.json | 1186 +++++++++\n> src/ipa/rpi/pisp/data/imx477_16mm.json | 1240 +++++++++\n> src/ipa/rpi/pisp/data/imx477_6mm.json | 1240 +++++++++\n> src/ipa/rpi/pisp/data/imx477_noir.json | 1148 ++++++++\n> src/ipa/rpi/pisp/data/imx477_scientific.json | 546 ++++\n> src/ipa/rpi/pisp/data/imx519.json | 634 +++++\n> src/ipa/rpi/pisp/data/imx708.json | 1270 +++++++++\n> src/ipa/rpi/pisp/data/imx708_noir.json | 1233 +++++++++\n> src/ipa/rpi/pisp/data/imx708_wide.json | 1293 +++++++++\n> src/ipa/rpi/pisp/data/imx708_wide_noir.json | 1148 ++++++++\n> src/ipa/rpi/pisp/data/meson.build | 29 +\n> src/ipa/rpi/pisp/data/ov5647.json | 1186 +++++++++\n> src/ipa/rpi/pisp/data/ov5647_noir.json | 1121 ++++++++\n> src/ipa/rpi/pisp/data/ov64a40.json | 1133 ++++++++\n> src/ipa/rpi/pisp/data/ov9281_mono.json | 215 ++\n> src/ipa/rpi/pisp/data/se327m12.json | 639 +++++\n> src/ipa/rpi/pisp/data/uncalibrated.json | 135 +\n> src/ipa/rpi/pisp/meson.build | 49 +\n> src/ipa/rpi/pisp/pisp.cpp | 1068 ++++++++\n> src/libcamera/control_ids_rpi.yaml | 13 +\n> .../pipeline/rpi/common/rpi_stream.h | 10 +\n> .../pipeline/rpi/pisp/data/example.yaml | 45 +\n> .../pipeline/rpi/pisp/data/meson.build | 8 +\n> src/libcamera/pipeline/rpi/pisp/meson.build | 12 +\n> src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++\n> subprojects/.gitignore | 1 +\n> subprojects/libpisp.wrap | 6 +\n> 42 files changed, 28410 insertions(+), 2 deletions(-)\n> create mode 100644 src/ipa/rpi/pisp/data/imx219.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx219_noir.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx290.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx296.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx296_16mm.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx296_6mm.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx296_mono.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx378.json\n> create mode 100755 src/ipa/rpi/pisp/data/imx415.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx462.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477_16mm.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477_6mm.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477_noir.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477_scientific.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx519.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx708.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx708_noir.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx708_wide.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx708_wide_noir.json\n> create mode 100644 src/ipa/rpi/pisp/data/meson.build\n> create mode 100644 src/ipa/rpi/pisp/data/ov5647.json\n> create mode 100644 src/ipa/rpi/pisp/data/ov5647_noir.json\n> create mode 100755 src/ipa/rpi/pisp/data/ov64a40.json\n> create mode 100644 src/ipa/rpi/pisp/data/ov9281_mono.json\n> create mode 100644 src/ipa/rpi/pisp/data/se327m12.json\n> create mode 100644 src/ipa/rpi/pisp/data/uncalibrated.json\n> create mode 100644 src/ipa/rpi/pisp/meson.build\n> create mode 100644 src/ipa/rpi/pisp/pisp.cpp\n> create mode 100644 src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> create mode 100644 src/libcamera/pipeline/rpi/pisp/data/meson.build\n> create mode 100644 src/libcamera/pipeline/rpi/pisp/meson.build\n> create mode 100644 src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> create mode 100644 subprojects/libpisp.wrap\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E91BAC326C\n\tfor ;\n\tMon, 13 Jan 2025 12:12:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4644268503;\n\tMon, 13 Jan 2025 13:12:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99EEB684E7\n\tfor ;\n\tMon, 13 Jan 2025 13:12:52 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F08DA788;\n\tMon, 13 Jan 2025 13:11:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fq+QC1re\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736770316;\n\tbh=WrmrcldbC5z+Nbfc12yce9tnjiJ0NHopwfryMiekPKI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Fq+QC1re2DontiKWV4wqOQqL7N2UqMpN71xKSXMG1HL9IX92P+7qoJD4a/txmWJvs\n\tKl/1pQpP+g0ZQw26ZXHmdGrFJXq+ZF2EqkG4IWESys690Iu+TXvcNXgipdq63uS/8A\n\t5vvb7bCFAioj4zOU6OY1vRIhJvxR0fncxXkxDyqo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250113093532.4054142-1-naush@raspberrypi.com>","References":"<20250113093532.4054142-1-naush@raspberrypi.com>","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 13 Jan 2025 12:12:48 +0000","Message-ID":"<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33045,"web_url":"https://patchwork.libcamera.org/comment/33045/","msgid":"","date":"2025-01-13T12:29:02","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2025. január 13., hétfő 13:12 keltezéssel, Kieran Bingham írta:\n\n> Hi Naush,\n> \n> Quoting Naushir Patuck (2025-01-13 09:24:42)\n> > Hi,\n> >\n> > A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> > upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> > unchanged from the Raspberry Pi downstream libcamera tree:\n> > https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> > available in this series since we have yet to attempt to upstream the kernel\n> > changes.\n> >\n> > IMPORTANT NOTE\n> > --------------\n> > The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> > kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> > drivers with this pipeline handler. When futher upstreaming development for\n> > embedded data is completed, RPi will backport the upstream kernel drives to our\n> > tree and this pipeline handler will then begin to work with both upstream and\n> > downstream kernel trees.\n> \n> Thanks for posting this!\n> \n> The first issue we face is the dependency in libpisp in the CI loops it\n> seems:\n> \n> https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1344547\n> \n> has many failed jobs, which I believe are all going to be more or less\n> instances of:\n> \n> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/69247972\n> \n> src/libcamera/pipeline/rpi/pisp/meson.build:8:14: ERROR: Dependency 'libpisp' is required but not found.\n> \n> I think we disable subprojects in the CI build maybe ?\n> \n> Any thoughts anyone?\n\nThe `wrap_mode=nofallback` option causes the error. But `libpisp` should\nalso probably call\n\n meson.override_dependency('libpisp', libpisp_dep)\n\nin its `src/meson.build`. And then there is no need for the explicit\n`fallback: ['libpisp', 'libpisp_dep']` when calling `dependency()`.\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \n> Do we need to build in libpisp into the CI as a dependency directly? Do\n> we need to manage keeping libcamera in sync with specific versions/API\n> compatibility of libpisp ?\n> \n> --\n> Kieran\n> \n> >\n> > Thanks,\n> > Naush\n> >\n> > Naushir Patuck (4):\n> > meson: Add libpisp.wrap\n> > ipa: rpi: Add support for Raspberry Pi 5\n> > pipeline: rpi: Add new stream flags for PiSP\n> > pipeline: rpi: Add support for Raspberry Pi 5\n> >\n> > Documentation/guides/pipeline-handler.rst | 2 +-\n> > include/libcamera/ipa/meson.build | 1 +\n> > include/libcamera/meson.build | 1 +\n> > meson.build | 1 +\n> > meson_options.txt | 4 +-\n> > src/ipa/rpi/pisp/data/imx219.json | 1187 +++++++++\n> > src/ipa/rpi/pisp/data/imx219_noir.json | 1112 ++++++++\n> > src/ipa/rpi/pisp/data/imx290.json | 341 +++\n> > src/ipa/rpi/pisp/data/imx296.json | 1194 +++++++++\n> > src/ipa/rpi/pisp/data/imx296_16mm.json | 1247 +++++++++\n> > src/ipa/rpi/pisp/data/imx296_6mm.json | 1247 +++++++++\n> > src/ipa/rpi/pisp/data/imx296_mono.json | 960 +++++++\n> > src/ipa/rpi/pisp/data/imx378.json | 634 +++++\n> > src/ipa/rpi/pisp/data/imx415.json | 1159 ++++++++\n> > src/ipa/rpi/pisp/data/imx462.json | 342 +++\n> > src/ipa/rpi/pisp/data/imx477.json | 1186 +++++++++\n> > src/ipa/rpi/pisp/data/imx477_16mm.json | 1240 +++++++++\n> > src/ipa/rpi/pisp/data/imx477_6mm.json | 1240 +++++++++\n> > src/ipa/rpi/pisp/data/imx477_noir.json | 1148 ++++++++\n> > src/ipa/rpi/pisp/data/imx477_scientific.json | 546 ++++\n> > src/ipa/rpi/pisp/data/imx519.json | 634 +++++\n> > src/ipa/rpi/pisp/data/imx708.json | 1270 +++++++++\n> > src/ipa/rpi/pisp/data/imx708_noir.json | 1233 +++++++++\n> > src/ipa/rpi/pisp/data/imx708_wide.json | 1293 +++++++++\n> > src/ipa/rpi/pisp/data/imx708_wide_noir.json | 1148 ++++++++\n> > src/ipa/rpi/pisp/data/meson.build | 29 +\n> > src/ipa/rpi/pisp/data/ov5647.json | 1186 +++++++++\n> > src/ipa/rpi/pisp/data/ov5647_noir.json | 1121 ++++++++\n> > src/ipa/rpi/pisp/data/ov64a40.json | 1133 ++++++++\n> > src/ipa/rpi/pisp/data/ov9281_mono.json | 215 ++\n> > src/ipa/rpi/pisp/data/se327m12.json | 639 +++++\n> > src/ipa/rpi/pisp/data/uncalibrated.json | 135 +\n> > src/ipa/rpi/pisp/meson.build | 49 +\n> > src/ipa/rpi/pisp/pisp.cpp | 1068 ++++++++\n> > src/libcamera/control_ids_rpi.yaml | 13 +\n> > .../pipeline/rpi/common/rpi_stream.h | 10 +\n> > .../pipeline/rpi/pisp/data/example.yaml | 45 +\n> > .../pipeline/rpi/pisp/data/meson.build | 8 +\n> > src/libcamera/pipeline/rpi/pisp/meson.build | 12 +\n> > src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++\n> > subprojects/.gitignore | 1 +\n> > subprojects/libpisp.wrap | 6 +\n> > 42 files changed, 28410 insertions(+), 2 deletions(-)\n> > create mode 100644 src/ipa/rpi/pisp/data/imx219.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx219_noir.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx290.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx296.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx296_16mm.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx296_6mm.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx296_mono.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx378.json\n> > create mode 100755 src/ipa/rpi/pisp/data/imx415.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx462.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477_16mm.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477_6mm.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477_noir.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477_scientific.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx519.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx708.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx708_noir.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide_noir.json\n> > create mode 100644 src/ipa/rpi/pisp/data/meson.build\n> > create mode 100644 src/ipa/rpi/pisp/data/ov5647.json\n> > create mode 100644 src/ipa/rpi/pisp/data/ov5647_noir.json\n> > create mode 100755 src/ipa/rpi/pisp/data/ov64a40.json\n> > create mode 100644 src/ipa/rpi/pisp/data/ov9281_mono.json\n> > create mode 100644 src/ipa/rpi/pisp/data/se327m12.json\n> > create mode 100644 src/ipa/rpi/pisp/data/uncalibrated.json\n> > create mode 100644 src/ipa/rpi/pisp/meson.build\n> > create mode 100644 src/ipa/rpi/pisp/pisp.cpp\n> > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/meson.build\n> > create mode 100644 src/libcamera/pipeline/rpi/pisp/meson.build\n> > create mode 100644 src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> > create mode 100644 subprojects/libpisp.wrap\n> >\n> > --\n> > 2.43.0\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF2B2C32F6\n\tfor ;\n\tMon, 13 Jan 2025 12:30:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F18D66851C;\n\tMon, 13 Jan 2025 13:30:34 +0100 (CET)","from mail-40133.protonmail.ch (mail-40133.protonmail.ch\n\t[185.70.40.133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 921B6684E7\n\tfor ;\n\tMon, 13 Jan 2025 13:30:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"S6D8MwPA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1736771432; x=1737030632;\n\tbh=GoV4Wb7fJneqYVEmGiiDfP5s1H6VhfyYG+ExdFIPsPk=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=S6D8MwPAcyKCs0p8wWkkFXmONK682vaEg8tAnTbHFKqWvFfgK2I+Uyc+nODA4ZgTy\n\tjvb77kMKlWEQIm9ZMMeZjQBt6egEltebgBZMJ2sI6sueuGcImpQqpSt53fGn+QdOtG\n\tVvVdg5w2KUpbQE5Z4PLj20DIhvcDkx12m/Upgsc65Aotz7aZnnZEO7V3Ip21d8Z7yh\n\tG/lr/h/9OQuTkXeVQQw+9FLwi4SFSbTMMgZjSVbsU37okwtvUaqcIrEvBKI/36hf9D\n\tuio8EhhMSrg3uueKF2Mnfqp+ed0mIYb6cULWQ9VD9cAcZNTjWC7q7+o120+6g3P1sh\n\tcKLZXqCdw6jKg==","Date":"Mon, 13 Jan 2025 12:29:02 +0000","To":"Kieran Bingham ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","Message-ID":"","In-Reply-To":"<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"a174451d3b8f99cdb83e8f055d532de5df31b9b5","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33072,"web_url":"https://patchwork.libcamera.org/comment/33072/","msgid":"","date":"2025-01-14T09:54:38","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\nOn Mon, 13 Jan 2025 at 12:30, Barnabás Pőcze wrote:\n>\n> Hi\n>\n>\n> 2025. január 13., hétfő 13:12 keltezéssel, Kieran Bingham írta:\n>\n> > Hi Naush,\n> >\n> > Quoting Naushir Patuck (2025-01-13 09:24:42)\n> > > Hi,\n> > >\n> > > A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> > > upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> > > unchanged from the Raspberry Pi downstream libcamera tree:\n> > > https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> > > available in this series since we have yet to attempt to upstream the kernel\n> > > changes.\n> > >\n> > > IMPORTANT NOTE\n> > > --------------\n> > > The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> > > kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> > > drivers with this pipeline handler. When futher upstreaming development for\n> > > embedded data is completed, RPi will backport the upstream kernel drives to our\n> > > tree and this pipeline handler will then begin to work with both upstream and\n> > > downstream kernel trees.\n> >\n> > Thanks for posting this!\n> >\n> > The first issue we face is the dependency in libpisp in the CI loops it\n> > seems:\n> >\n> > https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1344547\n> >\n> > has many failed jobs, which I believe are all going to be more or less\n> > instances of:\n> >\n> > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/69247972\n> >\n> > src/libcamera/pipeline/rpi/pisp/meson.build:8:14: ERROR: Dependency 'libpisp' is required but not found.\n> >\n> > I think we disable subprojects in the CI build maybe ?\n> >\n> > Any thoughts anyone?\n>\n> The `wrap_mode=nofallback` option causes the error. But `libpisp` should\n> also probably call\n>\n> meson.override_dependency('libpisp', libpisp_dep)\n>\n> in its `src/meson.build`. And then there is no need for the explicit\n> `fallback: ['libpisp', 'libpisp_dep']` when calling `dependency()`.\n\nI presume this is just a syntactic change and will not fix the CI\nissue? I can remove the libpisp wrap file and have a hard dependency\non libpisp for the pipeline handler/ipa, but that will mean it won't\nbe tested under CI...\n\nNaush\n\n>\n>\n> Regards,\n> Barnabás Pőcze\n>\n>\n> >\n> > Do we need to build in libpisp into the CI as a dependency directly? Do\n> > we need to manage keeping libcamera in sync with specific versions/API\n> > compatibility of libpisp ?\n> >\n> > --\n> > Kieran\n> >\n> > >\n> > > Thanks,\n> > > Naush\n> > >\n> > > Naushir Patuck (4):\n> > > meson: Add libpisp.wrap\n> > > ipa: rpi: Add support for Raspberry Pi 5\n> > > pipeline: rpi: Add new stream flags for PiSP\n> > > pipeline: rpi: Add support for Raspberry Pi 5\n> > >\n> > > Documentation/guides/pipeline-handler.rst | 2 +-\n> > > include/libcamera/ipa/meson.build | 1 +\n> > > include/libcamera/meson.build | 1 +\n> > > meson.build | 1 +\n> > > meson_options.txt | 4 +-\n> > > src/ipa/rpi/pisp/data/imx219.json | 1187 +++++++++\n> > > src/ipa/rpi/pisp/data/imx219_noir.json | 1112 ++++++++\n> > > src/ipa/rpi/pisp/data/imx290.json | 341 +++\n> > > src/ipa/rpi/pisp/data/imx296.json | 1194 +++++++++\n> > > src/ipa/rpi/pisp/data/imx296_16mm.json | 1247 +++++++++\n> > > src/ipa/rpi/pisp/data/imx296_6mm.json | 1247 +++++++++\n> > > src/ipa/rpi/pisp/data/imx296_mono.json | 960 +++++++\n> > > src/ipa/rpi/pisp/data/imx378.json | 634 +++++\n> > > src/ipa/rpi/pisp/data/imx415.json | 1159 ++++++++\n> > > src/ipa/rpi/pisp/data/imx462.json | 342 +++\n> > > src/ipa/rpi/pisp/data/imx477.json | 1186 +++++++++\n> > > src/ipa/rpi/pisp/data/imx477_16mm.json | 1240 +++++++++\n> > > src/ipa/rpi/pisp/data/imx477_6mm.json | 1240 +++++++++\n> > > src/ipa/rpi/pisp/data/imx477_noir.json | 1148 ++++++++\n> > > src/ipa/rpi/pisp/data/imx477_scientific.json | 546 ++++\n> > > src/ipa/rpi/pisp/data/imx519.json | 634 +++++\n> > > src/ipa/rpi/pisp/data/imx708.json | 1270 +++++++++\n> > > src/ipa/rpi/pisp/data/imx708_noir.json | 1233 +++++++++\n> > > src/ipa/rpi/pisp/data/imx708_wide.json | 1293 +++++++++\n> > > src/ipa/rpi/pisp/data/imx708_wide_noir.json | 1148 ++++++++\n> > > src/ipa/rpi/pisp/data/meson.build | 29 +\n> > > src/ipa/rpi/pisp/data/ov5647.json | 1186 +++++++++\n> > > src/ipa/rpi/pisp/data/ov5647_noir.json | 1121 ++++++++\n> > > src/ipa/rpi/pisp/data/ov64a40.json | 1133 ++++++++\n> > > src/ipa/rpi/pisp/data/ov9281_mono.json | 215 ++\n> > > src/ipa/rpi/pisp/data/se327m12.json | 639 +++++\n> > > src/ipa/rpi/pisp/data/uncalibrated.json | 135 +\n> > > src/ipa/rpi/pisp/meson.build | 49 +\n> > > src/ipa/rpi/pisp/pisp.cpp | 1068 ++++++++\n> > > src/libcamera/control_ids_rpi.yaml | 13 +\n> > > .../pipeline/rpi/common/rpi_stream.h | 10 +\n> > > .../pipeline/rpi/pisp/data/example.yaml | 45 +\n> > > .../pipeline/rpi/pisp/data/meson.build | 8 +\n> > > src/libcamera/pipeline/rpi/pisp/meson.build | 12 +\n> > > src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++\n> > > subprojects/.gitignore | 1 +\n> > > subprojects/libpisp.wrap | 6 +\n> > > 42 files changed, 28410 insertions(+), 2 deletions(-)\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx219.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx219_noir.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx290.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx296.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx296_16mm.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx296_6mm.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx296_mono.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx378.json\n> > > create mode 100755 src/ipa/rpi/pisp/data/imx415.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx462.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx477.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx477_16mm.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx477_6mm.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx477_noir.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx477_scientific.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx519.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx708.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx708_noir.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide_noir.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/meson.build\n> > > create mode 100644 src/ipa/rpi/pisp/data/ov5647.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/ov5647_noir.json\n> > > create mode 100755 src/ipa/rpi/pisp/data/ov64a40.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/ov9281_mono.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/se327m12.json\n> > > create mode 100644 src/ipa/rpi/pisp/data/uncalibrated.json\n> > > create mode 100644 src/ipa/rpi/pisp/meson.build\n> > > create mode 100644 src/ipa/rpi/pisp/pisp.cpp\n> > > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> > > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/meson.build\n> > > create mode 100644 src/libcamera/pipeline/rpi/pisp/meson.build\n> > > create mode 100644 src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> > > create mode 100644 subprojects/libpisp.wrap\n> > >\n> > > --\n> > > 2.43.0\n> > >\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10DCCC3303\n\tfor ;\n\tTue, 14 Jan 2025 09:55:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFCE66851C;\n\tTue, 14 Jan 2025 10:55:13 +0100 (CET)","from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com\n\t[IPv6:2607:f8b0:4864:20::b31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C8BC608A9\n\tfor ;\n\tTue, 14 Jan 2025 10:55:11 +0100 (CET)","by mail-yb1-xb31.google.com with SMTP id\n\t3f1490d57ef6-e545f6750abso963398276.2\n\tfor ;\n\tTue, 14 Jan 2025 01:55:11 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"HPQ6eylS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1736848510; x=1737453310;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ue5wZ64xl7E31xn6szaKkCySQtWzRGyK3JwAxogAcFU=;\n\tb=HPQ6eylSPJfeg1fUnt+MiaR+PNoaLZFv3DbOb2Wf6h2gRCT2DzsRX8gJJRgtvsuFAc\n\tJgPVqWd5TPiG4tr63uaUN2OgR6hDmaPRF9Ase7CKrNXYDAhogrz79IwnjflCv8cq7THT\n\t9ufCX1X5YwxKfHPVIcFA3rkmlnLyBjd1gCiDo+WjUfZLMzUCzAmUuNDvAtNkWnDzadzC\n\tNZRzfyWkMFEyQX/Gl2C2MTiKQmBZIgHzQhXYoe71cfznHMOVAUPJINFuiJ6YU90y/WOW\n\ts/8fjpX1/JeCR/yUggHSYrF44FacH51k5kr/gbzaeBhocVAWNQXy3EFSk9YagzBSrRUk\n\t7+zw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1736848510; x=1737453310;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=ue5wZ64xl7E31xn6szaKkCySQtWzRGyK3JwAxogAcFU=;\n\tb=Gb1KF4FRuiWrxRPOsRY6HIx2nmhLjNoDkuddGkNAsaTI413V3NWRjcY+oqfI0+eNEV\n\t0MsclyTYdqE4c5Bmp/CiHMpJHmc3RRCUtMURn85uV+Nd2XISnhNIZ1z5q80WVx6fcon2\n\t0Xt0WSM4rJ5BJ4nhzyiA10UkcC97fjjdcg01nMYe3XVrJvnFiVFmhQ3Xd0DZYCoH7WFb\n\tXQw61hXn7SdxiPI8CXZI0Fe+MzCJiybRCjW9dteCkizg/wdntkA6iJktQAXDnyt3La6h\n\txBXD8hhafhG/GEF1rfY/R9DyL1xJWGS5ZsusSVnQMh4Xqgg0ymTzhYJlXIjKIvfVWHOQ\n\t036Q==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWQajHEYXn/hiGTf0lGSyQCwDpS2vIXWR7DGBqSO0GdWlgXwQugTeyMPZTz6D3zCEBpmUhCKlYKahlHZrQ7GM8=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YyoFSFSqhrBAlyhqOHXmgLWXg5ohJr41Mhwuf85mTiB9LD87FJS\n\t6LayfL5SjEsBWPskNX9pz5sZYcskhJPatB6+D0o1UuXiQp21zW0xpPp+lBKBpb5C3mjHh1+1qiP\n\tr7cB7muaTA8LRykPY4TpIrEyfZVUrkUrUnRbdPIsfMI/qnC7UVfI=","X-Gm-Gg":"ASbGnctptgOvIzQbj57eaAPlAOwobKOgelXOAD+ikxSVgGjmmb4b78iLfih7mooG0Q6\n\tGbd3tss6n+acIEHSPWyk566683j9cSoq9hqczCw2GeMM6tbWvp/tM69lAv2TyohGsxY2Wlw==","X-Google-Smtp-Source":"AGHT+IHGyQi6KyCRS+vFPoiJJBR1tkI2CDRw1FhTsPWNB60oO6DsZyCpNjSE/JAfc1Azvy+SCebYzSY2wCOyErM8sI4=","X-Received":"by 2002:a05:6902:10c8:b0:e4a:ea18:b43a with SMTP id\n\t3f1490d57ef6-e54ee229271mr8144757276.7.1736848510149; Tue, 14 Jan 2025\n\t01:55:10 -0800 (PST)","MIME-Version":"1.0","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Tue, 14 Jan 2025 09:54:38 +0000","X-Gm-Features":"AbW1kvZOlq5NzNSvB8wGsXuar_wHNt3yWEDtqSWw-JFZOISyu1bzZMQb978kyFQ","Message-ID":"","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33073,"web_url":"https://patchwork.libcamera.org/comment/33073/","msgid":"","date":"2025-01-14T16:29:14","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2025. január 14., kedd 10:54 keltezéssel, Naushir Patuck írta:\n\n> Hi,\n> \n> On Mon, 13 Jan 2025 at 12:30, Barnabás Pőcze wrote:\n> >\n> > Hi\n> >\n> >\n> > 2025. január 13., hétfő 13:12 keltezéssel, Kieran Bingham írta:\n> >\n> > > Hi Naush,\n> > >\n> > > Quoting Naushir Patuck (2025-01-13 09:24:42)\n> > > > Hi,\n> > > >\n> > > > A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> > > > upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> > > > unchanged from the Raspberry Pi downstream libcamera tree:\n> > > > https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> > > > available in this series since we have yet to attempt to upstream the kernel\n> > > > changes.\n> > > >\n> > > > IMPORTANT NOTE\n> > > > --------------\n> > > > The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> > > > kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> > > > drivers with this pipeline handler. When futher upstreaming development for\n> > > > embedded data is completed, RPi will backport the upstream kernel drives to our\n> > > > tree and this pipeline handler will then begin to work with both upstream and\n> > > > downstream kernel trees.\n> > >\n> > > Thanks for posting this!\n> > >\n> > > The first issue we face is the dependency in libpisp in the CI loops it\n> > > seems:\n> > >\n> > > https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1344547\n> > >\n> > > has many failed jobs, which I believe are all going to be more or less\n> > > instances of:\n> > >\n> > > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/69247972\n> > >\n> > > src/libcamera/pipeline/rpi/pisp/meson.build:8:14: ERROR: Dependency 'libpisp' is required but not found.\n> > >\n> > > I think we disable subprojects in the CI build maybe ?\n> > >\n> > > Any thoughts anyone?\n> >\n> > The `wrap_mode=nofallback` option causes the error. But `libpisp` should\n> > also probably call\n> >\n> > meson.override_dependency('libpisp', libpisp_dep)\n> >\n> > in its `src/meson.build`. And then there is no need for the explicit\n> > `fallback: ['libpisp', 'libpisp_dep']` when calling `dependency()`.\n> \n> I presume this is just a syntactic change and will not fix the CI\n> issue? I can remove the libpisp wrap file and have a hard dependency\n> on libpisp for the pipeline handler/ipa, but that will mean it won't\n> be tested under CI...\n\nYes, this will not solve the issue, but useful nonetheless. It would appear that\n`-D force_fallback_for=libpisp` is enough to make it work, but there are other\njobs that want to use that option, and multiple occurrences overwrite each other.\nI am not sure what the best approach is. `--wrap-mode=nofallback` could be removed\naltogether, or replaced with `--wrap-mode=nodownload` + some magic to bring in the\nnecessary dependencies, or something else.\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \n> Naush\n> \n> >\n> >\n> > Regards,\n> > Barnabás Pőcze\n> >\n> >\n> > >\n> > > Do we need to build in libpisp into the CI as a dependency directly? Do\n> > > we need to manage keeping libcamera in sync with specific versions/API\n> > > compatibility of libpisp ?\n> > >\n> > > --\n> > > Kieran\n> > >\n> > > >\n> > > > Thanks,\n> > > > Naush\n> > > >\n> > > > Naushir Patuck (4):\n> > > > meson: Add libpisp.wrap\n> > > > ipa: rpi: Add support for Raspberry Pi 5\n> > > > pipeline: rpi: Add new stream flags for PiSP\n> > > > pipeline: rpi: Add support for Raspberry Pi 5\n> > > >\n> > > > Documentation/guides/pipeline-handler.rst | 2 +-\n> > > > include/libcamera/ipa/meson.build | 1 +\n> > > > include/libcamera/meson.build | 1 +\n> > > > meson.build | 1 +\n> > > > meson_options.txt | 4 +-\n> > > > src/ipa/rpi/pisp/data/imx219.json | 1187 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx219_noir.json | 1112 ++++++++\n> > > > src/ipa/rpi/pisp/data/imx290.json | 341 +++\n> > > > src/ipa/rpi/pisp/data/imx296.json | 1194 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx296_16mm.json | 1247 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx296_6mm.json | 1247 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx296_mono.json | 960 +++++++\n> > > > src/ipa/rpi/pisp/data/imx378.json | 634 +++++\n> > > > src/ipa/rpi/pisp/data/imx415.json | 1159 ++++++++\n> > > > src/ipa/rpi/pisp/data/imx462.json | 342 +++\n> > > > src/ipa/rpi/pisp/data/imx477.json | 1186 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx477_16mm.json | 1240 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx477_6mm.json | 1240 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx477_noir.json | 1148 ++++++++\n> > > > src/ipa/rpi/pisp/data/imx477_scientific.json | 546 ++++\n> > > > src/ipa/rpi/pisp/data/imx519.json | 634 +++++\n> > > > src/ipa/rpi/pisp/data/imx708.json | 1270 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx708_noir.json | 1233 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx708_wide.json | 1293 +++++++++\n> > > > src/ipa/rpi/pisp/data/imx708_wide_noir.json | 1148 ++++++++\n> > > > src/ipa/rpi/pisp/data/meson.build | 29 +\n> > > > src/ipa/rpi/pisp/data/ov5647.json | 1186 +++++++++\n> > > > src/ipa/rpi/pisp/data/ov5647_noir.json | 1121 ++++++++\n> > > > src/ipa/rpi/pisp/data/ov64a40.json | 1133 ++++++++\n> > > > src/ipa/rpi/pisp/data/ov9281_mono.json | 215 ++\n> > > > src/ipa/rpi/pisp/data/se327m12.json | 639 +++++\n> > > > src/ipa/rpi/pisp/data/uncalibrated.json | 135 +\n> > > > src/ipa/rpi/pisp/meson.build | 49 +\n> > > > src/ipa/rpi/pisp/pisp.cpp | 1068 ++++++++\n> > > > src/libcamera/control_ids_rpi.yaml | 13 +\n> > > > .../pipeline/rpi/common/rpi_stream.h | 10 +\n> > > > .../pipeline/rpi/pisp/data/example.yaml | 45 +\n> > > > .../pipeline/rpi/pisp/data/meson.build | 8 +\n> > > > src/libcamera/pipeline/rpi/pisp/meson.build | 12 +\n> > > > src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++\n> > > > subprojects/.gitignore | 1 +\n> > > > subprojects/libpisp.wrap | 6 +\n> > > > 42 files changed, 28410 insertions(+), 2 deletions(-)\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx219.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx219_noir.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx290.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx296.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx296_16mm.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx296_6mm.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx296_mono.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx378.json\n> > > > create mode 100755 src/ipa/rpi/pisp/data/imx415.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx462.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx477.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_16mm.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_6mm.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_noir.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_scientific.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx519.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx708.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx708_noir.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide_noir.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/meson.build\n> > > > create mode 100644 src/ipa/rpi/pisp/data/ov5647.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/ov5647_noir.json\n> > > > create mode 100755 src/ipa/rpi/pisp/data/ov64a40.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/ov9281_mono.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/se327m12.json\n> > > > create mode 100644 src/ipa/rpi/pisp/data/uncalibrated.json\n> > > > create mode 100644 src/ipa/rpi/pisp/meson.build\n> > > > create mode 100644 src/ipa/rpi/pisp/pisp.cpp\n> > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/meson.build\n> > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/meson.build\n> > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> > > > create mode 100644 subprojects/libpisp.wrap\n> > > >\n> > > > --\n> > > > 2.43.0\n> > > >\n> > >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9192C3304\n\tfor ;\n\tTue, 14 Jan 2025 16:29:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42950607D6;\n\tTue, 14 Jan 2025 17:29:20 +0100 (CET)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31726607D6\n\tfor ;\n\tTue, 14 Jan 2025 17:29:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"W8wEXmbb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1736872158; x=1737131358;\n\tbh=ltB86uIkswT1Kv1sYSkDWdyuJ3AmthBnmnlLsTdycHg=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=W8wEXmbbz5GvoqUM8ZULO7SCZo3jW77pZnUgXCWUnkXeRnFGo6xrRooBSygrBeRwx\n\ttVb/xoj1Exwiuxod/Sq/7Hzv8H0LNqq8e3XqDu9AYyGdEORbV4+s9yqVZVnuNqZMea\n\tuXcB+pQEMzA3ORldmuZCjj1QneYIJWdG8P+EFMWWXGAOobxy7RP+db0eR7v4u2AINN\n\tcZKsj/Zx6/y9IOoQuTjgfk/JEU/4ZCYfHR4GElqIknKZfdZFHTJJiy3ARTUvsGUkXR\n\tjTGmO3DlNEV0n+YmccxKoCEXzhOqm+YuvuG0nSogUB+XmjHjGnKNehIjJFC69L+Uqo\n\t87gXkNy64HBZw==","Date":"Tue, 14 Jan 2025 16:29:14 +0000","To":"Naushir Patuck ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","Message-ID":"","In-Reply-To":"","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>\n\t\n\t","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"51eba6e14648f64754ca735f9db4826c45fd628d","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33074,"web_url":"https://patchwork.libcamera.org/comment/33074/","msgid":"<20250114204618.GC29414@pendragon.ideasonboard.com>","date":"2025-01-14T20:46:18","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 14, 2025 at 04:29:14PM +0000, Barnabás Pőcze wrote:\n> 2025. január 14., kedd 10:54 keltezéssel, Naushir Patuck írta:\n> > On Mon, 13 Jan 2025 at 12:30, Barnabás Pőcze wrote:\n> > > 2025. január 13., hétfő 13:12 keltezéssel, Kieran Bingham írta:\n> > > > Quoting Naushir Patuck (2025-01-13 09:24:42)\n> > > > > Hi,\n> > > > >\n> > > > > A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> > > > > upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> > > > > unchanged from the Raspberry Pi downstream libcamera tree:\n> > > > > https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> > > > > available in this series since we have yet to attempt to upstream the kernel\n> > > > > changes.\n> > > > >\n> > > > > IMPORTANT NOTE\n> > > > > --------------\n> > > > > The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> > > > > kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> > > > > drivers with this pipeline handler. When futher upstreaming development for\n> > > > > embedded data is completed, RPi will backport the upstream kernel drives to our\n> > > > > tree and this pipeline handler will then begin to work with both upstream and\n> > > > > downstream kernel trees.\n> > > >\n> > > > Thanks for posting this!\n> > > >\n> > > > The first issue we face is the dependency in libpisp in the CI loops it\n> > > > seems:\n> > > >\n> > > > https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1344547\n> > > >\n> > > > has many failed jobs, which I believe are all going to be more or less\n> > > > instances of:\n> > > >\n> > > > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/69247972\n> > > >\n> > > > src/libcamera/pipeline/rpi/pisp/meson.build:8:14: ERROR: Dependency 'libpisp' is required but not found.\n> > > >\n> > > > I think we disable subprojects in the CI build maybe ?\n> > > >\n> > > > Any thoughts anyone?\n> > >\n> > > The `wrap_mode=nofallback` option causes the error. But `libpisp` should\n> > > also probably call\n> > >\n> > > meson.override_dependency('libpisp', libpisp_dep)\n> > >\n> > > in its `src/meson.build`. And then there is no need for the explicit\n> > > `fallback: ['libpisp', 'libpisp_dep']` when calling `dependency()`.\n> > \n> > I presume this is just a syntactic change and will not fix the CI\n> > issue? I can remove the libpisp wrap file and have a hard dependency\n> > on libpisp for the pipeline handler/ipa, but that will mean it won't\n> > be tested under CI...\n> \n> Yes, this will not solve the issue, but useful nonetheless. It would appear that\n> `-D force_fallback_for=libpisp` is enough to make it work, but there are other\n> jobs that want to use that option, and multiple occurrences overwrite each other.\n> I am not sure what the best approach is. `--wrap-mode=nofallback` could be removed\n> altogether, or replaced with `--wrap-mode=nodownload` + some magic to bring in the\n> necessary dependencies, or something else.\n\nIf we have to compile the dependencies from source, I would rather do\nthis at container build time to avoid CI failures unrelated to libcamera\nitself.\n\n> > > > Do we need to build in libpisp into the CI as a dependency directly? Do\n> > > > we need to manage keeping libcamera in sync with specific versions/API\n> > > > compatibility of libpisp ?\n> > > >\n> > > > > Naushir Patuck (4):\n> > > > > meson: Add libpisp.wrap\n> > > > > ipa: rpi: Add support for Raspberry Pi 5\n> > > > > pipeline: rpi: Add new stream flags for PiSP\n> > > > > pipeline: rpi: Add support for Raspberry Pi 5\n> > > > >\n> > > > > Documentation/guides/pipeline-handler.rst | 2 +-\n> > > > > include/libcamera/ipa/meson.build | 1 +\n> > > > > include/libcamera/meson.build | 1 +\n> > > > > meson.build | 1 +\n> > > > > meson_options.txt | 4 +-\n> > > > > src/ipa/rpi/pisp/data/imx219.json | 1187 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx219_noir.json | 1112 ++++++++\n> > > > > src/ipa/rpi/pisp/data/imx290.json | 341 +++\n> > > > > src/ipa/rpi/pisp/data/imx296.json | 1194 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx296_16mm.json | 1247 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx296_6mm.json | 1247 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx296_mono.json | 960 +++++++\n> > > > > src/ipa/rpi/pisp/data/imx378.json | 634 +++++\n> > > > > src/ipa/rpi/pisp/data/imx415.json | 1159 ++++++++\n> > > > > src/ipa/rpi/pisp/data/imx462.json | 342 +++\n> > > > > src/ipa/rpi/pisp/data/imx477.json | 1186 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx477_16mm.json | 1240 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx477_6mm.json | 1240 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx477_noir.json | 1148 ++++++++\n> > > > > src/ipa/rpi/pisp/data/imx477_scientific.json | 546 ++++\n> > > > > src/ipa/rpi/pisp/data/imx519.json | 634 +++++\n> > > > > src/ipa/rpi/pisp/data/imx708.json | 1270 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx708_noir.json | 1233 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx708_wide.json | 1293 +++++++++\n> > > > > src/ipa/rpi/pisp/data/imx708_wide_noir.json | 1148 ++++++++\n> > > > > src/ipa/rpi/pisp/data/meson.build | 29 +\n> > > > > src/ipa/rpi/pisp/data/ov5647.json | 1186 +++++++++\n> > > > > src/ipa/rpi/pisp/data/ov5647_noir.json | 1121 ++++++++\n> > > > > src/ipa/rpi/pisp/data/ov64a40.json | 1133 ++++++++\n> > > > > src/ipa/rpi/pisp/data/ov9281_mono.json | 215 ++\n> > > > > src/ipa/rpi/pisp/data/se327m12.json | 639 +++++\n> > > > > src/ipa/rpi/pisp/data/uncalibrated.json | 135 +\n> > > > > src/ipa/rpi/pisp/meson.build | 49 +\n> > > > > src/ipa/rpi/pisp/pisp.cpp | 1068 ++++++++\n> > > > > src/libcamera/control_ids_rpi.yaml | 13 +\n> > > > > .../pipeline/rpi/common/rpi_stream.h | 10 +\n> > > > > .../pipeline/rpi/pisp/data/example.yaml | 45 +\n> > > > > .../pipeline/rpi/pisp/data/meson.build | 8 +\n> > > > > src/libcamera/pipeline/rpi/pisp/meson.build | 12 +\n> > > > > src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++\n> > > > > subprojects/.gitignore | 1 +\n> > > > > subprojects/libpisp.wrap | 6 +\n> > > > > 42 files changed, 28410 insertions(+), 2 deletions(-)\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx219.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx219_noir.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx290.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx296.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx296_16mm.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx296_6mm.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx296_mono.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx378.json\n> > > > > create mode 100755 src/ipa/rpi/pisp/data/imx415.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx462.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_16mm.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_6mm.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_noir.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_scientific.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx519.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx708.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx708_noir.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide_noir.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/meson.build\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/ov5647.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/ov5647_noir.json\n> > > > > create mode 100755 src/ipa/rpi/pisp/data/ov64a40.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/ov9281_mono.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/se327m12.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/data/uncalibrated.json\n> > > > > create mode 100644 src/ipa/rpi/pisp/meson.build\n> > > > > create mode 100644 src/ipa/rpi/pisp/pisp.cpp\n> > > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> > > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/meson.build\n> > > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/meson.build\n> > > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> > > > > create mode 100644 subprojects/libpisp.wrap","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE3FBC3304\n\tfor ;\n\tTue, 14 Jan 2025 20:46:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A96C1684E4;\n\tTue, 14 Jan 2025 21:46:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A967607D6\n\tfor ;\n\tTue, 14 Jan 2025 21:46:24 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1746160;\n\tTue, 14 Jan 2025 21:45:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CNlnz6/3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736887526;\n\tbh=E/30Ve2qL87yFRo72zPTB5c1bP1h96JeQlcTni7EBsU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CNlnz6/3+ZBfIy6ANPEOBJZ6UXNQBKRY7AAdJ4mtY9fkdOODMppxGCVEJzFO2g4c2\n\tLbGk3z0ZIYJ+ZzTJHnPc+fZacFEGY6wO/FWVNBpK7MDU9qW06+t4q+uMWRKC1BONvd\n\tBs1Lzl8weBgeZhWbYkqIM4/t9gtwwhQFLcgTZntI=","Date":"Tue, 14 Jan 2025 22:46:18 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Naushir Patuck ,\n\tKieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","Message-ID":"<20250114204618.GC29414@pendragon.ideasonboard.com>","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>\n\t\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33075,"web_url":"https://patchwork.libcamera.org/comment/33075/","msgid":"<20250114205140.GD29414@pendragon.ideasonboard.com>","date":"2025-01-14T20:51:40","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 14, 2025 at 10:46:18PM +0200, Laurent Pinchart wrote:\n> On Tue, Jan 14, 2025 at 04:29:14PM +0000, Barnabás Pőcze wrote:\n> > 2025. január 14., kedd 10:54 keltezéssel, Naushir Patuck írta:\n> > > On Mon, 13 Jan 2025 at 12:30, Barnabás Pőcze wrote:\n> > > > 2025. január 13., hétfő 13:12 keltezéssel, Kieran Bingham írta:\n> > > > > Quoting Naushir Patuck (2025-01-13 09:24:42)\n> > > > > > Hi,\n> > > > > >\n> > > > > > A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> > > > > > upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> > > > > > unchanged from the Raspberry Pi downstream libcamera tree:\n> > > > > > https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> > > > > > available in this series since we have yet to attempt to upstream the kernel\n> > > > > > changes.\n> > > > > >\n> > > > > > IMPORTANT NOTE\n> > > > > > --------------\n> > > > > > The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> > > > > > kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> > > > > > drivers with this pipeline handler. When futher upstreaming development for\n> > > > > > embedded data is completed, RPi will backport the upstream kernel drives to our\n> > > > > > tree and this pipeline handler will then begin to work with both upstream and\n> > > > > > downstream kernel trees.\n> > > > >\n> > > > > Thanks for posting this!\n> > > > >\n> > > > > The first issue we face is the dependency in libpisp in the CI loops it\n> > > > > seems:\n> > > > >\n> > > > > https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1344547\n> > > > >\n> > > > > has many failed jobs, which I believe are all going to be more or less\n> > > > > instances of:\n> > > > >\n> > > > > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/69247972\n> > > > >\n> > > > > src/libcamera/pipeline/rpi/pisp/meson.build:8:14: ERROR: Dependency 'libpisp' is required but not found.\n> > > > >\n> > > > > I think we disable subprojects in the CI build maybe ?\n> > > > >\n> > > > > Any thoughts anyone?\n> > > >\n> > > > The `wrap_mode=nofallback` option causes the error. But `libpisp` should\n> > > > also probably call\n> > > >\n> > > > meson.override_dependency('libpisp', libpisp_dep)\n> > > >\n> > > > in its `src/meson.build`. And then there is no need for the explicit\n> > > > `fallback: ['libpisp', 'libpisp_dep']` when calling `dependency()`.\n> > > \n> > > I presume this is just a syntactic change and will not fix the CI\n> > > issue? I can remove the libpisp wrap file and have a hard dependency\n> > > on libpisp for the pipeline handler/ipa, but that will mean it won't\n> > > be tested under CI...\n> > \n> > Yes, this will not solve the issue, but useful nonetheless. It would appear that\n> > `-D force_fallback_for=libpisp` is enough to make it work, but there are other\n> > jobs that want to use that option, and multiple occurrences overwrite each other.\n> > I am not sure what the best approach is. `--wrap-mode=nofallback` could be removed\n> > altogether, or replaced with `--wrap-mode=nodownload` + some magic to bring in the\n> > necessary dependencies, or something else.\n> \n> If we have to compile the dependencies from source, I would rather do\n> this at container build time to avoid CI failures unrelated to libcamera\n> itself.\n\nAlso, when compiling libcamera today with a gcc 13.3.0 cross-compiler\nfrom buildroot 2024.11.1, I got the following error:\n\n../../src/libcamera/pipeline/rpi/pisp/pisp.cpp: In member function ‘void libcamera::PiSPCameraData::cfeBufferDequeue(libcamera::FrameBuffer*)’:\n../../src/libcamera/pipeline/rpi/pisp/pisp.cpp:1680:28: error: ‘index’ may be used uninitialized [-Werror=maybe-uninitialized]\n 1680 | << \", timestamp: \" << buffer->metadata().timestamp;\n | ^~~~~~~~~~~~~~~\n../../src/libcamera/pipeline/rpi/pisp/pisp.cpp:1656:13: note: ‘index’ was declared here\n 1656 | int index;\n | ^~~~~\n\nI haven't tested with other compiler versions yet, CI will give us more\ninformation once we handle the libpisp dependency.\n\n> > > > > Do we need to build in libpisp into the CI as a dependency directly? Do\n> > > > > we need to manage keeping libcamera in sync with specific versions/API\n> > > > > compatibility of libpisp ?\n> > > > >\n> > > > > > Naushir Patuck (4):\n> > > > > > meson: Add libpisp.wrap\n> > > > > > ipa: rpi: Add support for Raspberry Pi 5\n> > > > > > pipeline: rpi: Add new stream flags for PiSP\n> > > > > > pipeline: rpi: Add support for Raspberry Pi 5\n> > > > > >\n> > > > > > Documentation/guides/pipeline-handler.rst | 2 +-\n> > > > > > include/libcamera/ipa/meson.build | 1 +\n> > > > > > include/libcamera/meson.build | 1 +\n> > > > > > meson.build | 1 +\n> > > > > > meson_options.txt | 4 +-\n> > > > > > src/ipa/rpi/pisp/data/imx219.json | 1187 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx219_noir.json | 1112 ++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx290.json | 341 +++\n> > > > > > src/ipa/rpi/pisp/data/imx296.json | 1194 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx296_16mm.json | 1247 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx296_6mm.json | 1247 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx296_mono.json | 960 +++++++\n> > > > > > src/ipa/rpi/pisp/data/imx378.json | 634 +++++\n> > > > > > src/ipa/rpi/pisp/data/imx415.json | 1159 ++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx462.json | 342 +++\n> > > > > > src/ipa/rpi/pisp/data/imx477.json | 1186 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx477_16mm.json | 1240 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx477_6mm.json | 1240 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx477_noir.json | 1148 ++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx477_scientific.json | 546 ++++\n> > > > > > src/ipa/rpi/pisp/data/imx519.json | 634 +++++\n> > > > > > src/ipa/rpi/pisp/data/imx708.json | 1270 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx708_noir.json | 1233 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx708_wide.json | 1293 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/imx708_wide_noir.json | 1148 ++++++++\n> > > > > > src/ipa/rpi/pisp/data/meson.build | 29 +\n> > > > > > src/ipa/rpi/pisp/data/ov5647.json | 1186 +++++++++\n> > > > > > src/ipa/rpi/pisp/data/ov5647_noir.json | 1121 ++++++++\n> > > > > > src/ipa/rpi/pisp/data/ov64a40.json | 1133 ++++++++\n> > > > > > src/ipa/rpi/pisp/data/ov9281_mono.json | 215 ++\n> > > > > > src/ipa/rpi/pisp/data/se327m12.json | 639 +++++\n> > > > > > src/ipa/rpi/pisp/data/uncalibrated.json | 135 +\n> > > > > > src/ipa/rpi/pisp/meson.build | 49 +\n> > > > > > src/ipa/rpi/pisp/pisp.cpp | 1068 ++++++++\n> > > > > > src/libcamera/control_ids_rpi.yaml | 13 +\n> > > > > > .../pipeline/rpi/common/rpi_stream.h | 10 +\n> > > > > > .../pipeline/rpi/pisp/data/example.yaml | 45 +\n> > > > > > .../pipeline/rpi/pisp/data/meson.build | 8 +\n> > > > > > src/libcamera/pipeline/rpi/pisp/meson.build | 12 +\n> > > > > > src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++\n> > > > > > subprojects/.gitignore | 1 +\n> > > > > > subprojects/libpisp.wrap | 6 +\n> > > > > > 42 files changed, 28410 insertions(+), 2 deletions(-)\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx219.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx219_noir.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx290.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx296.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx296_16mm.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx296_6mm.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx296_mono.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx378.json\n> > > > > > create mode 100755 src/ipa/rpi/pisp/data/imx415.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx462.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_16mm.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_6mm.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_noir.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx477_scientific.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx519.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx708.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx708_noir.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide_noir.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/meson.build\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/ov5647.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/ov5647_noir.json\n> > > > > > create mode 100755 src/ipa/rpi/pisp/data/ov64a40.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/ov9281_mono.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/se327m12.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/data/uncalibrated.json\n> > > > > > create mode 100644 src/ipa/rpi/pisp/meson.build\n> > > > > > create mode 100644 src/ipa/rpi/pisp/pisp.cpp\n> > > > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> > > > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/meson.build\n> > > > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/meson.build\n> > > > > > create mode 100644 src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> > > > > > create mode 100644 subprojects/libpisp.wrap","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B8C0C3301\n\tfor ;\n\tTue, 14 Jan 2025 20:51:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE48168521;\n\tTue, 14 Jan 2025 21:51:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 220DF607D6\n\tfor ;\n\tTue, 14 Jan 2025 21:51:46 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99DBA7E9;\n\tTue, 14 Jan 2025 21:50:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hoP1/mV+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736887848;\n\tbh=Rm8awlvLN+1+qnXPPY0dCEnTo20jwIFEreqijzfSJEA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hoP1/mV+gVfOUorY/JnBSXbdU5Zp2UdUmxbIK+vFBMZgBzNB81VLWnIyyhl7Lhkj1\n\tskgwPE+1c355MxMRhiNIjzbcjAYk5u0fB0jWLs2p0dfgEyTZ1Y2CX6U8bCT6T/5p4I\n\tq5zqS4RWif+enwxx4tQ8mCyb9sFdOHevpewbaa4Y=","Date":"Tue, 14 Jan 2025 22:51:40 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Naushir Patuck ,\n\tKieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","Message-ID":"<20250114205140.GD29414@pendragon.ideasonboard.com>","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>\n\t\n\t\n\t\n\t<20250114204618.GC29414@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250114204618.GC29414@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33645,"web_url":"https://patchwork.libcamera.org/comment/33645/","msgid":"<9a5c9679-3c8a-4d69-aa97-5b37bc8a62c3@gmx.de>","date":"2025-03-18T22:30:31","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi Naush,\n\nThanks for the efforts upstreaming the Raspberry Pi 5 support. Is this\nsomething that is still being worked on? Is there a rough timeline when\nthe Raspberry Pi 5 will be supported via the upstream libcamera version?\n\nAs far as I understand from Jacopo's patch to the LKML [1], all the\nkernel bits are in place and only the \"PiSP Front End\" (in libpisp?) and\nthe actual libcamera IPAs and pipelines are missing. But this is already\n10 months ago and I am not fully aware of the progress and to which\ndegree the Raspberry Pi 5 is already supported by upstream libcamera.\n\nSince I am providing an application based on libcamera (a ROS 2 node) to\ncover generic V4L2 devices as well as the Raspberry Pi Camera Modules,\nand I am dealing with frequent issue reports as to why the Raspberry Pi\nCamera Modules do not work with libcamera, I am essentially wondering if\nthis situation will resolve itself in the near future, or if the\nRaspberry Pi fork of libcamera and the upstream version will continue to\nexist in parallel like this indefinitely.\n\nIs there anything I could help with to make this upstreaming of the\nRaspberry Pi 5 support happen?\n\nBest,\nChristian\n\n[1]\nhttps://lore.kernel.org/all/20240531080707.34568-1-jacopo.mondi@ideasonboard.com/\n\n\nAm 13.01.25 um 10:24 schrieb Naushir Patuck:\n> Hi,\n>\n> A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> unchanged from the Raspberry Pi downstream libcamera tree:\n> https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> available in this series since we have yet to attempt to upstream the kernel\n> changes.\n>\n> IMPORTANT NOTE\n> --------------\n> The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> drivers with this pipeline handler. When futher upstreaming development for\n> embedded data is completed, RPi will backport the upstream kernel drives to our\n> tree and this pipeline handler will then begin to work with both upstream and\n> downstream kernel trees.\n>\n> Thanks,\n> Naush\n>\n> Naushir Patuck (4):\n> meson: Add libpisp.wrap\n> ipa: rpi: Add support for Raspberry Pi 5\n> pipeline: rpi: Add new stream flags for PiSP\n> pipeline: rpi: Add support for Raspberry Pi 5\n>\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> include/libcamera/ipa/meson.build | 1 +\n> include/libcamera/meson.build | 1 +\n> meson.build | 1 +\n> meson_options.txt | 4 +-\n> src/ipa/rpi/pisp/data/imx219.json | 1187 +++++++++\n> src/ipa/rpi/pisp/data/imx219_noir.json | 1112 ++++++++\n> src/ipa/rpi/pisp/data/imx290.json | 341 +++\n> src/ipa/rpi/pisp/data/imx296.json | 1194 +++++++++\n> src/ipa/rpi/pisp/data/imx296_16mm.json | 1247 +++++++++\n> src/ipa/rpi/pisp/data/imx296_6mm.json | 1247 +++++++++\n> src/ipa/rpi/pisp/data/imx296_mono.json | 960 +++++++\n> src/ipa/rpi/pisp/data/imx378.json | 634 +++++\n> src/ipa/rpi/pisp/data/imx415.json | 1159 ++++++++\n> src/ipa/rpi/pisp/data/imx462.json | 342 +++\n> src/ipa/rpi/pisp/data/imx477.json | 1186 +++++++++\n> src/ipa/rpi/pisp/data/imx477_16mm.json | 1240 +++++++++\n> src/ipa/rpi/pisp/data/imx477_6mm.json | 1240 +++++++++\n> src/ipa/rpi/pisp/data/imx477_noir.json | 1148 ++++++++\n> src/ipa/rpi/pisp/data/imx477_scientific.json | 546 ++++\n> src/ipa/rpi/pisp/data/imx519.json | 634 +++++\n> src/ipa/rpi/pisp/data/imx708.json | 1270 +++++++++\n> src/ipa/rpi/pisp/data/imx708_noir.json | 1233 +++++++++\n> src/ipa/rpi/pisp/data/imx708_wide.json | 1293 +++++++++\n> src/ipa/rpi/pisp/data/imx708_wide_noir.json | 1148 ++++++++\n> src/ipa/rpi/pisp/data/meson.build | 29 +\n> src/ipa/rpi/pisp/data/ov5647.json | 1186 +++++++++\n> src/ipa/rpi/pisp/data/ov5647_noir.json | 1121 ++++++++\n> src/ipa/rpi/pisp/data/ov64a40.json | 1133 ++++++++\n> src/ipa/rpi/pisp/data/ov9281_mono.json | 215 ++\n> src/ipa/rpi/pisp/data/se327m12.json | 639 +++++\n> src/ipa/rpi/pisp/data/uncalibrated.json | 135 +\n> src/ipa/rpi/pisp/meson.build | 49 +\n> src/ipa/rpi/pisp/pisp.cpp | 1068 ++++++++\n> src/libcamera/control_ids_rpi.yaml | 13 +\n> .../pipeline/rpi/common/rpi_stream.h | 10 +\n> .../pipeline/rpi/pisp/data/example.yaml | 45 +\n> .../pipeline/rpi/pisp/data/meson.build | 8 +\n> src/libcamera/pipeline/rpi/pisp/meson.build | 12 +\n> src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++\n> subprojects/.gitignore | 1 +\n> subprojects/libpisp.wrap | 6 +\n> 42 files changed, 28410 insertions(+), 2 deletions(-)\n> create mode 100644 src/ipa/rpi/pisp/data/imx219.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx219_noir.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx290.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx296.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx296_16mm.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx296_6mm.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx296_mono.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx378.json\n> create mode 100755 src/ipa/rpi/pisp/data/imx415.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx462.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477_16mm.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477_6mm.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477_noir.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx477_scientific.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx519.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx708.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx708_noir.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx708_wide.json\n> create mode 100644 src/ipa/rpi/pisp/data/imx708_wide_noir.json\n> create mode 100644 src/ipa/rpi/pisp/data/meson.build\n> create mode 100644 src/ipa/rpi/pisp/data/ov5647.json\n> create mode 100644 src/ipa/rpi/pisp/data/ov5647_noir.json\n> create mode 100755 src/ipa/rpi/pisp/data/ov64a40.json\n> create mode 100644 src/ipa/rpi/pisp/data/ov9281_mono.json\n> create mode 100644 src/ipa/rpi/pisp/data/se327m12.json\n> create mode 100644 src/ipa/rpi/pisp/data/uncalibrated.json\n> create mode 100644 src/ipa/rpi/pisp/meson.build\n> create mode 100644 src/ipa/rpi/pisp/pisp.cpp\n> create mode 100644 src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> create mode 100644 src/libcamera/pipeline/rpi/pisp/data/meson.build\n> create mode 100644 src/libcamera/pipeline/rpi/pisp/meson.build\n> create mode 100644 src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> create mode 100644 subprojects/libpisp.wrap\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28C72C32F5\n\tfor ;\n\tTue, 18 Mar 2025 22:30:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA23968942;\n\tTue, 18 Mar 2025 23:30:35 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F0DC6893F\n\tfor ;\n\tTue, 18 Mar 2025 23:30:33 +0100 (CET)","from [10.0.0.2] ([192.164.19.145]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1N7zFj-1t8IAt1lsh-00zEpE\n\tfor\n\t; Tue, 18 Mar 2025 23:30:32 +0100"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmx.de header.i=rauch.christian@gmx.de\n\theader.b=\"my1zW1Ki\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;\n\ts=s31663417; t=1742337032; x=1742941832; i=rauch.christian@gmx.de;\n\tbh=YkXZoZXIphSnqarzuppHpTLAitsR8WQ0+JXQS4SUd+o=;\n\th=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:\n\tReferences:From:In-Reply-To:Content-Type:\n\tContent-Transfer-Encoding:cc:content-transfer-encoding:\n\tcontent-type:date:from:message-id:mime-version:reply-to:subject:\n\tto;\n\tb=my1zW1Ki5pi8SL1+MSZpCqnFpwWQTjXFhq3RHsJbe0pBHgEKpDVwxMfZx4uepQnT\n\tTmB+VJeJD06OJ6tKAvelDvqXdDWDmcwiR5Zu7xrp08egIX+u8DDvOy+d8HE9TQwgm\n\tjeTDEFOa+xphMEUYpBo9KlQxPDDv0V/ynoiXdYGfWt5Ho9LKRG/J1lQNzEFdo3apB\n\t8IT2H0B0XyyFPH+OKlLRvyLsWn01/mpBMViXSd5II/Dt+VzSoru/fF6CicwzM/VM1\n\tdwd/M+oIeaxVhEwFslS05olEubATub3uO32pEocBGxJY9EzMH/SQvErpwgGV1lVGQ\n\tdjmr7zUghZeu3h1wcA==","X-UI-Sender-Class":"724b4f7f-cbec-4199-ad4e-598c01a50d3a","Message-ID":"<9a5c9679-3c8a-4d69-aa97-5b37bc8a62c3@gmx.de>","Date":"Tue, 18 Mar 2025 23:30:31 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","To":"libcamera-devel@lists.libcamera.org","References":"<20250113093532.4054142-1-naush@raspberrypi.com>","Content-Language":"en-US","From":"Christian Rauch ","In-Reply-To":"<20250113093532.4054142-1-naush@raspberrypi.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:oM6uuH8Ny8By+9MC5EFu+zYlZi9r5m0hVg1iMUYT0B50SJmtRES\n\t1X1I51Q+8CbDVVbwXxHe6IKcgVEnBnYZvunEBGHJ2QN346PLOVs2JLUjhnfzmzdGdBM1Ytd\n\tSbjZ5DSBbjhF+LvedWCVN0qWk8384i64qpgDWI49OZ8cVrRz3fsR/WH9OHUV5Es1RiSiaou\n\tndhQ6IJVCKTQZmwHLDzvQ==","X-Spam-Flag":"NO","UI-OutboundReport":"notjunk:1; M01:P0:2/OLw2bfIhQ=;\n\tvy3pKtHd3GcJgIxJEFtErgP13bQ\n\tnBpNZKiPB+iwta+Ap5/Nl8972yyr2q3IjHyyWGzT+zPWKJ2GfAQ3JVtt5Svh30oMhDoyPwdSZ\n\tnVYgfXBlxR0y5P7L/ujaqJK6dRYr4LuchFoaz4/u8dFcCVeYkbgGsbySR+operadlC9i/VpK5\n\tuad5dSM3+w5nhCUeHfgqSdNQAE4CJRbFc2K4CSFilU29RXhVjmDXGKARIig9AF+1O/Nti2DpO\n\tj38NJBWa+ODW/nnVmTseI/xxkd7h7fff/nPK2nfbmEQieiJVH2MoQhI6RDe2MrbGExyrS32X2\n\tLVCPBwU4003mzorIkYGP0ZgIKdaLfs/rMCzW1KrvwULxQgKRR2uq9v/WDHkPtxa7gZ1EFcOMP\n\tFwlwunctiDiarq2Sxrzk7wEATraENPV6833TeSdHt4SdNSW7Zh5zXUSeyaJnLU6RFtGBbC39L\n\tcAy3yXaLmoU38/6e64DuvM03sPKsjWaU1YC6q62IBmmlncwmfVgYHaFbm7eJJR1heakJVK+ed\n\tYplg1aluf1pVXGFFP/49gr458TPBZDur/GYX55BKxyYjBDO2c8WEauAV8p7Nb2wkGw2FI9zut\n\tRMprqDNGiXxBW0ZVOGeJRTCCM4DEzqpLOzh2HgO6fvTGB5WE6Y4mUk5C5FAuAiN94Nq2izijN\n\tFLr2UxP4n2ML3sO27oZGKBkpzC6E3v5r5BWsnscoMzvjl3Za6okfVK2WMN4FduiZgVALMGp/f\n\tzujd9BJuNCRTmEDmER5JRhPvahbpV4mtK2ViqQJQ74O26jd9cuOlyi9xrm9fYaHnIMTGybVnh\n\t3KZxw6DVl+WF29a8ttumvaDT+1gBMM1nELcHggCFF0FSSlBhT9isPHvL5fghhXcTb+d6pNoOM\n\t3AWr6zOmBK6OklfV9kGP3jsAf0SDTLPktgdqAHcLBcYRtmjRBjGpAmGBTzCQM9zS6siGP/vZ7\n\tXNugELPOOUDMpK6ohhX8CfIOppMAPI3ZCxoSWG27RtC0ZDGshbkoBPZWAAjBpEnn1MGHDQkIU\n\t99IVCuX0jf9nLszyXKn2s0wlcoxY7pLskvXKWhfhHkpna98ODWsHg6vAyX/+a6VZRw6Ijjds3\n\tMmQvBS/eVrQ4TbTva7lDqHG0YDzw6icrHo/pUQSewUKgZyt5K+0WzQizndcJqsHNeJqwhMLmA\n\tZU91RdhAlq2QE5X0pPu3gZyrVB7xvsH5Cc3RzzuGfqzOaM3lNV1ACL6EmVM9frGeRKdKEkMEx\n\tZFK50d67QGu2XBfcgSw9UCqnCDEEBj9pqu/esMo5AJfhF1Q5rDuQ/uifsnYPFKYioFf/kcz6s\n\txdxa3ZVOTBWiE255lPELJ2RQxTpJxPoJYMM9ozVU/lyQ0s8WCe8khvzqnL0VpWr4ie/a0KVyr\n\trgh8PgjVcQP7kUbjpbzgf3Ib3aqZHsEnc8n4mvmNnMtPOn2MtjfG1+YjmosXODzjhCU79LAfl\n\t3/VVrSxAOOmYaIlDnHwO9sXITuc25KGyLW9eAusJ3QNqdqsdgW1t7Grhy+aAtnNoZm5kXWw==","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33646,"web_url":"https://patchwork.libcamera.org/comment/33646/","msgid":"<174234054189.3286393.1990799642241282436@ping.linuxembedded.co.uk>","date":"2025-03-18T23:29:01","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Christian,\n\nQuoting Christian Rauch (2025-03-18 22:30:31)\n> Hi Naush,\n> \n> Thanks for the efforts upstreaming the Raspberry Pi 5 support. Is this\n> something that is still being worked on? Is there a rough timeline when\n> the Raspberry Pi 5 will be supported via the upstream libcamera version?\n\nI'm afraid the biggest delay was getting the CI integrated and then to\nbuild cleanly, after these patches were posted. Naush did a great job\nat fixing libpisp before Embedded World, so everything is ready as far\nas I'm aware for Pi5 libcamera support to be merged ...\n\nThe only issue remaining is that this week the gitlab.freedesktop.org\nservers are down for migration as the hosting providers are being\nchanged over.\n\n> As far as I understand from Jacopo's patch to the LKML [1], all the\n> kernel bits are in place and only the \"PiSP Front End\" (in libpisp?) and\n> the actual libcamera IPAs and pipelines are missing. But this is already\n> 10 months ago and I am not fully aware of the progress and to which\n> degree the Raspberry Pi 5 is already supported by upstream libcamera.\n> \n> Since I am providing an application based on libcamera (a ROS 2 node) to\n> cover generic V4L2 devices as well as the Raspberry Pi Camera Modules,\n> and I am dealing with frequent issue reports as to why the Raspberry Pi\n> Camera Modules do not work with libcamera, I am essentially wondering if\n> this situation will resolve itself in the near future, or if the\n> Raspberry Pi fork of libcamera and the upstream version will continue to\n> exist in parallel like this indefinitely.\n> \n> Is there anything I could help with to make this upstreaming of the\n> Raspberry Pi 5 support happen?\n\nI very sincerely hope and expect to be able to merge it next week, and\nwill be targetting the next libcamera release the week after.\n\nPlease keep an eye on the IMPORTANT NOTE below though. I believe there\nis still some compatibility issues between 'mainline' kernel and\n'raspberry pi' kernel to keep an eye on.\n\n--\nKieran\n\n\n> \n> Best,\n> Christian\n> \n> [1]\n> https://lore.kernel.org/all/20240531080707.34568-1-jacopo.mondi@ideasonboard.com/\n> \n> \n> Am 13.01.25 um 10:24 schrieb Naushir Patuck:\n> > Hi,\n> >\n> > A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> > upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> > unchanged from the Raspberry Pi downstream libcamera tree:\n> > https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> > available in this series since we have yet to attempt to upstream the kernel\n> > changes.\n> >\n> > IMPORTANT NOTE\n> > --------------\n> > The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> > kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> > drivers with this pipeline handler. When futher upstreaming development for\n> > embedded data is completed, RPi will backport the upstream kernel drives to our\n> > tree and this pipeline handler will then begin to work with both upstream and\n> > downstream kernel trees.\n> >\n> > Thanks,\n> > Naush\n> >\n> > Naushir Patuck (4):\n> > meson: Add libpisp.wrap\n> > ipa: rpi: Add support for Raspberry Pi 5\n> > pipeline: rpi: Add new stream flags for PiSP\n> > pipeline: rpi: Add support for Raspberry Pi 5\n> >\n> > Documentation/guides/pipeline-handler.rst | 2 +-\n> > include/libcamera/ipa/meson.build | 1 +\n> > include/libcamera/meson.build | 1 +\n> > meson.build | 1 +\n> > meson_options.txt | 4 +-\n> > src/ipa/rpi/pisp/data/imx219.json | 1187 +++++++++\n> > src/ipa/rpi/pisp/data/imx219_noir.json | 1112 ++++++++\n> > src/ipa/rpi/pisp/data/imx290.json | 341 +++\n> > src/ipa/rpi/pisp/data/imx296.json | 1194 +++++++++\n> > src/ipa/rpi/pisp/data/imx296_16mm.json | 1247 +++++++++\n> > src/ipa/rpi/pisp/data/imx296_6mm.json | 1247 +++++++++\n> > src/ipa/rpi/pisp/data/imx296_mono.json | 960 +++++++\n> > src/ipa/rpi/pisp/data/imx378.json | 634 +++++\n> > src/ipa/rpi/pisp/data/imx415.json | 1159 ++++++++\n> > src/ipa/rpi/pisp/data/imx462.json | 342 +++\n> > src/ipa/rpi/pisp/data/imx477.json | 1186 +++++++++\n> > src/ipa/rpi/pisp/data/imx477_16mm.json | 1240 +++++++++\n> > src/ipa/rpi/pisp/data/imx477_6mm.json | 1240 +++++++++\n> > src/ipa/rpi/pisp/data/imx477_noir.json | 1148 ++++++++\n> > src/ipa/rpi/pisp/data/imx477_scientific.json | 546 ++++\n> > src/ipa/rpi/pisp/data/imx519.json | 634 +++++\n> > src/ipa/rpi/pisp/data/imx708.json | 1270 +++++++++\n> > src/ipa/rpi/pisp/data/imx708_noir.json | 1233 +++++++++\n> > src/ipa/rpi/pisp/data/imx708_wide.json | 1293 +++++++++\n> > src/ipa/rpi/pisp/data/imx708_wide_noir.json | 1148 ++++++++\n> > src/ipa/rpi/pisp/data/meson.build | 29 +\n> > src/ipa/rpi/pisp/data/ov5647.json | 1186 +++++++++\n> > src/ipa/rpi/pisp/data/ov5647_noir.json | 1121 ++++++++\n> > src/ipa/rpi/pisp/data/ov64a40.json | 1133 ++++++++\n> > src/ipa/rpi/pisp/data/ov9281_mono.json | 215 ++\n> > src/ipa/rpi/pisp/data/se327m12.json | 639 +++++\n> > src/ipa/rpi/pisp/data/uncalibrated.json | 135 +\n> > src/ipa/rpi/pisp/meson.build | 49 +\n> > src/ipa/rpi/pisp/pisp.cpp | 1068 ++++++++\n> > src/libcamera/control_ids_rpi.yaml | 13 +\n> > .../pipeline/rpi/common/rpi_stream.h | 10 +\n> > .../pipeline/rpi/pisp/data/example.yaml | 45 +\n> > .../pipeline/rpi/pisp/data/meson.build | 8 +\n> > src/libcamera/pipeline/rpi/pisp/meson.build | 12 +\n> > src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++\n> > subprojects/.gitignore | 1 +\n> > subprojects/libpisp.wrap | 6 +\n> > 42 files changed, 28410 insertions(+), 2 deletions(-)\n> > create mode 100644 src/ipa/rpi/pisp/data/imx219.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx219_noir.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx290.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx296.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx296_16mm.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx296_6mm.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx296_mono.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx378.json\n> > create mode 100755 src/ipa/rpi/pisp/data/imx415.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx462.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477_16mm.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477_6mm.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477_noir.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx477_scientific.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx519.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx708.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx708_noir.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide.json\n> > create mode 100644 src/ipa/rpi/pisp/data/imx708_wide_noir.json\n> > create mode 100644 src/ipa/rpi/pisp/data/meson.build\n> > create mode 100644 src/ipa/rpi/pisp/data/ov5647.json\n> > create mode 100644 src/ipa/rpi/pisp/data/ov5647_noir.json\n> > create mode 100755 src/ipa/rpi/pisp/data/ov64a40.json\n> > create mode 100644 src/ipa/rpi/pisp/data/ov9281_mono.json\n> > create mode 100644 src/ipa/rpi/pisp/data/se327m12.json\n> > create mode 100644 src/ipa/rpi/pisp/data/uncalibrated.json\n> > create mode 100644 src/ipa/rpi/pisp/meson.build\n> > create mode 100644 src/ipa/rpi/pisp/pisp.cpp\n> > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> > create mode 100644 src/libcamera/pipeline/rpi/pisp/data/meson.build\n> > create mode 100644 src/libcamera/pipeline/rpi/pisp/meson.build\n> > create mode 100644 src/libcamera/pipeline/rpi/pisp/pisp.cpp\n> > create mode 100644 subprojects/libpisp.wrap\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8BE4C326C\n\tfor ;\n\tTue, 18 Mar 2025 23:29:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0718D68947;\n\tWed, 19 Mar 2025 00:29:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 012F8617F8\n\tfor ;\n\tWed, 19 Mar 2025 00:29:04 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 660A155A;\n\tWed, 19 Mar 2025 00:27:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oaiiorFe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742340442;\n\tbh=4G6mNxe0nw5gItki2VnDv7ujkoWmKcpN8A+SEgOLiWo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=oaiiorFe+KclmjHVHZ7kXDArtkZQwcWs5t0kGxWvmgSqCODINNguJypzi9qaQGElZ\n\tRk/jodUnASBzqASziWGGxwljTLzlq2Qa2Wbs5wgoi8zKgmpYIHQx8ITrgRdr0oByUG\n\trK39/awdswXDDylH3RVxt4JWEJf8VCyGYJ5qajYM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<9a5c9679-3c8a-4d69-aa97-5b37bc8a62c3@gmx.de>","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<9a5c9679-3c8a-4d69-aa97-5b37bc8a62c3@gmx.de>","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","From":"Kieran Bingham ","To":"Christian Rauch ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 18 Mar 2025 23:29:01 +0000","Message-ID":"<174234054189.3286393.1990799642241282436@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33665,"web_url":"https://patchwork.libcamera.org/comment/33665/","msgid":"<174247012841.2025019.16444417126621465586@ping.linuxembedded.co.uk>","date":"2025-03-20T11:28:48","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Kieran Bingham (2025-01-13 12:12:48)\n> Hi Naush,\n> \n> Quoting Naushir Patuck (2025-01-13 09:24:42)\n> > Hi,\n> > \n> > A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> > upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> > unchanged from the Raspberry Pi downstream libcamera tree:\n> > https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> > available in this series since we have yet to attempt to upstream the kernel\n> > changes.\n> > \n> > IMPORTANT NOTE\n> > --------------\n> > The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> > kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> > drivers with this pipeline handler. When futher upstreaming development for\n> > embedded data is completed, RPi will backport the upstream kernel drives to our\n> > tree and this pipeline handler will then begin to work with both upstream and\n> > downstream kernel trees.\n> \n> Thanks for posting this!\n> \n> The first issue we face is the dependency in libpisp in the CI loops it\n> seems:\n> \n> https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1344547\n> \n> has many failed jobs, which I believe are all going to be more or less\n> instances of:\n> \n> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/69247972\n> \n> src/libcamera/pipeline/rpi/pisp/meson.build:8:14: ERROR: Dependency 'libpisp' is required but not found.\n> \n\nAll of this is now resolved, and these patches are successfully run\nthrough CI:\n\nhttps://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1386009\n\nA few linter issues but I wouldn't dwell on those:\n\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/73051446\n\n\nI'm keen to see these patches merged!\n\n\nNaush - it's been some time since you posted these. Are there any\nupdates or changes you require to these before merge?\n\nDue to the size - if you have any updates, please feel free to send me a\nPR/branch rather than hitting the list/patchwork with the large content\nof the tuning files again in this instance.\n\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73630C3304\n\tfor ;\n\tThu, 20 Mar 2025 11:28:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D72568952;\n\tThu, 20 Mar 2025 12:28:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5D1D617F7\n\tfor ;\n\tThu, 20 Mar 2025 12:28:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F3FE743;\n\tThu, 20 Mar 2025 12:27:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uqjg+hIE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742470028;\n\tbh=XLA7MTqFsdk8bmTwTNbrVnof8e0IMsAYZzl87WqnE6I=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=uqjg+hIE/w5dSj+9bfXhz/f6G6Vo45+/Iu7N0fwh8yQyi7uQB0H6Ro+zXn2KQbgIu\n\tTqcgnwIPN6N9A66JIcdZEuG/xnCGnKC3ZKnFPWKR54epiCXi8wxj52Ke3aJJyD6+e8\n\tDdWGcXkvBfMEb+dI2zspaioUmdJXrNGUss1uGrHg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 20 Mar 2025 11:28:48 +0000","Message-ID":"<174247012841.2025019.16444417126621465586@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33666,"web_url":"https://patchwork.libcamera.org/comment/33666/","msgid":"","date":"2025-03-20T11:43:37","subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nOn Thu, 20 Mar 2025 at 11:28, Kieran Bingham\n wrote:\n>\n> Hi Naush,\n>\n> Quoting Kieran Bingham (2025-01-13 12:12:48)\n> > Hi Naush,\n> >\n> > Quoting Naushir Patuck (2025-01-13 09:24:42)\n> > > Hi,\n> > >\n> > > A long time coming... this series add support for Raspberry Pi 5 (PiSP) to\n> > > upstream libcamera. The IPA and pipeline handler code have been taken mostly\n> > > unchanged from the Raspberry Pi downstream libcamera tree:\n> > > https://github.com/raspberrypi/libcamera. Support for IMX500 and CNNs are not\n> > > available in this series since we have yet to attempt to upstream the kernel\n> > > changes.\n> > >\n> > > IMPORTANT NOTE\n> > > --------------\n> > > The Pi 5 pipeline handler in this commit is NOT COMPATIBLE with the Raspberry Pi\n> > > kernel drivers just yet! Instead, you must use the mainline kernel upstream\n> > > drivers with this pipeline handler. When futher upstreaming development for\n> > > embedded data is completed, RPi will backport the upstream kernel drives to our\n> > > tree and this pipeline handler will then begin to work with both upstream and\n> > > downstream kernel trees.\n> >\n> > Thanks for posting this!\n> >\n> > The first issue we face is the dependency in libpisp in the CI loops it\n> > seems:\n> >\n> > https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1344547\n> >\n> > has many failed jobs, which I believe are all going to be more or less\n> > instances of:\n> >\n> > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/69247972\n> >\n> > src/libcamera/pipeline/rpi/pisp/meson.build:8:14: ERROR: Dependency 'libpisp' is required but not found.\n> >\n>\n> All of this is now resolved, and these patches are successfully run\n> through CI:\n>\n> https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1386009\n>\n> A few linter issues but I wouldn't dwell on those:\n>\n> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/73051446\n>\n>\n> I'm keen to see these patches merged!\n>\n>\n> Naush - it's been some time since you posted these. Are there any\n> updates or changes you require to these before merge?\n\nThe only update would be the libpisp.wrap file change, which I've just\nposted. Apart from that, I don't think any updates are needed before\nmerging. Exciting!!!\n\nRegards,\nNaush\n\n>\n> Due to the size - if you have any updates, please feel free to send me a\n> PR/branch rather than hitting the list/patchwork with the large content\n> of the tuning files again in this instance.\n>\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10270C3301\n\tfor ;\n\tThu, 20 Mar 2025 11:44:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 207EE6894F;\n\tThu, 20 Mar 2025 12:44:15 +0100 (CET)","from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com\n\t[IPv6:2607:f8b0:4864:20::1134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36980617F7\n\tfor ;\n\tThu, 20 Mar 2025 12:44:13 +0100 (CET)","by mail-yw1-x1134.google.com with SMTP id\n\t00721157ae682-6feb4b2d41bso187417b3.0\n\tfor ;\n\tThu, 20 Mar 2025 04:44:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"LkkmuuG2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1742471052; x=1743075852;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=t7Gyq8xFLeQGEfwHcz0csHhFXu88nqaX6YHcgbNSh/Q=;\n\tb=LkkmuuG2xc7095LyiTpSSNUHdxs3+FEzl1yicoAkwtrttG1rm96Heub1eW67nYBykK\n\tfkIIz8AezsPm3h1602pJcAnoo6Qghy60o4zTeXhnrcncfcomppu9UAlTqA06i8ZiVZm/\n\t2c+U8bO76J1nAlO7jHeNt8APNpbcp+Y3rW4IhVI/BLgMQh8xuplGXk3edB0IjkZI9qcD\n\tRhYZ+tZ/b5xn60WGtkWyyopKl3snVJ3zHGr6lKtPyrleMAYTlz39gPraXp0di+tcweTo\n\ty7GH1dTnRh78wXutiLql76dIPnOus6p2qEHqHkU7kNIkpcoam3HshJtKTiNNRBDnk5XQ\n\tT8kA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1742471052; x=1743075852;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=t7Gyq8xFLeQGEfwHcz0csHhFXu88nqaX6YHcgbNSh/Q=;\n\tb=wjZxHlHJGOxSCnpCFAHc/rd0lT5+WRQupe5VEmuqS4yxT+86MIB5Wq3VsU3IoLdoS4\n\tdFSLCsNmItgkqNynx9DOS2t7bfPUIbM5+CAoLX0YazhbQ0F9BGxj0OQi5mwFuUXUC+Sy\n\traWvHTFZURVsIVmko9Qw4NlJ28eE/93vTKx23ysFXjGsr+cmqHCBZNcT+SNV96dQb5U5\n\tmysyF67U7AvOZeIztyvN5P9wyi/4qk8kLD37detlBH2NP9SnCn/4K+uJaoHSadq/TGeB\n\tyq6g1TP78RPJG9x89Iz1GuXtz/5uTblOH5Wn0u/Sot9jXL5s+2gkZekbqwdiGzCFc4IE\n\tzQrw==","X-Gm-Message-State":"AOJu0Yxq9rQLhNmbr0jcGjtixJHPKVlgcZwlnfw6ztQ+r9KbDlBG0D6I\n\tk5Vo2ACjMDkn/s0UiY063h6cecyyR1mEBaDnFMtxoIQnYRSZk2HegDy/Ef1QEwrcOIZq82AbNtt\n\tYfw4tdRcf037KCkDz8bTqiMaYxN0/BSTwMb8jaHJcJh//bucs","X-Gm-Gg":"ASbGncv0qsNNV/szVVSXcXXdUdrntjKCk4NQ+DRysdwAzFtEfwPCRptOJ4lYD+86XO5\n\tXDGlZms2olAgOh6vL84bhFgQXY+gj+HKDEvCzXlJkCQjO+1mREfwOiuv47iHV0TDUCYc97IP3jN\n\tXcEjcKO5jmdNVGXhJfnVLAryUE4t95vZHKxtGfC+c1CyP8VhKjEOHijM/Vrg==","X-Google-Smtp-Source":"AGHT+IE2E2e1OExyadNKnXuDVe5A7HSeGovLqTeF5NATky6CeszwxakKoDdJfDJrfs1wIvSeVUcEc8rwCE7ifcMCuAY=","X-Received":"by 2002:a05:690c:f86:b0:6fb:9532:a7b with SMTP id\n\t00721157ae682-7009bf5c586mr40782077b3.2.1742471051908;\n\tThu, 20 Mar 2025 04:44:11 -0700 (PDT)","MIME-Version":"1.0","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<173677036881.3771432.2818841818649559900@ping.linuxembedded.co.uk>\n\t<174247012841.2025019.16444417126621465586@ping.linuxembedded.co.uk>","In-Reply-To":"<174247012841.2025019.16444417126621465586@ping.linuxembedded.co.uk>","From":"Naushir Patuck ","Date":"Thu, 20 Mar 2025 11:43:37 +0000","X-Gm-Features":"AQ5f1JoVq5CZZUJZuNSZoxXvweu2Pg22VjKOCPCGMSh6eJogxWwFIJBv0iMJfEM","Message-ID":"","Subject":"Re: [PATCH v1 0/4] Raspberry Pi: Add support for Pi 5 (PiSP)","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]