[{"id":32975,"web_url":"https://patchwork.libcamera.org/comment/32975/","msgid":"<173643912494.2992722.11686439600014671253@ping.linuxembedded.co.uk>","date":"2025-01-09T16:12:04","subject":"Re: [PATCH v3 0/7] Camera synchronisation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting David Plowman (2025-01-09 14:32:04)\n> Hi everyone\n> \n> Here's what I think is version 3 (?) of this patch set. The main\n> change here is just that the Sync controls have been made Raspberry Pi\n> specific. Note also that the \"FrameWallClock control\" patch is still\n> here (doesn't appear to have been merged at the time of writing).\n\nThanks I was just about to merge\nhttps://patchwork.libcamera.org/patch/22399/ but realised there was\nextraneous changes that needed to be removed. Now I've seen your update\nhere has the correct version that doesn't try to remove the SPDX header.\n\n--\nKieran\n\n\n> \n> Those interested in how a timing offset could be supplied should look\n> at the 4th patch (\"Add wallclock timestamp support\"). A proposed\n> \"SyncOffset\" control value would get remembered in applyControls(),\n> and then in processStats() it could be used in place of the offset\n> value from the SyncStatus (that pops out of the sync algorithm). Hope\n> that's clear!\n> \n> Thanks\n> David\n> \n> David Plowman (6):\n> controls: Add FrameWallClock control\n> libcamera: Add ClockRecovery class to generate wallclock timestamps\n> controls: Add camera synchronisation controls for Raspberry Pi\n> pipeline: rpi:: Add wallclock timestamp support\n> ipa: rpi: sync: Add an implementation of the camera sync algorithm\n> ipa: rpi: vc4: Update all tuning files for sync algorithm\n> \n> Naushir Patuck (1):\n> ipa: rpi: Add base classes and plumbing for sync algorithm\n> \n> include/libcamera/internal/clock_recovery.h | 68 ++++\n> include/libcamera/internal/meson.build | 1 +\n> src/ipa/rpi/common/ipa_base.cpp | 78 ++++-\n> src/ipa/rpi/common/ipa_base.h | 4 +-\n> src/ipa/rpi/controller/meson.build | 1 +\n> src/ipa/rpi/controller/rpi/sync.cpp | 330 ++++++++++++++++++\n> src/ipa/rpi/controller/rpi/sync.h | 68 ++++\n> src/ipa/rpi/controller/sync_algorithm.h | 31 ++\n> src/ipa/rpi/controller/sync_status.h | 27 ++\n> src/ipa/rpi/vc4/data/imx219.json | 7 +-\n> src/ipa/rpi/vc4/data/imx219_noir.json | 7 +-\n> src/ipa/rpi/vc4/data/imx283.json | 7 +-\n> src/ipa/rpi/vc4/data/imx290.json | 7 +-\n> src/ipa/rpi/vc4/data/imx296.json | 7 +-\n> src/ipa/rpi/vc4/data/imx296_mono.json | 7 +-\n> src/ipa/rpi/vc4/data/imx378.json | 7 +-\n> src/ipa/rpi/vc4/data/imx477.json | 7 +-\n> src/ipa/rpi/vc4/data/imx477_noir.json | 7 +-\n> src/ipa/rpi/vc4/data/imx477_scientific.json | 7 +-\n> src/ipa/rpi/vc4/data/imx519.json | 7 +-\n> src/ipa/rpi/vc4/data/imx708.json | 7 +-\n> src/ipa/rpi/vc4/data/imx708_noir.json | 7 +-\n> src/ipa/rpi/vc4/data/imx708_wide.json | 7 +-\n> src/ipa/rpi/vc4/data/imx708_wide_noir.json | 7 +-\n> src/ipa/rpi/vc4/data/ov5647.json | 7 +-\n> src/ipa/rpi/vc4/data/ov5647_noir.json | 7 +-\n> src/ipa/rpi/vc4/data/se327m12.json | 7 +-\n> src/libcamera/clock_recovery.cpp | 230 ++++++++++++\n> src/libcamera/control_ids_core.yaml | 15 +\n> src/libcamera/control_ids_rpi.yaml | 113 ++++++\n> src/libcamera/meson.build | 1 +\n> .../pipeline/rpi/common/pipeline_base.cpp | 5 +\n> .../pipeline/rpi/common/pipeline_base.h | 3 +\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 10 +-\n> 34 files changed, 1086 insertions(+), 25 deletions(-)\n> create mode 100644 include/libcamera/internal/clock_recovery.h\n> create mode 100644 src/ipa/rpi/controller/rpi/sync.cpp\n> create mode 100644 src/ipa/rpi/controller/rpi/sync.h\n> create mode 100644 src/ipa/rpi/controller/sync_algorithm.h\n> create mode 100644 src/ipa/rpi/controller/sync_status.h\n> create mode 100644 src/libcamera/clock_recovery.cpp\n> \n> -- \n> 2.39.5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D234EC32EF\n\tfor ;\n\tThu, 9 Jan 2025 16:12:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DFDBA684EA;\n\tThu, 9 Jan 2025 17:12:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C790661880\n\tfor ;\n\tThu, 9 Jan 2025 17:12:07 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BEF6110F;\n\tThu, 9 Jan 2025 17:11:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Kbpf6VEU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736439074;\n\tbh=RXObgl7ip5F/MxFikN7e7B8eJN5LeIzDE7kYB9xvml0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Kbpf6VEUXkC9S15lGP+JS4c/O7xIcYK0uvYEhWQJq+D9ZBiz+2ahrYoY4tZvm1P/B\n\taLRX4znTVKDGBOUswzhfbejbnCIySbUxhBlmRaf/TBa2jOX/j8HJMwYfTPhzKB5DuS\n\t5OboyspV71vt62ssNKM+qmx2cmd0tcWvTx2hugNk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250109143211.11939-1-david.plowman@raspberrypi.com>","References":"<20250109143211.11939-1-david.plowman@raspberrypi.com>","Subject":"Re: [PATCH v3 0/7] Camera synchronisation","From":"Kieran Bingham ","Cc":"David Plowman ","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 09 Jan 2025 16:12:04 +0000","Message-ID":"<173643912494.2992722.11686439600014671253@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]