[{"id":2997,"web_url":"https://patchwork.libcamera.org/comment/2997/","msgid":"<20191106081431.5voy7pjhipshkuh7@uno.localdomain>","date":"2019-11-06T08:14:31","subject":"Re: [libcamera-devel] [PATCH 00/10] libcamera: Fixes found while\n\tworking on new buffer API","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Mon, Oct 28, 2019 at 03:22:14AM +0100, Niklas Söderlund wrote:\n> Hi,\n>\n> This series is a random collection of small fixes I encountered while\n> working on the new buffer API. They could hopefully be merged without\n> much controversy opposed to the real buffer API change.\n\nThe two small comments I had apart, for the whole series:\nReviewed-by: Jacopo Mondi \n\nThanks, nice cleanup\n\n>\n> Niklas Söderlund (10):\n> libcamera: buffer: Drop forward declaration of BufferPool\n> libcamera: buffer: Plane: Drop friend statement\n> libcamera: buffer: Drop friend statment\n> libcamera: camera: Remove explicit stream to buffer map in\n> requestCompleted signal\n> cam: BufferWriter: Use the libcamera namespace\n> libcamera: v4l2_videodevice: Simplify error checking for\n> requestBuffers()\n> libcamera: pipeline_handler: Do not use argument as local variable\n> libcamera: pipelines: Align where to call base class queueRequest()\n> cam: Store camera as shared pointer everywhere\n> libcamera: pipeline: Drop forward declaration of BufferPool\n>\n> include/libcamera/buffer.h | 4 ---\n> include/libcamera/camera.h | 2 +-\n> src/cam/buffer_writer.cpp | 8 +++---\n> src/cam/capture.cpp | 6 +++--\n> src/cam/capture.h | 7 +++---\n> src/cam/main.cpp | 2 +-\n> src/libcamera/camera.cpp | 2 +-\n> src/libcamera/include/pipeline_handler.h | 1 -\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 ++--\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +--\n> src/libcamera/pipeline/uvcvideo.cpp | 4 +--\n> src/libcamera/pipeline/vimc.cpp | 4 +--\n> src/libcamera/pipeline_handler.cpp | 8 +++---\n> src/libcamera/v4l2_videodevice.cpp | 31 ++++++++----------------\n> src/qcam/main_window.cpp | 5 ++--\n> src/qcam/main_window.h | 3 +--\n> test/camera/capture.cpp | 4 ++-\n> 17 files changed, 42 insertions(+), 58 deletions(-)\n>\n> --\n> 2.23.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C20F60C41\n\tfor ;\n\tWed, 6 Nov 2019 09:12:35 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id A1C9A1BF20E;\n\tWed, 6 Nov 2019 08:12:33 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 6 Nov 2019 09:14:31 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191106081431.5voy7pjhipshkuh7@uno.localdomain>","References":"<20191028022224.795355-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"n7tcuazd643kicym\"","Content-Disposition":"inline","In-Reply-To":"<20191028022224.795355-1-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 00/10] libcamera: Fixes found while\n\tworking on new buffer API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 06 Nov 2019 08:12:35 -0000"}},{"id":3002,"web_url":"https://patchwork.libcamera.org/comment/3002/","msgid":"<785cfb72-1524-1ae1-1a0d-c400f3b95252@ideasonboard.com>","date":"2019-11-06T11:58:47","subject":"Re: [libcamera-devel] [PATCH 00/10] libcamera: Fixes found while\n\tworking on new buffer API","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 28/10/2019 02:22, Niklas Söderlund wrote:\n> Hi,\n> \n> This series is a random collection of small fixes I encountered while \n> working on the new buffer API. They could hopefully be merged without \n> much controversy opposed to the real buffer API change.\n\nIndeed, these look good.\n\nI see a few minor comments (well, and an important HAL fixup) from\nJacopo, but I can't find any other faults in there, so for the series:\n\nReviewed-by: Kieran Bingham \n\n\n\n> Niklas Söderlund (10):\n> libcamera: buffer: Drop forward declaration of BufferPool\n> libcamera: buffer: Plane: Drop friend statement\n> libcamera: buffer: Drop friend statment\n> libcamera: camera: Remove explicit stream to buffer map in\n> requestCompleted signal\n> cam: BufferWriter: Use the libcamera namespace\n> libcamera: v4l2_videodevice: Simplify error checking for\n> requestBuffers()\n> libcamera: pipeline_handler: Do not use argument as local variable\n> libcamera: pipelines: Align where to call base class queueRequest()\n> cam: Store camera as shared pointer everywhere\n> libcamera: pipeline: Drop forward declaration of BufferPool\n> \n> include/libcamera/buffer.h | 4 ---\n> include/libcamera/camera.h | 2 +-\n> src/cam/buffer_writer.cpp | 8 +++---\n> src/cam/capture.cpp | 6 +++--\n> src/cam/capture.h | 7 +++---\n> src/cam/main.cpp | 2 +-\n> src/libcamera/camera.cpp | 2 +-\n> src/libcamera/include/pipeline_handler.h | 1 -\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 ++--\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +--\n> src/libcamera/pipeline/uvcvideo.cpp | 4 +--\n> src/libcamera/pipeline/vimc.cpp | 4 +--\n> src/libcamera/pipeline_handler.cpp | 8 +++---\n> src/libcamera/v4l2_videodevice.cpp | 31 ++++++++----------------\n> src/qcam/main_window.cpp | 5 ++--\n> src/qcam/main_window.h | 3 +--\n> test/camera/capture.cpp | 4 ++-\n> 17 files changed, 42 insertions(+), 58 deletions(-)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89C6860BF3\n\tfor ;\n\tWed, 6 Nov 2019 12:58:51 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E93DC52C;\n\tWed, 6 Nov 2019 12:58:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1573041531;\n\tbh=2pn/dBw2JpgGaMg8HfQ9WYKkbrIV/tE6Pf2XH/H/zXE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=s59U2b8RophT7YvXb8+89JBDsY9YkjyblkHHsp/xbD4YzN16NTk2n0mRcEE6GPY0i\n\tL0EK88YuVk5zkzT8r1skvSUB5j2oenfgXqMxHXO+iqywIJ+6Qk17cPxOdxZtTKcLHK\n\tzQ6UrDh1qSelw4tPoUzT5x8JaYihswQtF2TTCBWk=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20191028022224.795355-1-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<785cfb72-1524-1ae1-1a0d-c400f3b95252@ideasonboard.com>","Date":"Wed, 6 Nov 2019 11:58:47 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20191028022224.795355-1-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 00/10] libcamera: Fixes found while\n\tworking on new buffer API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 06 Nov 2019 11:58:51 -0000"}}]