[{"id":2968,"web_url":"https://patchwork.libcamera.org/comment/2968/","msgid":"<20191027235027.GF28970@pendragon.ideasonboard.com>","date":"2019-10-27T23:50:27","subject":"Re: [libcamera-devel] [PATCH 00/10] libcamera: Use DRM_FORMAT_*\n\tfourcc codes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patches.\n\nOn Mon, Oct 28, 2019 at 12:43:02AM +0100, Jacopo Mondi wrote:\n> Hello,\n> this series moves libcamera to use the DRM/KMS defined DRM_FORMAT_*\n> fourcc codes towards applications.\n> \n> The series starts by updating the kernel headers to v5.2 and importing the\n> DRM/KMS required headers.\n> \n> It then introduces a PixelFormat type that aliases an uint32_t, which is used in\n> all application facing types. The numerical fourcc codes used for PixelFormat\n> are the DRM/KMS defined DRM_FORMAT_* fourcc codes.\n> \n> Helpers for conversion to/from PixelFormat and V4L2_PIX_FMT_* are provided in\n> the V4L2 video device and used in all pipeline handlers. Finally the test\n> application and QCam are ported to use te DRM/KMS defined pixel codes.\n> \n> Thanks Laurent for having looked at the series and fixed the nasty DRM/V4L2 RBG\n> format conversion issues.\n\nYou're welcome.\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart \n\n> Jacopo Mondi (9):\n> include: linux: Update headers to Linux v5.2\n> include: linux: Import DRM/KMS headers from Linux v5.2\n> include: drm_fourcc: Add Motion-JPEG fourcc code\n> libcamera: Define PixelFormat type\n> libcamera: stream: Use the newly defined PixelFormat\n> libcamera: v4l2_videodevice: Add PixelFormat conversion\n> libcamera: pipeline: Use PixelFormat for application formats\n> qcam: Convert to use DRM formats\n> test: camera: buffer_import: Use DRM/KMS format\n> \n> Laurent Pinchart (1):\n> libcamera: formats: Write libcamera in lowercase\n> \n> include/libcamera/meson.build | 1 +\n> include/libcamera/pixelformats.h | 18 +\n> include/libcamera/stream.h | 13 +-\n> include/linux/drm.h | 1042 ++++++++++++++++++++++\n> include/linux/drm_fourcc.h | 765 ++++++++++++++++\n> include/linux/drm_mode.h | 1032 +++++++++++++++++++++\n> include/linux/media-bus-format.h | 4 +-\n> include/linux/media.h | 27 +-\n> include/linux/v4l2-controls.h | 29 +\n> include/linux/videodev2.h | 31 +-\n> src/libcamera/formats.cpp | 2 +-\n> src/libcamera/include/formats.h | 2 +-\n> src/libcamera/include/v4l2_videodevice.h | 5 +\n> src/libcamera/meson.build | 1 +\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 7 +-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 25 +-\n> src/libcamera/pipeline/uvcvideo.cpp | 4 +-\n> src/libcamera/pipeline/vimc.cpp | 15 +-\n> src/libcamera/pixelformats.cpp | 28 +\n> src/libcamera/stream.cpp | 17 +-\n> src/libcamera/v4l2_videodevice.cpp | 141 +++\n> src/qcam/format_converter.cpp | 30 +-\n> test/camera/buffer_import.cpp | 4 +-\n> 23 files changed, 3170 insertions(+), 73 deletions(-)\n> create mode 100644 include/libcamera/pixelformats.h\n> create mode 100644 include/linux/drm.h\n> create mode 100644 include/linux/drm_fourcc.h\n> create mode 100644 include/linux/drm_mode.h\n> create mode 100644 src/libcamera/pixelformats.cpp\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16F926017C\n\tfor ;\n\tMon, 28 Oct 2019 00:50:37 +0100 (CET)","from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net\n\t[93.2.121.143])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C61F325;\n\tMon, 28 Oct 2019 00:50:35 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572220236;\n\tbh=g+vgzf+Wm2UR2oeLy9W4HsFBF3mhG+/m1gtbOMAAcYU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VAppMElAtd5Oj2K8hZ85OcPD9tlwCXWql0Pg67glOx8d/y8TZQ6zL5JuImVFjsoEi\n\tqKyRqZ4NLtH8wUNGlZAqckq0jWruK1EEMB0URp0EL6Sd8evYsJ3VwEHJtRBhZ0LYmE\n\tN5sKDkKQAIIoy2pdLaKtBF0/dDBqlx3Ha5vFzkDU=","Date":"Mon, 28 Oct 2019 01:50:27 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191027235027.GF28970@pendragon.ideasonboard.com>","References":"<20191027234312.35284-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191027234312.35284-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 00/10] libcamera: Use DRM_FORMAT_*\n\tfourcc codes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 27 Oct 2019 23:50:37 -0000"}}]