[{"id":32500,"web_url":"https://patchwork.libcamera.org/comment/32500/","msgid":"<173323715695.3135963.4678634528933456378@ping.linuxembedded.co.uk>","date":"2024-12-03T14:45:56","subject":"Re: [PATCH v2 0/1] libcamera: software_isp: Actually apply black\n\tlevel from tuning data","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-12-03 09:38:12)\n> This is an alternative proposal fixing the black level to\n> https://patchwork.libcamera.org/patch/21703/ by Robert. This patch\n> fixes just the obvious bug, the other parts of the given series,\n> i.e. attempt to fix problems when switching cameras[1] or introducing\n> IMX355 helper, are not covered. This patch can be handled separately or\n> incorporated into the Robert’s series or another solution may be\n> proposed.\n> \n> [1] I wonder whether\n> https://patchwork.libcamera.org/project/libcamera/list/?series=4752\n> could be related.\n> \n> Changes in v2:\n> - Rebased on master.\n\nThanks for the reviews and test tags.\n\nCI passes, at\nhttps://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1322420 so\nI've merged.\n\n--\nKieran\n\n> \n> Milan Zamazal (1):\n> libcamera: software_isp: Actually apply black level from tuning data\n> \n> src/ipa/simple/algorithms/blc.cpp | 7 +++++--\n> src/ipa/simple/algorithms/blc.h | 4 ++++\n> src/ipa/simple/soft_simple.cpp | 3 +--\n> 3 files changed, 10 insertions(+), 4 deletions(-)\n> \n> -- \n> 2.44.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3995BDCBF\n\tfor ;\n\tTue, 3 Dec 2024 14:46:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAB2B6608F;\n\tTue, 3 Dec 2024 15:46:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7DD365FD6\n\tfor ;\n\tTue, 3 Dec 2024 15:45:59 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35A4D34D;\n\tTue, 3 Dec 2024 15:45:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BYc1FoGt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733237132;\n\tbh=RsFlrxw2tpIPmSnwooy4VyZBDabrekpezmIHc33fX88=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=BYc1FoGtfcxMVZABrRdHOP/gWVHyCMQd/Mt8gdIJvEyZ1g2fKPg7GPC29L8ygr87U\n\t/D04sed01VsQs88lww4s/ROemX0Y9DS2YFj3FVrgQ1Cqg2VamBHJAM4tyQRCb11uWg\n\tvS3CCP1m8GDPleYDvnjnYbqlSdAd78rw5Eu+eL8A=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241203093814.67984-1-mzamazal@redhat.com>","References":"<20241203093814.67984-1-mzamazal@redhat.com>","Subject":"Re: [PATCH v2 0/1] libcamera: software_isp: Actually apply black\n\tlevel from tuning data","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tRobert Mader ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Tue, 03 Dec 2024 14:45:56 +0000","Message-ID":"<173323715695.3135963.4678634528933456378@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]