[{"id":32468,"web_url":"https://patchwork.libcamera.org/comment/32468/","msgid":"<173291505107.4100433.10659654919073240451@ping.linuxembedded.co.uk>","date":"2024-11-29T21:17:31","subject":"Re: [PATCH v7 0/2] Add camera sensor properties for ciri","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Harvey Yang (2024-11-29 12:27:48)\n> Hi folks,\n> \n> This patch adds camera sensor properties for sensors on mtkisp7. It's\n> required to produce correct color bars test pattern instead of random\n> pattern.\n> \n> Tested on mtkisp7 branch with ChromeOS tast test `camera.HAL3Frame`.\n> \n> This patch passed gitlab pipeline:\n> https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1319966\n\nGetting this one through the merge CI has been problematic because of\nfailed tests related to ThreadAffinity.\n\nThese patches are not expected to be related to the failures I saw on\nThreadAffinity, and on the third attempt I now have a successful [0]\npipeline, so I'll merge these now.\n\n[0] https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1320174\n\n--\nKieran\n\n> \n> The source file includes quite some legacy code that has linter\n> warnings. This patch follows the same legacy format, so there are some\n> lint warnings as well.\n> \n> v7:\n> - Updated commits' author.\n> \n> v6:\n> - Added controls' delays.\n> \n> v5:\n> - Fixed the conversion from RAW10 to RAW16 for black levels.\n> \n> v4:\n> - Added black level values.\n> \n> v3:\n> - Updated commit messages.\n> - Added proper linear conversion rules for the two sensors.\n> \n> v2:\n> - Removed hi1339 that was not upstreamed and deprecated.\n> - Added CameraSensorHelper implementations, while might not end up\n> using.\n> - Split into two patches for two sensors.\n> \n> BR,\n> Harvey\n> \n> Harvey Yang (2):\n> libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor\n> properties\n> libcamera: libipa: camera_sensor: Add GalaxyCore gc08a3 sensor\n> properties\n> \n> src/ipa/libipa/camera_sensor_helper.cpp | 26 +++++++++++++++++++\n> .../sensor/camera_sensor_properties.cpp | 26 +++++++++++++++++++\n> 2 files changed, 52 insertions(+)\n> \n> -- \n> 2.47.0.338.g60cca15819-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8918BE175\n\tfor ;\n\tFri, 29 Nov 2024 21:17:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2F246603D;\n\tFri, 29 Nov 2024 22:17:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 453E266025\n\tfor ;\n\tFri, 29 Nov 2024 22:17:34 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A14DA57;\n\tFri, 29 Nov 2024 22:17:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T06nZQrg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732915029;\n\tbh=4B5ycQhT181cEJhyPUnBGdZbtMmE75BJkjm2mo2Hl0o=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=T06nZQrgg8X0xP6SXlpceVA0qP3FfLulcxwcgUhA84KvRRxnaTrepWbGKVN9Z87G2\n\tvNhdGcNVDNo8XG0LniRJK5m5LtwVM9JP1PjpBQLtX0cUKAL24CwdUjzZG3y9kkwmkW\n\txOA5FitwHiFSSC+zrCZRgzF0MGoMyitW3+ZDKt4k=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241129123032.2957763-1-chenghaoyang@chromium.org>","References":"<20241129123032.2957763-1-chenghaoyang@chromium.org>","Subject":"Re: [PATCH v7 0/2] Add camera sensor properties for ciri","From":"Kieran Bingham ","Cc":"Harvey Yang ","To":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 29 Nov 2024 21:17:31 +0000","Message-ID":"<173291505107.4100433.10659654919073240451@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32477,"web_url":"https://patchwork.libcamera.org/comment/32477/","msgid":"","date":"2024-11-30T04:16:08","subject":"Re: [PATCH v7 0/2] Add camera sensor properties for ciri","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Thank you Kieran!\n\nOn Sat, Nov 30, 2024 at 5:17 AM Kieran Bingham\n wrote:\n>\n> Quoting Harvey Yang (2024-11-29 12:27:48)\n> > Hi folks,\n> >\n> > This patch adds camera sensor properties for sensors on mtkisp7. It's\n> > required to produce correct color bars test pattern instead of random\n> > pattern.\n> >\n> > Tested on mtkisp7 branch with ChromeOS tast test `camera.HAL3Frame`.\n> >\n> > This patch passed gitlab pipeline:\n> > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1319966\n>\n> Getting this one through the merge CI has been problematic because of\n> failed tests related to ThreadAffinity.\n>\n> These patches are not expected to be related to the failures I saw on\n> ThreadAffinity, and on the third attempt I now have a successful [0]\n> pipeline, so I'll merge these now.\n>\n> [0] https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1320174\n>\n> --\n> Kieran\n>\n> >\n> > The source file includes quite some legacy code that has linter\n> > warnings. This patch follows the same legacy format, so there are some\n> > lint warnings as well.\n> >\n> > v7:\n> > - Updated commits' author.\n> >\n> > v6:\n> > - Added controls' delays.\n> >\n> > v5:\n> > - Fixed the conversion from RAW10 to RAW16 for black levels.\n> >\n> > v4:\n> > - Added black level values.\n> >\n> > v3:\n> > - Updated commit messages.\n> > - Added proper linear conversion rules for the two sensors.\n> >\n> > v2:\n> > - Removed hi1339 that was not upstreamed and deprecated.\n> > - Added CameraSensorHelper implementations, while might not end up\n> > using.\n> > - Split into two patches for two sensors.\n> >\n> > BR,\n> > Harvey\n> >\n> > Harvey Yang (2):\n> > libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor\n> > properties\n> > libcamera: libipa: camera_sensor: Add GalaxyCore gc08a3 sensor\n> > properties\n> >\n> > src/ipa/libipa/camera_sensor_helper.cpp | 26 +++++++++++++++++++\n> > .../sensor/camera_sensor_properties.cpp | 26 +++++++++++++++++++\n> > 2 files changed, 52 insertions(+)\n> >\n> > --\n> > 2.47.0.338.g60cca15819-goog\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8490DBE175\n\tfor ;\n\tSat, 30 Nov 2024 04:16:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E94566048;\n\tSat, 30 Nov 2024 05:16:22 +0100 (CET)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1471E618B5\n\tfor ;\n\tSat, 30 Nov 2024 05:16:21 +0100 (CET)","by mail-lf1-x133.google.com with SMTP id\n\t2adb3069b0e04-53dd668c5easo2596664e87.1\n\tfor ;\n\tFri, 29 Nov 2024 20:16:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"XmMNMVFY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1732940180; x=1733544980;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=V/CpaZF8Nfn6PGxbqG/B/vQJW1LLw/O0qawyPGAf94s=;\n\tb=XmMNMVFY0I/WgAdvaGH8wIdIReStZAg/9rMFqYveEf61rSdMocucDlAeTdjF/Fn3C3\n\tLD3zl+o/tXqS4AU3UNXt4tWtS2QMen8KmoUKFi6/2IhKUHd95hC7N8aoRByrJAUxNL7R\n\t5MBrTCmZ0r3aXJlEOu2HJjG5P+Sy/DJHq2D/E=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732940180; x=1733544980;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=V/CpaZF8Nfn6PGxbqG/B/vQJW1LLw/O0qawyPGAf94s=;\n\tb=jpyseUrXPvxVLxGiYnR1E3xftsBSZHCeQeoqh4CPP+49sct+8TUnScknvjzt1sBGoT\n\t7iXKUxV4YNeBNSX6tmg3fk5Sz58mMSiS9AADKlk6IfCX6ru+LZZmBUFfxXsW+lAlouYd\n\tpALnpSpzrzMoKASpedOYctgoqXMpn0BNzGagW3w0mH9X5qCtXLC1V+UcinMGf4ByXP/q\n\tCq981pVepOlsSUYa4YeVcFs4uuUeupQyyPjMd0itNdKcYXUpQOEx7+s+VCmatP+ZyJE3\n\tB8UW0XueGahirt8Me7vWNbDc3NaA9c0ChN/0XiPeOqQlvY/GJQM9KBJ9IYxXGZGm3Ceq\n\tzO7w==","X-Gm-Message-State":"AOJu0Yz2H6FgFbuYIQ7Cjpg7ExWpRpgRq2hRUlQ9S8YdUMzddMImroB2\n\tb4LXPaKQrE0TDndn2N9oDgIfZjpwZLJ01X/QGYhQWDlCPoHaphf4EzF6cC+IQEMTXpdNphLE1ZW\n\tRyz47Ovu8pjPblHIFTFlvfX1+tTMbcaYoJW/R","X-Gm-Gg":"ASbGncuMC2WypKQuHBTjLbsPjtykOLFjhtqEPbTlqveV1J6aJODKuexB+PnkBOUbcD8\n\tflkhtc5W8DG0bsAshrL0KtrVfBBtNNT4vkU9arypFD0sZx451UnM9xx6PoaMvC4MF","X-Google-Smtp-Source":"AGHT+IGi7sB5e6ZKKaF3EVYfte1H8WOvNzCxWbyxvIULULhPpfBn3J3cSnqa46d/ubfbmpAoT3x/G40Ixs/YypKh5Ss=","X-Received":"by 2002:a05:6512:ea9:b0:53d:f647:430c with SMTP id\n\t2adb3069b0e04-53df6474329mr3547433e87.17.1732940179981;\n\tFri, 29 Nov 2024 20:16:19 -0800 (PST)","MIME-Version":"1.0","References":"<20241129123032.2957763-1-chenghaoyang@chromium.org>\n\t<173291505107.4100433.10659654919073240451@ping.linuxembedded.co.uk>","In-Reply-To":"<173291505107.4100433.10659654919073240451@ping.linuxembedded.co.uk>","From":"Cheng-Hao Yang ","Date":"Sat, 30 Nov 2024 12:16:08 +0800","Message-ID":"","Subject":"Re: [PATCH v7 0/2] Add camera sensor properties for ciri","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]