[{"id":32481,"web_url":"https://patchwork.libcamera.org/comment/32481/","msgid":"","date":"2024-12-02T08:41:06","subject":"Re: [PATCH 0/2] Use Sensor Delays from CameraSensorProperties in RPi","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Dan,\n\nOn Wed, 27 Nov 2024 at 13:32, Daniel Scally wrote:\n>\n> Hello all\n>\n> This set follows on from the recent move to add control delay values to the\n> CameraSensorProperties data by removing the independent implementation found in\n> the Raspberry Pi IPA's CameraSensorHelpers. The IPA had helpers for two sensors,\n> the OV7251 and OV9281, which did not have any CameraSensorProperties defined so\n> a patch is included to add those.\n>\n> Thanks\n> Dan\n\nThanks for tidying this up! For both patches:\n\nReviewed-by: Naushir Patuck \n\n\n>\n> Daniel Scally (2):\n> libcamera: camera_sensor_properties: Add ov7251 and ov9281\n> libcamera: rpi: Draw sensor delays from CameraSensorProperties\n>\n> include/libcamera/ipa/raspberrypi.mojom | 4 ----\n> src/ipa/rpi/cam_helper/cam_helper.cpp | 13 ------------\n> src/ipa/rpi/cam_helper/cam_helper.h | 7 -------\n> src/ipa/rpi/cam_helper/cam_helper_imx283.cpp | 12 -----------\n> src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 11 ----------\n> src/ipa/rpi/cam_helper/cam_helper_imx296.cpp | 11 ----------\n> src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 11 ----------\n> src/ipa/rpi/cam_helper/cam_helper_imx519.cpp | 11 ----------\n> src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 11 ----------\n> src/ipa/rpi/cam_helper/cam_helper_ov5647.cpp | 15 --------------\n> src/ipa/rpi/cam_helper/cam_helper_ov64a40.cpp | 12 -----------\n> src/ipa/rpi/cam_helper/cam_helper_ov7251.cpp | 12 -----------\n> src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 12 -----------\n> src/ipa/rpi/common/ipa_base.cpp | 14 ++-----------\n> .../pipeline/rpi/common/pipeline_base.cpp | 9 +++++----\n> .../sensor/camera_sensor_properties.cpp | 20 +++++++++++++++++++\n> 16 files changed, 27 insertions(+), 158 deletions(-)\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB19CBDCBF\n\tfor ;\n\tMon, 2 Dec 2024 08:41:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 908A16605C;\n\tMon, 2 Dec 2024 09:41:40 +0100 (CET)","from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com\n\t[IPv6:2607:f8b0:4864:20::1133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFC3066010\n\tfor ;\n\tMon, 2 Dec 2024 09:41:37 +0100 (CET)","by mail-yw1-x1133.google.com with SMTP id\n\t00721157ae682-6ef9cdecc60so164087b3.1\n\tfor ;\n\tMon, 02 Dec 2024 00:41:37 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"r5MsvNjN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1733128896; x=1733733696;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=5mHxM+/IX6rQnDLFP3M7z4ez7hpP3A/0hJH8GwBnLaw=;\n\tb=r5MsvNjNyLFiFk8Mb88uxeeE3qnENDB9DYqJ86ej48lBAK5/KYUwlhnBeX4HSUHgIy\n\to9fd7AddYhXweyBmIsd2Og6yMkne4qUtAED02sg+7hXNMv/A7IvZ+hgyoxHKgRrAK6hm\n\tAVOnI0t8krmfq9mBDTsdzEdFvp3EaFZ3EuAHFNBFQArU7EEi6wkC4CtSgdQ9D2ufOzrw\n\t2nqbdUPsAEKiouI2RHn4CsWVnlg83t48DyRLuMnHFoppdSw/QbxZDe+17B4rlez1oZgI\n\touM9VUhkWrukSFQkxjVMMkhs0jpZKLb79rDoSQcG2iJ/3uDNzyzjyaI8ABsEoQ13m9+S\n\tpHag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733128896; x=1733733696;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=5mHxM+/IX6rQnDLFP3M7z4ez7hpP3A/0hJH8GwBnLaw=;\n\tb=mwrTAZ6gRdDtFwYfT2LCD5Dr0TWiAJZ0nMKWPST2FtP1rwch4CYg/wYC5ZpYTZYKuT\n\tGau1UaRUG9v8PqOhzQTkAx5GwpmX9++991QTlyrpwHjHXil8q9LfLsye+C3KSKoxgiV0\n\t4sCCQ9UmYAPpFgjVN5Nsu1NE9K/tEOj/LtUNwupS3tRhLhg9N1bucR4CpaHzBd0NIkn2\n\t/35vVCspblxMMjCvnGqbfYmXbNG1UZyXDJlsITR9x2WpK3/GOufkiil0A3BdorZppMl7\n\tb/wBXWRXNvHcKQOtNwoJyT069FiPfVWH4GebRltUrovqV7fnMWh1P6wQ60Dh5GBWN18M\n\tUpgg==","X-Gm-Message-State":"AOJu0Yyfvly1Eh3VpIYX70YLN0sqDgYShXfbjzLxr737JmOQNEmG5Y0I\n\t83yjmtIDF7WkR5Ddl6zekH1iL1ncG0OQGAiVCUeM/8Le09cDDY0ilxxK4aWsjjpOiiqdbLpWd2f\n\t7LoApxss1kxOo61YUIVZJPQ0S8eseKbx1b5Wrqg==","X-Gm-Gg":"ASbGncuPnTpclabFEoovcsNxwPeN4oz1YIoSFQ08v+Eot0Z672/lgoWtkWIFTSO3W2P\n\tEXdRyQhdHUVanFLQVUH4snOe9X+mM2yRo3FMVA5/DD+dK6X3XS+Qk3UjD2/jXQbI=","X-Google-Smtp-Source":"AGHT+IFqCttbAtypd3Vh7aRRE5BT6wuuIoU50jw20k8DLYNL1Jxqw9ShAQqDEWxYcBbl+Ao+8+++TLRp49m0Iq0QRY0=","X-Received":"by 2002:a05:690c:3187:b0:6ef:652b:91cd with SMTP id\n\t00721157ae682-6ef652b958dmr39520927b3.7.1733128896569;\n\tMon, 02 Dec 2024 00:41:36 -0800 (PST)","MIME-Version":"1.0","References":"<20241127133233.247977-1-dan.scally@ideasonboard.com>","In-Reply-To":"<20241127133233.247977-1-dan.scally@ideasonboard.com>","From":"Naushir Patuck ","Date":"Mon, 2 Dec 2024 08:41:06 +0000","Message-ID":"","Subject":"Re: [PATCH 0/2] Use Sensor Delays from CameraSensorProperties in RPi","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, david.plowman@raspberrypi.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]