[{"id":32420,"web_url":"https://patchwork.libcamera.org/comment/32420/","msgid":"","date":"2024-11-28T09:22:23","subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Harevy\n\nPlease note that our CI system has detected 10 test failures on CTS\nwhen testing this series:\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/67301704\nhttps://yvain.ideasonboard.com/scheduler/job/84\n\nOur baseline with CTS is 7 test failures.\n\nWe know CTS failures might be a fluke but I'm wondering if you have\nrun CTS on your systems and detected similar results or not.\n\nThanks\n j\n\n\nOn Wed, Nov 27, 2024 at 09:25:50AM +0000, Harvey Yang wrote:\n> Hi folks,\n>\n> This series of patches adds a new signal metadataAvailable in\n> libcamera::Camera, and supports partial result in Android adapter.\n>\n> Although Android allows a partial result to contain both buffers and\n> metadata, we probably don't need such a feature. Splitting them into\n> different partial results should fit both MediaTek's and Intel's\n> requirements.\n>\n> This patch passed gitlab pipeline:\n> https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1317276\n>\n> There are still some discussion of the new signal in the previous patch,\n> with Jacopo. I'll update the patch when we reach agreement.\n>\n> I understand that the last patch is a bit large, while I don't know how\n> to split that furthermore. Let me know if there are some pieces that can\n> be standalone patches.\n>\n> BR,\n> Harvey\n>\n>\n> Han-Lin Chen (2):\n> libcamera: Camera: Add signals for completion of metadata as a partial\n> result\n> android: Add JpegExifMetadata to store tags setting into Exif\n>\n> Harvey Yang (7):\n> android: Move StreamBuffer out of Camera3RequestDescriptor\n> android: Set StreamBuffer::srcBuffer in\n> CameraDevice::processCaptureRequest\n> android: Migrate StreamBuffer::internalBuffer to\n> Camera3RequestDescriptor\n> android: Add CameraDevice::sendCaptureResult()\n> android: Cleanup CAMERA3_MSG_ERROR_REQUEST\n> android: Remove Camera3RequestDescriptor::streamsProcessMutex_\n> android: Support partial results\n>\n> include/libcamera/camera.h | 1 +\n> include/libcamera/internal/pipeline_handler.h | 1 +\n> include/libcamera/internal/request.h | 4 +\n> include/libcamera/request.h | 1 +\n> src/android/camera_capabilities.cpp | 11 +-\n> src/android/camera_capabilities.h | 2 +\n> src/android/camera_device.cpp | 926 ++++++++++++------\n> src/android/camera_device.h | 46 +-\n> src/android/camera_request.cpp | 94 +-\n> src/android/camera_request.h | 96 +-\n> src/android/camera_stream.cpp | 20 +-\n> src/android/camera_stream.h | 10 +-\n> src/android/jpeg/encoder.h | 2 +-\n> src/android/jpeg/encoder_jea.cpp | 2 +-\n> src/android/jpeg/encoder_jea.h | 2 +-\n> src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> src/android/jpeg/encoder_libjpeg.h | 2 +-\n> src/android/jpeg/post_processor_jpeg.cpp | 16 +-\n> src/android/jpeg/post_processor_jpeg.h | 2 +-\n> src/android/post_processor.h | 4 +-\n> src/android/yuv/post_processor_yuv.cpp | 2 +-\n> src/android/yuv/post_processor_yuv.h | 2 +-\n> src/libcamera/camera.cpp | 6 +\n> src/libcamera/pipeline_handler.cpp | 41 +\n> src/libcamera/request.cpp | 21 +\n> 25 files changed, 908 insertions(+), 408 deletions(-)\n>\n> --\n> 2.47.0.338.g60cca15819-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CC96C3226\n\tfor ;\n\tThu, 28 Nov 2024 09:22:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CFDA65F55;\n\tThu, 28 Nov 2024 10:22:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18E72618B9\n\tfor ;\n\tThu, 28 Nov 2024 10:22:27 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1898D741;\n\tThu, 28 Nov 2024 10:22:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jk3aQpPu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732785723;\n\tbh=3+5DPWyr4OjTXDsvPZwp3GZ+JFyocnq5Aa8+QXyWXRk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jk3aQpPurCcd15IH8QmT1OapzydwYtXsybazkWuiQnXh6HwZd2Eia6A7gA5/ifsbR\n\teWguthQEeCRFpnb3//+lNavOorZ48395r5RZEEQbju+oqKLj8IuA+sHLDifwmTgSfh\n\t6WRvCis/O12EmI1mQCMgIbbLO0Zh4hpkQ/5N4j/U=","Date":"Thu, 28 Nov 2024 10:22:23 +0100","From":"Jacopo Mondi ","To":"Harvey Yang ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","Message-ID":"","References":"<20241127092632.3145984-1-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241127092632.3145984-1-chenghaoyang@chromium.org>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32425,"web_url":"https://patchwork.libcamera.org/comment/32425/","msgid":"","date":"2024-11-28T12:59:57","subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"A second run of CTS reported 7 failures\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/67365473\n\nThe three additional ones were likely flukes then.\n\nOn Thu, Nov 28, 2024 at 10:22:23AM +0100, Jacopo Mondi wrote:\n> Hi Harevy\n>\n> Please note that our CI system has detected 10 test failures on CTS\n> when testing this series:\n> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67301704\n> https://yvain.ideasonboard.com/scheduler/job/84\n>\n> Our baseline with CTS is 7 test failures.\n>\n> We know CTS failures might be a fluke but I'm wondering if you have\n> run CTS on your systems and detected similar results or not.\n>\n> Thanks\n> j\n>\n>\n> On Wed, Nov 27, 2024 at 09:25:50AM +0000, Harvey Yang wrote:\n> > Hi folks,\n> >\n> > This series of patches adds a new signal metadataAvailable in\n> > libcamera::Camera, and supports partial result in Android adapter.\n> >\n> > Although Android allows a partial result to contain both buffers and\n> > metadata, we probably don't need such a feature. Splitting them into\n> > different partial results should fit both MediaTek's and Intel's\n> > requirements.\n> >\n> > This patch passed gitlab pipeline:\n> > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1317276\n> >\n> > There are still some discussion of the new signal in the previous patch,\n> > with Jacopo. I'll update the patch when we reach agreement.\n> >\n> > I understand that the last patch is a bit large, while I don't know how\n> > to split that furthermore. Let me know if there are some pieces that can\n> > be standalone patches.\n> >\n> > BR,\n> > Harvey\n> >\n> >\n> > Han-Lin Chen (2):\n> > libcamera: Camera: Add signals for completion of metadata as a partial\n> > result\n> > android: Add JpegExifMetadata to store tags setting into Exif\n> >\n> > Harvey Yang (7):\n> > android: Move StreamBuffer out of Camera3RequestDescriptor\n> > android: Set StreamBuffer::srcBuffer in\n> > CameraDevice::processCaptureRequest\n> > android: Migrate StreamBuffer::internalBuffer to\n> > Camera3RequestDescriptor\n> > android: Add CameraDevice::sendCaptureResult()\n> > android: Cleanup CAMERA3_MSG_ERROR_REQUEST\n> > android: Remove Camera3RequestDescriptor::streamsProcessMutex_\n> > android: Support partial results\n> >\n> > include/libcamera/camera.h | 1 +\n> > include/libcamera/internal/pipeline_handler.h | 1 +\n> > include/libcamera/internal/request.h | 4 +\n> > include/libcamera/request.h | 1 +\n> > src/android/camera_capabilities.cpp | 11 +-\n> > src/android/camera_capabilities.h | 2 +\n> > src/android/camera_device.cpp | 926 ++++++++++++------\n> > src/android/camera_device.h | 46 +-\n> > src/android/camera_request.cpp | 94 +-\n> > src/android/camera_request.h | 96 +-\n> > src/android/camera_stream.cpp | 20 +-\n> > src/android/camera_stream.h | 10 +-\n> > src/android/jpeg/encoder.h | 2 +-\n> > src/android/jpeg/encoder_jea.cpp | 2 +-\n> > src/android/jpeg/encoder_jea.h | 2 +-\n> > src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> > src/android/jpeg/encoder_libjpeg.h | 2 +-\n> > src/android/jpeg/post_processor_jpeg.cpp | 16 +-\n> > src/android/jpeg/post_processor_jpeg.h | 2 +-\n> > src/android/post_processor.h | 4 +-\n> > src/android/yuv/post_processor_yuv.cpp | 2 +-\n> > src/android/yuv/post_processor_yuv.h | 2 +-\n> > src/libcamera/camera.cpp | 6 +\n> > src/libcamera/pipeline_handler.cpp | 41 +\n> > src/libcamera/request.cpp | 21 +\n> > 25 files changed, 908 insertions(+), 408 deletions(-)\n> >\n> > --\n> > 2.47.0.338.g60cca15819-goog\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28286BDE6B\n\tfor ;\n\tThu, 28 Nov 2024 13:00:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A47D165F67;\n\tThu, 28 Nov 2024 14:00:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D416165898\n\tfor ;\n\tThu, 28 Nov 2024 14:00:00 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D095E59D;\n\tThu, 28 Nov 2024 13:59:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MqPKZcrK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732798776;\n\tbh=z2eor0ILSmF22bmIbbOYIEHXnm49jdyLHM8N5iXhlxk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MqPKZcrKXkNkOPKbyCNJLpRthVCpLqOOzfb4zMI3NP/gz6617zagaLOzL9yvmfTQp\n\t2isK/WuBXoMgt2utK8oXLA0Bhv1vaxVRxeBI8aQQRDjlLXIG8qc+/L8wEVW4tCl0KA\n\tdX7kWaqqjVA9ScVtAZ60jlN36edXDn143YdA4NEs=","Date":"Thu, 28 Nov 2024 13:59:57 +0100","From":"Jacopo Mondi ","To":"Jacopo Mondi ","Cc":"Harvey Yang , \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","Message-ID":"","References":"<20241127092632.3145984-1-chenghaoyang@chromium.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32515,"web_url":"https://patchwork.libcamera.org/comment/32515/","msgid":"","date":"2024-12-04T13:56:31","subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Jacopo,\n\nOn Thu, Nov 28, 2024 at 9:00 PM Jacopo Mondi\n wrote:\n>\n> A second run of CTS reported 7 failures\n> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67365473\n>\n> The three additional ones were likely flukes then.\n>\n> On Thu, Nov 28, 2024 at 10:22:23AM +0100, Jacopo Mondi wrote:\n> > Hi Harevy\n> >\n> > Please note that our CI system has detected 10 test failures on CTS\n> > when testing this series:\n> > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67301704\n> > https://yvain.ideasonboard.com/scheduler/job/84\n> >\n> > Our baseline with CTS is 7 test failures.\n> >\n> > We know CTS failures might be a fluke but I'm wondering if you have\n> > run CTS on your systems and detected similar results or not.\n\nYeah v2 seems to fail more CTS tests than the previous version.\nIn my last trial though, the tot I have on gitlab [1] passes as many\nCTS tests as the origin/master does.\n\nI'll run CTS again before the next version of series.\n\nBR,\nHarvey\n\n[1]: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/commit/97b8c426656755b4a6e21cc8d8397ccd92395481\n\n> >\n> > Thanks\n> > j\n> >\n> >\n> > On Wed, Nov 27, 2024 at 09:25:50AM +0000, Harvey Yang wrote:\n> > > Hi folks,\n> > >\n> > > This series of patches adds a new signal metadataAvailable in\n> > > libcamera::Camera, and supports partial result in Android adapter.\n> > >\n> > > Although Android allows a partial result to contain both buffers and\n> > > metadata, we probably don't need such a feature. Splitting them into\n> > > different partial results should fit both MediaTek's and Intel's\n> > > requirements.\n> > >\n> > > This patch passed gitlab pipeline:\n> > > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1317276\n> > >\n> > > There are still some discussion of the new signal in the previous patch,\n> > > with Jacopo. I'll update the patch when we reach agreement.\n> > >\n> > > I understand that the last patch is a bit large, while I don't know how\n> > > to split that furthermore. Let me know if there are some pieces that can\n> > > be standalone patches.\n> > >\n> > > BR,\n> > > Harvey\n> > >\n> > >\n> > > Han-Lin Chen (2):\n> > > libcamera: Camera: Add signals for completion of metadata as a partial\n> > > result\n> > > android: Add JpegExifMetadata to store tags setting into Exif\n> > >\n> > > Harvey Yang (7):\n> > > android: Move StreamBuffer out of Camera3RequestDescriptor\n> > > android: Set StreamBuffer::srcBuffer in\n> > > CameraDevice::processCaptureRequest\n> > > android: Migrate StreamBuffer::internalBuffer to\n> > > Camera3RequestDescriptor\n> > > android: Add CameraDevice::sendCaptureResult()\n> > > android: Cleanup CAMERA3_MSG_ERROR_REQUEST\n> > > android: Remove Camera3RequestDescriptor::streamsProcessMutex_\n> > > android: Support partial results\n> > >\n> > > include/libcamera/camera.h | 1 +\n> > > include/libcamera/internal/pipeline_handler.h | 1 +\n> > > include/libcamera/internal/request.h | 4 +\n> > > include/libcamera/request.h | 1 +\n> > > src/android/camera_capabilities.cpp | 11 +-\n> > > src/android/camera_capabilities.h | 2 +\n> > > src/android/camera_device.cpp | 926 ++++++++++++------\n> > > src/android/camera_device.h | 46 +-\n> > > src/android/camera_request.cpp | 94 +-\n> > > src/android/camera_request.h | 96 +-\n> > > src/android/camera_stream.cpp | 20 +-\n> > > src/android/camera_stream.h | 10 +-\n> > > src/android/jpeg/encoder.h | 2 +-\n> > > src/android/jpeg/encoder_jea.cpp | 2 +-\n> > > src/android/jpeg/encoder_jea.h | 2 +-\n> > > src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> > > src/android/jpeg/encoder_libjpeg.h | 2 +-\n> > > src/android/jpeg/post_processor_jpeg.cpp | 16 +-\n> > > src/android/jpeg/post_processor_jpeg.h | 2 +-\n> > > src/android/post_processor.h | 4 +-\n> > > src/android/yuv/post_processor_yuv.cpp | 2 +-\n> > > src/android/yuv/post_processor_yuv.h | 2 +-\n> > > src/libcamera/camera.cpp | 6 +\n> > > src/libcamera/pipeline_handler.cpp | 41 +\n> > > src/libcamera/request.cpp | 21 +\n> > > 25 files changed, 908 insertions(+), 408 deletions(-)\n> > >\n> > > --\n> > > 2.47.0.338.g60cca15819-goog\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15489BDB1C\n\tfor ;\n\tWed, 4 Dec 2024 14:02:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DCE54660B6;\n\tWed, 4 Dec 2024 15:02:28 +0100 (CET)","from mail-lf1-x135.google.com (mail-lf1-x135.google.com\n\t[IPv6:2a00:1450:4864:20::135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 810E8618B5\n\tfor ;\n\tWed, 4 Dec 2024 15:02:27 +0100 (CET)","by mail-lf1-x135.google.com with SMTP id\n\t2adb3069b0e04-53e1c3dfbb0so1066268e87.3\n\tfor ;\n\tWed, 04 Dec 2024 06:02:27 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"RvIFc95b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1733320946; x=1733925746;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=j03mcZwH0PDrZJCjnlKWzETOj4MApI7u+y9uGgtaPvU=;\n\tb=RvIFc95bmOHptf1HRWcfk3GHKUIczOiIRL6HZAeKBtRX/nj9jliTQ1fEs8fJvR7PKS\n\tTvxSnoHU8Lt1dEvumU376FY9ssDfzNusoMxRt7jEIlsW16f+DqujZzKx266UNDlBb6Qt\n\t0iaeJvT2SfYfDYQkWgqqWuwPP4BypxYRARL8E=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733320946; x=1733925746;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=j03mcZwH0PDrZJCjnlKWzETOj4MApI7u+y9uGgtaPvU=;\n\tb=RJ5o8EkVwisI1tQFQd7rS2f7hZ9/K1OLeNGJ91CHRqGXWXWznsYu5QyFecVU588VPM\n\ttZOlJyl2wdfGbwYlCiRFRXUZjitD0XBaMFHpuCXtWAwmu1lJI3W1JUVGov1kkVLUxwQm\n\tYfKmlYKRhtGixvNS6KJc5ruTRJkX1tcjJelKEAzv1SSdmtN5iY8KAPJYEJ4XrPCwrOeG\n\tNHJ84OFnl3vpT9q28yyllSc1hBiwuP2CwKYD7FvHPFFiGNJP4b3EToPy1KHmsvFQoVsp\n\tuZrQWHYfkNFCEKUcX+g8FYZT9Fxtp65jUPXXaM4TNXVO1dimqSwlZhRPpomOz+YxvfBF\n\tiflA==","X-Gm-Message-State":"AOJu0YzML1Xq/wGKWo6t4ylk4R6p4+38dgiB1gUOAqey7JrkVw8IM/Rl\n\tZNZo7Z9fP7KDzTe40Lb2ajfXqujVraTnEAWrpGYj0h97b+QiZop5G8FKi6LNX73YHPZEoKUtVl7\n\tibM+cofXpbor6/luRPIV1toVWgfPvGlcFCoGWgqxOOTcsgDXhtQ==","X-Gm-Gg":"ASbGnctdgq1tzGtgLDpwuXcV/KipnQCu6H43WqfY+zrjfO8EGCX4iYKUhaKqdyj3Wz0\n\tXWyMeekL9/H6MMZp8GQU3x/s3EHcR+QPw8Usfid+RbjXj4++Bva21U2TZSb/eHTMJZA==","X-Google-Smtp-Source":"AGHT+IH4caXGtIzF7QJ14SLeq8WGf6vDfLtv1XvhqnS/f4ARUbDeZzL2FSfaw0h/+ov1vUWJgvC3+k0AE7HSeFJCwm4=","X-Received":"by 2002:a05:651c:1149:b0:2ff:78be:e02d with SMTP id\n\t38308e7fff4ca-30009be4b7fmr42416241fa.11.1733320602356;\n\tWed, 04 Dec 2024 05:56:42 -0800 (PST)","MIME-Version":"1.0","References":"<20241127092632.3145984-1-chenghaoyang@chromium.org>\n\t\n\t","In-Reply-To":"","From":"Cheng-Hao Yang ","Date":"Wed, 4 Dec 2024 21:56:31 +0800","Message-ID":"","Subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32516,"web_url":"https://patchwork.libcamera.org/comment/32516/","msgid":"","date":"2024-12-04T14:03:21","subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Harvey\n\nOn Wed, Dec 04, 2024 at 09:56:31PM +0800, Cheng-Hao Yang wrote:\n> Hi Jacopo,\n>\n> On Thu, Nov 28, 2024 at 9:00 PM Jacopo Mondi\n> wrote:\n> >\n> > A second run of CTS reported 7 failures\n> > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67365473\n> >\n> > The three additional ones were likely flukes then.\n> >\n> > On Thu, Nov 28, 2024 at 10:22:23AM +0100, Jacopo Mondi wrote:\n> > > Hi Harevy\n> > >\n> > > Please note that our CI system has detected 10 test failures on CTS\n> > > when testing this series:\n> > > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67301704\n> > > https://yvain.ideasonboard.com/scheduler/job/84\n> > >\n> > > Our baseline with CTS is 7 test failures.\n> > >\n> > > We know CTS failures might be a fluke but I'm wondering if you have\n> > > run CTS on your systems and detected similar results or not.\n>\n> Yeah v2 seems to fail more CTS tests than the previous version.\n> In my last trial though, the tot I have on gitlab [1] passes as many\n> CTS tests as the origin/master does.\n\nI see the test not being run at all\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/jobs/67693898\n\nI think this is intended as I don't think we allow forked repositories\nto run CTS on our test infrastructure (I guess??) ?\n\nWhat CTS run are you referring to ?\n\n>\n> I'll run CTS again before the next version of series.\n>\n> BR,\n> Harvey\n>\n> [1]: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/commit/97b8c426656755b4a6e21cc8d8397ccd92395481\n>\n> > >\n> > > Thanks\n> > > j\n> > >\n> > >\n> > > On Wed, Nov 27, 2024 at 09:25:50AM +0000, Harvey Yang wrote:\n> > > > Hi folks,\n> > > >\n> > > > This series of patches adds a new signal metadataAvailable in\n> > > > libcamera::Camera, and supports partial result in Android adapter.\n> > > >\n> > > > Although Android allows a partial result to contain both buffers and\n> > > > metadata, we probably don't need such a feature. Splitting them into\n> > > > different partial results should fit both MediaTek's and Intel's\n> > > > requirements.\n> > > >\n> > > > This patch passed gitlab pipeline:\n> > > > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1317276\n> > > >\n> > > > There are still some discussion of the new signal in the previous patch,\n> > > > with Jacopo. I'll update the patch when we reach agreement.\n> > > >\n> > > > I understand that the last patch is a bit large, while I don't know how\n> > > > to split that furthermore. Let me know if there are some pieces that can\n> > > > be standalone patches.\n> > > >\n> > > > BR,\n> > > > Harvey\n> > > >\n> > > >\n> > > > Han-Lin Chen (2):\n> > > > libcamera: Camera: Add signals for completion of metadata as a partial\n> > > > result\n> > > > android: Add JpegExifMetadata to store tags setting into Exif\n> > > >\n> > > > Harvey Yang (7):\n> > > > android: Move StreamBuffer out of Camera3RequestDescriptor\n> > > > android: Set StreamBuffer::srcBuffer in\n> > > > CameraDevice::processCaptureRequest\n> > > > android: Migrate StreamBuffer::internalBuffer to\n> > > > Camera3RequestDescriptor\n> > > > android: Add CameraDevice::sendCaptureResult()\n> > > > android: Cleanup CAMERA3_MSG_ERROR_REQUEST\n> > > > android: Remove Camera3RequestDescriptor::streamsProcessMutex_\n> > > > android: Support partial results\n> > > >\n> > > > include/libcamera/camera.h | 1 +\n> > > > include/libcamera/internal/pipeline_handler.h | 1 +\n> > > > include/libcamera/internal/request.h | 4 +\n> > > > include/libcamera/request.h | 1 +\n> > > > src/android/camera_capabilities.cpp | 11 +-\n> > > > src/android/camera_capabilities.h | 2 +\n> > > > src/android/camera_device.cpp | 926 ++++++++++++------\n> > > > src/android/camera_device.h | 46 +-\n> > > > src/android/camera_request.cpp | 94 +-\n> > > > src/android/camera_request.h | 96 +-\n> > > > src/android/camera_stream.cpp | 20 +-\n> > > > src/android/camera_stream.h | 10 +-\n> > > > src/android/jpeg/encoder.h | 2 +-\n> > > > src/android/jpeg/encoder_jea.cpp | 2 +-\n> > > > src/android/jpeg/encoder_jea.h | 2 +-\n> > > > src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> > > > src/android/jpeg/encoder_libjpeg.h | 2 +-\n> > > > src/android/jpeg/post_processor_jpeg.cpp | 16 +-\n> > > > src/android/jpeg/post_processor_jpeg.h | 2 +-\n> > > > src/android/post_processor.h | 4 +-\n> > > > src/android/yuv/post_processor_yuv.cpp | 2 +-\n> > > > src/android/yuv/post_processor_yuv.h | 2 +-\n> > > > src/libcamera/camera.cpp | 6 +\n> > > > src/libcamera/pipeline_handler.cpp | 41 +\n> > > > src/libcamera/request.cpp | 21 +\n> > > > 25 files changed, 908 insertions(+), 408 deletions(-)\n> > > >\n> > > > --\n> > > > 2.47.0.338.g60cca15819-goog\n> > > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4686EBDB1C\n\tfor ;\n\tWed, 4 Dec 2024 14:03:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E440D660B6;\n\tWed, 4 Dec 2024 15:03:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1405A618B5\n\tfor ;\n\tWed, 4 Dec 2024 15:03:26 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 248926D6;\n\tWed, 4 Dec 2024 15:02:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FW4GNKhp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733320977;\n\tbh=Hd4bce1P814fXENtLhcCcvsg9I36zPRxUH+eTZfTn6M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FW4GNKhp/IKM9wwzgvTQT+Q1GCmSVg/xhjUjRDnnnpynGRjsnPD/TCH3DZPIzG9DW\n\tAqkoMYqjU1ZWP1svpxkHRtCq2QdLFW91WUIXRpbvPZrl7ucDH4mhJ1fTHCwF10Tvn0\n\tiZoe+k+DTnmkE+qs1HMJOeJ4GDhX+7TO56iK5N3Y=","Date":"Wed, 4 Dec 2024 15:03:21 +0100","From":"Jacopo Mondi ","To":"Cheng-Hao Yang ","Cc":"Jacopo Mondi , \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","Message-ID":"","References":"<20241127092632.3145984-1-chenghaoyang@chromium.org>\n\t\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32517,"web_url":"https://patchwork.libcamera.org/comment/32517/","msgid":"","date":"2024-12-04T14:10:28","subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Jacopo,\n\nOn Wed, Dec 4, 2024 at 10:03 PM Jacopo Mondi\n wrote:\n>\n> Hi Harvey\n>\n> On Wed, Dec 04, 2024 at 09:56:31PM +0800, Cheng-Hao Yang wrote:\n> > Hi Jacopo,\n> >\n> > On Thu, Nov 28, 2024 at 9:00 PM Jacopo Mondi\n> > wrote:\n> > >\n> > > A second run of CTS reported 7 failures\n> > > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67365473\n> > >\n> > > The three additional ones were likely flukes then.\n> > >\n> > > On Thu, Nov 28, 2024 at 10:22:23AM +0100, Jacopo Mondi wrote:\n> > > > Hi Harevy\n> > > >\n> > > > Please note that our CI system has detected 10 test failures on CTS\n> > > > when testing this series:\n> > > > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67301704\n> > > > https://yvain.ideasonboard.com/scheduler/job/84\n> > > >\n> > > > Our baseline with CTS is 7 test failures.\n> > > >\n> > > > We know CTS failures might be a fluke but I'm wondering if you have\n> > > > run CTS on your systems and detected similar results or not.\n> >\n> > Yeah v2 seems to fail more CTS tests than the previous version.\n> > In my last trial though, the tot I have on gitlab [1] passes as many\n> > CTS tests as the origin/master does.\n>\n> I see the test not being run at all\n> https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/jobs/67693898\n>\n> I think this is intended as I don't think we allow forked repositories\n> to run CTS on our test infrastructure (I guess??) ?\n>\n> What CTS run are you referring to ?\n\nI ran CTS (android-cts-13_r7) manually with my own soraka DUT.\nWe can also use the result on gitlab instead. Do I need to ask for\nyour help to run it everytime?\n\nBR,\nHarvey\n\n>\n> >\n> > I'll run CTS again before the next version of series.\n> >\n> > BR,\n> > Harvey\n> >\n> > [1]: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/commit/97b8c426656755b4a6e21cc8d8397ccd92395481\n> >\n> > > >\n> > > > Thanks\n> > > > j\n> > > >\n> > > >\n> > > > On Wed, Nov 27, 2024 at 09:25:50AM +0000, Harvey Yang wrote:\n> > > > > Hi folks,\n> > > > >\n> > > > > This series of patches adds a new signal metadataAvailable in\n> > > > > libcamera::Camera, and supports partial result in Android adapter.\n> > > > >\n> > > > > Although Android allows a partial result to contain both buffers and\n> > > > > metadata, we probably don't need such a feature. Splitting them into\n> > > > > different partial results should fit both MediaTek's and Intel's\n> > > > > requirements.\n> > > > >\n> > > > > This patch passed gitlab pipeline:\n> > > > > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1317276\n> > > > >\n> > > > > There are still some discussion of the new signal in the previous patch,\n> > > > > with Jacopo. I'll update the patch when we reach agreement.\n> > > > >\n> > > > > I understand that the last patch is a bit large, while I don't know how\n> > > > > to split that furthermore. Let me know if there are some pieces that can\n> > > > > be standalone patches.\n> > > > >\n> > > > > BR,\n> > > > > Harvey\n> > > > >\n> > > > >\n> > > > > Han-Lin Chen (2):\n> > > > > libcamera: Camera: Add signals for completion of metadata as a partial\n> > > > > result\n> > > > > android: Add JpegExifMetadata to store tags setting into Exif\n> > > > >\n> > > > > Harvey Yang (7):\n> > > > > android: Move StreamBuffer out of Camera3RequestDescriptor\n> > > > > android: Set StreamBuffer::srcBuffer in\n> > > > > CameraDevice::processCaptureRequest\n> > > > > android: Migrate StreamBuffer::internalBuffer to\n> > > > > Camera3RequestDescriptor\n> > > > > android: Add CameraDevice::sendCaptureResult()\n> > > > > android: Cleanup CAMERA3_MSG_ERROR_REQUEST\n> > > > > android: Remove Camera3RequestDescriptor::streamsProcessMutex_\n> > > > > android: Support partial results\n> > > > >\n> > > > > include/libcamera/camera.h | 1 +\n> > > > > include/libcamera/internal/pipeline_handler.h | 1 +\n> > > > > include/libcamera/internal/request.h | 4 +\n> > > > > include/libcamera/request.h | 1 +\n> > > > > src/android/camera_capabilities.cpp | 11 +-\n> > > > > src/android/camera_capabilities.h | 2 +\n> > > > > src/android/camera_device.cpp | 926 ++++++++++++------\n> > > > > src/android/camera_device.h | 46 +-\n> > > > > src/android/camera_request.cpp | 94 +-\n> > > > > src/android/camera_request.h | 96 +-\n> > > > > src/android/camera_stream.cpp | 20 +-\n> > > > > src/android/camera_stream.h | 10 +-\n> > > > > src/android/jpeg/encoder.h | 2 +-\n> > > > > src/android/jpeg/encoder_jea.cpp | 2 +-\n> > > > > src/android/jpeg/encoder_jea.h | 2 +-\n> > > > > src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> > > > > src/android/jpeg/encoder_libjpeg.h | 2 +-\n> > > > > src/android/jpeg/post_processor_jpeg.cpp | 16 +-\n> > > > > src/android/jpeg/post_processor_jpeg.h | 2 +-\n> > > > > src/android/post_processor.h | 4 +-\n> > > > > src/android/yuv/post_processor_yuv.cpp | 2 +-\n> > > > > src/android/yuv/post_processor_yuv.h | 2 +-\n> > > > > src/libcamera/camera.cpp | 6 +\n> > > > > src/libcamera/pipeline_handler.cpp | 41 +\n> > > > > src/libcamera/request.cpp | 21 +\n> > > > > 25 files changed, 908 insertions(+), 408 deletions(-)\n> > > > >\n> > > > > --\n> > > > > 2.47.0.338.g60cca15819-goog\n> > > > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12848BDB13\n\tfor ;\n\tWed, 4 Dec 2024 14:10:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BC00660BE;\n\tWed, 4 Dec 2024 15:10:44 +0100 (CET)","from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com\n\t[IPv6:2a00:1450:4864:20::12c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB033660A9\n\tfor ;\n\tWed, 4 Dec 2024 15:10:40 +0100 (CET)","by mail-lf1-x12c.google.com with SMTP id\n\t2adb3069b0e04-53e203d77a9so220362e87.0\n\tfor ;\n\tWed, 04 Dec 2024 06:10:40 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"k8k/eo80\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1733321440; x=1733926240;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5TObIRTxvPIWJfnfMGBxCXMlR4au2e7LpEHIsHTvW1s=;\n\tb=k8k/eo803JZeH/7sYwcpmKTo5Xb6jlT9/BZtqhsDbRPc0LCOOqgdrtGEJL6dpcOJyc\n\tychEsj9D0oxygayaJ9GMUvZzKaXgN3KIQhDOSanHvmQHV8z6veJHL8SGCAPEYKmAMPA9\n\tq7DOT+ObsVB92rcv+I73i4pIb9K0uGan8yEYE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733321440; x=1733926240;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=5TObIRTxvPIWJfnfMGBxCXMlR4au2e7LpEHIsHTvW1s=;\n\tb=ks1obO8mIR7SaAb9NYFmAPmeqsDyeRaVAHgLBl3e0Ku3kAaJ+8p6pcWkpwl3xi29w9\n\t1VKPor4GmpqOGzxOx8JarWCmFBsWx+galQ0M8LG8U4Ey+o+dYGJCOjklqq6tnbuQAhVw\n\tIus5lUYFr2yr7MR7XNd+y20CscphrjTcsDPdmGTFakgl3UKo7VK2++OB1+xxv4hkCpH3\n\tEyey2BPUMsCIrh1oIWi8qrYzAgY5fOpjv9/x1pETvjz8FO52icz7kPJiG2xUslOESywa\n\tXAy4qBQHCgz0h3a8ykZ55ZL54eXAJvoQCpf0iqVnIrY6ZGmlS7dsXU74u463wHccjSS7\n\tymAA==","X-Gm-Message-State":"AOJu0Yxa8RpWVG6ZzhBkFR1H1y2Z9/3eqmvdtt3ChmByEQZogImANltn\n\taZFc7d31HgmoIxGI+SMjNJtJGJrqUuJ8QLDM9/yJF0MFx/k9ge2eDZxNYKyZhxKCJA7u96QYwj8\n\txwaKXM79bHnc7pZL9USbDAbS9TAbY2XddO0YUGk1yVuJsNg+STA==","X-Gm-Gg":"ASbGnctfQ87vszh4x4j/lfDERmbW0L7gClx5y/vIauX4KA4w69LzwVbRuZ96mktAG1r\n\tL8O6xiOv80AEzh8fUNsXRSThP/OyGW5J0GBRfsT4s2uTRxzKFqYJVboeUgqedLp2JsA==","X-Google-Smtp-Source":"AGHT+IFfIslKyqqeN6eKPJ83Xu6shAqNMVc4lYNZbemQKibBResBqkdAOHuaslA5qu2S3o2VGa3dMnddu/hv8RIn9rQ=","X-Received":"by 2002:a05:6512:2346:b0:53e:1ed4:c02f with SMTP id\n\t2adb3069b0e04-53e1ed4c2f7mr557256e87.25.1733321439947;\n\tWed, 04 Dec 2024 06:10:39 -0800 (PST)","MIME-Version":"1.0","References":"<20241127092632.3145984-1-chenghaoyang@chromium.org>\n\t\n\t\n\t\n\t","In-Reply-To":"","From":"Cheng-Hao Yang ","Date":"Wed, 4 Dec 2024 22:10:28 +0800","Message-ID":"","Subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32519,"web_url":"https://patchwork.libcamera.org/comment/32519/","msgid":"","date":"2024-12-04T14:37:06","subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Harvey\n\nOn Wed, Dec 04, 2024 at 10:10:28PM +0800, Cheng-Hao Yang wrote:\n> Hi Jacopo,\n>\n> On Wed, Dec 4, 2024 at 10:03 PM Jacopo Mondi\n> wrote:\n> >\n> > Hi Harvey\n> >\n> > On Wed, Dec 04, 2024 at 09:56:31PM +0800, Cheng-Hao Yang wrote:\n> > > Hi Jacopo,\n> > >\n> > > On Thu, Nov 28, 2024 at 9:00 PM Jacopo Mondi\n> > > wrote:\n> > > >\n> > > > A second run of CTS reported 7 failures\n> > > > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67365473\n> > > >\n> > > > The three additional ones were likely flukes then.\n> > > >\n> > > > On Thu, Nov 28, 2024 at 10:22:23AM +0100, Jacopo Mondi wrote:\n> > > > > Hi Harevy\n> > > > >\n> > > > > Please note that our CI system has detected 10 test failures on CTS\n> > > > > when testing this series:\n> > > > > https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67301704\n> > > > > https://yvain.ideasonboard.com/scheduler/job/84\n> > > > >\n> > > > > Our baseline with CTS is 7 test failures.\n> > > > >\n> > > > > We know CTS failures might be a fluke but I'm wondering if you have\n> > > > > run CTS on your systems and detected similar results or not.\n> > >\n> > > Yeah v2 seems to fail more CTS tests than the previous version.\n> > > In my last trial though, the tot I have on gitlab [1] passes as many\n> > > CTS tests as the origin/master does.\n> >\n> > I see the test not being run at all\n> > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/jobs/67693898\n> >\n> > I think this is intended as I don't think we allow forked repositories\n> > to run CTS on our test infrastructure (I guess??) ?\n> >\n> > What CTS run are you referring to ?\n>\n> I ran CTS (android-cts-13_r7) manually with my own soraka DUT.\n\nAh sorry, I didn't get it\n\n> We can also use the result on gitlab instead. Do I need to ask for\n> your help to run it everytime?\n>\n\nI don't think we can (and should) allow forks of camera/libcamera to\nrun tests on our physical infrastructure, only series collected from\npatchwork that touch src/android are run on our LAVA lab.\n\nI'll ask if it is possible or desirable to make singular execptions.\n\n\n> BR,\n> Harvey\n>\n> >\n> > >\n> > > I'll run CTS again before the next version of series.\n> > >\n> > > BR,\n> > > Harvey\n> > >\n> > > [1]: https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/commit/97b8c426656755b4a6e21cc8d8397ccd92395481\n> > >\n> > > > >\n> > > > > Thanks\n> > > > > j\n> > > > >\n> > > > >\n> > > > > On Wed, Nov 27, 2024 at 09:25:50AM +0000, Harvey Yang wrote:\n> > > > > > Hi folks,\n> > > > > >\n> > > > > > This series of patches adds a new signal metadataAvailable in\n> > > > > > libcamera::Camera, and supports partial result in Android adapter.\n> > > > > >\n> > > > > > Although Android allows a partial result to contain both buffers and\n> > > > > > metadata, we probably don't need such a feature. Splitting them into\n> > > > > > different partial results should fit both MediaTek's and Intel's\n> > > > > > requirements.\n> > > > > >\n> > > > > > This patch passed gitlab pipeline:\n> > > > > > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1317276\n> > > > > >\n> > > > > > There are still some discussion of the new signal in the previous patch,\n> > > > > > with Jacopo. I'll update the patch when we reach agreement.\n> > > > > >\n> > > > > > I understand that the last patch is a bit large, while I don't know how\n> > > > > > to split that furthermore. Let me know if there are some pieces that can\n> > > > > > be standalone patches.\n> > > > > >\n> > > > > > BR,\n> > > > > > Harvey\n> > > > > >\n> > > > > >\n> > > > > > Han-Lin Chen (2):\n> > > > > > libcamera: Camera: Add signals for completion of metadata as a partial\n> > > > > > result\n> > > > > > android: Add JpegExifMetadata to store tags setting into Exif\n> > > > > >\n> > > > > > Harvey Yang (7):\n> > > > > > android: Move StreamBuffer out of Camera3RequestDescriptor\n> > > > > > android: Set StreamBuffer::srcBuffer in\n> > > > > > CameraDevice::processCaptureRequest\n> > > > > > android: Migrate StreamBuffer::internalBuffer to\n> > > > > > Camera3RequestDescriptor\n> > > > > > android: Add CameraDevice::sendCaptureResult()\n> > > > > > android: Cleanup CAMERA3_MSG_ERROR_REQUEST\n> > > > > > android: Remove Camera3RequestDescriptor::streamsProcessMutex_\n> > > > > > android: Support partial results\n> > > > > >\n> > > > > > include/libcamera/camera.h | 1 +\n> > > > > > include/libcamera/internal/pipeline_handler.h | 1 +\n> > > > > > include/libcamera/internal/request.h | 4 +\n> > > > > > include/libcamera/request.h | 1 +\n> > > > > > src/android/camera_capabilities.cpp | 11 +-\n> > > > > > src/android/camera_capabilities.h | 2 +\n> > > > > > src/android/camera_device.cpp | 926 ++++++++++++------\n> > > > > > src/android/camera_device.h | 46 +-\n> > > > > > src/android/camera_request.cpp | 94 +-\n> > > > > > src/android/camera_request.h | 96 +-\n> > > > > > src/android/camera_stream.cpp | 20 +-\n> > > > > > src/android/camera_stream.h | 10 +-\n> > > > > > src/android/jpeg/encoder.h | 2 +-\n> > > > > > src/android/jpeg/encoder_jea.cpp | 2 +-\n> > > > > > src/android/jpeg/encoder_jea.h | 2 +-\n> > > > > > src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> > > > > > src/android/jpeg/encoder_libjpeg.h | 2 +-\n> > > > > > src/android/jpeg/post_processor_jpeg.cpp | 16 +-\n> > > > > > src/android/jpeg/post_processor_jpeg.h | 2 +-\n> > > > > > src/android/post_processor.h | 4 +-\n> > > > > > src/android/yuv/post_processor_yuv.cpp | 2 +-\n> > > > > > src/android/yuv/post_processor_yuv.h | 2 +-\n> > > > > > src/libcamera/camera.cpp | 6 +\n> > > > > > src/libcamera/pipeline_handler.cpp | 41 +\n> > > > > > src/libcamera/request.cpp | 21 +\n> > > > > > 25 files changed, 908 insertions(+), 408 deletions(-)\n> > > > > >\n> > > > > > --\n> > > > > > 2.47.0.338.g60cca15819-goog\n> > > > > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6847BDB13\n\tfor ;\n\tWed, 4 Dec 2024 14:37:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 860FD660C4;\n\tWed, 4 Dec 2024 15:37:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC962660BB\n\tfor ;\n\tWed, 4 Dec 2024 15:37:09 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D52A6D6;\n\tWed, 4 Dec 2024 15:36:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FO3attEk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733323001;\n\tbh=fMFvCFFZMBgcwOMi/gYaeZGDcErFdMQE/We55NTb66g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FO3attEkXc3TQ/Uj978jyWezopvRQjC2g/uESXS0PqkZN10AfHJbqSlzHMbGS4xq6\n\trQalbC6ok4NYTo9UoSvaEAs+yuejnIzlFg+iNj/xtBokKwc/DHcjnF3tyLRNXcknsX\n\tHfecbRldIhT6pN+607qOHD0iFuHacXAvzcgB99j8=","Date":"Wed, 4 Dec 2024 15:37:06 +0100","From":"Jacopo Mondi ","To":"Cheng-Hao Yang ","Cc":"Jacopo Mondi , \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 0/8] Signal metadataAvailable and Android partial\n\tresult","Message-ID":"","References":"<20241127092632.3145984-1-chenghaoyang@chromium.org>\n\t\n\t\n\t\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]