[{"id":34,"web_url":"https://patchwork.libcamera.org/comment/34/","msgid":"","date":"2018-12-10T13:41:53","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add initial logger\n\tsupport","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nI pushed the master branch with my gitlab runner on top and it failed\nthe build tests I'm afraid :(\n\nFailure at :\n\n\thttps://gitlab.com/libcamera/libcamera/-/jobs/132294793\n\n[1/9] Compiling C++ object\n'src/libcamera/src@libcamera@@camera@sha/log.cpp.o'.\nFAILED: src/libcamera/src@libcamera@@camera@sha/log.cpp.o\nc++ -Isrc/libcamera/src@libcamera@@camera@sha -Isrc/libcamera\n-I../src/libcamera -Iinclude -I../include -I../src/libcamera/include\n-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall\n-Winvalid-pch -Wnon-virtual-dtor -O0 -g -Wall -Wextra -Werror\n-Wno-unused-parameter -fPIC -MD -MQ\n'src/libcamera/src@libcamera@@camera@sha/log.cpp.o' -MF\n'src/libcamera/src@libcamera@@camera@sha/log.cpp.o.d' -o\n'src/libcamera/src@libcamera@@camera@sha/log.cpp.o' -c\n../src/libcamera/log.cpp\n../src/libcamera/log.cpp: In constructor\n'libcamera::LogMessage::LogMessage(const char*, unsigned int,\nlibcamera::LogSeverity)':\n../src/libcamera/log.cpp:69:39: error: 'basename' was not declared in\nthis scope\n msgStream << \" \" << basename(fileName) << \":\" << line << \" \";\n ^\n--\nRegards\n\nKieran\n\n\nOn 04/12/2018 22:11, Laurent Pinchart wrote:\n> Hello,\n> \n> This patch series adds an initial logger to the library. It's so far\n> very dumb and is lacking many features, so volunteers are needed to\n> extend it :-)\n> \n> Laurent Pinchart (3):\n> Overhaul the directory structure\n> libcamera: Add initial logger\n> libcamera: Use the logger instead of cout\n> \n> include/libcamera/libcamera.h | 4 ++\n> lib/meson.build | 6 ---\n> meson.build | 4 +-\n> src/libcamera/include/log.h | 38 ++++++++++++++++\n> src/libcamera/include/utils.h | 12 +++++\n> src/libcamera/log.cpp | 81 +++++++++++++++++++++++++++++++++\n> {lib => src/libcamera}/main.cpp | 10 ++--\n> src/libcamera/meson.build | 14 ++++++\n> src/meson.build | 1 +\n> test/init.cpp | 2 +-\n> test/meson.build | 2 +-\n> 11 files changed, 160 insertions(+), 14 deletions(-)\n> delete mode 100644 lib/meson.build\n> create mode 100644 src/libcamera/include/log.h\n> create mode 100644 src/libcamera/include/utils.h\n> create mode 100644 src/libcamera/log.cpp\n> rename {lib => src/libcamera}/main.cpp (68%)\n> create mode 100644 src/libcamera/meson.build\n> create mode 100644 src/meson.build\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81DB560B0F\n\tfor ;\n\tMon, 10 Dec 2018 14:41:57 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68828549;\n\tMon, 10 Dec 2018 14:41:56 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544449316;\n\tbh=C+Iiw45J+WbU23gO9rSip7EGFE5/zohAD9lA+5O71h0=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=cdmMskfx6720H2ZALwF7oVb9FHsdJrtU35nJqc3PjImraokvH8egHsoCRms+yszUd\n\tGmPFGE8HP6Eyv6CJBCIFeEjzhi6LGJFL751lf5HXnCfLQVEoUpMMi8DcIwGfWlnagC\n\tIv6CWDXlh10CdgP15dx54ZTLt6nYY4QTAj7LCKYw=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20181204221123.571-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\txsFNBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABzTBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT7CwYAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8tbOwU0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAHCwWUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 10 Dec 2018 13:41:53 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20181204221123.571-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add initial logger\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 10 Dec 2018 13:41:57 -0000"}},{"id":35,"web_url":"https://patchwork.libcamera.org/comment/35/","msgid":"<4338156.pW8CNAMT9F@avalon>","date":"2018-12-10T14:48:32","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add initial logger\n\tsupport","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Monday, 10 December 2018 15:41:53 EET Kieran Bingham wrote:\n> Hi Laurent,\n> \n> I pushed the master branch with my gitlab runner on top and it failed\n> the build tests I'm afraid :(\n> \n> Failure at :\n> \n> \thttps://gitlab.com/libcamera/libcamera/-/jobs/132294793\n> \n> [1/9] Compiling C++ object\n> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o'.\n> FAILED: src/libcamera/src@libcamera@@camera@sha/log.cpp.o\n> c++ -Isrc/libcamera/src@libcamera@@camera@sha -Isrc/libcamera\n> -I../src/libcamera -Iinclude -I../include -I../src/libcamera/include\n> -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall\n> -Winvalid-pch -Wnon-virtual-dtor -O0 -g -Wall -Wextra -Werror\n> -Wno-unused-parameter -fPIC -MD -MQ\n> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o' -MF\n> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o.d' -o\n> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o' -c\n> ../src/libcamera/log.cpp\n> ../src/libcamera/log.cpp: In constructor\n> 'libcamera::LogMessage::LogMessage(const char*, unsigned int,\n> libcamera::LogSeverity)':\n> ../src/libcamera/log.cpp:69:39: error: 'basename' was not declared in\n> this scope\n> msgStream << \" \" << basename(fileName) << \":\" << line << \" \";\n\nWhich libc was that compiled with ? At this point I don't think we should \nsupport other C libraries than glibc. We'll fix it eventually of course.\n\n> On 04/12/2018 22:11, Laurent Pinchart wrote:\n> > Hello,\n> > \n> > This patch series adds an initial logger to the library. It's so far\n> > very dumb and is lacking many features, so volunteers are needed to\n> > extend it :-)\n> > \n> > Laurent Pinchart (3):\n> > Overhaul the directory structure\n> > libcamera: Add initial logger\n> > libcamera: Use the logger instead of cout\n> > \n> > include/libcamera/libcamera.h | 4 ++\n> > lib/meson.build | 6 ---\n> > meson.build | 4 +-\n> > src/libcamera/include/log.h | 38 ++++++++++++++++\n> > src/libcamera/include/utils.h | 12 +++++\n> > src/libcamera/log.cpp | 81 +++++++++++++++++++++++++++++++++\n> > {lib => src/libcamera}/main.cpp | 10 ++--\n> > src/libcamera/meson.build | 14 ++++++\n> > src/meson.build | 1 +\n> > test/init.cpp | 2 +-\n> > test/meson.build | 2 +-\n> > 11 files changed, 160 insertions(+), 14 deletions(-)\n> > delete mode 100644 lib/meson.build\n> > create mode 100644 src/libcamera/include/log.h\n> > create mode 100644 src/libcamera/include/utils.h\n> > create mode 100644 src/libcamera/log.cpp\n> > rename {lib => src/libcamera}/main.cpp (68%)\n> > create mode 100644 src/libcamera/meson.build\n> > create mode 100644 src/meson.build","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D2AA60B0F\n\tfor ;\n\tMon, 10 Dec 2018 15:47:51 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 819BD549;\n\tMon, 10 Dec 2018 15:47:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544453270;\n\tbh=1HaYVqOc0YLyr376sS6XwfmxSL8ODd3AU0eeFh4Nzkc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oMyoxqOjXP9vFVCkTs9kaJyes69zjFQ37ILAcTv2jUrv3fD42fk4sqnhIXG+XeWcB\n\tvONBRhLE5iquZJz0wLbo9iY1oXseyXbSGmJvf0aCwNVpS/j8QQ4pV1L7+3I7E97ACu\n\t9DkUVcntuW9GaB9Q9NzJkXN6plVi86TTNKlBTPfo=","From":"Laurent Pinchart ","To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Date":"Mon, 10 Dec 2018 16:48:32 +0200","Message-ID":"<4338156.pW8CNAMT9F@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"","References":"<20181204221123.571-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add initial logger\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 10 Dec 2018 14:47:51 -0000"}},{"id":36,"web_url":"https://patchwork.libcamera.org/comment/36/","msgid":"<0392a529-8e8c-5142-8f8f-e93899f59c19@ideasonboard.com>","date":"2018-12-10T15:10:42","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add initial logger\n\tsupport","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 10/12/2018 14:48, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Monday, 10 December 2018 15:41:53 EET Kieran Bingham wrote:\n>> Hi Laurent,\n>>\n>> I pushed the master branch with my gitlab runner on top and it failed\n>> the build tests I'm afraid :(\n>>\n>> Failure at :\n>>\n>> \thttps://gitlab.com/libcamera/libcamera/-/jobs/132294793\n>>\n>> [1/9] Compiling C++ object\n>> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o'.\n>> FAILED: src/libcamera/src@libcamera@@camera@sha/log.cpp.o\n>> c++ -Isrc/libcamera/src@libcamera@@camera@sha -Isrc/libcamera\n>> -I../src/libcamera -Iinclude -I../include -I../src/libcamera/include\n>> -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall\n>> -Winvalid-pch -Wnon-virtual-dtor -O0 -g -Wall -Wextra -Werror\n>> -Wno-unused-parameter -fPIC -MD -MQ\n>> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o' -MF\n>> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o.d' -o\n>> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o' -c\n>> ../src/libcamera/log.cpp\n>> ../src/libcamera/log.cpp: In constructor\n>> 'libcamera::LogMessage::LogMessage(const char*, unsigned int,\n>> libcamera::LogSeverity)':\n>> ../src/libcamera/log.cpp:69:39: error: 'basename' was not declared in\n>> this scope\n>> msgStream << \" \" << basename(fileName) << \":\" << line << \" \";\n> \n> Which libc was that compiled with ? At this point I don't think we should \n> support other C libraries than glibc. We'll fix it eventually of course.\n\nThis is against a musl libc on alpine-linux.\n\nI agree - this isn't really a priority for us right now - but perhaps\nhighlights that at some point we should consider what toolchains the\nlibrary will be built with.\n\nI expect we should also try compiling with clang/LLVM when we get our\nautomated test infrastructure set up.\n\n--\nKieran\n\n\n> \n>> On 04/12/2018 22:11, Laurent Pinchart wrote:\n>>> Hello,\n>>>\n>>> This patch series adds an initial logger to the library. It's so far\n>>> very dumb and is lacking many features, so volunteers are needed to\n>>> extend it :-)\n>>>\n>>> Laurent Pinchart (3):\n>>> Overhaul the directory structure\n>>> libcamera: Add initial logger\n>>> libcamera: Use the logger instead of cout\n>>> \n>>> include/libcamera/libcamera.h | 4 ++\n>>> lib/meson.build | 6 ---\n>>> meson.build | 4 +-\n>>> src/libcamera/include/log.h | 38 ++++++++++++++++\n>>> src/libcamera/include/utils.h | 12 +++++\n>>> src/libcamera/log.cpp | 81 +++++++++++++++++++++++++++++++++\n>>> {lib => src/libcamera}/main.cpp | 10 ++--\n>>> src/libcamera/meson.build | 14 ++++++\n>>> src/meson.build | 1 +\n>>> test/init.cpp | 2 +-\n>>> test/meson.build | 2 +-\n>>> 11 files changed, 160 insertions(+), 14 deletions(-)\n>>> delete mode 100644 lib/meson.build\n>>> create mode 100644 src/libcamera/include/log.h\n>>> create mode 100644 src/libcamera/include/utils.h\n>>> create mode 100644 src/libcamera/log.cpp\n>>> rename {lib => src/libcamera}/main.cpp (68%)\n>>> create mode 100644 src/libcamera/meson.build\n>>> create mode 100644 src/meson.build\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA7B760B0F\n\tfor ;\n\tMon, 10 Dec 2018 16:10:45 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CCA554B;\n\tMon, 10 Dec 2018 16:10:45 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544454645;\n\tbh=a0P4SUg0FiZOoEQFEDiGPBC/5EYIcVEC+dYolAvWkks=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=lgogEKA5cSed0j7pKwSCzQa3SV+og+kM40GUHAiYefRvPqFcXFWaVfuDjKWhltgZh\n\tzG3MDS53pKa1K3bxUN9L3wkTyGr/MfjLmbuTGtjvyxlO7xoC8K0t8mTcchkosn3m03\n\tcgNa7gQ7Ca/mBWcYI56AUrhjebTk/bP3WJF0Dp6Y=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20181204221123.571-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<4338156.pW8CNAMT9F@avalon>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\txsFNBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABzTBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT7CwYAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8tbOwU0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAHCwWUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<0392a529-8e8c-5142-8f8f-e93899f59c19@ideasonboard.com>","Date":"Mon, 10 Dec 2018 15:10:42 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<4338156.pW8CNAMT9F@avalon>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add initial logger\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 10 Dec 2018 15:10:46 -0000"}},{"id":37,"web_url":"https://patchwork.libcamera.org/comment/37/","msgid":"<2071501.cBFSPVPX8y@avalon>","date":"2018-12-10T20:02:05","subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add initial logger\n\tsupport","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Monday, 10 December 2018 17:10:42 EET Kieran Bingham wrote:\n> On 10/12/2018 14:48, Laurent Pinchart wrote:\n> > On Monday, 10 December 2018 15:41:53 EET Kieran Bingham wrote:\n> >> Hi Laurent,\n> >> \n> >> I pushed the master branch with my gitlab runner on top and it failed\n> >> the build tests I'm afraid :(\n> >> \n> >> Failure at :\n> >> \thttps://gitlab.com/libcamera/libcamera/-/jobs/132294793\n> >> \n> >> [1/9] Compiling C++ object\n> >> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o'.\n> >> FAILED: src/libcamera/src@libcamera@@camera@sha/log.cpp.o\n> >> c++ -Isrc/libcamera/src@libcamera@@camera@sha -Isrc/libcamera\n> >> -I../src/libcamera -Iinclude -I../include -I../src/libcamera/include\n> >> -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall\n> >> -Winvalid-pch -Wnon-virtual-dtor -O0 -g -Wall -Wextra -Werror\n> >> -Wno-unused-parameter -fPIC -MD -MQ\n> >> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o' -MF\n> >> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o.d' -o\n> >> 'src/libcamera/src@libcamera@@camera@sha/log.cpp.o' -c\n> >> ../src/libcamera/log.cpp\n> >> ../src/libcamera/log.cpp: In constructor\n> >> 'libcamera::LogMessage::LogMessage(const char*, unsigned int,\n> >> libcamera::LogSeverity)':\n> >> ../src/libcamera/log.cpp:69:39: error: 'basename' was not declared in\n> >> this scope\n> >> \n> >> msgStream << \" \" << basename(fileName) << \":\" << line << \" \";\n> > \n> > Which libc was that compiled with ? At this point I don't think we should\n> > support other C libraries than glibc. We'll fix it eventually of course.\n> \n> This is against a musl libc on alpine-linux.\n> \n> I agree - this isn't really a priority for us right now - but perhaps\n> highlights that at some point we should consider what toolchains the\n> library will be built with.\n\nAbsolutely agreed. I think catering for the needs of multiple lib C \nimplementations now would hinder development, but in the not too distant \nfuture we'll have to handle this task.\n\n> I expect we should also try compiling with clang/LLVM when we get our\n> automated test infrastructure set up.\n\nI agree as well, and I think this could be addressed sooner than later.\n\n> >> On 04/12/2018 22:11, Laurent Pinchart wrote:\n> >>> Hello,\n> >>> \n> >>> This patch series adds an initial logger to the library. It's so far\n> >>> very dumb and is lacking many features, so volunteers are needed to\n> >>> extend it :-)\n> >>> \n> >>> Laurent Pinchart (3):\n> >>> Overhaul the directory structure\n> >>> libcamera: Add initial logger\n> >>> libcamera: Use the logger instead of cout\n> >>> \n> >>> include/libcamera/libcamera.h | 4 ++\n> >>> lib/meson.build | 6 ---\n> >>> meson.build | 4 +-\n> >>> src/libcamera/include/log.h | 38 ++++++++++++++++\n> >>> src/libcamera/include/utils.h | 12 +++++\n> >>> src/libcamera/log.cpp | 81 +++++++++++++++++++++++++++++++++\n> >>> {lib => src/libcamera}/main.cpp | 10 ++--\n> >>> src/libcamera/meson.build | 14 ++++++\n> >>> src/meson.build | 1 +\n> >>> test/init.cpp | 2 +-\n> >>> test/meson.build | 2 +-\n> >>> 11 files changed, 160 insertions(+), 14 deletions(-)\n> >>> delete mode 100644 lib/meson.build\n> >>> create mode 100644 src/libcamera/include/log.h\n> >>> create mode 100644 src/libcamera/include/utils.h\n> >>> create mode 100644 src/libcamera/log.cpp\n> >>> rename {lib => src/libcamera}/main.cpp (68%)\n> >>> create mode 100644 src/libcamera/meson.build\n> >>> create mode 100644 src/meson.build","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D04DC60B0F\n\tfor ;\n\tMon, 10 Dec 2018 21:01:24 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ECE2454B;\n\tMon, 10 Dec 2018 21:01:23 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1544472084;\n\tbh=rWAsxi77TYVNobYxt8JASLHfK0WDUNhu46+3uQASLvQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MYcAbVNnSriMo0nMD/bWXMVOCH6E9Zv943aUAeMgHpJ1vbvslReRB4IpmtJT8y7Tp\n\twMZ10QdjFHsh48gqlZkPKYnA6tv1xNggwI2CtzHWQQ0Ob4EbnR9MDnK6MIHsZcdy8J\n\tm3YC19qMLvLKdE+aro+8bcLxrSAKgAT8cAjOIqwM=","From":"Laurent Pinchart ","To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Date":"Mon, 10 Dec 2018 22:02:05 +0200","Message-ID":"<2071501.cBFSPVPX8y@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<0392a529-8e8c-5142-8f8f-e93899f59c19@ideasonboard.com>","References":"<20181204221123.571-1-laurent.pinchart@ideasonboard.com>\n\t<4338156.pW8CNAMT9F@avalon>\n\t<0392a529-8e8c-5142-8f8f-e93899f59c19@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH 0/3] libcamera: Add initial logger\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 10 Dec 2018 20:01:25 -0000"}}]