[{"id":32257,"web_url":"https://patchwork.libcamera.org/comment/32257/","msgid":"","date":"2024-11-19T09:21:07","subject":"Re: [PATCH v2 0/4] Add support for Sony IMX327 and IMX462 sensors","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Geoffrey\n\nThanks for the update!\n\nOn Mon, 18 Nov 2024 at 22:53, Geoffrey Van Landeghem\n wrote:\n>\n> Hi,\n> This patch-set comes as part of an ongoing effort to support Sony IMX327 and IMX462 sensors better in the linux kernel.\n> For the kernel, following changes are proposed upstream:\n>\n> https://lore.kernel.org/linux-media/20241114-media-imx290-imx462-v1-0-c538a2e24786@raspberrypi.com/\n>\n> Also discussed here:\n> https://github.com/raspberrypi/linux/pull/5859\n>\n> After those changes have been applied, the 2 Starvis sensors will no longer be identied by libcamera as a IMX290 and therefore require this patch-set to work correctly.\n>\n> Thanks,\n> Geoffrey\n>\n> Geoffrey Van Landeghem (4):\n> libcamera: libipa: camera_sensor: Provide CameraSensorHelper and\n> CameraSensorProperties for the Sony IMX462 image sensor.\n> ipa: rpi: cam_helper: Add Sony IMX327\n> ipa: raspberrypi: Add tuning file for IMX462 sensor\n> ipa: raspberrypi: Add tuning file for IMX327 sensor\n>\n> src/ipa/libipa/camera_sensor_helper.cpp | 5 +\n> src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 2 +\n> src/ipa/rpi/vc4/data/imx327.json | 215 ++++++++++++++++++\n> src/ipa/rpi/vc4/data/imx462.json | 215 ++++++++++++++++++\n> src/ipa/rpi/vc4/data/meson.build | 2 +\n> .../sensor/camera_sensor_properties.cpp | 4 +\n> 6 files changed, 443 insertions(+)\n> create mode 100644 src/ipa/rpi/vc4/data/imx327.json\n> create mode 100644 src/ipa/rpi/vc4/data/imx462.json\n>\n> --\n> 2.43.0\n>\n\nI guess I'm a bit curious just how similar these sensors are the the\n290, but I'm fine with this support, so perhaps I can add\n\nReviewed-by: David Plowman \n\nto all the patches in this set.\n\nThanks!\nDavid","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 833BFC32F1\n\tfor ;\n\tTue, 19 Nov 2024 09:21:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 975F465EE0;\n\tTue, 19 Nov 2024 10:21:21 +0100 (CET)","from mail-ua1-x930.google.com (mail-ua1-x930.google.com\n\t[IPv6:2607:f8b0:4864:20::930])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3F3665ED8\n\tfor ;\n\tTue, 19 Nov 2024 10:21:19 +0100 (CET)","by mail-ua1-x930.google.com with SMTP id\n\ta1e0cc1a2514c-85700088a4dso984728241.1\n\tfor ;\n\tTue, 19 Nov 2024 01:21:19 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"S0Oy1C+e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1732008078; x=1732612878;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=vZGiq5jQELqqLlscNs1+Xp0IRw+84+8w1dmMF89j6Fc=;\n\tb=S0Oy1C+eem1BQ3bawQTjdCdcmdPybD3mhMmZQRGd6+7h8UMGnJkE6H3DG+Vt4jM2D9\n\tm28zFVSoDANfBE4xGeQfy2OJogiQxMRc2vTQvnR2KpPuRS1ZGrW7jTXlxdsp7TpEYsLV\n\txTXuuBu4M7jaJQNVLCxyCPqp5krO/f+dNzEuG1+/ZgcKfChfVotf2SoR2/97rb4TlDAv\n\t0C/1OWhDDcDe5UcwDKRVsD+zi7d+5+U4m2LTwbtoO9c/9fOVbNa56pVf16NwwMuDYxyt\n\t8irQujwJkr5iZaEjwHQ5QVPULYQuT7UZhZIlcI9fA94NxJyKLaJCS60nBdqkYj4hKsCo\n\tl+MQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732008078; x=1732612878;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=vZGiq5jQELqqLlscNs1+Xp0IRw+84+8w1dmMF89j6Fc=;\n\tb=P8c0lUrt4prJeawbNaOYg/b59mM221Sqoxiwg3cR8R2XLxrJas90CXjvd+ucFJ3Jkb\n\tVxHqvasUDtSREqFqaqISnGMakAh3dqXa+q0nYIKPwdjUv4FqfVPII4MORGhV7fzmjoOF\n\tQ38M2piLNZs+NdYGqIpkb3x7zgQv8F5b8QuPd6WM/OskTgEqtnTaar4MrErZlMiqD13f\n\tfr1q71oBR8bL84tqB6wgi+Epo8dXY5JsVjQxEeEM+oa3XW+78YBKAW6ehH3VAfftp/Pa\n\tfhxQi9g97QS22UE3AqvhtQfs0GNZQ3H1rNeyxqq6sx0AAxBhj8Be7bEWhhGEeBmyL9lq\n\t91bQ==","X-Gm-Message-State":"AOJu0YzdYgFTwNaZ2rE6VDRTGX5wNZJaHAWqT6JA9K0GUQPZvl5eLrM1\n\tp8NzLJLYFrW6lCuHBDKL9SZh02NUD+//7mKqK/k7a3BaWQncFiJJuhidLfzeMBYPtD0nDH/lZXg\n\tpI5v7XNJ6CIrhDblkT0gEKo7rvs2srUDe91PrDQ==","X-Google-Smtp-Source":"AGHT+IEpaMNHPAKzBi+VItiygKs9VnoAVRs7D2+bhmz9RrbrcL8/U2zxOK84ApOg+/tlGtllvWWiriW6YcptThSm8Js=","X-Received":"by 2002:a05:6102:390c:b0:4a4:79cf:be83 with SMTP id\n\tada2fe7eead31-4ad62af4f13mr13735054137.10.1732008078558;\n\tTue, 19 Nov 2024 01:21:18 -0800 (PST)","MIME-Version":"1.0","References":"<20241118225310.446706-1-geoffrey.vl@gmail.com>","In-Reply-To":"<20241118225310.446706-1-geoffrey.vl@gmail.com>","From":"David Plowman ","Date":"Tue, 19 Nov 2024 09:21:07 +0000","Message-ID":"","Subject":"Re: [PATCH v2 0/4] Add support for Sony IMX327 and IMX462 sensors","To":"Geoffrey Van Landeghem ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]