{"id":21955,"url":"https://patchwork.libcamera.org/api/covers/21955/?format=json","web_url":"https://patchwork.libcamera.org/cover/21955/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118150528.1856797-1-stefan.klug@ideasonboard.com>","date":"2024-11-18T15:05:03","name":"[0/4] Move Matrix class from libipa to libcamera","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/21955/mbox/","series":[{"id":4797,"url":"https://patchwork.libcamera.org/api/series/4797/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4797","date":"2024-11-18T15:05:03","name":"Move Matrix class from libipa to libcamera","version":1,"mbox":"https://patchwork.libcamera.org/series/4797/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21955/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2C5BC32DD\n\tfor ;\n\tMon, 18 Nov 2024 15:05:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB25B658E2;\n\tMon, 18 Nov 2024 16:05:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1CE760532\n\tfor ;\n\tMon, 18 Nov 2024 16:05:42 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4424:4869:bb88:5c61])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F265F316;\n\tMon, 18 Nov 2024 16:05:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JPTo17fc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731942326;\n\tbh=K8hRoKT1mLqyoO+pBpbTzIaaNuAt0tHXYVs/wrfM+/E=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=JPTo17fcDxmp1Bn7zksx6ly6fPMiLB+w0kdzwww0yw3SZ9bZ9pMviaUE+SahcnSzI\n\tnrGH52jrw5WxKLm3VgvMt9cHw404xQ3XBovzKSSxl1RwcGZK1SiZciSvWAPqJgl/6P\n\tTPAI64QT5+9YBpiNqC6mn0J4f3R4+hXHxiG32gds=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 0/4] Move Matrix class from libipa to libcamera","Date":"Mon, 18 Nov 2024 16:05:03 +0100","Message-ID":"<20241118150528.1856797-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi all,\n\nMy upcoming dewarper series implements parametric lens dewarping inside\nthe rkisp1 pipeline. That code makes use of the Matrix class but lives\noutside of the IPA. I suspect there will be more cases, where a matrix\nis of good use inside libcamera.\n\nThis series movies the Matrix into libacmera/internal. As that gets\nlinked to the IPAs anyways, there are no negative effects for the IPAs.\n\nThis was tested on an imx8mp, but only compile tested for the\nRaspberryPi.\n\nRegards,\nStefan\n\nStefan Klug (4):\n libcamera: Copy matrix class from libipa to libcamera\n libcamera: Enable and use matrix implementation from\n libcamera/internal\n libcamera: matrix: Use Span instead of vector for construction\n libipa: Remove Matrix class from libipa\n\n .../libcamera/internal}/matrix.h | 23 ++++----\n include/libcamera/internal/meson.build | 1 +\n src/ipa/libipa/meson.build | 2 -\n src/ipa/libipa/vector.h | 3 +-\n src/ipa/rkisp1/algorithms/ccm.h | 3 +-\n src/ipa/rkisp1/ipa_context.h | 2 +-\n src/ipa/rpi/controller/rpi/ccm.cpp | 56 +++++--------------\n src/ipa/rpi/controller/rpi/ccm.h | 35 +-----------\n src/{ipa/libipa => libcamera}/matrix.cpp | 18 ++++--\n src/libcamera/meson.build | 1 +\n 10 files changed, 48 insertions(+), 96 deletions(-)\n rename {src/ipa/libipa => include/libcamera/internal}/matrix.h (89%)\n rename src/{ipa/libipa => libcamera}/matrix.cpp (89%)"}