[{"id":32214,"web_url":"https://patchwork.libcamera.org/comment/32214/","msgid":"<173192895411.576258.11887900307272109634@ping.linuxembedded.co.uk>","date":"2024-11-18T11:22:34","subject":"Re: [RFC PATCH 00/11] Improve linear algebra helpers in libipa","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-11-17 22:17:01)\n> Hello,\n> \n> This patch series tries to simplify IPA linear algebra calculations by\n> improving the Vector class API. The first 9 patches improves the Vector\n> class, and the last two patches showcase the improvements this can bring\n> in the rkisp1 AWB algorithm.\n> \n> I'm relatively happy with the result. The only part I'm not sure about\n> is the introduction of the RGB type alias.\n\nPersonally I like it. I like not repeating three identical lines for\n3 types that always follow each other around.\n\n--\nKieran\n\n> \n> Laurent Pinchart (11):\n> ipa: libipa: vector: Add mutable x(), y() and z() accessors\n> ipa: libipa: vector: Add r(), g() and b() accessors\n> ipa: libipa: vector: Add copy constructor and assignment operator\n> ipa: libipa: vector: Rename the dot product operator*() to dot()\n> ipa: libipa: vector: Generalize arithmetic operators\n> ipa: libipa: vector: Add missing binary arithemtic operators\n> ipa: libipa: vector: Add compound assignment operators\n> ipa: libipa: vector: Add element-wise min() and max() functions\n> ipa: libipa: vector: Add sum() and normalize() functions\n> ipa: rkisp1: awb: Use RGB class to store colour gains\n> ipa: rkisp1: awb: Replace manual calculations with Vector and Matrix\n> \n> src/ipa/libipa/vector.cpp | 261 ++++++++++++++++++++++++++----\n> src/ipa/libipa/vector.h | 257 +++++++++++++++++++++++------\n> src/ipa/rkisp1/algorithms/awb.cpp | 134 +++++++--------\n> src/ipa/rkisp1/algorithms/awb.h | 2 +-\n> src/ipa/rkisp1/ipa_context.cpp | 31 +---\n> src/ipa/rkisp1/ipa_context.h | 20 +--\n> 6 files changed, 505 insertions(+), 200 deletions(-)\n> \n> \n> base-commit: 5c71df927ddaaa01204bff1e647c9d2bf653d95f\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD4ECC32DD\n\tfor ;\n\tMon, 18 Nov 2024 11:22:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 80E45658C4;\n\tMon, 18 Nov 2024 12:22:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E664C60532\n\tfor ;\n\tMon, 18 Nov 2024 12:22:36 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 599455B3;\n\tMon, 18 Nov 2024 12:22:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CSfqfv2H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731928940;\n\tbh=sJg6uVMQKrNB0WpLkKemb0CxAF1tqy0l2slH0o4Dikc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=CSfqfv2HJGAcN9V39QoMCubCAGuOabYFhnZMMfTKHPAaTXQSALHeECALYAtx8aPvn\n\t7DZwnUsvcIiDffSj5FGBdJRkOcUnqaD9mK8QNDxCLxIJ6kopq4ral/K/vAd4KsSefE\n\tFzhW+7Zl30WoXZxHB1V/FlHOtlQmNzKs5SD2Z3qM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241117221712.29616-1-laurent.pinchart@ideasonboard.com>","References":"<20241117221712.29616-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [RFC PATCH 00/11] Improve linear algebra helpers in libipa","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 18 Nov 2024 11:22:34 +0000","Message-ID":"<173192895411.576258.11887900307272109634@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]