[{"id":32136,"web_url":"https://patchwork.libcamera.org/comment/32136/","msgid":"<173149202044.1543188.5517436564757172061@ping.linuxembedded.co.uk>","date":"2024-11-13T10:00:20","subject":"Re: [PATCH v2 0/2] Add DmaSyncer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Harvey Yang (2024-11-13 05:54:31)\n> Hi folks,\n> \n> This series of patches follows the discussion with Kieran in patch [1],\n\nAha, ok so I was a bit confused here. I didn't recall suggesting anytime\nwe should make this into an object, but what you mean is that it follows\n\"Roberts\" implementation - not 'Mine'.\n\nI don't mind a helper object here ... Just clarifying (to my self) that\nthis was not produced from something I said ;-)\n\nMoving syncBufferForCPU to a helper in dma_buf_allocator.h does indeed\nseem like a good idea to promote re-usabilty though! So lets follow the\nreviews on the patches ;-)\n\n--\nKieran\n\n> which adds a helper function and a helper class to make synchronizing\n> DMA buffers easier.\n> \n> The second patch updates debayer_cpu to utilize the new helper class.\n> The following mtkisp7 pipeline handler will also depend on the helper\n> class.\n> \n> I put the function in DmaBufAllocator and the helper class in the same\n> file for now. Let me know if I should put them elsewhere.\n> \n> This passes gitlab pipeline:\n> https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1309296\n> \n> v2:\n> - Fixed ioctl return value check when being interrupted.\n> \n> BR,\n> Harvey\n> \n> [1]: [PATCH v4] libcamera: debayer_cpu: Sync DMABUFs\n> \n> \n> Harvey Yang (2):\n> DmaBufAllocator: Add Dma Buffer synchronization function & helper\n> class\n> debayer_cpu: Replace syncing DMABUFs with DmaSyncer\n> \n> .../libcamera/internal/dma_buf_allocator.h | 33 +++++++\n> src/libcamera/dma_buf_allocator.cpp | 90 +++++++++++++++++++\n> src/libcamera/software_isp/debayer_cpu.cpp | 29 ++----\n> 3 files changed, 131 insertions(+), 21 deletions(-)\n> \n> -- \n> 2.47.0.277.g8800431eea-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09C08BE173\n\tfor ;\n\tWed, 13 Nov 2024 10:00:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B7BD65802;\n\tWed, 13 Nov 2024 11:00:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A0DC605B5\n\tfor ;\n\tWed, 13 Nov 2024 11:00:24 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6F381306;\n\tWed, 13 Nov 2024 11:00:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F4TUx1W8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731492010;\n\tbh=cGil7l/ZLp0hJKPNJy4TFraKhO1oR8cl5EOTMiLkjs8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=F4TUx1W8TxJjx+TvTznaVXjsyraEJ00DO7RINIy8PbXkdQMiRwfB2SkwEHE5x0NRl\n\th2tSGsohinXhucqSw6Z05v8RpjZ/fVhRlpvG76/BZs13DacaLRDqZTmZ3F89yFlEwA\n\to132rxuOdiKRzMlcecaxqQA1BFcONR1jbkBeJiDQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241113055524.3099340-1-chenghaoyang@chromium.org>","References":"<20241113055524.3099340-1-chenghaoyang@chromium.org>","Subject":"Re: [PATCH v2 0/2] Add DmaSyncer","From":"Kieran Bingham ","Cc":"Harvey Yang ","To":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 13 Nov 2024 10:00:20 +0000","Message-ID":"<173149202044.1543188.5517436564757172061@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32137,"web_url":"https://patchwork.libcamera.org/comment/32137/","msgid":"","date":"2024-11-13T10:10:22","subject":"Re: [PATCH v2 0/2] Add DmaSyncer","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Kieran,\n\nOn Wed, Nov 13, 2024 at 6:00 PM Kieran Bingham\n wrote:\n>\n> Quoting Harvey Yang (2024-11-13 05:54:31)\n> > Hi folks,\n> >\n> > This series of patches follows the discussion with Kieran in patch [1],\n>\n> Aha, ok so I was a bit confused here. I didn't recall suggesting anytime\n> we should make this into an object, but what you mean is that it follows\n> \"Roberts\" implementation - not 'Mine'.\n>\n> I don't mind a helper object here ... Just clarifying (to my self) that\n> this was not produced from something I said ;-)\n\nAh I didn't mean that the current version is the conclusion of our\ndiscussion or your suggestion. Just saying that there's such a\ndiscussion, and this series is what I think a first step to work on with.\n\nSorry if the message looks to mean otherwise :)\n\nBR,\nHarvey\n\n>\n> Moving syncBufferForCPU to a helper in dma_buf_allocator.h does indeed\n> seem like a good idea to promote re-usabilty though! So lets follow the\n> reviews on the patches ;-)\n>\n> --\n> Kieran\n>\n> > which adds a helper function and a helper class to make synchronizing\n> > DMA buffers easier.\n> >\n> > The second patch updates debayer_cpu to utilize the new helper class.\n> > The following mtkisp7 pipeline handler will also depend on the helper\n> > class.\n> >\n> > I put the function in DmaBufAllocator and the helper class in the same\n> > file for now. Let me know if I should put them elsewhere.\n> >\n> > This passes gitlab pipeline:\n> > https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1309296\n> >\n> > v2:\n> > - Fixed ioctl return value check when being interrupted.\n> >\n> > BR,\n> > Harvey\n> >\n> > [1]: [PATCH v4] libcamera: debayer_cpu: Sync DMABUFs\n> >\n> >\n> > Harvey Yang (2):\n> > DmaBufAllocator: Add Dma Buffer synchronization function & helper\n> > class\n> > debayer_cpu: Replace syncing DMABUFs with DmaSyncer\n> >\n> > .../libcamera/internal/dma_buf_allocator.h | 33 +++++++\n> > src/libcamera/dma_buf_allocator.cpp | 90 +++++++++++++++++++\n> > src/libcamera/software_isp/debayer_cpu.cpp | 29 ++----\n> > 3 files changed, 131 insertions(+), 21 deletions(-)\n> >\n> > --\n> > 2.47.0.277.g8800431eea-goog\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65E51C324C\n\tfor ;\n\tWed, 13 Nov 2024 10:10:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 758B565802;\n\tWed, 13 Nov 2024 11:10:36 +0100 (CET)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E170F605B5\n\tfor ;\n\tWed, 13 Nov 2024 11:10:34 +0100 (CET)","by mail-lj1-x22b.google.com with SMTP id\n\t38308e7fff4ca-2fb51e00c05so79413571fa.0\n\tfor ;\n\tWed, 13 Nov 2024 02:10:34 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"avIjGRNu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1731492634; x=1732097434;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=33iJ6dXP3P3OZN2lH29HSzSf3LN9eIS1pT5KJ5H3MVE=;\n\tb=avIjGRNuJX+JQG/4uThJ+KGPpjhBQ7kLtua7IUvmK7yrG++fE9ARWLxSpp3LRoaWpo\n\tpqpgeLDRCgAlOvMD4mnNLIboLnDLPlpkFCMamdeTkIuCuXTP0GxadIUTTn0LjdD5+wMQ\n\t2yYzjxVMlwPT5i7VsBe/mmRHtjs2uvojjzsyI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731492634; x=1732097434;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=33iJ6dXP3P3OZN2lH29HSzSf3LN9eIS1pT5KJ5H3MVE=;\n\tb=mbk8AOwhfk3yqaR2XznAgBZrJK2BicTG8cG97UsosZPw4BiL/EwgDv0fjXwPTMrHCv\n\tJ/wrNrvJ3EwRwQ8+Xt+YoKMdJiI4mZFuvUJ8hubpSw/e5iuR712UHd0wpDjlKZR0W43B\n\tBnLsOMuk/zYiFupKlIaM34jxV/GEvIZQmQCDfy+3CvQiC49LINkL5RizwjdtBL7QnVkx\n\t/K8vHSnZ3MG/xGV/NWaflQ+nuq2DUQCqIeasOidGlnkT3vudzutvXwyI8PpiipUOU498\n\tN2FVGvS6N2sLZixEBgcjHeOGljh/7fBrR9c8wFuvXmf787Yx+HF73nrS02rhapT48krD\n\tGWCg==","X-Gm-Message-State":"AOJu0YyEfKQAIEnwcWQultdL264XK1hPp+2Dd02nKMuxgtFQBB+Jq1wj\n\tzWDtbYxW4ew19NWUepiIf7FdfeNlGuVlgQiB68OORoDFf4dWjMdWrpZa66IblJpcxkMPx0wgm7o\n\t+8O++2Jms1wq6sgO7n9xGU5RlJrkytXe7xwvZEe5UDzz1NW0=","X-Google-Smtp-Source":"AGHT+IEWveHniNvykIgLqOrLAe+oKknbKSUZVwp28BGQ8c/x1KM8U6dDxhBzfuZlmfAgVxbIrgpp/vY67J6S8ViP21s=","X-Received":"by 2002:a05:651c:1596:b0:2fa:d7ea:a219 with SMTP id\n\t38308e7fff4ca-2ff202ac259mr129626881fa.37.1731492633788;\n\tWed, 13 Nov 2024 02:10:33 -0800 (PST)","MIME-Version":"1.0","References":"<20241113055524.3099340-1-chenghaoyang@chromium.org>\n\t<173149202044.1543188.5517436564757172061@ping.linuxembedded.co.uk>","In-Reply-To":"<173149202044.1543188.5517436564757172061@ping.linuxembedded.co.uk>","From":"Cheng-Hao Yang ","Date":"Wed, 13 Nov 2024 18:10:22 +0800","Message-ID":"","Subject":"Re: [PATCH v2 0/2] Add DmaSyncer","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]