[{"id":32101,"web_url":"https://patchwork.libcamera.org/comment/32101/","msgid":"","date":"2024-11-11T11:04:36","subject":"Re: [PATCH v3 00/11] Add Mali-C55 IPA Module and Algorithms","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Dan\n\nOn Thu, Nov 07, 2024 at 11:48:08AM +0000, Daniel Scally wrote:\n> Hello all\n>\n> This series adds an IPA Module to go with the Mali-C55 ISP's pipeline handler.\n> Algorithms are included for Black Level Correction, Auto-Exposure and Gain, Auto\n> White Balance and Lens Shading Correction. A tuning file for the IXM415 sensor\n> is also included.\n>\n> The series is based on the \"Miscellaneous Mali-C55 Pipeline Fixes\" set and the\n> \"Centralise common functions in IPA modules​\" set.\n>\n> The pipeline handler / IPA module implemented following application of this\n> patchset is developed using version 8 of the Mali-C55 ISP driver currently on\n> the linux-media mailing list [1]\n>\n> Thanks\n> Dan\n>\n> Series level changes:\n>\n> \t- A new patch adds the unsigned Q format helpers\n\nApart from the small comment on this patch, the rest looks pretty\nstandard and we've been testing and running this since 6 months, so I\nwould really like to see it in\n\nReviewed-by: Jacopo Mondi \n\nWe're adding yet another IPA that implements the current Request-based\nloop, so it's one more to convert in future, but it doesn't make\nsense to hold this one back waiting for a new structure.\n\nSo yeah, from my side: go ahead and merge\n\n>\n> [1] https://lore.kernel.org/linux-media/20241106100534.768400-1-dan.scally@ideasonboard.com/T/#t\n>\n> Daniel Scally (9):\n> ipa: helpers: Add Unsigned Q(m, n) helpers\n> include: linux: Add mali-c55-config.h\n> include: linux: Add Mali-C55 Stats and Params V4L2 format\n> libcamera: mali-c55: Acquire and plumb in 3a params and stats\n> ipa: mali-c55: Add Mali-C55 ISP IPA module\n> ipa: mali-c55: Add Agc algorithm\n> ipa: mali-c55: Add AWB Algorithm\n> ipa: mali-c55: Add Lens Shading Correction algorithm\n> ipa: mali-c55: Add IMX415 tuning data file\n>\n> Jacopo Mondi (2):\n> mali-c55: Plumb the IPA module in\n> ipa: mali-c55: Add BLC Algorithm\n>\n> Documentation/Doxyfile-common.in | 1 +\n> include/libcamera/ipa/mali-c55.mojom | 34 +\n> include/libcamera/ipa/meson.build | 1 +\n> include/linux/mali-c55-config.h | 909 +++++++++++++++++++\n> include/linux/videodev2.h | 3 +\n> meson_options.txt | 2 +-\n> src/ipa/libipa/helpers.cpp | 29 +\n> src/ipa/libipa/helpers.h | 2 +\n> src/ipa/mali-c55/algorithms/agc.cpp | 409 +++++++++\n> src/ipa/mali-c55/algorithms/agc.h | 81 ++\n> src/ipa/mali-c55/algorithms/algorithm.h | 39 +\n> src/ipa/mali-c55/algorithms/awb.cpp | 230 +++++\n> src/ipa/mali-c55/algorithms/awb.h | 40 +\n> src/ipa/mali-c55/algorithms/blc.cpp | 140 +++\n> src/ipa/mali-c55/algorithms/blc.h | 42 +\n> src/ipa/mali-c55/algorithms/lsc.cpp | 216 +++++\n> src/ipa/mali-c55/algorithms/lsc.h | 45 +\n> src/ipa/mali-c55/algorithms/meson.build | 8 +\n> src/ipa/mali-c55/data/imx415.yaml | 325 +++++++\n> src/ipa/mali-c55/data/meson.build | 9 +\n> src/ipa/mali-c55/data/uncalibrated.yaml | 7 +\n> src/ipa/mali-c55/ipa_context.cpp | 101 +++\n> src/ipa/mali-c55/ipa_context.h | 85 ++\n> src/ipa/mali-c55/mali-c55.cpp | 399 ++++++++\n> src/ipa/mali-c55/meson.build | 33 +\n> src/ipa/mali-c55/module.h | 27 +\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 541 ++++++++++-\n> 27 files changed, 3728 insertions(+), 30 deletions(-)\n> create mode 100644 include/libcamera/ipa/mali-c55.mojom\n> create mode 100644 include/linux/mali-c55-config.h\n> create mode 100644 src/ipa/mali-c55/algorithms/agc.cpp\n> create mode 100644 src/ipa/mali-c55/algorithms/agc.h\n> create mode 100644 src/ipa/mali-c55/algorithms/algorithm.h\n> create mode 100644 src/ipa/mali-c55/algorithms/awb.cpp\n> create mode 100644 src/ipa/mali-c55/algorithms/awb.h\n> create mode 100644 src/ipa/mali-c55/algorithms/blc.cpp\n> create mode 100644 src/ipa/mali-c55/algorithms/blc.h\n> create mode 100644 src/ipa/mali-c55/algorithms/lsc.cpp\n> create mode 100644 src/ipa/mali-c55/algorithms/lsc.h\n> create mode 100644 src/ipa/mali-c55/algorithms/meson.build\n> create mode 100644 src/ipa/mali-c55/data/imx415.yaml\n> create mode 100644 src/ipa/mali-c55/data/meson.build\n> create mode 100644 src/ipa/mali-c55/data/uncalibrated.yaml\n> create mode 100644 src/ipa/mali-c55/ipa_context.cpp\n> create mode 100644 src/ipa/mali-c55/ipa_context.h\n> create mode 100644 src/ipa/mali-c55/mali-c55.cpp\n> create mode 100644 src/ipa/mali-c55/meson.build\n> create mode 100644 src/ipa/mali-c55/module.h\n>\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 874B8BE173\n\tfor ;\n\tMon, 11 Nov 2024 11:04:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DC04657C0;\n\tMon, 11 Nov 2024 12:04:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CED665486\n\tfor ;\n\tMon, 11 Nov 2024 12:04:40 +0100 (CET)","from ideasonboard.com (mob-5-90-143-109.net.vodafone.it\n\t[5.90.143.109])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93C3A6AF;\n\tMon, 11 Nov 2024 12:04:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vSvVSwcw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731323068;\n\tbh=qlVbFKCJhKTClnnpzdHPyPoMNN9IwQE0tB0aALn9i8A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vSvVSwcwSZCYMcyC3vFJBijRz+Cc6eZB4ua+vxcspcrPvZ9mNQniE98UXheLI/5Ex\n\tDkpchbVV/bVE5GkRr1ZyIzQDZGqz5tZZyZu4wOx+P5tezLxlEUwZ8uRdwePaQimhHL\n\tbGilaUVic43iXYSdtqeNJRD8i0diXwTp/rZelv1w=","Date":"Mon, 11 Nov 2024 12:04:36 +0100","From":"Jacopo Mondi ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, Anthony.McGivern@arm.com","Subject":"Re: [PATCH v3 00/11] Add Mali-C55 IPA Module and Algorithms","Message-ID":"","References":"<20241107114819.57599-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241107114819.57599-1-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]