[{"id":32068,"web_url":"https://patchwork.libcamera.org/comment/32068/","msgid":"<20241108014719.GD32614@pendragon.ideasonboard.com>","date":"2024-11-08T01:47:19","subject":"Re: [PATCH v6 0/3] Clean up pending requests on stop in software ISP","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nApplied, thank you.\n\nOn Wed, Nov 06, 2024 at 09:17:18PM +0100, Milan Zamazal wrote:\n> Fix for the bug #234 where software ISP may not clean up some pending\n> buffers in stopDevice.\n> \n> Changes in v6:\n> - Fix the ordering of function declarations and implementations.\n> - Minor code restructuring as suggested by Laurent.\n> - A comment wording improved.\n> - A C++20 construct avoided.\n> \n> Changes in v5:\n> - Use a struct instead of std::pair in conversionQueue_.\n> \n> Changes in v4:\n> - Request explicitly tracked as suggested by Laurent.\n> \n> Changes in v3:\n> - Split to two patches according to different code areas affected.\n> - Added a check for the request status to prevent canceling a request\n> multiple times.\n> - Calling conversionBuffers_.clear() after the cleanup, to be safer.\n> \n> Changes in v2:\n> - The request is additionally canceled.\n> - New helper method PipelineHandler::cancelRequest() introduced.\n> \n> Milan Zamazal (3):\n> libcamera: pipeline_handler: Provide cancelRequest\n> libcamera: simple: Track requests in conversionQueue_\n> libcamera: software_isp: Clean up pending requests on stop\n> \n> include/libcamera/internal/pipeline_handler.h | 1 +\n> src/libcamera/pipeline/simple/simple.cpp | 36 ++++++++++++-------\n> src/libcamera/pipeline_handler.cpp | 23 ++++++++----\n> 3 files changed, 40 insertions(+), 20 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2920BE173\n\tfor ;\n\tFri, 8 Nov 2024 01:47:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7E6D65485;\n\tFri, 8 Nov 2024 02:47:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 424B460589\n\tfor ;\n\tFri, 8 Nov 2024 02:47:26 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF9616DE;\n\tFri, 8 Nov 2024 02:47:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N3Dr62x0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731030436;\n\tbh=eJlDQr+ShyrZyPBBDtb/nO6rtXAFNxfoEMcXghdVClk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=N3Dr62x0ALX82ILRTfuKLldDNWWrdsgr7XKHtik6y6Aof7nT7hN/8MyL5gyXkZJ7W\n\tgqv6DWroaw8PiCgZepby5AwRysEIXuf1PVQrrsKw8eELPoOy1+rBsSpJuRMYEJDm5v\n\tyQLjEP61ckayRxAFlueTE2Pe+JXxbdpqtv6HnqHQ=","Date":"Fri, 8 Nov 2024 03:47:19 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, robert.mader@posteo.de,\n\tkieran.bingham@ideasonboard.com, hdegoede@redhat.com","Subject":"Re: [PATCH v6 0/3] Clean up pending requests on stop in software ISP","Message-ID":"<20241108014719.GD32614@pendragon.ideasonboard.com>","References":"<20241106201721.1624461-1-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241106201721.1624461-1-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]