{"id":21822,"url":"https://patchwork.libcamera.org/api/covers/21822/?format=json","web_url":"https://patchwork.libcamera.org/cover/21822/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241106201721.1624461-1-mzamazal@redhat.com>","date":"2024-11-06T20:17:18","name":"[v6,0/3] Clean up pending requests on stop in software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"mbox":"https://patchwork.libcamera.org/cover/21822/mbox/","series":[{"id":4774,"url":"https://patchwork.libcamera.org/api/series/4774/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4774","date":"2024-11-06T20:17:18","name":"Clean up pending requests on stop in software ISP","version":6,"mbox":"https://patchwork.libcamera.org/series/4774/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21822/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC67CBDB13\n\tfor ;\n\tWed, 6 Nov 2024 20:17:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B15765456;\n\tWed, 6 Nov 2024 21:17:36 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FE9965431\n\tfor ;\n\tWed, 6 Nov 2024 21:17:33 +0100 (CET)","from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-680-EmH_9JPLNUebNW-26pP59A-1;\n\tWed, 06 Nov 2024 15:17:29 -0500","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 197141955F69; Wed, 6 Nov 2024 20:17:28 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.4])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6D21D1956088; Wed, 6 Nov 2024 20:17:25 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"gBiuAjkG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1730924252;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=a/8UQ5+T3MCEFwE3lsVhJf9kBAb9BwLYtFPxesFOwuQ=;\n\tb=gBiuAjkGrcd+OORIUhYxpNDeCserC2K+Z0zIShleKBMhveG2jSRjvUe+U6Uk8kQhPPAKtD\n\tJ9mVvk1LSjBayGU/ypj1f5DqUQBVAGf/5yDk+90vLQ8ZbSJWlygSEmfgRq2ukbLF4ZIcbv\n\tng5bYp61Z1g7+M4EuzH5E49pm0usRiQ=","X-MC-Unique":"EmH_9JPLNUebNW-26pP59A-1","X-Mimecast-MFC-AGG-ID":"EmH_9JPLNUebNW-26pP59A","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , robert.mader@posteo.de,\n\tkieran.bingham@ideasonboard.com, laurent.pinchart@ideasonboard.com,\n\thdegoede@redhat.com","Subject":"[PATCH v6 0/3] Clean up pending requests on stop in software ISP","Date":"Wed, 6 Nov 2024 21:17:18 +0100","Message-ID":"<20241106201721.1624461-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"NJBwzXQCBZaNdV2v1yGE9edO8If7wx2Ty5Zzc5VH9VI_1730924248","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fix for the bug #234 where software ISP may not clean up some pending\nbuffers in stopDevice.\n\nChanges in v6:\n- Fix the ordering of function declarations and implementations.\n- Minor code restructuring as suggested by Laurent.\n- A comment wording improved.\n- A C++20 construct avoided.\n\nChanges in v5:\n- Use a struct instead of std::pair in conversionQueue_.\n\nChanges in v4:\n- Request explicitly tracked as suggested by Laurent.\n\nChanges in v3:\n- Split to two patches according to different code areas affected.\n- Added a check for the request status to prevent canceling a request\n multiple times.\n- Calling conversionBuffers_.clear() after the cleanup, to be safer.\n\nChanges in v2:\n- The request is additionally canceled.\n- New helper method PipelineHandler::cancelRequest() introduced.\n\nMilan Zamazal (3):\n libcamera: pipeline_handler: Provide cancelRequest\n libcamera: simple: Track requests in conversionQueue_\n libcamera: software_isp: Clean up pending requests on stop\n\n include/libcamera/internal/pipeline_handler.h | 1 +\n src/libcamera/pipeline/simple/simple.cpp | 36 ++++++++++++-------\n src/libcamera/pipeline_handler.cpp | 23 ++++++++----\n 3 files changed, 40 insertions(+), 20 deletions(-)"}