{"id":21781,"url":"https://patchwork.libcamera.org/api/covers/21781/?format=json","web_url":"https://patchwork.libcamera.org/cover/21781/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241031094957.18471-1-naush@raspberrypi.com>","date":"2024-10-31T09:49:50","name":"[v4,0/7] Raspberry Pi: Add controls::rpi::ScalerCrops","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/21781/mbox/","series":[{"id":4760,"url":"https://patchwork.libcamera.org/api/series/4760/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4760","date":"2024-10-31T09:49:50","name":"Raspberry Pi: Add controls::rpi::ScalerCrops","version":4,"mbox":"https://patchwork.libcamera.org/series/4760/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21781/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0361C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 31 Oct 2024 09:52:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A4BE653AC;\n\tThu, 31 Oct 2024 10:52:44 +0100 (CET)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 344ED618BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 31 Oct 2024 10:52:42 +0100 (CET)","by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-4315b957ae8so840025e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 31 Oct 2024 02:52:42 -0700 (PDT)","from naush-laptop.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4327d6983c2sm19789835e9.42.2024.10.31.02.52.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 31 Oct 2024 02:52:40 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"lOa7JSEh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1730368361; x=1730973161;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=yguVaq99linEW/mz34LbN3fDEh7ICN2e264hc/htwYM=;\n\tb=lOa7JSEhLaVcjTWqsYWeR1jJpr6hzb5rS9O16BjVyo1B1xmb5TrMgwzSd1tWJ2yTVq\n\tQFtEZAiQoqoESa3XiMEkJdpWwy3wqfKTAbChSiZ7sltc4dQZQxF8fSTD3T70th5KWyOR\n\t8EZvReGKvzJ4mMttuqwhyHfuAlZMZydMGs5J8/kS7tuVNrnoCi5fcpnzJkuwd8BffJVI\n\tM+8xovk730iSUsUclpHJ09o6YuXhO1zVAApp+b8gyJStfwnLphc+9mD03gJHorZQ4LoP\n\tn/LmqwP74XuMzYphvL4JKLTkR8sIVBbOI00640/4rmx3+YVHWNtrpoZlx96WEjfUQgJI\n\tUj8A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730368361; x=1730973161;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=yguVaq99linEW/mz34LbN3fDEh7ICN2e264hc/htwYM=;\n\tb=aLBFhrBiz5kgK6tQcMWC77D0e6CrO+pu1DNJUvofS/lNAX8ju3EXezGy+n55WIiJUW\n\tG6Oe+2rqGn7VUTbME105tlKeYVPazTC3oYsOLgVudVC3Urk9SHnr0EpARZ6kZ0qxd0wo\n\tLhjiJSuSZrFUZMIPjMum0lgQCIeyOMj6UN5FKsu8SpXPEYUZKn4bDD6UubbAVawzMHJY\n\t80fYO2jCea6fKqIZRcQD4zGWDx5aDcslm7G4Z8VMePm/nvpRMtqH0q95CuG98puo6CHR\n\tDkcpiT/uCKACaVTqpvGtTafIqrwRWxYjRFkeaCAU6NhagA8+WcuQEiBp3SssBXBBS1Xo\n\tEQmQ==","X-Gm-Message-State":"AOJu0YzrwMUicoURCqUbgiUk/O/NKUASHI2xTHNUo3NXcjpcQHXy4nmt\n\tP5LKCxBzigS4GV2MJdczycYASnbxkws3qcmCdC6PoA+8Vs+HaCiSNGpy1jVjFPKlZ70S+KZ5vNB\n\tx","X-Google-Smtp-Source":"AGHT+IHNzkTUsGUfQCFX+aBVhB9M6o4X4QFGgnTPLMv1uhu6nHpONOKd8wUebGEpBuuUVy1RnL4low==","X-Received":"by 2002:a05:600c:4fd4:b0:42c:b9c8:2b95 with SMTP id\n\t5b1f17b1804b1-4319ad3ea89mr72810055e9.6.1730368361339; \n\tThu, 31 Oct 2024 02:52:41 -0700 (PDT)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck <naush@raspberrypi.com>","Subject":"[PATCH v4 0/7] \tRaspberry Pi: Add controls::rpi::ScalerCrops","Date":"Thu, 31 Oct 2024 09:49:50 +0000","Message-Id":"<20241031094957.18471-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi,\n\nNo functional differenced in v7 compared to v6:\n\n- Fix commit message + code comments regarding priority of the controls.\n- Fix indentation of the control info for rpi::ScalerCrops.\n\nRegards,\nNaush\n\nNaushir Patuck (7):\n  controls: rpi: Add a vendor rpi::ScalerCrops control\n  pipeline: rpi: Remove CameraData::scalerCrop_\n  pipeline: rpi: Pass crop rectangle as a parameter to\n    platformSetIspCrop()\n  pipeline: rpi: Introduce CameraData::CropParams\n  pipeline: rpi: Track which ISP output is configured for a stream\n  pipeline: rpi: Pass ISP output index into platformSetIspCrop()\n  pipeline: rpi: Handler controls::rpi::ScalerCrops\n\n src/ipa/rpi/common/ipa_base.cpp               | 12 +++\n src/libcamera/control_ids_rpi.yaml            | 25 +++++\n .../pipeline/rpi/common/pipeline_base.cpp     | 95 +++++++++++++------\n .../pipeline/rpi/common/pipeline_base.h       | 22 ++++-\n src/libcamera/pipeline/rpi/vc4/vc4.cpp        | 17 +++-\n 5 files changed, 135 insertions(+), 36 deletions(-)"}