{"id":21766,"url":"https://patchwork.libcamera.org/api/covers/21766/?format=json","web_url":"https://patchwork.libcamera.org/cover/21766/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241029085837.3615699-1-chenghaoyang@chromium.org>","date":"2024-10-29T08:57:54","name":"[v7,0/1] Add thread affinity","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/21766/mbox/","series":[{"id":4751,"url":"https://patchwork.libcamera.org/api/series/4751/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4751","date":"2024-10-29T08:57:54","name":"Add thread affinity","version":7,"mbox":"https://patchwork.libcamera.org/series/4751/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21766/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E6B5C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Oct 2024 08:58:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28911653A1;\n\tTue, 29 Oct 2024 09:58:47 +0100 (CET)","from mail-pg1-x534.google.com (mail-pg1-x534.google.com\n\t[IPv6:2607:f8b0:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0147565398\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Oct 2024 09:58:44 +0100 (CET)","by mail-pg1-x534.google.com with SMTP id\n\t41be03b00d2f7-656d8b346d2so3465786a12.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Oct 2024 01:58:44 -0700 (PDT)","from chenghaoyang-low.c.googlers.com.com\n\t(27.247.221.35.bc.googleusercontent.com. [35.221.247.27])\n\tby smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-7edc89f2faesm7000856a12.60.2024.10.29.01.58.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 29 Oct 2024 01:58:42 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"a/o8XtDe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1730192323; x=1730797123;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=8P21cB3UomaALVfMKPgLow2VprwuWgCYgJxpaun1YSA=;\n\tb=a/o8XtDeKIYSXNrsuYESxdwwdVao8O88/VhpVv6g6Xx1f43a+ujUq+frRwcvDzxN5x\n\t+uSXxE9mLBPrq9+H18RPCJVSNGEuPk6IrueF48pL2TVm95KZuTfzThUl7847arx2b7/r\n\tlnV1UEFUF6lQlVTwTUIgg+0ek8ERdCGQPAYQQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730192323; x=1730797123;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=8P21cB3UomaALVfMKPgLow2VprwuWgCYgJxpaun1YSA=;\n\tb=Gp23h6a2JXwcPiOzTIdcwST8+UWA/+P23I8rUp3YZR7Pa/l0OfrXVJooWpJFARbNJ2\n\txvt3qviaULKR9GG6KmSHIxWbKQqVnHd1iAlb0hBpYLMgw5mJMOXaRjMUQwMs1Kn33e66\n\t+MMIxNcXRaSVejkzC4hlye/Pw40/Q5luOr3blZKBxTA4dSKMcLj/uDGgqpsKfgo16O4M\n\ttHk0df0aXs5aSWrVpG6He1lideuPn4/j9IJGCeyKinqW/AEzb43k1Z8hFun//rogo2a6\n\tNnZ8h+kpwmrQ3OBO05P3s850Y5atOVTOOyXipgrO3uXBnWTzJg9fzd+ZIUt7PfsBB6pu\n\txVNA==","X-Gm-Message-State":"AOJu0Ywm0XdIz3pBOl97MD3rR8dY3EYJxEno+HfvUTWc70NcMds/HsZT\n\tCHlFztSzPrwHqUEXGmc3Kk9MhM7KIXUR5B0orKGeJJvquIti7nhzhgUlbJeHEVxiM2HnhdjyHn4\n\t=","X-Google-Smtp-Source":"AGHT+IEgxWoNm9A4v5p5/cWGR0E/lv840PeQHbu+yi2L4niNX6dyQ0gEx3F+I6LWfy1WsrbD4w+LKQ==","X-Received":"by 2002:a05:6a21:a247:b0:1d9:76a3:a208 with SMTP id\n\tadf61e73a8af0-1d9a8505f8cmr14117239637.47.1730192323147; \n\tTue, 29 Oct 2024 01:58:43 -0700 (PDT)","From":"Harvey Yang <chenghaoyang@chromium.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang <chenghaoyang@chromium.org>","Subject":"[PATCH v7 0/1] Add thread affinity","Date":"Tue, 29 Oct 2024 08:57:54 +0000","Message-ID":"<20241029085837.3615699-1-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.47.0.163.g1226f6d8fa-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi folks,\n\nThis patch adds a method to set thread affinity, which is needed to\nensure performance in mtkisp7 pipeline handler and IPA.\n\nThis passes gitlab pipeline:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1299712\n\nv7:\n- Add unit tests.\n\nv6:\n- Set thread affinity before run(), if it was not started yet.\n\nv5:\n- Return failure if any index is invalid.\n- Drop the check of max size.\n\nv4:\n- Use `sizeof(data_->cpuset_.value())`.\n\nv3:\n- Keep the cpu indices in ThreadData.\n\nv2:\n- Check cpu indices within [0, `std::thread::hardware_concurrency()`).\n- Limit max size of cpus to be CPU_SETSIZE.\n\nBR,\nHarvey\n\nHan-Lin Chen (1):\n  libcamera: add method to set thread affinity\n\n include/libcamera/base/thread.h |  5 ++++\n src/libcamera/base/thread.cpp   | 47 +++++++++++++++++++++++++++++++++\n test/threads.cpp                | 40 ++++++++++++++++++++++++++++\n 3 files changed, 92 insertions(+)"}