[{"id":31785,"web_url":"https://patchwork.libcamera.org/comment/31785/","msgid":"<87y12mvqt7.fsf@gmail.com>","date":"2024-10-17T12:47:04","subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/people/146/","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"content":"The chart from camshark (see attachment).\n\n--\nBest regards,\nMikhail Rudenko","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61F5FC32FC\n\tfor ;\n\tThu, 17 Oct 2024 12:48:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EDCF65383;\n\tThu, 17 Oct 2024 14:48:09 +0200 (CEST)","from mail-lf1-x130.google.com (mail-lf1-x130.google.com\n\t[IPv6:2a00:1450:4864:20::130])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C49176353B\n\tfor ;\n\tThu, 17 Oct 2024 14:48:07 +0200 (CEST)","by mail-lf1-x130.google.com with SMTP id\n\t2adb3069b0e04-539e59dadebso1363935e87.0\n\tfor ;\n\tThu, 17 Oct 2024 05:48:07 -0700 (PDT)","from razdolb ([83.149.246.185]) by smtp.gmail.com with ESMTPSA id\n\t2adb3069b0e04-539fffa8b0csm778056e87.52.2024.10.17.05.48.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 17 Oct 2024 05:48:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KldJswyl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1729169286; x=1729774086;\n\tdarn=lists.libcamera.org; \n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:from:to:cc:subject:date:message-id:reply-to;\n\tbh=bpeJMSMOl8NUUSbS7T8KcCRXXG0194C1wk8F5B2vKjQ=;\n\tb=KldJswylWBC7gGZQZDG9SlVg0lAOV+G57jKbPiUmKiSzZ23zgsZeZzN+CKRTLF7uQO\n\trcdw54vmD5oMKjSmfC3RDASbIQ9m1O4IKOMrQgW8IF1ShXyoONNbfDe8ySazjIB29s3M\n\t3n0P+YRyWyPCht7DSk/whbzs9OOQbHHlOtxThmG3OG5wmktMq+EZpTT3xjzSoUvm60hh\n\twvVeRavY87SiKf7hCekiXT25/IJNOA//q7uyWmShE29MRhy+z70mohrpY42ea2rLFBt7\n\tqSmHTMNPISINUqnWlaRQAG8vd6UJdCqaHejpCzzo8zyJi1Dm5K+kxDvnjBvbkt6XLwDh\n\tzqaw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729169286; x=1729774086;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=bpeJMSMOl8NUUSbS7T8KcCRXXG0194C1wk8F5B2vKjQ=;\n\tb=UQQD0kA6yE+kykXn03o8hXRkq8JLEX7rPOCYeEmXhg1xd4BCXsX4XevgMerkT2scpm\n\t0nkkkL5GmO1FMiB+wSDcJSm8TeaFdoGC0qULaDQMhnKyXXrtijMbncmFseTuzl6Ud3x2\n\tyQGArqJZEvlS542J1SaCBx1ccIzWsxUetiBeD0isKL2mo8JEge7STov/wAWADkApjpre\n\tCTRM/d9sE64ZIiK6pkEOM0WZm2F0VDS05fqLLmPyceKZYF2qYl3WUgVBLuNJmeFULKf4\n\tHt1EqhtZn/jMFUydhtogu2hSUpFb4RaIExf19BbQEXwE5klJfIvprl2H3pc7a5ZzGdtU\n\tFRwg==","X-Gm-Message-State":"AOJu0Yxshn5M3mqk+4hlqfuwLNYAbDyOcyE6ztsWXvhqvPDmsKzILWeb\n\tuc6URDZqu68YWFnmCuXc1JGpNfvrziOTh9z0iPTrOPMyDjJ3v26xqjkCmQ==","X-Google-Smtp-Source":"AGHT+IHCqSTh8Z8fs50pAJeHgWoTs7AWXfA+71GPTapITuBl0lL0IhaVpRs7cnpbX8mh3SgxiE/Ifw==","X-Received":"by 2002:a05:6512:15a3:b0:53a:16b:f14f with SMTP id\n\t2adb3069b0e04-53a03f18f73mr5074778e87.19.1729169285957; \n\tThu, 17 Oct 2024 05:48:05 -0700 (PDT)","References":"<20241017124613.3853273-1-mike.rudenko@gmail.com>","User-agent":"mu4e 1.10.8; emacs 29.4.50","From":"Mikhail Rudenko ","To":"Mikhail Rudenko ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","Date":"Thu, 17 Oct 2024 15:47:04 +0300","In-reply-to":"<20241017124613.3853273-1-mike.rudenko@gmail.com>","Message-ID":"<87y12mvqt7.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"=-=-=\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31786,"web_url":"https://patchwork.libcamera.org/comment/31786/","msgid":"<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>","date":"2024-10-17T13:35:40","subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Mikhail,\n\nQuoting Mikhail Rudenko (2024-10-17 13:47:04)\n> The chart from camshark (see attachment).\n> \n\nThat looks like a good result indeed!\n\nI'll test out the patches.\n\nThanks!\n--\nKieran\n\n\n> --\n> Best regards,\n> Mikhail Rudenko\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC786C32FC\n\tfor ;\n\tThu, 17 Oct 2024 13:35:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACEE265383;\n\tThu, 17 Oct 2024 15:35:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED0816353B\n\tfor ;\n\tThu, 17 Oct 2024 15:35:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6158669;\n\tThu, 17 Oct 2024 15:34:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dxGe+yB4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729172040;\n\tbh=WdSe9JGGtfMl1JAP7r2tHhr/SvE+UYu4261WdNI6oOw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=dxGe+yB4a8wW9jFo/1uhHRaeMhwCs7dL6wADtbbW3wTeudI0AXZOefeoJptNfVoh/\n\tJKvCm1xzO9tU6hKTcmQV7arkZjXk5ZXZexjQufWjyKOuaj0sgzQw/AGtNxXX93zBKw\n\tACN1E2Y4E4tApGSknxIrxg/Q5PFi/d9nbbg7gTFE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<87y12mvqt7.fsf@gmail.com>","References":"<20241017124613.3853273-1-mike.rudenko@gmail.com>\n\t<87y12mvqt7.fsf@gmail.com>","Subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Mikhail Rudenko ","Date":"Thu, 17 Oct 2024 14:35:40 +0100","Message-ID":"<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31810,"web_url":"https://patchwork.libcamera.org/comment/31810/","msgid":"<172929040031.877857.7799971285577062955@ping.linuxembedded.co.uk>","date":"2024-10-18T22:26:40","subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Mikhail,\n\nQuoting Kieran Bingham (2024-10-17 14:35:40)\n> Hi Mikhail,\n> \n> Quoting Mikhail Rudenko (2024-10-17 13:47:04)\n> > The chart from camshark (see attachment).\n> > \n> \n> That looks like a good result indeed!\n> \n> I'll test out the patches.\n\nI've just tried this out - and it seems to work well on the IMX283 I\nhave - but caused quite noticible AnalogueGain oscillations on the\nIMX335 ... I would 'bet' that's not the fault of this series - but the\nfact that we don't have per-sensor delayed-controls set up correctly\nwhich I already know about - but I haven't seen that get fixed up yet.\n\nI think your series probably highlights the fault that already exists...\n\n--\nKieran\n\n> \n> Thanks!\n> --\n> Kieran\n> \n> \n> > --\n> > Best regards,\n> > Mikhail Rudenko\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6E3BC32FE\n\tfor ;\n\tFri, 18 Oct 2024 22:26:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 63C8B6538A;\n\tSat, 19 Oct 2024 00:26:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C638633C7\n\tfor ;\n\tSat, 19 Oct 2024 00:26:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33CC4160;\n\tSat, 19 Oct 2024 00:24:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wpJ9YigL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729290299;\n\tbh=EkWnJIoXofIQT19C6+1tE/DM098TkP9pL3Pc5M/fYRs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=wpJ9YigLUUwGtzwgpgl/VnUwzuHxn8a0nIcJ/gK1ecg6cE7Eez6kz10CVUqWt3db8\n\tYknL4fYZxH661BZUKcEPWPBo61yM4DP93+UL55C/R8k9HbGJXnykF15IngiWdrfpR9\n\tq6owpS2rPy8VvyH2wvkZPopUOBE92CXfCtOFLlkY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>","References":"<20241017124613.3853273-1-mike.rudenko@gmail.com>\n\t<87y12mvqt7.fsf@gmail.com>\n\t<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Mikhail Rudenko ","Date":"Fri, 18 Oct 2024 23:26:40 +0100","Message-ID":"<172929040031.877857.7799971285577062955@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31830,"web_url":"https://patchwork.libcamera.org/comment/31830/","msgid":"<87sesq7u1o.fsf@gmail.com>","date":"2024-10-20T13:39:45","subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/people/146/","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"content":"Hi Kieran,\n\nOn 2024-10-18 at 23:26 +01, Kieran Bingham wrote:\n\n> Hi Mikhail,\n>\n> Quoting Kieran Bingham (2024-10-17 14:35:40)\n>> Hi Mikhail,\n>>\n>> Quoting Mikhail Rudenko (2024-10-17 13:47:04)\n>> > The chart from camshark (see attachment).\n>> >\n>>\n>> That looks like a good result indeed!\n>>\n>> I'll test out the patches.\n>\n> I've just tried this out - and it seems to work well on the IMX283 I\n> have - but caused quite noticible AnalogueGain oscillations on the\n> IMX335 ... I would 'bet' that's not the fault of this series - but the\n> fact that we don't have per-sensor delayed-controls set up correctly\n> which I already know about - but I haven't seen that get fixed up yet.\n\nI did a few more tests myself (I use OV4689 btw), and also observed\nanalogue gain oscillations on darker scenes when AGC tries to steer the\ngain above 1.0. It looks like the hardcoded gain delay value of 1 is\nwrong at least for my sensor. When I increased it to 2, gain\noscillations were gone. I have also tweaked a few things here and there\nand will send v2 soon.\n\n> I think your series probably highlights the fault that already exists...\n\nI feel like we have reached the moment when we should switch from the\ndelays hardcoded in the pipeline handler to sensor specific values like\nrpi does. I could try doing that, but in a separate series. What do you\nthink?\n\n--\nBest regards,\nMikhail","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F412BC3306\n\tfor ;\n\tSun, 20 Oct 2024 14:01:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F7586538F;\n\tSun, 20 Oct 2024 16:01:13 +0200 (CEST)","from mail-lj1-x236.google.com (mail-lj1-x236.google.com\n\t[IPv6:2a00:1450:4864:20::236])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7C9B65379\n\tfor ;\n\tSun, 20 Oct 2024 16:01:11 +0200 (CEST)","by mail-lj1-x236.google.com with SMTP id\n\t38308e7fff4ca-2fb388e64b0so34056131fa.0\n\tfor ;\n\tSun, 20 Oct 2024 07:01:11 -0700 (PDT)","from razdolb (static.40.223.216.95.clients.your-server.de.\n\t[95.216.223.40]) by smtp.gmail.com with ESMTPSA id\n\t38308e7fff4ca-2fb9ad60d8asm2374931fa.38.2024.10.20.07.01.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 20 Oct 2024 07:01:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"icMAbNVX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1729432870; x=1730037670;\n\tdarn=lists.libcamera.org; \n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:from:to:cc:subject:date:message-id:reply-to;\n\tbh=w+QaXwpxOoW8+R2w4zDjmMyZMkZfO8C4tBPKP++s99k=;\n\tb=icMAbNVXxsDPe9rkTVd8xh74yAj4YczQjE08YlFMOqH8NB+Adhu9NybkwnFd+M3a+N\n\tMMwTQ2xUFLAbzogWgcrzimdaC1rt5sZgN+554w2+qfj/TFSp6s7TSqTL3D9Wix3Rzrdr\n\tgbNXQ0IVafSE0m2wck0vF/7RR7Pe8z/KidPF29l2MFyPQtO9U2ijdqSyWG67sk14jI3H\n\tspwR2Su6LLHoll1VRIhVmX5zKRzm+/xafrPTEF9+T/gSnycI5SPXzfZrlZZd6vLkYCRz\n\t/uv8ny249aSuTsX4xTc0sI3T1bmFf6rW6axvCYroqOtU4IKIsfp69ssY5ulKh5jfZpPL\n\tmJkQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729432870; x=1730037670;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=w+QaXwpxOoW8+R2w4zDjmMyZMkZfO8C4tBPKP++s99k=;\n\tb=qIK0DVDsWftNiIUFOsQ1W3v+x94ZD9dK1zHYPiY2gTgdfgGikNt8TK9PA60hf4SdA2\n\tUu6kir9ZNYc0wyrRIFopJCDLZ718ibEWX8E6XYg2YvVyCPnPTe46fBice22nZk9fq10h\n\tBQiG1Hp/CepgLxZ6AD6kskmzfUm11wmfMDRBsM0WRyg59y+n/VySmQMIGDW5RET8Lia7\n\tz9TWj3JN9hoye1ue3j0K6OhDe2oBfyJ87/jAqmebMZspDEwQg/ynehYGl0adlqQMKlNm\n\tHevlK+e6soagjhBvio8o1mMAuDKrVORX5zW1duCV6bRNUf0RWVXb0AXjpWqgG4MnKTNP\n\t1zSw==","X-Gm-Message-State":"AOJu0YyDsqvp/mdUyJzRFI+LdQWCrxEt+c/omExgrCwUw8qqoNHhrCMP\n\tRkMVzyn3+uxNfLx5IRJFNq7kVYZXYXmJWm4GIYNtCyvRExjVwjmnnk/0Aw==","X-Google-Smtp-Source":"AGHT+IH5XtmOPAHzbjnoHRV3kxfKCX5XpZFMu58uO7SzSrAmvcaR+uLnb6a/kt5xzmC4ww3P6rQyKw==","X-Received":"by 2002:a05:651c:1a0c:b0:2fa:d84a:bd83 with SMTP id\n\t38308e7fff4ca-2fb9b03eb19mr5662151fa.24.1729432869868; \n\tSun, 20 Oct 2024 07:01:09 -0700 (PDT)","References":"<20241017124613.3853273-1-mike.rudenko@gmail.com>\n\t<87y12mvqt7.fsf@gmail.com>\n\t<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>\n\t<172929040031.877857.7799971285577062955@ping.linuxembedded.co.uk>","User-agent":"mu4e 1.10.8; emacs 29.4.50","From":"Mikhail Rudenko ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","Date":"Sun, 20 Oct 2024 16:39:45 +0300","In-reply-to":"<172929040031.877857.7799971285577062955@ping.linuxembedded.co.uk>","Message-ID":"<87sesq7u1o.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31837,"web_url":"https://patchwork.libcamera.org/comment/31837/","msgid":"<172944560675.769772.2708999939540996047@ping.linuxembedded.co.uk>","date":"2024-10-20T17:33:26","subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Mikhail Rudenko (2024-10-20 14:39:45)\n> Hi Kieran,\n> \n> On 2024-10-18 at 23:26 +01, Kieran Bingham wrote:\n> \n> > Hi Mikhail,\n> >\n> > Quoting Kieran Bingham (2024-10-17 14:35:40)\n> >> Hi Mikhail,\n> >>\n> >> Quoting Mikhail Rudenko (2024-10-17 13:47:04)\n> >> > The chart from camshark (see attachment).\n> >> >\n> >>\n> >> That looks like a good result indeed!\n> >>\n> >> I'll test out the patches.\n> >\n> > I've just tried this out - and it seems to work well on the IMX283 I\n> > have - but caused quite noticible AnalogueGain oscillations on the\n> > IMX335 ... I would 'bet' that's not the fault of this series - but the\n> > fact that we don't have per-sensor delayed-controls set up correctly\n> > which I already know about - but I haven't seen that get fixed up yet.\n> \n> I did a few more tests myself (I use OV4689 btw), and also observed\n> analogue gain oscillations on darker scenes when AGC tries to steer the\n> gain above 1.0. It looks like the hardcoded gain delay value of 1 is\n> wrong at least for my sensor. When I increased it to 2, gain\n> oscillations were gone. I have also tweaked a few things here and there\n> and will send v2 soon.\n> \n> > I think your series probably highlights the fault that already exists...\n> \n> I feel like we have reached the moment when we should switch from the\n> delays hardcoded in the pipeline handler to sensor specific values like\n> rpi does. I could try doing that, but in a separate series. What do you\n> think?\n\nOh - absolutely. If it's something you're willing to work on - I think\nthat would be a massive help. Indeed, I think that's a separate series.\n\n\n--\nKieran\n\n\n> \n> --\n> Best regards,\n> Mikhail","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70635C3306\n\tfor ;\n\tSun, 20 Oct 2024 17:33:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 360FD65391;\n\tSun, 20 Oct 2024 19:33:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0633D65379\n\tfor ;\n\tSun, 20 Oct 2024 19:33:30 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 97BA0352;\n\tSun, 20 Oct 2024 19:31:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JFsFMrgh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729445504;\n\tbh=kA4UI97/hSBSA+dzLD1ud/qAYsqRhCHycFGnnB1FQIw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=JFsFMrghIp8jc20ccGv49RisfX3rjI2muyZ8tHiPgplT2ZRx2o0qmGeK+D3dimGpM\n\t3BD3IfVzf7w/vyxbNOdv9yBZAV1VVHZKSvUzmCwcLlg4tIfJ1+TdLd5j9KUHRdM7q2\n\tK0mEjrXlxMzUeM1aCIMwiL6LK+QZIAi5erBK5V8M=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<87sesq7u1o.fsf@gmail.com>","References":"<20241017124613.3853273-1-mike.rudenko@gmail.com>\n\t<87y12mvqt7.fsf@gmail.com>\n\t<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>\n\t<172929040031.877857.7799971285577062955@ping.linuxembedded.co.uk>\n\t<87sesq7u1o.fsf@gmail.com>","Subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Mikhail Rudenko ","Date":"Sun, 20 Oct 2024 18:33:26 +0100","Message-ID":"<172944560675.769772.2708999939540996047@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31860,"web_url":"https://patchwork.libcamera.org/comment/31860/","msgid":"<874j557a0k.fsf@gmail.com>","date":"2024-10-21T15:08:56","subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/people/146/","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"content":"On 2024-10-20 at 18:33 +01, Kieran Bingham wrote:\n\n> Quoting Mikhail Rudenko (2024-10-20 14:39:45)\n>> Hi Kieran,\n>>\n>> On 2024-10-18 at 23:26 +01, Kieran Bingham wrote:\n>>\n>> > Hi Mikhail,\n>> >\n>> > Quoting Kieran Bingham (2024-10-17 14:35:40)\n>> >> Hi Mikhail,\n>> >>\n>> >> Quoting Mikhail Rudenko (2024-10-17 13:47:04)\n>> >> > The chart from camshark (see attachment).\n>> >> >\n>> >>\n>> >> That looks like a good result indeed!\n>> >>\n>> >> I'll test out the patches.\n>> >\n>> > I've just tried this out - and it seems to work well on the IMX283 I\n>> > have - but caused quite noticible AnalogueGain oscillations on the\n>> > IMX335 ... I would 'bet' that's not the fault of this series - but the\n>> > fact that we don't have per-sensor delayed-controls set up correctly\n>> > which I already know about - but I haven't seen that get fixed up yet.\n>>\n>> I did a few more tests myself (I use OV4689 btw), and also observed\n>> analogue gain oscillations on darker scenes when AGC tries to steer the\n>> gain above 1.0. It looks like the hardcoded gain delay value of 1 is\n>> wrong at least for my sensor. When I increased it to 2, gain\n>> oscillations were gone. I have also tweaked a few things here and there\n>> and will send v2 soon.\n>>\n>> > I think your series probably highlights the fault that already exists...\n>>\n>> I feel like we have reached the moment when we should switch from the\n>> delays hardcoded in the pipeline handler to sensor specific values like\n>> rpi does. I could try doing that, but in a separate series. What do you\n>> think?\n>\n> Oh - absolutely. If it's something you're willing to work on - I think\n> that would be a massive help. Indeed, I think that's a separate series.\n\nI'd like to give it a try. Am I right that adding\n\n virtual void getDelays(int &exposureDelay, int &gainDelay, int &vblankDelay, int &hblankDelay)\n\nto CameraSensorHelper returning generic delays, then overriding it for\nsensors where we know the exact delays is a valid approach? Also, why do\nwe have both CamHelper and CameraSensorHelper, with former being\nsignificantly more featureful, but all the IPAs except rpi using the\nlatter?\n\n--\nBest regards,\nMikhail","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18DA7BD808\n\tfor ;\n\tMon, 21 Oct 2024 15:26:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B105365393;\n\tMon, 21 Oct 2024 17:26:08 +0200 (CEST)","from mail-lj1-x233.google.com (mail-lj1-x233.google.com\n\t[IPv6:2a00:1450:4864:20::233])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A67E6538B\n\tfor ;\n\tMon, 21 Oct 2024 17:26:07 +0200 (CEST)","by mail-lj1-x233.google.com with SMTP id\n\t38308e7fff4ca-2fb5638dd57so46477761fa.0\n\tfor ;\n\tMon, 21 Oct 2024 08:26:07 -0700 (PDT)","from razdolb (static.40.223.216.95.clients.your-server.de.\n\t[95.216.223.40]) by smtp.gmail.com with ESMTPSA id\n\t38308e7fff4ca-2fb9ae0fee4sm4908301fa.100.2024.10.21.08.26.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Oct 2024 08:26:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KRbtcrMm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1729524366; x=1730129166;\n\tdarn=lists.libcamera.org; \n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:from:to:cc:subject:date:message-id:reply-to;\n\tbh=0YEH3OeqWpVZ+S1sdxZgvtaJ2JizIs2tw0Gi5qBZmFA=;\n\tb=KRbtcrMmI2fL06q81kPrBAxanmus8PBf0/5g05wYCbqH6DhZenngeOf5Vg0LPgXCRy\n\tq7wU+1zeDcGDeJGej1R0RrpYckf58JJ4bZXy+f6+F0zwfaTk4AARDf1UhRDtxX/p4saG\n\ttlqADEU0rQnuN5GbVbXnMqU0xmw6lDDGPVae/nbm3bX7XRwOt/FAWst+fkfnzGu6ZWso\n\t+Us9Tq3AGsAtjwxXSeMSlObsXCM01RxujAHCKcW7MWbSHRDe0wRwvJ0VqvyoP+eHamNs\n\txm4vXNBrX0onZOQZ9/A1qQvY3UZeMvCaoWu7KrMX2AdifZXS8DpLc5YbNRT9BsvrZGsK\n\taLCw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729524366; x=1730129166;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=0YEH3OeqWpVZ+S1sdxZgvtaJ2JizIs2tw0Gi5qBZmFA=;\n\tb=oiv572oiyJ2mnIoWr5hLRzC0xxCINwbiU4bE9edhnRyzCIsqI7pmDIo3v5vjY2DpFb\n\twc4HDr08VLrPaL0Bbk/xmPEcJDAbl3xnn+yyNGl1qsO/OVtbkE6abWVR2EWXs2ub4FaI\n\txO/QHphgFb3J5ltSLquXy8Il1gvw5dgmw4jh6TuJkhEpoLE9UTwchn7tvYvWNg0g1zXR\n\tq9+ojGM6BWWtI/H5OrBjWJZ5R8pQZ15m2Vq+KbqySe1ufZOVbTS3ufu6TgX11UACfp86\n\tP87kXw58L2CrkYIQsFd5ezOUWTw4rPInmlpEkq5sqAvfHVV5UdlAhjf5SZgWqpkC6+RC\n\tUieQ==","X-Gm-Message-State":"AOJu0YxCF79D9J/phUExDNqkdh3FYDpldkhw8AsGE1BT4k3YfVTv9CPx\n\tpGNKT7HABVgbu6k8SoH2Zrk77sZu+GxQTuPmCDpANTquOBCF9tiaAOqhewmy","X-Google-Smtp-Source":"AGHT+IGFiZgrurD6lCPAGIUx/bMwgL/I4HadLDE4jTUYFrNQG94UJhqBVyqhLTkyBZWPIPUmSPPSgg==","X-Received":"by 2002:a2e:be09:0:b0:2fb:519e:b784 with SMTP id\n\t38308e7fff4ca-2fb82e937a5mr45323341fa.3.1729524366109; \n\tMon, 21 Oct 2024 08:26:06 -0700 (PDT)","References":"<20241017124613.3853273-1-mike.rudenko@gmail.com>\n\t<87y12mvqt7.fsf@gmail.com>\n\t<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>\n\t<172929040031.877857.7799971285577062955@ping.linuxembedded.co.uk>\n\t<87sesq7u1o.fsf@gmail.com>\n\t<172944560675.769772.2708999939540996047@ping.linuxembedded.co.uk>","User-agent":"mu4e 1.10.8; emacs 29.4.50","From":"Mikhail Rudenko ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","Date":"Mon, 21 Oct 2024 18:08:56 +0300","In-reply-to":"<172944560675.769772.2708999939540996047@ping.linuxembedded.co.uk>","Message-ID":"<874j557a0k.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31861,"web_url":"https://patchwork.libcamera.org/comment/31861/","msgid":"<172952523040.3353069.15098135296036172855@ping.linuxembedded.co.uk>","date":"2024-10-21T15:40:30","subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Mikhail Rudenko (2024-10-21 16:08:56)\n> \n> On 2024-10-20 at 18:33 +01, Kieran Bingham wrote:\n> \n> > Quoting Mikhail Rudenko (2024-10-20 14:39:45)\n> >> Hi Kieran,\n> >>\n> >> On 2024-10-18 at 23:26 +01, Kieran Bingham wrote:\n> >>\n> >> > Hi Mikhail,\n> >> >\n> >> > Quoting Kieran Bingham (2024-10-17 14:35:40)\n> >> >> Hi Mikhail,\n> >> >>\n> >> >> Quoting Mikhail Rudenko (2024-10-17 13:47:04)\n> >> >> > The chart from camshark (see attachment).\n> >> >> >\n> >> >>\n> >> >> That looks like a good result indeed!\n> >> >>\n> >> >> I'll test out the patches.\n> >> >\n> >> > I've just tried this out - and it seems to work well on the IMX283 I\n> >> > have - but caused quite noticible AnalogueGain oscillations on the\n> >> > IMX335 ... I would 'bet' that's not the fault of this series - but the\n> >> > fact that we don't have per-sensor delayed-controls set up correctly\n> >> > which I already know about - but I haven't seen that get fixed up yet.\n> >>\n> >> I did a few more tests myself (I use OV4689 btw), and also observed\n> >> analogue gain oscillations on darker scenes when AGC tries to steer the\n> >> gain above 1.0. It looks like the hardcoded gain delay value of 1 is\n> >> wrong at least for my sensor. When I increased it to 2, gain\n> >> oscillations were gone. I have also tweaked a few things here and there\n> >> and will send v2 soon.\n> >>\n> >> > I think your series probably highlights the fault that already exists...\n> >>\n> >> I feel like we have reached the moment when we should switch from the\n> >> delays hardcoded in the pipeline handler to sensor specific values like\n> >> rpi does. I could try doing that, but in a separate series. What do you\n> >> think?\n> >\n> > Oh - absolutely. If it's something you're willing to work on - I think\n> > that would be a massive help. Indeed, I think that's a separate series.\n> \n> I'd like to give it a try. Am I right that adding\n> \n> virtual void getDelays(int &exposureDelay, int &gainDelay, int &vblankDelay, int &hblankDelay)\n\nYes, quite likely. I don't know what the plumbing will look like yet,\nand maybe it would help to use something more structured than a series\nof int references, but that's what's needed somewhere...\n\n> to CameraSensorHelper returning generic delays, then overriding it for\n> sensors where we know the exact delays is a valid approach? Also, why do\n> we have both CamHelper and CameraSensorHelper, with former being\n> significantly more featureful, but all the IPAs except rpi using the\n> latter?\n\nBecause Raspberry Pi create their own IPA - which doesn't use the\nCameraSensorHelpers - because they are not as featureful ... and all the\nother IPAs can not use the Raspberry Pi helpers - because they are in\nthe Raspberry Pi IPA instead of common code ... and no one has yet tried\nto align the libipa code until now.\n\nUltimately - Making sure that the helpers in libipa can be grown in a\nway that Raspberry Pi can also use them will then mean that we only need\nto have *one* location for all the common camera sensor specific\nhelpers.\n\n--\nKieran\n\n\n> \n> --\n> Best regards,\n> Mikhail","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6A20C32A3\n\tfor ;\n\tMon, 21 Oct 2024 15:40:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 433E065392;\n\tMon, 21 Oct 2024 17:40:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B06E26538A\n\tfor ;\n\tMon, 21 Oct 2024 17:40:33 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B98513D5;\n\tMon, 21 Oct 2024 17:38:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GhXTW0DS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729525127;\n\tbh=8jW/vr+8xByXmjgXbVsqAiNEJ0yCFqlZVbynLxhtgIQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GhXTW0DSi376zt9qqmqeVpGFyGnB5R/g6XbpQvpc+5RFgjjBkn/RrSrHVolN1ZEaa\n\tmooN65s8ltFtBqzffDNhRGXt1693cRYBGCJsgBI6R1ZyoDSY7s1I64ACl0L25QqYX8\n\tIWAiQ7QqngIbrKzjV3EzJhF+JkdnAbnlPvrQKxgw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<874j557a0k.fsf@gmail.com>","References":"<20241017124613.3853273-1-mike.rudenko@gmail.com>\n\t<87y12mvqt7.fsf@gmail.com>\n\t<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>\n\t<172929040031.877857.7799971285577062955@ping.linuxembedded.co.uk>\n\t<87sesq7u1o.fsf@gmail.com>\n\t<172944560675.769772.2708999939540996047@ping.linuxembedded.co.uk>\n\t<874j557a0k.fsf@gmail.com>","Subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Mikhail Rudenko ","Date":"Mon, 21 Oct 2024 16:40:30 +0100","Message-ID":"<172952523040.3353069.15098135296036172855@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31862,"web_url":"https://patchwork.libcamera.org/comment/31862/","msgid":"<20241021154422.GO2712@pendragon.ideasonboard.com>","date":"2024-10-21T15:44:22","subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Oct 21, 2024 at 04:40:30PM +0100, Kieran Bingham wrote:\n> Quoting Mikhail Rudenko (2024-10-21 16:08:56)\n> > On 2024-10-20 at 18:33 +01, Kieran Bingham wrote:\n> > > Quoting Mikhail Rudenko (2024-10-20 14:39:45)\n> > >> On 2024-10-18 at 23:26 +01, Kieran Bingham wrote:\n> > >> > Quoting Kieran Bingham (2024-10-17 14:35:40)\n> > >> >> Quoting Mikhail Rudenko (2024-10-17 13:47:04)\n> > >> >> > The chart from camshark (see attachment).\n> > >> >> >\n> > >> >>\n> > >> >> That looks like a good result indeed!\n> > >> >>\n> > >> >> I'll test out the patches.\n> > >> >\n> > >> > I've just tried this out - and it seems to work well on the IMX283 I\n> > >> > have - but caused quite noticible AnalogueGain oscillations on the\n> > >> > IMX335 ... I would 'bet' that's not the fault of this series - but the\n> > >> > fact that we don't have per-sensor delayed-controls set up correctly\n> > >> > which I already know about - but I haven't seen that get fixed up yet.\n> > >>\n> > >> I did a few more tests myself (I use OV4689 btw), and also observed\n> > >> analogue gain oscillations on darker scenes when AGC tries to steer the\n> > >> gain above 1.0. It looks like the hardcoded gain delay value of 1 is\n> > >> wrong at least for my sensor. When I increased it to 2, gain\n> > >> oscillations were gone. I have also tweaked a few things here and there\n> > >> and will send v2 soon.\n> > >>\n> > >> > I think your series probably highlights the fault that already exists...\n> > >>\n> > >> I feel like we have reached the moment when we should switch from the\n> > >> delays hardcoded in the pipeline handler to sensor specific values like\n> > >> rpi does. I could try doing that, but in a separate series. What do you\n> > >> think?\n> > >\n> > > Oh - absolutely. If it's something you're willing to work on - I think\n> > > that would be a massive help. Indeed, I think that's a separate series.\n> > \n> > I'd like to give it a try. Am I right that adding\n> > \n> > virtual void getDelays(int &exposureDelay, int &gainDelay, int &vblankDelay, int &hblankDelay)\n> \n> Yes, quite likely. I don't know what the plumbing will look like yet,\n> and maybe it would help to use something more structured than a series\n> of int references, but that's what's needed somewhere...\n\nA map of controls to delay values maybe.\n\n> > to CameraSensorHelper returning generic delays, then overriding it for\n> > sensors where we know the exact delays is a valid approach? Also, why do\n> > we have both CamHelper and CameraSensorHelper, with former being\n> > significantly more featureful, but all the IPAs except rpi using the\n> > latter?\n> \n> Because Raspberry Pi create their own IPA - which doesn't use the\n> CameraSensorHelpers - because they are not as featureful ... and all the\n> other IPAs can not use the Raspberry Pi helpers - because they are in\n> the Raspberry Pi IPA instead of common code ... and no one has yet tried\n> to align the libipa code until now.\n\nIt's also because the RPi IPA predates CameraSensorHelper if I recall\ncorrectly.\n\n> Ultimately - Making sure that the helpers in libipa can be grown in a\n> way that Raspberry Pi can also use them will then mean that we only need\n> to have *one* location for all the common camera sensor specific\n> helpers.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EE51BD808\n\tfor ;\n\tMon, 21 Oct 2024 15:44:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F86265392;\n\tMon, 21 Oct 2024 17:44:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FEAB6538A\n\tfor ;\n\tMon, 21 Oct 2024 17:44:28 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E9FE3D5;\n\tMon, 21 Oct 2024 17:42:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wXJl9De8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729525362;\n\tbh=48I+cbMy4Ji2s/WsllDlco/MfCTMzQf9z+xp1Yo4cA8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wXJl9De88VFJiyAu6xMMpzL5XTIDxar27EVzpgcB4z8XCkD3UA8QR5XfhcMF1aBvx\n\t4EfsIZAmUnwscxSwTv4hhq9JZ2Of37X5xMYhwCM45BLML7M14Rl8+TZCbMXLePmCOV\n\tyM23a7DyNX9L3c2XzmlaZ3zCc/rN87IGgobITHck=","Date":"Mon, 21 Oct 2024 18:44:22 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Mikhail Rudenko ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","Message-ID":"<20241021154422.GO2712@pendragon.ideasonboard.com>","References":"<20241017124613.3853273-1-mike.rudenko@gmail.com>\n\t<87y12mvqt7.fsf@gmail.com>\n\t<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>\n\t<172929040031.877857.7799971285577062955@ping.linuxembedded.co.uk>\n\t<87sesq7u1o.fsf@gmail.com>\n\t<172944560675.769772.2708999939540996047@ping.linuxembedded.co.uk>\n\t<874j557a0k.fsf@gmail.com>\n\t<172952523040.3353069.15098135296036172855@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<172952523040.3353069.15098135296036172855@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31863,"web_url":"https://patchwork.libcamera.org/comment/31863/","msgid":"<87wmi15tvz.fsf@gmail.com>","date":"2024-10-21T15:51:48","subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/people/146/","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"content":"On 2024-10-21 at 18:44 +03, Laurent Pinchart wrote:\n\n> On Mon, Oct 21, 2024 at 04:40:30PM +0100, Kieran Bingham wrote:\n>> Quoting Mikhail Rudenko (2024-10-21 16:08:56)\n>> > On 2024-10-20 at 18:33 +01, Kieran Bingham wrote:\n>> > > Quoting Mikhail Rudenko (2024-10-20 14:39:45)\n>> > >> On 2024-10-18 at 23:26 +01, Kieran Bingham wrote:\n>> > >> > Quoting Kieran Bingham (2024-10-17 14:35:40)\n>> > >> >> Quoting Mikhail Rudenko (2024-10-17 13:47:04)\n>> > >> >> > The chart from camshark (see attachment).\n>> > >> >> >\n>> > >> >>\n>> > >> >> That looks like a good result indeed!\n>> > >> >>\n>> > >> >> I'll test out the patches.\n>> > >> >\n>> > >> > I've just tried this out - and it seems to work well on the IMX283 I\n>> > >> > have - but caused quite noticible AnalogueGain oscillations on the\n>> > >> > IMX335 ... I would 'bet' that's not the fault of this series - but the\n>> > >> > fact that we don't have per-sensor delayed-controls set up correctly\n>> > >> > which I already know about - but I haven't seen that get fixed up yet.\n>> > >>\n>> > >> I did a few more tests myself (I use OV4689 btw), and also observed\n>> > >> analogue gain oscillations on darker scenes when AGC tries to steer the\n>> > >> gain above 1.0. It looks like the hardcoded gain delay value of 1 is\n>> > >> wrong at least for my sensor. When I increased it to 2, gain\n>> > >> oscillations were gone. I have also tweaked a few things here and there\n>> > >> and will send v2 soon.\n>> > >>\n>> > >> > I think your series probably highlights the fault that already exists...\n>> > >>\n>> > >> I feel like we have reached the moment when we should switch from the\n>> > >> delays hardcoded in the pipeline handler to sensor specific values like\n>> > >> rpi does. I could try doing that, but in a separate series. What do you\n>> > >> think?\n>> > >\n>> > > Oh - absolutely. If it's something you're willing to work on - I think\n>> > > that would be a massive help. Indeed, I think that's a separate series.\n>> >\n>> > I'd like to give it a try. Am I right that adding\n>> >\n>> > virtual void getDelays(int &exposureDelay, int &gainDelay, int &vblankDelay, int &hblankDelay)\n>>\n>> Yes, quite likely. I don't know what the plumbing will look like yet,\n>> and maybe it would help to use something more structured than a series\n>> of int references, but that's what's needed somewhere...\n>\n> A map of controls to delay values maybe.\n\nThe \"series of int references\" is what CamHelper currently does, so I\nthought it could be a starting point. A map sounds more reasonable,\nyes. I'll try to get an RFC ready this week.\n\n>> > to CameraSensorHelper returning generic delays, then overriding it for\n>> > sensors where we know the exact delays is a valid approach? Also, why do\n>> > we have both CamHelper and CameraSensorHelper, with former being\n>> > significantly more featureful, but all the IPAs except rpi using the\n>> > latter?\n>>\n>> Because Raspberry Pi create their own IPA - which doesn't use the\n>> CameraSensorHelpers - because they are not as featureful ... and all the\n>> other IPAs can not use the Raspberry Pi helpers - because they are in\n>> the Raspberry Pi IPA instead of common code ... and no one has yet tried\n>> to align the libipa code until now.\n>\n> It's also because the RPi IPA predates CameraSensorHelper if I recall\n> correctly.\n>\n>> Ultimately - Making sure that the helpers in libipa can be grown in a\n>> way that Raspberry Pi can also use them will then mean that we only need\n>> to have *one* location for all the common camera sensor specific\n>> helpers.\n\nI see, thanks. I'll stick to growing CameraSensorHelper as needed for\nnow.\n\n--\nBest regards,\nMikhail","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05133C32A3\n\tfor ;\n\tMon, 21 Oct 2024 15:59:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C642265392;\n\tMon, 21 Oct 2024 17:59:49 +0200 (CEST)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 126816538A\n\tfor ;\n\tMon, 21 Oct 2024 17:59:48 +0200 (CEST)","by mail-lf1-x12e.google.com with SMTP id\n\t2adb3069b0e04-539fe76e802so5321538e87.1\n\tfor ;\n\tMon, 21 Oct 2024 08:59:47 -0700 (PDT)","from razdolb (static.40.223.216.95.clients.your-server.de.\n\t[95.216.223.40]) by smtp.gmail.com with ESMTPSA id\n\t2adb3069b0e04-53a223e5951sm514676e87.58.2024.10.21.08.59.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Oct 2024 08:59:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WK6F1sjG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1729526387; x=1730131187;\n\tdarn=lists.libcamera.org; \n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:from:to:cc:subject:date:message-id:reply-to;\n\tbh=LFp9Ei2S6KbynSpSefV0vaWNqx2UoxRr18OiVq1pT4A=;\n\tb=WK6F1sjGT6PBkEWzsm1oa6Rs/rKmuu53bDgwafiBJdJrRkCOXimJHpjMQq3qUkmNIT\n\t5SDs4yn3TsU3CjkWUReIL5gn6CWgHthmR9Cfg2Ns9QfMiRehk+4ZXO1GaTCuzSKkq5vT\n\tOjXngkQIHkKAeT5/z7uBvAxVvM36UmkRv6UAI9AN6/IMXQztM5HV1ll0mJiw9MODrt+o\n\tgy/A2UTyN0/48Jc893TrLgbyg8OLudCxE/8TPVrp9Tr3DJXfgqQeXcueeYioHz8WTrNQ\n\tFmghqEUOed1JBHmCrskW6iZLxO/kg+8yHCs18FwV4WArrmdkosH3E3lcb8eozk1Z/hNJ\n\tAfRA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729526387; x=1730131187;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=LFp9Ei2S6KbynSpSefV0vaWNqx2UoxRr18OiVq1pT4A=;\n\tb=pR1Zi0xILd1wNA8ezRNqYeBPMu9OrCa+IWLasM2usP4qCrZr6E9GukgglERdaYYjzV\n\tP/UJtDr+IAUCpc7W+NS6JBDRMrelgA8USLMJvb8nwBlrFBRnqNXJltFJLDilLwxL0ogG\n\taq7axncp1InrU86WMjJiHsNQolW0uIlfFhAHFTTLliloWaij19ilp/dbyGwPkRa/K++a\n\tI2v/Qos/dRYPRB6u04nsegvbGv97+tzKL9aDpS9dp2L7OIBiZNdeLF5KmIpfEFYt0h22\n\tN7rstSJwZW4IoFcAzZiKXInvFb4yKXCxrxNQv3huIv+fDSjjE0TLnTHn6bhsZXNXnrlx\n\t1F1A==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCV2ypxw0ZfFfmrp86NLuFTKohtIitGSEl99p5IJVNmTbEU761+TCj4HY5UzcjgCJq362uzh9QPogVXzn3r/uqk=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwsPTFYRw0sqTuirZOn8hJdfdSeGE2Ds5+p1dOqJCIdeKZJ+9Zw\n\tPI+D5ubvjHe5dNHwU+mALszRnbHV6ieXiqytdO5LqAX/UMmAyMXIYEOve9jV","X-Google-Smtp-Source":"AGHT+IHmUHEiRvZBNS5shtdpiSZzzMAxejODeKLtUlWuQDTsCP60/rdAa/XxRuYPDNwdbY5KiRMsiQ==","X-Received":"by 2002:a05:6512:1290:b0:539:918c:5124 with SMTP id\n\t2adb3069b0e04-53a154b123amr5987351e87.31.1729526386700; \n\tMon, 21 Oct 2024 08:59:46 -0700 (PDT)","References":"<20241017124613.3853273-1-mike.rudenko@gmail.com>\n\t<87y12mvqt7.fsf@gmail.com>\n\t<172917214085.877857.18068855398483986446@ping.linuxembedded.co.uk>\n\t<172929040031.877857.7799971285577062955@ping.linuxembedded.co.uk>\n\t<87sesq7u1o.fsf@gmail.com>\n\t<172944560675.769772.2708999939540996047@ping.linuxembedded.co.uk>\n\t<874j557a0k.fsf@gmail.com>\n\t<172952523040.3353069.15098135296036172855@ping.linuxembedded.co.uk>\n\t<20241021154422.GO2712@pendragon.ideasonboard.com>","User-agent":"mu4e 1.10.8; emacs 29.4.50","From":"Mikhail Rudenko ","To":"Laurent Pinchart ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/3] Reduce rkisp1 flicker on first start","Date":"Mon, 21 Oct 2024 18:51:48 +0300","In-reply-to":"<20241021154422.GO2712@pendragon.ideasonboard.com>","Message-ID":"<87wmi15tvz.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]