[{"id":31843,"web_url":"https://patchwork.libcamera.org/comment/31843/","msgid":"","date":"2024-10-21T03:26:53","subject":"Re: [PATCH 0/4] libipa: Initialize FrameContext with ActiveState","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Oct 16, 2024 at 07:03:41PM +0200, Jacopo Mondi wrote:\n> This series allows IPA modules to override the FrameContext initialization\n> to allow them to be default-initialized with the most recent algorithms' state\n> provided in ActiveState.\n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> \n> My use case is explained in detail in commit message 4/4 but I wonder if this\n> is useful for Paul's algorithm seeding work as well.\n\nUnfortunately my algorithm seeding work is for seeding the algorithm\nbetween different cameras, which potentially have different sensors, so\nwe have to go via controls :/\n\n> Jacopo Mondi (4):\n> libipa: FrameContext: Move init() to FrameContext\n> libipa: FCQueue: Make sure FrameContext#0 is initialized\n> libipa: FCQueue: Initialize FrameContext with activeState\n> ipa: rkisp1: Initialize FrameContext.agc.meteringMode\n> \n> src/ipa/ipu3/ipa_context.h | 2 +-\n> src/ipa/ipu3/ipu3.cpp | 9 ++++--\n> src/ipa/libipa/fc_queue.cpp | 20 +++++++++++--\n> src/ipa/libipa/fc_queue.h | 48 ++++++++++++++++++++++++-------\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 ++\n> src/ipa/rkisp1/ipa_context.cpp | 11 +++++++\n> src/ipa/rkisp1/ipa_context.h | 5 +++-\n> src/ipa/rkisp1/rkisp1.cpp | 12 +++++---\n> src/ipa/simple/ipa_context.h | 2 +-\n> src/ipa/simple/soft_simple.cpp | 9 ++++--\n> 10 files changed, 93 insertions(+), 27 deletions(-)\n> \n> --\n> 2.47.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E207CC3304\n\tfor ;\n\tMon, 21 Oct 2024 03:27:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65B3965391;\n\tMon, 21 Oct 2024 05:27:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8441F60395\n\tfor ;\n\tMon, 21 Oct 2024 05:27:00 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:6758:2ada:48a8:78df])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07DFC74A;\n\tMon, 21 Oct 2024 05:25:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"imQDgd5q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729481115;\n\tbh=KQe4EOTK7od3HK7aiVHAD+jUIZ48Et5HTDRU1opvzIc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=imQDgd5qp69sv3dSlFSchj5pSDO8J41XCSNls8GAJ9BLjpt9wnqTq5yn6hH+XnaVO\n\tL3KiaWiCZB9oHfIdZWBqLsjoO0qHvJaVry1A5YWBRfUENyEakUgYX2H3IMKh3dqOK0\n\tRg2ZWBlXyDyIlVSyFSn6IhS5Bf74aWIk4vly2wik=","Date":"Mon, 21 Oct 2024 12:26:53 +0900","From":"Paul Elder ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/4] libipa: Initialize FrameContext with ActiveState","Message-ID":"","References":"<20241016170348.715993-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20241016170348.715993-1-jacopo.mondi@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]