[{"id":31743,"web_url":"https://patchwork.libcamera.org/comment/31743/","msgid":"<20241015102142.GC5682@pendragon.ideasonboard.com>","date":"2024-10-15T10:21:42","subject":"Re: [RFC 0/4] libcamera: Implement YamlEmitter","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Oct 14, 2024 at 11:59:32AM +0200, Jacopo Mondi wrote:\n> This series collects Paul's\n> [PATCH 0/2] libcamera: Add support for dumping capture script\n\nPaul has sent a v2, and has received review comments. I suppose you\ndon't plan to address them. Paul, will you send a v3 for Jacopo to\nrebase this series on ?\n\n> and implements a YamlEmitter class on top, replacing the usage of raw\n> output streams with the YamlEmitter class.\n> \n> RFC mostly to collect opinions on the interface.\n> Documentation mostly to be done, rough edges here and there :)\n> \n> Jacopo Mondi (2):\n> libcamera: Implement YamlEmitter\n> libcamera: pipeline_handler: Use YamlEmitter\n> \n> Paul Elder (2):\n> pipeline: Add support for dumping capture script and metadata\n> apps: cam: Add support for loading configuration from capture script\n> \n> include/libcamera/internal/camera.h | 3 +\n> include/libcamera/internal/meson.build | 1 +\n> include/libcamera/internal/pipeline_handler.h | 23 +\n> include/libcamera/internal/yaml_emitter.h | 172 +++++++\n> src/apps/cam/camera_session.cpp | 22 +-\n> src/apps/cam/capture_script.cpp | 164 +++++++\n> src/apps/cam/capture_script.h | 8 +\n> src/libcamera/camera.cpp | 13 +\n> src/libcamera/meson.build | 1 +\n> src/libcamera/pipeline_handler.cpp | 87 ++++\n> src/libcamera/yaml_emitter.cpp | 427 ++++++++++++++++++\n> 11 files changed, 911 insertions(+), 10 deletions(-)\n> create mode 100644 include/libcamera/internal/yaml_emitter.h\n> create mode 100644 src/libcamera/yaml_emitter.cpp","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C092C326C\n\tfor ;\n\tTue, 15 Oct 2024 10:21:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C8ED65382;\n\tTue, 15 Oct 2024 12:21:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E6C460537\n\tfor ;\n\tTue, 15 Oct 2024 12:21:45 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [185.143.39.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BBC82A27;\n\tTue, 15 Oct 2024 12:20:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Tqi6CtDI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728987603;\n\tbh=PCbNrh7iv9zkkMXYiGO0FCdXS2s1QLA1BXpIhSEfdio=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Tqi6CtDIfa0bDH/hv+m9j5R6VJwCIrJDv9jTAZiQJUwXsGi5xb9/yGHzGd/74WH9Y\n\ty/A1DXGpj7dKU85FWdG9MG3xXILAc8+nLPhLbgL1IxjrQDO8IHYwXFinXtpLTmdYTD\n\tfaERFyXyegR2FJfdRkBJGqSQZJMDDeLyqi92xzn8=","Date":"Tue, 15 Oct 2024 13:21:42 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org,\n\tPaul Elder ","Subject":"Re: [RFC 0/4] libcamera: Implement YamlEmitter","Message-ID":"<20241015102142.GC5682@pendragon.ideasonboard.com>","References":"<20241014095937.24924-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241014095937.24924-1-jacopo.mondi@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]