[{"id":31714,"web_url":"https://patchwork.libcamera.org/comment/31714/","msgid":"","date":"2024-10-11T10:47:06","subject":"Re: [PATCH 0/3] libcamera: rkisp1: sensorConfig assorted fixes","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Umang,\n\nOn Fri, Oct 11, 2024 at 02:52:19PM GMT, Umang Jain wrote:\n> Assorted fixes for rkisp1, mainly pertaining to sensor configuration\n> plumbing.\n>\n> 1/3 fixes the passing of sensorConfig by using const reference.\n> 2/3 fixes a logical error around sensorConfig and sensor format\n> 3/3 fixes mis-ordering of forward declaration\n\nThanks for the quick fixes\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Umang Jain (3):\n> libcamera: rkisp1: Use const reference for sensor configuration\n> libcamera: rkisp1: Rectify SensorConfiguration check\n> libcamera: rkisp1: Maintain alphabetical order of forward declarations\n>\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 ++--\n> src/libcamera/pipeline/rkisp1/rkisp1_path.h | 4 ++--\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n>\n> --\n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A468C3260\n\tfor ;\n\tFri, 11 Oct 2024 10:47:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2D1D618C3;\n\tFri, 11 Oct 2024 12:47:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F153618C3\n\tfor ;\n\tFri, 11 Oct 2024 12:47:11 +0200 (CEST)","from ideasonboard.com (unknown [5.77.68.122])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 565DD220;\n\tFri, 11 Oct 2024 12:45:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eg0UUBmR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728643532;\n\tbh=oiD2lVQdYb9LanVuRsLOi9nr32mZcb23x5P5MqGHOX0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eg0UUBmRQyXSOOcPP2YnicSJsql2JN5+dbPZOnA2hzREJHF3hK45K5TgYkExY8wp5\n\t5lnYxrWbxr6VXVkmok61I6m2q/Aw9beCi29VF0VIXqVHUWXXkfh0BcE3NofBW9yP8w\n\tbfLJSTboAV5wtvnO73N/CuiLvQl0mI8UDbMI3F4E=","Date":"Fri, 11 Oct 2024 12:47:06 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ,\n\tKieran Bingham , \n\tLaurent Pinchart ,\n\tStefan Klug ","Subject":"Re: [PATCH 0/3] libcamera: rkisp1: sensorConfig assorted fixes","Message-ID":"","References":"<20241011092222.537322-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241011092222.537322-1-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]