[{"id":31705,"web_url":"https://patchwork.libcamera.org/comment/31705/","msgid":"<20241010200528.GJ32107@pendragon.ideasonboard.com>","date":"2024-10-10T20:05:28","subject":"Re: [PATCH 0/3] libcamera: controls: Add namespace to ControlId","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Oct 10, 2024 at 05:47:16PM +0900, Paul Elder wrote:\n> This series adds vendor (aka namespace) information to ControlId so that\n> it can be queried by appliations, and presumably used to organize the UI\n> with relation to control namespaces.\n> \n> The word \"vendor\" is used instead of namespace, as it is what shows up\n> in control_ranges.yaml, and also since it doesn't conflict with the C++\n> keyword.\n\nI was expecting \"namespace\" (or \"ns\") instead of \"vendor\", but \"vendor\"\nmakes sense, especially as it avoids the keyword clash.\n\n> Paul Elder (3):\n> libcamera: controls: Add vendor information to ControlId\n> apps: cam: Print control vendor information when listing controls\n> py: Add bindings for ControlId vendor information\n> \n> include/libcamera/controls.h | 8 ++++++--\n> src/apps/cam/camera_session.cpp | 7 +++++--\n> src/libcamera/control_ids.cpp.in | 4 ++--\n> src/libcamera/control_serializer.cpp | 2 +-\n> src/libcamera/controls.cpp | 16 +++++++++++++---\n> src/libcamera/v4l2_device.cpp | 2 +-\n> src/py/libcamera/py_main.cpp | 1 +\n> 7 files changed, 29 insertions(+), 11 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B961C32EA\n\tfor ;\n\tThu, 10 Oct 2024 20:05:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0593B6536B;\n\tThu, 10 Oct 2024 22:05:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F06586353A\n\tfor ;\n\tThu, 10 Oct 2024 22:05:32 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.230.15])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6389D4D4;\n\tThu, 10 Oct 2024 22:03:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LtZ8MoS0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728590634;\n\tbh=d1iLQ83Q4wCBzpIeHovH9VoTxFHRCiRRkwg8pW8fBK8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LtZ8MoS0O47Aq5hsdwAoMUSe2MrO/40X3NCQFkAEUffnuaMs5zCJ8Dv8Bdyd+y6S+\n\t3+y1Lf0pMyFUPflC/JUt4o8xMPt1wcEsSNv2ojG7AiinEdUtamS4T+3gkDaYMmyt0Q\n\t097bZSXROzzAMeGzp6zZ6LjcjX8Efsk82yYjmnE8=","Date":"Thu, 10 Oct 2024 23:05:28 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/3] libcamera: controls: Add namespace to ControlId","Message-ID":"<20241010200528.GJ32107@pendragon.ideasonboard.com>","References":"<20241010084719.712485-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241010084719.712485-1-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31759,"web_url":"https://patchwork.libcamera.org/comment/31759/","msgid":"","date":"2024-10-16T11:22:42","subject":"Re: [PATCH 0/3] libcamera: controls: Add namespace to ControlId","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Oct 10, 2024 at 11:05:28PM +0300, Laurent Pinchart wrote:\n> On Thu, Oct 10, 2024 at 05:47:16PM +0900, Paul Elder wrote:\n> > This series adds vendor (aka namespace) information to ControlId so that\n> > it can be queried by appliations, and presumably used to organize the UI\n> > with relation to control namespaces.\n> > \n> > The word \"vendor\" is used instead of namespace, as it is what shows up\n> > in control_ranges.yaml, and also since it doesn't conflict with the C++\n> > keyword.\n> \n> I was expecting \"namespace\" (or \"ns\") instead of \"vendor\", but \"vendor\"\n> makes sense, especially as it avoids the keyword clash.\n\nI was expecting that too but namespace clashes and ns is too short and\nnondescriptive so I went with vendor since that's what was already used.\n\n\nPaul\n\n> \n> > Paul Elder (3):\n> > libcamera: controls: Add vendor information to ControlId\n> > apps: cam: Print control vendor information when listing controls\n> > py: Add bindings for ControlId vendor information\n> > \n> > include/libcamera/controls.h | 8 ++++++--\n> > src/apps/cam/camera_session.cpp | 7 +++++--\n> > src/libcamera/control_ids.cpp.in | 4 ++--\n> > src/libcamera/control_serializer.cpp | 2 +-\n> > src/libcamera/controls.cpp | 16 +++++++++++++---\n> > src/libcamera/v4l2_device.cpp | 2 +-\n> > src/py/libcamera/py_main.cpp | 1 +\n> > 7 files changed, 29 insertions(+), 11 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B26C9C326C\n\tfor ;\n\tWed, 16 Oct 2024 11:22:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67BDE65384;\n\tWed, 16 Oct 2024 13:22:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BC0A6537E\n\tfor ;\n\tWed, 16 Oct 2024 13:22:49 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:b5b2:fcb4:385e:af78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFB28A2F;\n\tWed, 16 Oct 2024 13:21:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jrNFn/eb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729077666;\n\tbh=UBgU9sq6yqeZbIPNOZ0OXFw7nCeHH8qIv3SBWmTtugw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jrNFn/eblfdk0xomF6plaaxeBrYiTMIpfCO1dYgJOusm8FiFSbhTKNvmTY58JoO4/\n\tBPQmNn4ZU+n/qDVNugGCFjHA4Bn7WxWdjnwXBimeXEpX6Psswd4wek318EtGk44fzX\n\tSCytMV+SjQVkpfyugu4Ni9KNGdGgynxmnidBgGNQ=","Date":"Wed, 16 Oct 2024 20:22:42 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 0/3] libcamera: controls: Add namespace to ControlId","Message-ID":"","References":"<20241010084719.712485-1-paul.elder@ideasonboard.com>\n\t<20241010200528.GJ32107@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20241010200528.GJ32107@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]