{"id":21568,"url":"https://patchwork.libcamera.org/api/covers/21568/?format=json","web_url":"https://patchwork.libcamera.org/cover/21568/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241009193318.2394762-1-mzamazal@redhat.com>","date":"2024-10-09T19:33:15","name":"[v2,0/2] Add contrast control to software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"mbox":"https://patchwork.libcamera.org/cover/21568/mbox/","series":[{"id":4677,"url":"https://patchwork.libcamera.org/api/series/4677/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4677","date":"2024-10-09T19:33:15","name":"Add contrast control to software ISP","version":2,"mbox":"https://patchwork.libcamera.org/series/4677/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21568/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 899C0C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  9 Oct 2024 19:33:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5742965369;\n\tWed,  9 Oct 2024 21:33:31 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FD9B618C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  9 Oct 2024 21:33:29 +0200 (CEST)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-508-B7m49UxvNhG53zPmnKe1HQ-1;\n\tWed, 09 Oct 2024 15:33:25 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 7995B1956080; Wed,  9 Oct 2024 19:33:24 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.78])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 0A56D300018D; Wed,  9 Oct 2024 19:33:22 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"TR5ueRr6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1728502408;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=XDqeDS8yIb74lJw1A3ADyOhomSBb20hZQdGmnHktRyQ=;\n\tb=TR5ueRr6rQ3cEznu4hSoMZtBZR7+xqUc4lMvTm+O5ffqdUbPYxOABTeCzjzriFB2BCANMS\n\t6aEnNDi9F7aRUzjs935CjmzqooneKD33xX8Pc8nf4Gj1ME9si/0AffCmyqmf1N6KZo45xt\n\tggkVB+sDXgiDeR3O9zfXx/yJkF1niAU=","X-MC-Unique":"B7m49UxvNhG53zPmnKe1HQ-1","From":"Milan Zamazal <mzamazal@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"[PATCH v2 0/2] Add contrast control to software ISP","Date":"Wed,  9 Oct 2024 21:33:15 +0200","Message-ID":"<20241009193318.2394762-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"These are preview patches adding support to software ISP for modifying\nimage processing parameters in runtime.  They depend on patches not yet\nmerged and are likely to be modified based on how those patches evolve.\nThey serve as an illustration and proof of concept how the\nimplementation of software ISP controls can be done.\n\nThe first software ISP image control, implemented here, is contrast.  It\nis simple to implement, doesn’t slow down image processing and can\nenhance the image easily.\n\nChanges in v2:\n- Rebased on the merged version of software ISP refactoring.\n- Control initialization moved from toplevel to an algorithm.\n\nMilan Zamazal (2):\n  libcamera: software_isp: Add contrast algorithm\n  libcamera: software_isp: Add contrast control\n\n .../internal/software_isp/software_isp.h      |  3 +-\n include/libcamera/ipa/soft.mojom              |  2 +-\n src/ipa/simple/algorithms/contrast.cpp        | 52 +++++++++++++++++++\n src/ipa/simple/algorithms/contrast.h          | 39 ++++++++++++++\n src/ipa/simple/algorithms/lut.cpp             | 20 +++++--\n src/ipa/simple/algorithms/meson.build         |  1 +\n src/ipa/simple/data/uncalibrated.yaml         |  1 +\n src/ipa/simple/ipa_context.h                  |  8 +++\n src/ipa/simple/soft_simple.cpp                | 11 ++--\n src/libcamera/pipeline/simple/simple.cpp      |  2 +-\n src/libcamera/software_isp/software_isp.cpp   |  8 ++-\n 11 files changed, 134 insertions(+), 13 deletions(-)\n create mode 100644 src/ipa/simple/algorithms/contrast.cpp\n create mode 100644 src/ipa/simple/algorithms/contrast.h"}