[{"id":31617,"web_url":"https://patchwork.libcamera.org/comment/31617/","msgid":"","date":"2024-10-08T11:30:31","subject":"Re: [PATCH v3 0/7] Raspberry Pi: Add controls::rpi::ScalerCrops","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nPatches 1/7 and 7/7 in this series need one more R-B tag then would be\nready to merge. Would somebody be able to have a look at them please?\n\nThanks!\nNaush\n\n\nOn Thu, 3 Oct 2024 at 08:53, Naushir Patuck wrote:\n>\n> Hi,\n>\n> Version 3 of this work is functionally identical to v2, but with the following\n> minor changes:\n>\n> - Update the control documentation to reflect the priority of rpi::ScalerCrops\n> over the ScalerCrop control.\n> - Remove the default constructor of CropParams, requiring replacing cropParams_[n]\n> accessor with cropsParams_.at(n) in the pipeline handler code.\n>\n> Thanks,\n> Naush\n>\n> Naushir Patuck (7):\n> controls: rpi: Add a vendor rpi::ScalerCrops control\n> pipeline: rpi: Remove CameraData::scalerCrop_\n> pipeline: rpi: Pass crop rectangle as a parameter to\n> platformSetIspCrop()\n> pipeline: rpi: Introduce CameraData::CropParams\n> pipeline: rpi: Track which ISP output is configured for a stream\n> pipeline: rpi: Pass ISP output index into platformSetIspCrop()\n> pipeline: rpi: Handler controls::rpi::ScalerCrops\n>\n> src/ipa/rpi/common/ipa_base.cpp | 14 +++\n> src/libcamera/control_ids_rpi.yaml | 25 +++++\n> .../pipeline/rpi/common/pipeline_base.cpp | 94 +++++++++++++------\n> .../pipeline/rpi/common/pipeline_base.h | 22 ++++-\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 17 +++-\n> 5 files changed, 136 insertions(+), 36 deletions(-)\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6710BE080\n\tfor ;\n\tTue, 8 Oct 2024 11:31:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3A346352E;\n\tTue, 8 Oct 2024 13:31:06 +0200 (CEST)","from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com\n\t[IPv6:2607:f8b0:4864:20::b33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9390618C9\n\tfor ;\n\tTue, 8 Oct 2024 13:31:04 +0200 (CEST)","by mail-yb1-xb33.google.com with SMTP id\n\t3f1490d57ef6-e28f0dd88b3so57541276.0\n\tfor ;\n\tTue, 08 Oct 2024 04:31:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Tzyyz+m0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1728387063; x=1728991863;\n\tdarn=lists.libcamera.org; \n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=8GuFnZIRSHXDf6xZ5SikK4QSdzxEdfhTinrrJDTM9QM=;\n\tb=Tzyyz+m0/T7AEN7vCE8xoHAoLIJFwhisItP4iHxIK5k3fPl7MoI2Kz6rc7vifKTntn\n\teGTrXbeW1JoGWTsD/htcmH+82l5Xo9Y1xm+SlW+F5i2TNROD9HjZEdQ4hvEXRiqjnw1u\n\tOB402cFCg8V7sch05I9v6XACwGgNwf8UyfSOUIyCecHbtEu4zRc+nKgK3OFdyq6vZqfP\n\t6RBA17+OzALPHu3mjJsPkgNRA4qPZZ+pp8kkih/VgCeGLJFkPwfHOqEkh58WiwoPZESs\n\tjew825QV0hLulBsMefBZV9pT7vukETisCM8dliY5sj5OMHfl9HiOvdt+THgVwtALUQmo\n\tJw9Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1728387063; x=1728991863;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=8GuFnZIRSHXDf6xZ5SikK4QSdzxEdfhTinrrJDTM9QM=;\n\tb=UK1SWDU9FKKWOf2wcIAE9bDo5mskVrIuqmAVEh00Mei7aY+F+HnY9m/iy1C0Mp3pWh\n\tPFt4weRGFWFJz0OT9n30xLPCnDXB3J242mr7YA7o2fq1gHaP0FJdXqOdN0invcfI6hDd\n\tCzSYuNElPluSHu5z23TRefDnw4fq8BqFUdPGjhErM9eJTocCpZcM3GgaHntG2O6FUxVZ\n\t0PQoUS+j7AEegqniFTs4WFhED9d+93fGoe9EYBdD2jAJgstJoWv5DrXf/ZP+0Z3NEGys\n\tChtu2Ak88dO4Mw2BX5C25PWZ88Q7tTy0IrHvG51/EQ/PcWdvcRNXao5mKiWXTOsmx5wO\n\tQHzA==","X-Gm-Message-State":"AOJu0Yy2Qbi1c0+wjBSVMKKWinYESdavhZ2Z2s6a0zQjIiMGQutu2tPO\n\tkuQkqN4dugtjsed2d85GCAwvdl/TR6/6TdR6AGLWR6C/N9Vdb/k1cZE4v9EvMjlgFj/88b+m0iH\n\t4OaegNtzVsv+XBNHfUBbplJj7yr3JcTRTuHOU1vXUC41mVryu","X-Google-Smtp-Source":"AGHT+IE7qVCEnNmLUvcK1AcKs8hwJAW65kcor4Hu4TsgvZSVov9CboREdvbv7vaTCJBFqjplvF6IUum5SjYfAqFsqX8=","X-Received":"by 2002:a05:690c:74c1:b0:6e2:1b45:d0a4 with SMTP id\n\t00721157ae682-6e2c730b036mr48825397b3.10.1728387063489;\n\tTue, 08 Oct 2024 04:31:03 -0700 (PDT)","MIME-Version":"1.0","References":"<20241003074720.18882-1-naush@raspberrypi.com>","In-Reply-To":"<20241003074720.18882-1-naush@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 8 Oct 2024 12:30:31 +0100","Message-ID":"","Subject":"Re: [PATCH v3 0/7] Raspberry Pi: Add controls::rpi::ScalerCrops","To":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31760,"web_url":"https://patchwork.libcamera.org/comment/31760/","msgid":"","date":"2024-10-16T11:32:27","subject":"Re: [PATCH v3 0/7] Raspberry Pi: Add controls::rpi::ScalerCrops","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Another gentle ping for the patches below.\n\n\nOn Tue, 8 Oct 2024 at 12:30, Naushir Patuck wrote:\n\n> Hi all,\n>\n> Patches 1/7 and 7/7 in this series need one more R-B tag then would be\n> ready to merge. Would somebody be able to have a look at them please?\n>\n> Thanks!\n> Naush\n>\n>\n> On Thu, 3 Oct 2024 at 08:53, Naushir Patuck wrote:\n> >\n> > Hi,\n> >\n> > Version 3 of this work is functionally identical to v2, but with the\n> following\n> > minor changes:\n> >\n> > - Update the control documentation to reflect the priority of\n> rpi::ScalerCrops\n> > over the ScalerCrop control.\n> > - Remove the default constructor of CropParams, requiring replacing\n> cropParams_[n]\n> > accessor with cropsParams_.at(n) in the pipeline handler code.\n> >\n> > Thanks,\n> > Naush\n> >\n> > Naushir Patuck (7):\n> > controls: rpi: Add a vendor rpi::ScalerCrops control\n> > pipeline: rpi: Remove CameraData::scalerCrop_\n> > pipeline: rpi: Pass crop rectangle as a parameter to\n> > platformSetIspCrop()\n> > pipeline: rpi: Introduce CameraData::CropParams\n> > pipeline: rpi: Track which ISP output is configured for a stream\n> > pipeline: rpi: Pass ISP output index into platformSetIspCrop()\n> > pipeline: rpi: Handler controls::rpi::ScalerCrops\n> >\n> > src/ipa/rpi/common/ipa_base.cpp | 14 +++\n> > src/libcamera/control_ids_rpi.yaml | 25 +++++\n> > .../pipeline/rpi/common/pipeline_base.cpp | 94 +++++++++++++------\n> > .../pipeline/rpi/common/pipeline_base.h | 22 ++++-\n> > src/libcamera/pipeline/rpi/vc4/vc4.cpp | 17 +++-\n> > 5 files changed, 136 insertions(+), 36 deletions(-)\n> >\n> > --\n> > 2.34.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 675B5C32FA\n\tfor ;\n\tWed, 16 Oct 2024 11:33:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C49C65383;\n\tWed, 16 Oct 2024 13:33:06 +0200 (CEST)","from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com\n\t[IPv6:2607:f8b0:4864:20::b34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FF376537E\n\tfor ;\n\tWed, 16 Oct 2024 13:33:04 +0200 (CEST)","by mail-yb1-xb34.google.com with SMTP id\n\t3f1490d57ef6-e2930f12216so476715276.2\n\tfor ;\n\tWed, 16 Oct 2024 04:33:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cQaGLGTM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1729078382; x=1729683182;\n\tdarn=lists.libcamera.org; \n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=eTCXLpiHS3xQXB8dEqM9Hc1oQBlaP+ioabEqG9lS/Mw=;\n\tb=cQaGLGTMsHYEmUCnN3KFl3sKVVgHa4HHJ0pA1nULUtzdkrdkFUnB53k9s7pouleRqj\n\t+hWag5Adt4JI6bEPrS2v4m7C6+NMYJYTm8DngJ8omr6DrsChpjjLTOhefIca52feklTs\n\tQhpj2MXiusVi0RjuRW+0/d/gDf4buX1EZiGjf29pARqyJbRfI8YE8KPGytm54+1L6nvT\n\t1IKrzaQ9A/XmzVa9EE7bQUlFF/VCL4b/lpZgjJ59qttI4Co8+Ey3/K1+ZKYWInWQ2NnQ\n\tgIPh9Zl5j/yktPre0m8ri7/UEtpljlQS9AXg1L83R/mHy5SarCV8MAqEA8cusEv8NkNq\n\t9o8w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729078382; x=1729683182;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=eTCXLpiHS3xQXB8dEqM9Hc1oQBlaP+ioabEqG9lS/Mw=;\n\tb=kKBIRxJvS7wjvQIiJ8DQ1rF5drUW8IXRbxJWtuuF4TZYKUHszQf18327UWc7a83lqS\n\th+sfjiAS99FLMwRDmp0Je662zSdFucIkeHWJMO0BvqA3fvU9jOguNVmgNocPDP0b7vAm\n\tHFhV7BJLb5wespiTBmQqLxUWqbHxP55qgXHyiyqBFkGwg7s832HUGy3SXT/bs433cPu8\n\tTfIrtCdncIm/6yrgimO/LG0KatKCBoLT1KmLGV7gn6s9/SqxPTeILa0lNBFff3Nea39S\n\tIlZnZPJd+ZQ1cIr1rQD2r95l89XtZn4MwPWaNoiYYx0CQO7TSu4TTAl+FofMJxws5g+K\n\tmpvA==","X-Gm-Message-State":"AOJu0YzJkB+g6XHyBQsL2tio/qbDp9u8fE220lGELVaXgqGalMaA84jo\n\t/dfpz7x0ncY6SHK/fLQl3pNCrvGFBbVzm3CxqjEyBSCKMMydMx6OPv8bywnYaC2GLiuKNOXe0cv\n\tMbtpH8hBphYvLiyUCHB+A0GSimxoTSr7NGEwBPekbDzxW6wE/","X-Google-Smtp-Source":"AGHT+IFrSZKo21Lj0+C6h65Oxm6VrDQ6U9jRjUgvs1O9AjJ2wZyuJf0mQC5sw6W6Npe8U1xZo99QR5lMn2WuTvpypXE=","X-Received":"by 2002:a05:690c:f84:b0:6e2:636:d9d1 with SMTP id\n\t00721157ae682-6e3da4fbd36mr7794257b3.0.1729078382374; Wed, 16 Oct 2024\n\t04:33:02 -0700 (PDT)","MIME-Version":"1.0","References":"<20241003074720.18882-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Wed, 16 Oct 2024 12:32:27 +0100","Message-ID":"","Subject":"Re: [PATCH v3 0/7] Raspberry Pi: Add controls::rpi::ScalerCrops","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000c559480624966eb3\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]