{"id":21486,"url":"https://patchwork.libcamera.org/api/covers/21486/?format=json","web_url":"https://patchwork.libcamera.org/cover/21486/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241003074720.18882-1-naush@raspberrypi.com>","date":"2024-10-03T07:47:13","name":"[v3,0/7] Raspberry Pi: Add controls::rpi::ScalerCrops","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/21486/mbox/","series":[{"id":4651,"url":"https://patchwork.libcamera.org/api/series/4651/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4651","date":"2024-10-03T07:47:13","name":"Raspberry Pi: Add controls::rpi::ScalerCrops","version":3,"mbox":"https://patchwork.libcamera.org/series/4651/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21486/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 196D2BD80A\n\tfor ;\n\tThu, 3 Oct 2024 07:53:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE9CA63529;\n\tThu, 3 Oct 2024 09:53:47 +0200 (CEST)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9E5F62C93\n\tfor ;\n\tThu, 3 Oct 2024 09:53:44 +0200 (CEST)","by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-42cb0d0311fso797515e9.1\n\tfor ;\n\tThu, 03 Oct 2024 00:53:44 -0700 (PDT)","from naush-laptop.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42f8025b583sm8740825e9.12.2024.10.03.00.53.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Oct 2024 00:53:43 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Zmpz1MtH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1727942024; x=1728546824;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=xA7huv5rpGgW/QH3pBGLdwJmUR3luxF4NoDtz7+Vxxc=;\n\tb=Zmpz1MtHQl102Bui0Nhn1r0zOUj4StTmkyrUZ36hj78qBBx13Ypm7Ta3ZlMuDya3jP\n\t0xI+4iA5efMpFFYNl+2ItX7n6XWJ1tt0N+qu2DqpUSK+DWisIye7ZSEw6dpaPKA78WDV\n\tpTiF0CkDW3H7gfxTiUvL/cgiapXpa1UE051Fw7Swbiw258Cj7mW96Zbzj0vZotoTRNam\n\t4dFwdQOVCMdZsQCdmZHJVasL+jpHhcZmslBcAsVR7VEKcZRAzuAqPs6hKObWSVa7L1Q0\n\tTAnEhXgAvYzD/dckNJKnuMYwqRIwbT+hTJPr6tkpUqbrrnMJcBoyb3HgfXEjlPTX/EJK\n\tQaMA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727942024; x=1728546824;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=xA7huv5rpGgW/QH3pBGLdwJmUR3luxF4NoDtz7+Vxxc=;\n\tb=o3KNrNMo9+eY3xw3XncbdCURKIwP8YhRQuaceNrNvKPzJR9tG81BlI046rnCP40MBD\n\ttpA35OEiVcCGV8Pa6nktrkL4nxOns2tqbSiwiz5sQRo336XhrqBHDnymE7gwJ4r/GfhF\n\tB2zWI44GO1qL9HFGeyAlrTn9SWCxNxhS1j9GQKSNtiGSS1pTP6CNhpv0gO2hzdV/nsCT\n\tsXM5h6RQljQ73oJQY8p5GZajYa9VrlFw0yKfMPe10JPd7tnViJAvdGidtryZAKBrK6NP\n\t7CeDKlXQRhngOxP62vMJ9tRZAigiVWOiEswbs00CE3AAUTnV6ph1zuoGBQl4Zex7m9ew\n\t5h9Q==","X-Gm-Message-State":"AOJu0Yz48mxvWSVU8WZpu8sNKlW2tu5EvskLYCaDjZOlAVzHtnmuANiI\n\tO/CO5abxtixtHCvI8f9ifwCsmoz/v/Lg5C1dnn6McrZvyjfM3JrayM9lW35ewcxJ0CFaLtf4UlW\n\ta","X-Google-Smtp-Source":"AGHT+IGTfkqDxZeOLvA5ZKX6UteYt7er7LsWDyKujsWwJNofS625o+5f2KiQsY1wCWrNQr4zDJbhIw==","X-Received":"by 2002:a05:600c:3b2a:b0:42c:aeee:80c with SMTP id\n\t5b1f17b1804b1-42f778ffc41mr20879655e9.9.1727942023592; \n\tThu, 03 Oct 2024 00:53:43 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ","Subject":"[PATCH v3 0/7] \tRaspberry Pi: Add controls::rpi::ScalerCrops","Date":"Thu, 3 Oct 2024 08:47:13 +0100","Message-Id":"<20241003074720.18882-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nVersion 3 of this work is functionally identical to v2, but with the following\nminor changes:\n\n- Update the control documentation to reflect the priority of rpi::ScalerCrops\n over the ScalerCrop control.\n- Remove the default constructor of CropParams, requiring replacing cropParams_[n]\n accessor with cropsParams_.at(n) in the pipeline handler code.\n\nThanks,\nNaush\n\nNaushir Patuck (7):\n controls: rpi: Add a vendor rpi::ScalerCrops control\n pipeline: rpi: Remove CameraData::scalerCrop_\n pipeline: rpi: Pass crop rectangle as a parameter to\n platformSetIspCrop()\n pipeline: rpi: Introduce CameraData::CropParams\n pipeline: rpi: Track which ISP output is configured for a stream\n pipeline: rpi: Pass ISP output index into platformSetIspCrop()\n pipeline: rpi: Handler controls::rpi::ScalerCrops\n\n src/ipa/rpi/common/ipa_base.cpp | 14 +++\n src/libcamera/control_ids_rpi.yaml | 25 +++++\n .../pipeline/rpi/common/pipeline_base.cpp | 94 +++++++++++++------\n .../pipeline/rpi/common/pipeline_base.h | 22 ++++-\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 17 +++-\n 5 files changed, 136 insertions(+), 36 deletions(-)"}