{"id":21439,"url":"https://patchwork.libcamera.org/api/covers/21439/?format=json","web_url":"https://patchwork.libcamera.org/cover/21439/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240930195915.152187-1-jacopo.mondi@ideasonboard.com>","date":"2024-09-30T19:59:08","name":"[v9,0/5] Add Face Detection Controls","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/21439/mbox/","series":[{"id":4642,"url":"https://patchwork.libcamera.org/api/series/4642/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4642","date":"2024-09-30T19:59:08","name":"Add Face Detection Controls","version":9,"mbox":"https://patchwork.libcamera.org/series/4642/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21439/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E22DC3257\n\tfor ;\n\tMon, 30 Sep 2024 19:59:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B32163512;\n\tMon, 30 Sep 2024 21:59:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1234E63502\n\tfor ;\n\tMon, 30 Sep 2024 21:59:30 +0200 (CEST)","from ideasonboard.com (unknown [95.131.46.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E624A280;\n\tMon, 30 Sep 2024 21:57:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aPV4XLSt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727726278;\n\tbh=JHjwqWeHIk8wgeVTtA07DTkzGh1Brh4ngQbF7CCpsv0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=aPV4XLSteJNzAHkpcJYfXQ7ZYBT9C7S9BffRTGlrCq0ewXxWV0eN/iIRwZkpwOdJM\n\t/vR0EgkTJfffTD3eVuHuyJbDAgexdYaSI5EGksR7OtIv0u3lg4JHqHaIsUUmsJRzGL\n\tbhLosLr8WfZTtq31ayQfBgoNctUBk8bUZpqLoxos=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tHarvey Yang ","Subject":"[PATCH v9 0/5] Add Face Detection Controls","Date":"Mon, 30 Sep 2024 21:59:08 +0200","Message-ID":"<20240930195915.152187-1-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.46.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"I took over \"[PATCH v8 0/3] Add Face Detection Controls\" on top of the patch\nto the Rectangle class on which we have gone back and forth for the last week\n\nHarvey and cros team please review the first patch and test if you think it's\nneeded.\n\nv9:\n- add \"libcamera: geometry: Clarify Rectangle's top-left corner\"\n- Rebase 2/5 on top of this using min(p1.y, p2.y)\n- Break out 3/5 from 4/5\n- Reword parts of 4/5 to make it more similar to the existing controls\n descriptions\n- Make FaceDetectMode a int32_t as required by\n e6da224926b0 (\"libcamera: controls: Handle enum values without a cast\")\n- Use int32_t as a type for FaceDetectMode in 5/5\n- Populate ANDROID_STATISTICS_FACE_SCORES with actual face scores\n- Populate the ANDROID_STATISTICS_FACE_DETECT_MODE metadata from settings\n only if present\n\nPipeline:\nhttps://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1280968\n\n\nv8: Reverted back to v5 that new control ids in the draft.\n\nv7: Fixed comments.\n\nv6:\n- Added control_ids_android as the new control id list.\n - Moved the new control ids there, instead of in draft.\n\nv5:\n- Rewrote Rectangle's c'tor that allows any two diagonal points.\n - Added unit tests.\n\nv4:\n- Added support of FaceDetectModeFull and FaceDetectFaceIds.\n- Fixed descriptions of control sizes.\n\nv3: Applied fixes according to Jacopo's comments.\n- Moved the new face detection controls from core to draft.\n- Amended new controls' descriptions.\n\nv2:\n- Squashed the fourth CL into the last patch, as it's a fix.\n- Fixed CLs based on checkstyle's suggestions.\n\n\nHarvey Yang (1):\n libcamera: android: Add face detection control support\n\nJacopo Mondi (1):\n libcamera: geometry: Clarify Rectangle's top-left corner\n\nYudhistira Erlandinata (3):\n libcamera: geometry: Add two-point Rectangle constructor\n libcamera: controls: Add ControlTypePoint\n libcamera: control_ids_draft: Add face detection controls\n\n include/libcamera/controls.h | 6 ++\n include/libcamera/geometry.h | 7 ++\n src/android/camera_capabilities.cpp | 44 +++++++-\n src/android/camera_device.cpp | 66 +++++++++++-\n src/libcamera/control_ids_draft.yaml | 82 +++++++++++++++\n src/libcamera/controls.cpp | 6 ++\n src/libcamera/geometry.cpp | 151 +++++++++++++++++++++++++++\n test/geometry.cpp | 14 +++\n 8 files changed, 370 insertions(+), 6 deletions(-)\n\n--\n2.46.1"}