{"id":21330,"url":"https://patchwork.libcamera.org/api/covers/21330/?format=json","web_url":"https://patchwork.libcamera.org/cover/21330/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240923093317.3500444-1-chenghaoyang@google.com>","date":"2024-09-23T09:30:43","name":"[v5,0/3] Add Face Detection Controls","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/21330/mbox/","series":[{"id":4614,"url":"https://patchwork.libcamera.org/api/series/4614/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4614","date":"2024-09-23T09:30:43","name":"Add Face Detection Controls","version":5,"mbox":"https://patchwork.libcamera.org/series/4614/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21330/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9EB51C0F1B\n\tfor ;\n\tMon, 23 Sep 2024 09:33:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B5E56350E;\n\tMon, 23 Sep 2024 11:33:26 +0200 (CEST)","from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com\n\t[IPv6:2607:f8b0:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 687D26037E\n\tfor ;\n\tMon, 23 Sep 2024 11:33:24 +0200 (CEST)","by mail-pl1-x62d.google.com with SMTP id\n\td9443c01a7336-206aee4073cso44118565ad.1\n\tfor ;\n\tMon, 23 Sep 2024 02:33:24 -0700 (PDT)","from chenghaoyang-low.c.googlers.com.com\n\t(0.223.81.34.bc.googleusercontent.com. [34.81.223.0])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-207946d6673sm129864995ad.158.2024.09.23.02.33.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 23 Sep 2024 02:33:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"hP+c/kUC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727084002; x=1727688802;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=bQ88hznwBAVdbzTOFWqOMrnt2jK5dY561baBX+AixiI=;\n\tb=hP+c/kUCRoFyPhoxFZE/delLyKbsuYflUtNPcCy7C+lYDgek3PN3+WybY92kEjQIVu\n\tzlOS3RGkJ/0uXFk6tp6tcqQw/dd1MJx4yZs/6H1u11b3ETh2YUDCp/KTLA7DE5L9DXWX\n\twrJYiGkdT2i1R0cd5NqzWKMS2osNzGS4Kg0mA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727084002; x=1727688802;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=bQ88hznwBAVdbzTOFWqOMrnt2jK5dY561baBX+AixiI=;\n\tb=FNY+PmgOMos2+oQAa964GYZE4STmw3aqj4oYYhEid4232OHk57t2QNjUKNoETpGt2n\n\tevGLJxwwNfMPPC/NV5h//uc1yMnIYGtcilbSfxDVow5+SbRRLekWO5qTe/Krc5RoBc7D\n\trJ6l3hO3ttsbE64xRytFP1QccfaFMfc4Ou0pQ+rNkaF+75V+GZFJynEN+ftcRhozm1Xk\n\tkbEizaE9kJ9sbK8gfqbi6jmUShCUEfi8o9n/3Lt+ZvH2bKTBjP2bu+uBnLzRN/NScqyL\n\tGY9EzgnBdN+CG1VDUF80jadQc0xxBw2k94xwBPKZXg/2GfsGuLI45vbxFQPKdoGkP1LG\n\t1LXQ==","X-Gm-Message-State":"AOJu0YwsogRuQciEeOYDmZ0NbCDz5/GSD6F8FVj8nScu2nzi+hLlAJce\n\txEqs5aug6hV0AaMzaZN5RrjNaln5X9F0CODu4fsEo5cTqZv2u28mrepyH6eiCZ3NaVv/bfImkoQ\n\t=","X-Google-Smtp-Source":"AGHT+IGhD3VhAFA72a3P47gTCpjTOn3IVEu1mpDwXh7emdmlBvhiAuaDBNqpjePU2J2++jfhxzlHAQ==","X-Received":"by 2002:a17:902:f60f:b0:202:51ca:9823 with SMTP id\n\td9443c01a7336-208d9854d26mr173182045ad.46.1727084002603; \n\tMon, 23 Sep 2024 02:33:22 -0700 (PDT)","From":"Harvey Yang ","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ","Subject":"[PATCH v5 0/3] Add Face Detection Controls","Date":"Mon, 23 Sep 2024 09:30:43 +0000","Message-ID":"<20240923093317.3500444-1-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.792.g87dc391469-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi folks,\n\nThis series of patches adds face detection controls in the control ids,\nthe corresponding usages, and a c'tor of libcamera::Rectangle to\nconstruct it easiler with face detection results.\n\nIt passed gitlab pipeline checks:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1276305\n\nThis is one of the series cherry-picked from cros mtkisp7 branch.\n\nThe corresponding CLs in cros are:\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741266\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741267\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669229\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669232\n\nThe usages in pipeline handler mtkisp7 will be added later.\n\nThe checkstyle's suggestion on the second patch is ignored, as it\nchanges the style of previous code.\n\nv5:\n- Rewrote Rectangle's c'tor that allows any two diagonal points.\n - Added unit tests.\n\nv4:\n- Added support of FaceDetectModeFull and FaceDetectFaceIds.\n- Fixed descriptions of control sizes.\n\nv3: Applied fixes according to Jacopo's comments.\n- Moved the new face detection controls from core to draft.\n- Amended new controls' descriptions.\n\nv2:\n- Squashed the fourth CL into the last patch, as it's a fix.\n- Fixed CLs based on checkstyle's suggestions.\n\nHarvey Yang (1):\n libcamera: android: Add face detection control support\n\nYudhistira Erlandinata (2):\n libcamera: Add rectangle two-point constructor\n libcamera: Add face detection controls\n\n include/libcamera/controls.h | 6 ++\n include/libcamera/geometry.h | 7 +++\n src/android/camera_capabilities.cpp | 45 +++++++++++++--\n src/android/camera_device.cpp | 75 +++++++++++++++++++++++-\n src/libcamera/control_ids_draft.yaml | 85 ++++++++++++++++++++++++++++\n src/libcamera/controls.cpp | 6 ++\n src/libcamera/geometry.cpp | 7 +++\n test/geometry.cpp | 14 +++++\n 8 files changed, 239 insertions(+), 6 deletions(-)"}