[{"id":31163,"web_url":"https://patchwork.libcamera.org/comment/31163/","msgid":"<172604149773.822979.17907300706459640720@ping.linuxembedded.co.uk>","date":"2024-09-11T07:58:17","subject":"Re: [PATCH 0/3] qcam: Fix GL renderer on Qt 6","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-09-11 00:46:46)\n> Hello,\n> \n> This small series fixes the GL render with Qt 6. The fix is actually in\n> patch 1/3 only, with patches 2/3 and 3/3 bringing additional cleanups\n> and improvements.\n> \n\nThanks - just re-tested and can confirm it's working again on my X13s\nwith qcam -r gles - and now the behaviour of both with and without is\nmatched for the letter boxing.\n\nTested-by: Kieran Bingham \nReviewed-by: Kieran Bingham \n\n\n> Laurent Pinchart (3):\n> qcam: viewfinder_gl: Fix binding of vertex buffer and shader program\n> qcam: viewfinder_gl: Drop duplicate glClearColor()\n> qcam: viewfinder_gl: Render image centered in letterbox\n> \n> src/apps/qcam/assets/shader/bayer_8.vert | 4 +-\n> src/apps/qcam/assets/shader/identity.vert | 3 +-\n> src/apps/qcam/viewfinder_gl.cpp | 54 ++++++++++++++---------\n> src/apps/qcam/viewfinder_gl.h | 2 +-\n> 4 files changed, 39 insertions(+), 24 deletions(-)\n> \n> \n> base-commit: f75b8dd26feaca86701704390dea18c71e2f0350\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0986CC324C\n\tfor ;\n\tWed, 11 Sep 2024 07:58:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1279634FE;\n\tWed, 11 Sep 2024 09:58:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B95C634E3\n\tfor ;\n\tWed, 11 Sep 2024 09:58:20 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BEFA7C80;\n\tWed, 11 Sep 2024 09:57:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tC+2Db9H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726041422;\n\tbh=zO75+klYOF4OzwQ6W01rZExw5wlTf1FG8urmU5nNsOE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tC+2Db9H5K1xwq+8yBQTXjNSlk30ii5huxMHDSdu8sDrjiU9OqLjB9UE3UxPeae5U\n\tzy+2kVsW6xPVtIGQ5+B5CMdjbhoh0V7svk5MLzZtECYv9A3eA/WQezdbaQMST2B//m\n\t/YEDdWwCIX0WYXeEZfSpIaDA15lxXO1JulFUdPh0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240910234649.28591-1-laurent.pinchart@ideasonboard.com>","References":"<20240910234649.28591-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 0/3] qcam: Fix GL renderer on Qt 6","From":"Kieran Bingham ","Cc":"Neal Gompa ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 11 Sep 2024 08:58:17 +0100","Message-ID":"<172604149773.822979.17907300706459640720@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31184,"web_url":"https://patchwork.libcamera.org/comment/31184/","msgid":"","date":"2024-09-12T08:45:19","subject":"Re: [PATCH 0/3] qcam: Fix GL renderer on Qt 6","submitter":{"id":181,"url":"https://patchwork.libcamera.org/api/people/181/","name":"Neal Gompa","email":"neal@gompa.dev"},"content":"On Wed, Sep 11, 2024 at 1:47 AM Laurent Pinchart\n wrote:\n>\n> Hello,\n>\n> This small series fixes the GL render with Qt 6. The fix is actually in\n> patch 1/3 only, with patches 2/3 and 3/3 bringing additional cleanups\n> and improvements.\n>\n> Laurent Pinchart (3):\n> qcam: viewfinder_gl: Fix binding of vertex buffer and shader program\n> qcam: viewfinder_gl: Drop duplicate glClearColor()\n> qcam: viewfinder_gl: Render image centered in letterbox\n>\n> src/apps/qcam/assets/shader/bayer_8.vert | 4 +-\n> src/apps/qcam/assets/shader/identity.vert | 3 +-\n> src/apps/qcam/viewfinder_gl.cpp | 54 ++++++++++++++---------\n> src/apps/qcam/viewfinder_gl.h | 2 +-\n> 4 files changed, 39 insertions(+), 24 deletions(-)\n>\n>\n> base-commit: f75b8dd26feaca86701704390dea18c71e2f0350\n> --\n\nLGTM.\n\nReviewed-by: Neal Gompa ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D2CAC324C\n\tfor ;\n\tThu, 12 Sep 2024 08:46:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3F3F634FB;\n\tThu, 12 Sep 2024 10:46:01 +0200 (CEST)","from mail-ej1-f48.google.com (mail-ej1-f48.google.com\n\t[209.85.218.48])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E39D618F6\n\tfor ;\n\tThu, 12 Sep 2024 10:45:59 +0200 (CEST)","by mail-ej1-f48.google.com with SMTP id\n\ta640c23a62f3a-a8a7596b7dfso103954566b.0\n\tfor ;\n\tThu, 12 Sep 2024 01:45:59 -0700 (PDT)","from mail-ed1-f41.google.com (mail-ed1-f41.google.com.\n\t[209.85.208.41]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a8d25ce970csm714681166b.159.2024.09.12.01.45.56\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 12 Sep 2024 01:45:58 -0700 (PDT)","by mail-ed1-f41.google.com with SMTP id\n\t4fb4d7f45d1cf-5c241feb80dso3502108a12.0\n\tfor ;\n\tThu, 12 Sep 2024 01:45:56 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1726130759; x=1726735559;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=cy4yvZIozR8IKAyZcNNDw9NMKjLKdC/SQnTRUkwhZRY=;\n\tb=OLIY8zh5Vyd9jRX64TIImwKhHPNorOJtWzEm1xKpQLj9FSynIvRg8Lp94xG8XO9/wU\n\tT2uaUCGmMrxvKrVTTEudf26NCLPDamBeqO1UOGu/egcwqg0tu0YQhMG8mpRVz4iHG8r7\n\tvbb6g5ldlIvby4t5tcmkXlTDXcmx59qGPBpGAm4IoMepCD7b1emAib6TwLQgBQdSWiDw\n\tYCqKTkQoGN5i+NbbUh5Y18x2cr33aZYj7Px95WXY50JBlHd0sOLOccafCqWHvoqwU1tw\n\t0aiHbp/iFfUviWU8FY5uOVKXbUjffiDsHFjmeqntsx+SWS6coTP23gc9QJ1MEpQR7FeZ\n\tEbHA==","X-Gm-Message-State":"AOJu0YxXiPQtqz3N3m/5Gjx8VUlqS52YKC6S17vJ5H7IBW4XlPzsQ+5m\n\tI5ryf1WHnqgNCJrqPCLMq5LWdQ6vmNBS/+4RRipaXqqCpfvjLBhW8D7cz0eSS8Y=","X-Google-Smtp-Source":"AGHT+IEuwyjbnRDuU9eOXooqEUNQHo6uHPXiAEdSFkXdRPuuYz20lamnCbHiHeypkaQLbZrqGzkxEg==","X-Received":["by 2002:a17:907:7b8d:b0:a8d:65f4:c7c6 with SMTP id\n\ta640c23a62f3a-a8ffae00183mr754329266b.24.1726130758409; \n\tThu, 12 Sep 2024 01:45:58 -0700 (PDT)","by 2002:a05:6402:2546:b0:5c2:7741:7d82 with SMTP id\n\t4fb4d7f45d1cf-5c4143626camr1897093a12.11.1726130756074;\n\tThu, 12 Sep 2024 01:45:56 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20240910234649.28591-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20240910234649.28591-1-laurent.pinchart@ideasonboard.com>","From":"Neal Gompa ","Date":"Thu, 12 Sep 2024 10:45:19 +0200","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH 0/3] qcam: Fix GL renderer on Qt 6","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]