[{"id":2822,"web_url":"https://patchwork.libcamera.org/comment/2822/","msgid":"<20191008014950.GA12218@pendragon.ideasonboard.com>","date":"2019-10-08T01:49:50","subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patches.\n\nOn Mon, Oct 07, 2019 at 10:58:37AM +0200, Jacopo Mondi wrote:\n> With the small changes in patches 4 and 5:\n> - Define the FIFO path as a macro in 4/5\n> - Adjust path printout in error paths in 5/5\n> \n> I would push this version.\n\nSo would I, but the new test fails on my system :-S Could you\ndouble-check on your side ? If you get no failure I'll investigate.\n\n> Jacopo Mondi (5):\n> ipa: vimc: Rename ipa_dummy to ipa_vimc\n> test: ipa: Rename the ipa_test to ipa_module_test\n> ipa: meson: Give IPAs access to internal libcamera APIs\n> ipa: vimc: Add support for tracing operations\n> test: ipa: Add test for the IPA Interface\n> \n> include/ipa/ipa_vimc.h | 22 +++\n> src/ipa/ipa_dummy.cpp | 46 ------\n> src/ipa/ipa_vimc.cpp | 112 ++++++++++++++\n> src/ipa/meson.build | 18 ++-\n> test/ipa/ipa_interface_test.cpp | 142 ++++++++++++++++++\n> .../ipa/{ipa_test.cpp => ipa_module_test.cpp} | 4 +-\n> test/ipa/meson.build | 3 +-\n> 7 files changed, 292 insertions(+), 55 deletions(-)\n> create mode 100644 include/ipa/ipa_vimc.h\n> delete mode 100644 src/ipa/ipa_dummy.cpp\n> create mode 100644 src/ipa/ipa_vimc.cpp\n> create mode 100644 test/ipa/ipa_interface_test.cpp\n> rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (92%)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B7636157B\n\tfor ;\n\tTue, 8 Oct 2019 03:49:55 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [192.252.136.7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4139754C;\n\tTue, 8 Oct 2019 03:49:54 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570499394;\n\tbh=oRiesSTCe98h1FoK7aavlJy1phfe9PIPz/anpbO0afs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=X/ifCgGkjeJz2VRFYprEy8tvBV/ubQ2OfkcQLMRo/zDh0rqSTqytLhw801BSOFT2V\n\tSUUkbmJJHStkCX10Efsrf76O9mNO27iz3zSmqwUz3HmHyr/9iDzaPMv5DZWyyxvtY8\n\tvjW2qaaqC3+ke6mjpbYt6chd2OPva3HCGSG90Liw=","Date":"Tue, 8 Oct 2019 04:49:50 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191008014950.GA12218@pendragon.ideasonboard.com>","References":"<20191007085842.7608-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191007085842.7608-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 08 Oct 2019 01:49:55 -0000"}},{"id":2824,"web_url":"https://patchwork.libcamera.org/comment/2824/","msgid":"<20191008083936.x2lzmebdx7wkfyq3@uno.localdomain>","date":"2019-10-08T08:39:36","subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Tue, Oct 08, 2019 at 04:49:50AM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patches.\n>\n> On Mon, Oct 07, 2019 at 10:58:37AM +0200, Jacopo Mondi wrote:\n> > With the small changes in patches 4 and 5:\n> > - Define the FIFO path as a macro in 4/5\n> > - Adjust path printout in error paths in 5/5\n> >\n> > I would push this version.\n>\n> So would I, but the new test fails on my system :-S Could you\n\nOh really ?\n\n> double-check on your side ? If you get no failure I'll investigate.\n\nit works here.. I have a build failure with gcc which I should fix\nwhen applying but the test is ok\n\ndiff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\nindex 83eef7440fa4..cac6efeaf3ff 100644\n--- a/test/ipa/ipa_interface_test.cpp\n+++ b/test/ipa/ipa_interface_test.cpp\n@@ -129,7 +129,7 @@ protected:\n private:\n void readFifo(EventNotifier *notifier)\n {\n- size_t s = read(notifier->fd(), &data_, 1);\n+ ssize_t s = read(notifier->fd(), &data_, 1);\n if (s < 0) {\n cerr << \"Failed to to read from IPA test fifo at: \"\n << ipaFifoPath << strerror(errno) << endl;\n\nCould someone else try this ?\n\nThanks\n j\n\n>\n> > Jacopo Mondi (5):\n> > ipa: vimc: Rename ipa_dummy to ipa_vimc\n> > test: ipa: Rename the ipa_test to ipa_module_test\n> > ipa: meson: Give IPAs access to internal libcamera APIs\n> > ipa: vimc: Add support for tracing operations\n> > test: ipa: Add test for the IPA Interface\n> >\n> > include/ipa/ipa_vimc.h | 22 +++\n> > src/ipa/ipa_dummy.cpp | 46 ------\n> > src/ipa/ipa_vimc.cpp | 112 ++++++++++++++\n> > src/ipa/meson.build | 18 ++-\n> > test/ipa/ipa_interface_test.cpp | 142 ++++++++++++++++++\n> > .../ipa/{ipa_test.cpp => ipa_module_test.cpp} | 4 +-\n> > test/ipa/meson.build | 3 +-\n> > 7 files changed, 292 insertions(+), 55 deletions(-)\n> > create mode 100644 include/ipa/ipa_vimc.h\n> > delete mode 100644 src/ipa/ipa_dummy.cpp\n> > create mode 100644 src/ipa/ipa_vimc.cpp\n> > create mode 100644 test/ipa/ipa_interface_test.cpp\n> > rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (92%)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6512960BC6\n\tfor ;\n\tTue, 8 Oct 2019 10:37:51 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id EB36460021;\n\tTue, 8 Oct 2019 08:37:50 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 8 Oct 2019 10:39:36 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191008083936.x2lzmebdx7wkfyq3@uno.localdomain>","References":"<20191007085842.7608-1-jacopo@jmondi.org>\n\t<20191008014950.GA12218@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"w3trokqmv73yybw2\"","Content-Disposition":"inline","In-Reply-To":"<20191008014950.GA12218@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 08 Oct 2019 08:37:51 -0000"}},{"id":2825,"web_url":"https://patchwork.libcamera.org/comment/2825/","msgid":"<20191008084336.uypqrhenffd2bf7r@uno.localdomain>","date":"2019-10-08T08:43:36","subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi again,\n\nOn Tue, Oct 08, 2019 at 10:39:36AM +0200, Jacopo Mondi wrote:\n> On Tue, Oct 08, 2019 at 04:49:50AM +0300, Laurent Pinchart wrote:\n> > Hi Jacopo,\n> >\n> > Thank you for the patches.\n> >\n> > On Mon, Oct 07, 2019 at 10:58:37AM +0200, Jacopo Mondi wrote:\n> > > With the small changes in patches 4 and 5:\n> > > - Define the FIFO path as a macro in 4/5\n> > > - Adjust path printout in error paths in 5/5\n> > >\n> > > I would push this version.\n> >\n> > So would I, but the new test fails on my system :-S Could you\n>\n> Oh really ?\n>\n> > double-check on your side ? If you get no failure I'll investigate.\n>\n> it works here.. I have a build failure with gcc which I should fix\n> when applying but the test is ok\n>\n> diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> index 83eef7440fa4..cac6efeaf3ff 100644\n> --- a/test/ipa/ipa_interface_test.cpp\n> +++ b/test/ipa/ipa_interface_test.cpp\n> @@ -129,7 +129,7 @@ protected:\n> private:\n> void readFifo(EventNotifier *notifier)\n> {\n> - size_t s = read(notifier->fd(), &data_, 1);\n> + ssize_t s = read(notifier->fd(), &data_, 1);\n> if (s < 0) {\n> cerr << \"Failed to to read from IPA test fifo at: \"\n> << ipaFifoPath << strerror(errno) << endl;\n>\n\nScratch this, I was testing a previous version :/\n\n> Could someone else try this ?\n\nI now see it failing, but only when building with gcc o_0\nI'll investigate, my bad I only tested the clang compiled version...\n\n>\n> Thanks\n> j\n>\n> >\n> > > Jacopo Mondi (5):\n> > > ipa: vimc: Rename ipa_dummy to ipa_vimc\n> > > test: ipa: Rename the ipa_test to ipa_module_test\n> > > ipa: meson: Give IPAs access to internal libcamera APIs\n> > > ipa: vimc: Add support for tracing operations\n> > > test: ipa: Add test for the IPA Interface\n> > >\n> > > include/ipa/ipa_vimc.h | 22 +++\n> > > src/ipa/ipa_dummy.cpp | 46 ------\n> > > src/ipa/ipa_vimc.cpp | 112 ++++++++++++++\n> > > src/ipa/meson.build | 18 ++-\n> > > test/ipa/ipa_interface_test.cpp | 142 ++++++++++++++++++\n> > > .../ipa/{ipa_test.cpp => ipa_module_test.cpp} | 4 +-\n> > > test/ipa/meson.build | 3 +-\n> > > 7 files changed, 292 insertions(+), 55 deletions(-)\n> > > create mode 100644 include/ipa/ipa_vimc.h\n> > > delete mode 100644 src/ipa/ipa_dummy.cpp\n> > > create mode 100644 src/ipa/ipa_vimc.cpp\n> > > create mode 100644 test/ipa/ipa_interface_test.cpp\n> > > rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (92%)\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n\n\n\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0A7860BC6\n\tfor ;\n\tTue, 8 Oct 2019 10:41:50 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 5DABE1C001D;\n\tTue, 8 Oct 2019 08:41:50 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 8 Oct 2019 10:43:36 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191008084336.uypqrhenffd2bf7r@uno.localdomain>","References":"<20191007085842.7608-1-jacopo@jmondi.org>\n\t<20191008014950.GA12218@pendragon.ideasonboard.com>\n\t<20191008083936.x2lzmebdx7wkfyq3@uno.localdomain>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"urcbuvyygvyapll2\"","Content-Disposition":"inline","In-Reply-To":"<20191008083936.x2lzmebdx7wkfyq3@uno.localdomain>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 08 Oct 2019 08:41:51 -0000"}},{"id":2826,"web_url":"https://patchwork.libcamera.org/comment/2826/","msgid":"<20191008084821.pxftvs5fustmnpwb@uno.localdomain>","date":"2019-10-08T08:48:21","subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi, -again-\n\nOn Tue, Oct 08, 2019 at 10:39:36AM +0200, Jacopo Mondi wrote:\n> On Tue, Oct 08, 2019 at 04:49:50AM +0300, Laurent Pinchart wrote:\n> > Hi Jacopo,\n> >\n> > Thank you for the patches.\n> >\n> > On Mon, Oct 07, 2019 at 10:58:37AM +0200, Jacopo Mondi wrote:\n> > > With the small changes in patches 4 and 5:\n> > > - Define the FIFO path as a macro in 4/5\n> > > - Adjust path printout in error paths in 5/5\n> > >\n> > > I would push this version.\n> >\n> > So would I, but the new test fails on my system :-S Could you\n>\n> Oh really ?\n\nJust remove the stale dummy_ipa binary from your build directory, or\nit gets picked before the new ipa_vimc one :)\n\nI feel like I could push this, but I'll wait for you to test again.\n\nThanks\n j\n\n>\n> > double-check on your side ? If you get no failure I'll investigate.\n>\n> it works here.. I have a build failure with gcc which I should fix\n> when applying but the test is ok\n>\n> diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> index 83eef7440fa4..cac6efeaf3ff 100644\n> --- a/test/ipa/ipa_interface_test.cpp\n> +++ b/test/ipa/ipa_interface_test.cpp\n> @@ -129,7 +129,7 @@ protected:\n> private:\n> void readFifo(EventNotifier *notifier)\n> {\n> - size_t s = read(notifier->fd(), &data_, 1);\n> + ssize_t s = read(notifier->fd(), &data_, 1);\n> if (s < 0) {\n> cerr << \"Failed to to read from IPA test fifo at: \"\n> << ipaFifoPath << strerror(errno) << endl;\n>\n> Could someone else try this ?\n>\n> Thanks\n> j\n>\n> >\n> > > Jacopo Mondi (5):\n> > > ipa: vimc: Rename ipa_dummy to ipa_vimc\n> > > test: ipa: Rename the ipa_test to ipa_module_test\n> > > ipa: meson: Give IPAs access to internal libcamera APIs\n> > > ipa: vimc: Add support for tracing operations\n> > > test: ipa: Add test for the IPA Interface\n> > >\n> > > include/ipa/ipa_vimc.h | 22 +++\n> > > src/ipa/ipa_dummy.cpp | 46 ------\n> > > src/ipa/ipa_vimc.cpp | 112 ++++++++++++++\n> > > src/ipa/meson.build | 18 ++-\n> > > test/ipa/ipa_interface_test.cpp | 142 ++++++++++++++++++\n> > > .../ipa/{ipa_test.cpp => ipa_module_test.cpp} | 4 +-\n> > > test/ipa/meson.build | 3 +-\n> > > 7 files changed, 292 insertions(+), 55 deletions(-)\n> > > create mode 100644 include/ipa/ipa_vimc.h\n> > > delete mode 100644 src/ipa/ipa_dummy.cpp\n> > > create mode 100644 src/ipa/ipa_vimc.cpp\n> > > create mode 100644 test/ipa/ipa_interface_test.cpp\n> > > rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (92%)\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n\n\n\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 744EA60BC6\n\tfor ;\n\tTue, 8 Oct 2019 10:46:36 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id DD3E920005;\n\tTue, 8 Oct 2019 08:46:35 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 8 Oct 2019 10:48:21 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191008084821.pxftvs5fustmnpwb@uno.localdomain>","References":"<20191007085842.7608-1-jacopo@jmondi.org>\n\t<20191008014950.GA12218@pendragon.ideasonboard.com>\n\t<20191008083936.x2lzmebdx7wkfyq3@uno.localdomain>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"mfjb6hkvutfmr3g7\"","Content-Disposition":"inline","In-Reply-To":"<20191008083936.x2lzmebdx7wkfyq3@uno.localdomain>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 08 Oct 2019 08:46:36 -0000"}},{"id":2829,"web_url":"https://patchwork.libcamera.org/comment/2829/","msgid":"<20191008102622.GA16543@pendragon.ideasonboard.com>","date":"2019-10-08T10:26:22","subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Tue, Oct 08, 2019 at 10:48:21AM +0200, Jacopo Mondi wrote:\n> On Tue, Oct 08, 2019 at 10:39:36AM +0200, Jacopo Mondi wrote:\n> > On Tue, Oct 08, 2019 at 04:49:50AM +0300, Laurent Pinchart wrote:\n> >> On Mon, Oct 07, 2019 at 10:58:37AM +0200, Jacopo Mondi wrote:\n> >>> With the small changes in patches 4 and 5:\n> >>> - Define the FIFO path as a macro in 4/5\n> >>> - Adjust path printout in error paths in 5/5\n> >>>\n> >>> I would push this version.\n> >>\n> >> So would I, but the new test fails on my system :-S Could you\n> >\n> > Oh really ?\n> \n> Just remove the stale dummy_ipa binary from your build directory, or\n> it gets picked before the new ipa_vimc one :)\n> \n> I feel like I could push this, but I'll wait for you to test again.\n\nTested-by: Laurent Pinchart \n\nPlease push.\n\n> >> double-check on your side ? If you get no failure I'll investigate.\n> >\n> > it works here.. I have a build failure with gcc which I should fix\n> > when applying but the test is ok\n> >\n> > diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> > index 83eef7440fa4..cac6efeaf3ff 100644\n> > --- a/test/ipa/ipa_interface_test.cpp\n> > +++ b/test/ipa/ipa_interface_test.cpp\n> > @@ -129,7 +129,7 @@ protected:\n> > private:\n> > void readFifo(EventNotifier *notifier)\n> > {\n> > - size_t s = read(notifier->fd(), &data_, 1);\n> > + ssize_t s = read(notifier->fd(), &data_, 1);\n> > if (s < 0) {\n> > cerr << \"Failed to to read from IPA test fifo at: \"\n> > << ipaFifoPath << strerror(errno) << endl;\n> >\n> > Could someone else try this ?\n> >\n> >>> Jacopo Mondi (5):\n> >>> ipa: vimc: Rename ipa_dummy to ipa_vimc\n> >>> test: ipa: Rename the ipa_test to ipa_module_test\n> >>> ipa: meson: Give IPAs access to internal libcamera APIs\n> >>> ipa: vimc: Add support for tracing operations\n> >>> test: ipa: Add test for the IPA Interface\n> >>>\n> >>> include/ipa/ipa_vimc.h | 22 +++\n> >>> src/ipa/ipa_dummy.cpp | 46 ------\n> >>> src/ipa/ipa_vimc.cpp | 112 ++++++++++++++\n> >>> src/ipa/meson.build | 18 ++-\n> >>> test/ipa/ipa_interface_test.cpp | 142 ++++++++++++++++++\n> >>> .../ipa/{ipa_test.cpp => ipa_module_test.cpp} | 4 +-\n> >>> test/ipa/meson.build | 3 +-\n> >>> 7 files changed, 292 insertions(+), 55 deletions(-)\n> >>> create mode 100644 include/ipa/ipa_vimc.h\n> >>> delete mode 100644 src/ipa/ipa_dummy.cpp\n> >>> create mode 100644 src/ipa/ipa_vimc.cpp\n> >>> create mode 100644 test/ipa/ipa_interface_test.cpp\n> >>> rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (92%)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 478C561565\n\tfor ;\n\tTue, 8 Oct 2019 12:26:30 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [80.194.85.162])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6CB455F;\n\tTue, 8 Oct 2019 12:26:29 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570530389;\n\tbh=IMi3l28WAJb38mU24Sod9kKcUt3QWdpGuWs8Refgojc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J5cTKJ4faF0s+IVymp2FD5moifY9AVIOK1ekkfILVkfk7penNFaXgh7YyyhlIZe9L\n\t8AyBz7TEcG/Gkaze0pbtCXZR5IWj0Zj36cMPWjuxCcqcU7VhL8to8mS7hJq4T4jFcI\n\t97q1yGT78tE2DKEBPN8TBVhKpA223F2toFJFZ1sU=","Date":"Tue, 8 Oct 2019 13:26:22 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191008102622.GA16543@pendragon.ideasonboard.com>","References":"<20191007085842.7608-1-jacopo@jmondi.org>\n\t<20191008014950.GA12218@pendragon.ideasonboard.com>\n\t<20191008083936.x2lzmebdx7wkfyq3@uno.localdomain>\n\t<20191008084821.pxftvs5fustmnpwb@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191008084821.pxftvs5fustmnpwb@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 08 Oct 2019 10:26:30 -0000"}},{"id":2833,"web_url":"https://patchwork.libcamera.org/comment/2833/","msgid":"<20191008134133.7yc3sc7xsz7fxdnp@uno.localdomain>","date":"2019-10-08T13:41:33","subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Tue, Oct 08, 2019 at 01:26:22PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Tue, Oct 08, 2019 at 10:48:21AM +0200, Jacopo Mondi wrote:\n> > On Tue, Oct 08, 2019 at 10:39:36AM +0200, Jacopo Mondi wrote:\n> > > On Tue, Oct 08, 2019 at 04:49:50AM +0300, Laurent Pinchart wrote:\n> > >> On Mon, Oct 07, 2019 at 10:58:37AM +0200, Jacopo Mondi wrote:\n> > >>> With the small changes in patches 4 and 5:\n> > >>> - Define the FIFO path as a macro in 4/5\n> > >>> - Adjust path printout in error paths in 5/5\n> > >>>\n> > >>> I would push this version.\n> > >>\n> > >> So would I, but the new test fails on my system :-S Could you\n> > >\n> > > Oh really ?\n> >\n> > Just remove the stale dummy_ipa binary from your build directory, or\n> > it gets picked before the new ipa_vimc one :)\n> >\n> > I feel like I could push this, but I'll wait for you to test again.\n>\n> Tested-by: Laurent Pinchart \n>\n> Please push.\n\nNow pushed with your tag\n\nThanks\n j\n\n>\n> > >> double-check on your side ? If you get no failure I'll investigate.\n> > >\n> > > it works here.. I have a build failure with gcc which I should fix\n> > > when applying but the test is ok\n> > >\n> > > diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> > > index 83eef7440fa4..cac6efeaf3ff 100644\n> > > --- a/test/ipa/ipa_interface_test.cpp\n> > > +++ b/test/ipa/ipa_interface_test.cpp\n> > > @@ -129,7 +129,7 @@ protected:\n> > > private:\n> > > void readFifo(EventNotifier *notifier)\n> > > {\n> > > - size_t s = read(notifier->fd(), &data_, 1);\n> > > + ssize_t s = read(notifier->fd(), &data_, 1);\n> > > if (s < 0) {\n> > > cerr << \"Failed to to read from IPA test fifo at: \"\n> > > << ipaFifoPath << strerror(errno) << endl;\n> > >\n> > > Could someone else try this ?\n> > >\n> > >>> Jacopo Mondi (5):\n> > >>> ipa: vimc: Rename ipa_dummy to ipa_vimc\n> > >>> test: ipa: Rename the ipa_test to ipa_module_test\n> > >>> ipa: meson: Give IPAs access to internal libcamera APIs\n> > >>> ipa: vimc: Add support for tracing operations\n> > >>> test: ipa: Add test for the IPA Interface\n> > >>>\n> > >>> include/ipa/ipa_vimc.h | 22 +++\n> > >>> src/ipa/ipa_dummy.cpp | 46 ------\n> > >>> src/ipa/ipa_vimc.cpp | 112 ++++++++++++++\n> > >>> src/ipa/meson.build | 18 ++-\n> > >>> test/ipa/ipa_interface_test.cpp | 142 ++++++++++++++++++\n> > >>> .../ipa/{ipa_test.cpp => ipa_module_test.cpp} | 4 +-\n> > >>> test/ipa/meson.build | 3 +-\n> > >>> 7 files changed, 292 insertions(+), 55 deletions(-)\n> > >>> create mode 100644 include/ipa/ipa_vimc.h\n> > >>> delete mode 100644 src/ipa/ipa_dummy.cpp\n> > >>> create mode 100644 src/ipa/ipa_vimc.cpp\n> > >>> create mode 100644 test/ipa/ipa_interface_test.cpp\n> > >>> rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (92%)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 461FD6157C\n\tfor ;\n\tTue, 8 Oct 2019 15:39:48 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id CD02D24000A;\n\tTue, 8 Oct 2019 13:39:47 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 8 Oct 2019 15:41:33 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191008134133.7yc3sc7xsz7fxdnp@uno.localdomain>","References":"<20191007085842.7608-1-jacopo@jmondi.org>\n\t<20191008014950.GA12218@pendragon.ideasonboard.com>\n\t<20191008083936.x2lzmebdx7wkfyq3@uno.localdomain>\n\t<20191008084821.pxftvs5fustmnpwb@uno.localdomain>\n\t<20191008102622.GA16543@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"3iwxz4odpq2rhutj\"","Content-Disposition":"inline","In-Reply-To":"<20191008102622.GA16543@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] test: Add IPA interface test\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 08 Oct 2019 13:39:48 -0000"}}]