[{"id":31081,"web_url":"https://patchwork.libcamera.org/comment/31081/","msgid":"","date":"2024-09-03T14:09:50","subject":"Re: [PATCH v4 0/3] Add Face Detection Controls","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"On Tue, Sep 3, 2024 at 6:40 PM Harvey Yang \nwrote:\n\n> Hi folks,\n>\n> This series of patches adds face detection controls in the control ids,\n> the corresponding usages, and a c'tor of libcamera::Rectangle to\n> construct it easiler with face detection results.\n>\n> It passed gitlab pipeline checks:\n> https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1261374\n\nSorry, forgot to update the link:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/jobs/63084742\n\n\n\n>\n>\n> This is one of the series cherry-picked from cros mtkisp7 branch.\n>\n> The corresponding CLs in cros are:\n>\n> https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741266\n>\n> https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741267\n>\n> https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669229\n>\n> https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669232\n>\n> The usages in pipeline handler mtkisp7 will be added later.\n>\n> The checkstyle's suggestion on the second patch is ignored, as it\n> changes the style of previous code.\n>\n> v4:\n> - Added support of FaceDetectModeFull and FaceDetectFaceIds\n> - Fixed descriptions of control sizes.\n>\n> v3: Applied fixes according to Jacopo's comments.\n> - Moved the new face detection controls from core to draft.\n> - Amended new controls' descriptions.\n>\n> v2:\n> - Squashed the fourth CL into the last patch, as it's a fix.\n> - Fixed CLs based on checkstyle's suggestions.\n>\n>\n> BR,\n> Harvey\n>\n> Harvey Yang (1):\n> libcamera: android: Add face detection control support\n>\n> Yudhistira Erlandinata (2):\n> libcamera: Add rectangle two-point constructor\n> libcamera: Add face detection controls\n>\n> include/libcamera/controls.h | 6 ++\n> include/libcamera/geometry.h | 2 +\n> src/android/camera_capabilities.cpp | 45 +++++++++++++--\n> src/android/camera_device.cpp | 75 +++++++++++++++++++++++-\n> src/libcamera/control_ids_draft.yaml | 85 ++++++++++++++++++++++++++++\n> src/libcamera/controls.cpp | 6 ++\n> src/libcamera/geometry.cpp | 14 +++++\n> 7 files changed, 227 insertions(+), 6 deletions(-)\n>\n> --\n> 2.46.0.469.g59c65b2a67-goog\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14BAAC324C\n\tfor ;\n\tTue, 3 Sep 2024 14:10:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0273634E5;\n\tTue, 3 Sep 2024 16:10:03 +0200 (CEST)","from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E87B8634A6\n\tfor ;\n\tTue, 3 Sep 2024 16:10:02 +0200 (CEST)","by mail-lj1-x234.google.com with SMTP id\n\t38308e7fff4ca-2f50ca18a13so64860801fa.1\n\tfor ;\n\tTue, 03 Sep 2024 07:10:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"D8POVzXB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1725372602; x=1725977402;\n\tdarn=lists.libcamera.org; \n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=3b4R9lC4gjSIICe+voNWHp/goDe29/rGocCEWJ6Wg/M=;\n\tb=D8POVzXBVA16K0kulRUEPa+Y97twoopwEYoePbXo5mcxY3hObUBV2pcfHAeKQrJbqr\n\tPyn+Hd32yUXQIUo71Tdy3jdSTbk4+3D096cZuwDdI8xOgv+oKT6BN8NvnJT0zeEICOw1\n\t/x0SalYv7IQyOlFEG2QkO8Bb3qNCANYJxckEI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725372602; x=1725977402;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=3b4R9lC4gjSIICe+voNWHp/goDe29/rGocCEWJ6Wg/M=;\n\tb=kQ8zzyhuKkFpXbeEukt+k729mlkWfH0lTV+Jr/L8dl/pMmf7TFHqkFjtQCKQKl5B44\n\tQ0W+4jo6wpQRG4rkkWqw726mKf7nJ5o2vaOgeGLekabcJydvbAvbCysBABcDZQ5NtyhY\n\tWar04raoWzLBmc0rNeofDkVHWDkE3xheFb2Nc8fasFENbi9cLdrgGXbWxYtlGkDUbShq\n\tgtfXBNq1eknkO200z2NUgxyTaR2gY7gq3gBFXLLY56or1gN0q7x1azHKlm8ptr1A4evy\n\tW1AmZ1mNDrFndp3xL6+y8/JagoESrUMV5Ds7shb2DaCXba4Qp+EKb6tDuXQ//NiXypze\n\tHIvQ==","X-Gm-Message-State":"AOJu0Yxz786veJdzjehwB++xVavDnEHj+Zp3ZSf3F+2iCzISzF6ALMbb\n\tXnQvd49izLpFWgKSomeupK7wvUqJFz46iOhng7shsENG8YAPLV3kC08npsN6DVE8lSorLEhjTJr\n\tK9t6DkEamZbgWSyhDiKp9Xrncz/ZP8zgNK0jh8YSO0DfktdQTlSWwG5M=","X-Google-Smtp-Source":"AGHT+IH/Sk/Ad0kBhfGfoE5/Y0BsYIZuLP1Ua6r8HfI4N41IRDMSLulAmAy5FSE02AV/3rwLmiGnVQ/tSH5vqjrFNlU=","X-Received":"by 2002:a2e:f1a:0:b0:2ee:8555:4742 with SMTP id\n\t38308e7fff4ca-2f6103c87d9mr97372521fa.27.1725372601537;\n\tTue, 03 Sep 2024 07:10:01 -0700 (PDT)","MIME-Version":"1.0","References":"<20240903104018.3289112-1-chenghaoyang@chromium.org>","In-Reply-To":"<20240903104018.3289112-1-chenghaoyang@chromium.org>","From":"Cheng-Hao Yang ","Date":"Tue, 3 Sep 2024 22:09:50 +0800","Message-ID":"","Subject":"Re: [PATCH v4 0/3] Add Face Detection Controls","To":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"0000000000000538590621379d02\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]