[{"id":2796,"web_url":"https://patchwork.libcamera.org/comment/2796/","msgid":"<20191006092948.GA4726@bigcity.dyn.berto.se>","date":"2019-10-06T09:29:48","subject":"Re: [libcamera-devel] [PATCH 0/9] Timer fixes and enhancements","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your series.\n\nOn 2019-10-06 08:32:17 +0300, Laurent Pinchart wrote:\n> Hello,\n> \n> This series fixes several issues with the Timer class (in patches 2/9,\n> 5/9 and 6/9), and extends the class with support for absolute deadlines\n> (patch 8/9) which should be useful for IPAs.\n> \n> Please see individual patches for details.\n\nI read all the patches and updated the IPA work to make use of this, and \nit still works ;-) I plan to send out the next IPA version depending on \nthis series.\n\nFor the whole series:\n\nReviewed-by: Niklas Söderlund \n\n> \n> Laurent Pinchart (9):\n> libcamera: timer: Remove the interval() method\n> libcamera: timer: Don't reset deadline after time out\n> test: timer: Test that deadline() isn't reset upon time out\n> test: timer: Test that a timer can be restarted before it expires\n> libcamera: timer: Allow restarting a timer before expiration\n> libcamera: timer: Forbid starting or stopping timer from another\n> thread\n> test: timer-thread: Test starting a timer from another thread\n> libcamera: timer: Add start() method with absolute deadline\n> test: timer: Test start() with absolute deadline\n> \n> include/libcamera/timer.h | 6 +--\n> src/libcamera/timer.cpp | 73 +++++++++++++++++++++++---------\n> src/qcam/qt_event_dispatcher.cpp | 7 ++-\n> test/timer-thread.cpp | 58 +++++++++++++++++++------\n> test/timer.cpp | 54 +++++++++++++++++++----\n> 5 files changed, 153 insertions(+), 45 deletions(-)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8714A60E1D\n\tfor ;\n\tSun, 6 Oct 2019 11:29:50 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id t8so7196570lfc.13\n\tfor ;\n\tSun, 06 Oct 2019 02:29:50 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tz20sm2790635ljk.63.2019.10.06.02.29.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 06 Oct 2019 02:29:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=YmgXMz78hUsPtSZQsnRSr/Y8vrfIv9p7qU5OaLfYxzI=;\n\tb=KBBfyvpa0mRDtNs8k9GY2lpfsFJQZPJnKwFtNn9MpHN1tF57zKG7ubdUOn+TcciRHF\n\tbDKSJbQhSmrWCCb7AZGdveZx0CeWnuSYd9Li+KzGbrVS/93fodtgA7olIEGvMX/oKBp4\n\tOrBYtY6VnW7Nc2LWVFqMTOjtbBr7Q7Ul0j/W4AZfWo0/mrjF6mF1GF6s980NJsF1oxXF\n\t3z7+No9nGZl86XJgkc/8Yvpv8546RxVkhY72o9p0LLdlVGzgWxdTcsrC5c8ieFR8IctR\n\tC8N3yUok6Ecw8ZfhNlQZy8gyt9Q282Fp3rxvOeacdh9K4DVbmk2eYbZMahehCen5Smu3\n\tKMkA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=YmgXMz78hUsPtSZQsnRSr/Y8vrfIv9p7qU5OaLfYxzI=;\n\tb=W8At1a9KmT4kLYXe8tYZ30NYasgpvQxyPRxTt1lChjZvHOWQXIVXQFi/44A7hWHzqu\n\tYh9OefAjmofarIYjNTQ9fIiJKz3UkfbKVnt4eUdmAXs4bsE+cD7AUdjgsTic/ZRJfFx5\n\tpAyqjfq6feWvfxHy37/5lz+DHV9QdZS+N57ndJhSscCBGcgtjK8KENU3L1uTGVWNWk9Z\n\ttD75yCJpxinFaHdwj3Y/Fsqo3Ao0+9aCleK7HXKH2TZ2zPpKd82aJeclPXtgBNDkqotw\n\tKDCMIkXCiYVEZlhLrFGdwGmwLEKL/5GEyuXMXxJIY1/FMiSOY5n9PU0iTEXAaQ7VFFpd\n\tUUVg==","X-Gm-Message-State":"APjAAAXYCCMUiSIdADg6x4Y/A13KOzjK1bJcLL3HfK9Kjsif1omDC4n7\n\tg39DKreeV/5H2JMfcN/PBfMc23T0dmE=","X-Google-Smtp-Source":"APXvYqx7ZRjLNL8qk6PzwNn5Oc9l56xgRBpZ1iNxoQfLIIyEIIEVrYwjbgf3BfX8wJo6Dm5rreEmfA==","X-Received":"by 2002:ac2:4218:: with SMTP id\n\ty24mr8324407lfh.148.1570354189605; \n\tSun, 06 Oct 2019 02:29:49 -0700 (PDT)","Date":"Sun, 6 Oct 2019 11:29:48 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191006092948.GA4726@bigcity.dyn.berto.se>","References":"<20191006053226.8976-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191006053226.8976-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 0/9] Timer fixes and enhancements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 06 Oct 2019 09:29:50 -0000"}}]