{"id":21048,"url":"https://patchwork.libcamera.org/api/covers/21048/?format=json","web_url":"https://patchwork.libcamera.org/cover/21048/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240829195703.1456614-1-chenghaoyang@chromium.org>","date":"2024-08-29T19:47:39","name":"[v10,0/7] Add VirtualPipelineHandler","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/21048/mbox/","series":[{"id":4547,"url":"https://patchwork.libcamera.org/api/series/4547/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4547","date":"2024-08-29T19:47:39","name":"Add VirtualPipelineHandler","version":10,"mbox":"https://patchwork.libcamera.org/series/4547/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21048/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1BA2C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 29 Aug 2024 19:57:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09C0763466;\n\tThu, 29 Aug 2024 21:57:09 +0200 (CEST)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8085963456\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 29 Aug 2024 21:57:07 +0200 (CEST)","by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-428141be2ddso9054315e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 29 Aug 2024 12:57:07 -0700 (PDT)","from chenghaoyang-germany.c.googlers.com.com\n\t(161.126.77.34.bc.googleusercontent.com. [34.77.126.161])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42ba7b4271fsm54602805e9.29.2024.08.29.12.57.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 29 Aug 2024 12:57:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Bm98l0or\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1724961426; x=1725566226;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=d/9iY2syyk3Sw0GzvPLhj2YTTqHRW4GwnT/xZoQBg5E=;\n\tb=Bm98l0orLWYWtWgK6NkDVkeI8LXFX7Ex6l2hZ5ZZXzrifGw1C13PjeT9Wh5Ea6Rcez\n\tkKfLU8VJQVPTm/f0NDa31wHJGGTxYz1gf8yMN16q/wRjZq9iA2IL7Xv7TQ2W+Dech7MT\n\thAKPzT220pHG6YDT8wgewRRGYstbhweV4PPlk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1724961426; x=1725566226;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=d/9iY2syyk3Sw0GzvPLhj2YTTqHRW4GwnT/xZoQBg5E=;\n\tb=eIsSlddfccn9GOGle6BgOBUy26U46MZIrv+BouXgbcv2XgjwLMPan248GOokQbQkng\n\tWgmVH+428rUJBdSesEwYMoDxCp63pWYsBMi92erqgGdaxETS5MNHTt8fcfbT8dl8RvsY\n\t3c2b/JxUm42oCJDHIBnVvumU2P2g3y3f4QeMMxahROQMdkDRcslNNTl5nGGBbXTTjNUe\n\tyULSqOoafpzfHILsm/KOqMaBaUBXxc2GZjPF/cOEuMQwVGD/KDK/KjzLMdJ4zDMRZLZP\n\t/1O5606knufy34dAJ5+GUt8NQCFSz602i+gjlp4q03Zjlz9P5LD7t1Hi3ZGMfmPgUrVN\n\t4HLw==","X-Gm-Message-State":"AOJu0YylSWKYqQeR8vKnjSQ2YnSXlIWP7ojvWHjTSAq6lwC6j6yRv+5A\n\tfgL02SA2CFn+bBoa0xw+6XXBHFwwL7pMbhJnK6VjfbjqjvMk725UD2MMk5VDxWoAxSZ/wBMuQ58\n\tz3Q==","X-Google-Smtp-Source":"AGHT+IHb6Pob0RnzAsX8FWpDqjAq//jUk95+MjE8SUzHZSw5Ul/QjwJdU/K/3I6CZ3fbKv7PWJECBQ==","X-Received":"by 2002:a05:600c:310b:b0:426:627d:5542 with SMTP id\n\t5b1f17b1804b1-42bb01e6c05mr33107385e9.28.1724961426361; \n\tThu, 29 Aug 2024 12:57:06 -0700 (PDT)","From":"Harvey Yang <chenghaoyang@chromium.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang <chenghaoyang@chromium.org>","Subject":"[PATCH v10 0/7] Add VirtualPipelineHandler","Date":"Thu, 29 Aug 2024 19:47:39 +0000","Message-ID":"<20240829195703.1456614-1-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.46.0.469.g59c65b2a67-goog","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi all,\n\nThis series adds virtual pipeline handler, which doesn't depend on any\nhardware, like camera sensor or ISP. Currently the configuration\nsupports test patterns and images.\n\nIt passed the gitlab pipeline:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1260567\n\nI failed to pass multi_stream_test when trying to enable multiple\nstreams though. Please give me some hints what it tests and what I\nmissed:\n```\n[295:43:43.910237144] [1441841]  INFO IPAManager ipa_manager.cpp:137 libcamera is not installed. Adding '/usr/local/google/home/chenghaoyang/Workspace/libca\nmera/build/src/ipa' to the IPA search path\n[295:43:43.914030564] [1441841]  INFO Camera camera_manager.cpp:325 libcamera v0.3.1+79-8ca4f033-dirty (2024-08-29T19:18:51UTC)\n[295:43:43.915493754] [1441844] ERROR DmaBufAllocator dma_buf_allocator.cpp:120 Could not open any dma-buf provider\n[295:43:43.919118835] [1441841]  INFO IPAManager ipa_manager.cpp:137 libcamera is not installed. Adding '/usr/local/google/home/chenghaoyang/Workspace/libca\nmera/build/src/ipa' to the IPA search path\n[295:43:43.922245825] [1441841]  INFO Camera camera_manager.cpp:325 libcamera v0.3.1+79-8ca4f033-dirty (2024-08-29T19:18:51UTC)\n[295:43:43.922820175] [1441846] ERROR DmaBufAllocator dma_buf_allocator.cpp:120 Could not open any dma-buf provider\nUnable to set the pipeline to the playing state.\n```\n\nGitlab pipeline failure:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1260412\n\n\nUpdate in v10:\nApply fixes according to Jacopo's and Barnabás' comments.\n- Split test_pattern and path fields in the yaml format.\n- Let FrameGenerators control frameCount_.\n- Fixed match() returning values.\n\nUpdate in v9: Allocate contiguous memory for planes in the same\nFrameBuffer.\n\nBR,\nHarvey\n\nHarvey Yang (4):\n  libcamera: add DmaBufAllocator::exportBuffers()\n  libcamera: Remove PipelineHandler Fatal check of non-empty\n    MediaDevices\n  libcamera: virtual: Add VirtualPipelineHandler\n  libcamera: software_isp: Refactor SoftwareIsp to use\n    DmaBufAllocator::exportBuffers\n\nKonami Shu (3):\n  libcamera: pipeline: Add test pattern for VirtualPipelineHandler\n  libcamera: virtual: Read config and register cameras based on the\n    config\n  libcamera: virtual: Add ImageFrameGenerator\n\n .../libcamera/internal/dma_buf_allocator.h    |  12 +\n meson.build                                   |   1 +\n meson_options.txt                             |   3 +-\n src/android/meson.build                       |  19 --\n src/libcamera/dma_buf_allocator.cpp           |  55 +++\n src/libcamera/pipeline/virtual/README.md      |  50 +++\n .../pipeline/virtual/data/virtual.yaml        |  37 ++\n .../pipeline/virtual/frame_generator.h        |  28 ++\n .../virtual/image_frame_generator.cpp         | 179 ++++++++++\n .../pipeline/virtual/image_frame_generator.h  |  54 +++\n src/libcamera/pipeline/virtual/meson.build    |  13 +\n src/libcamera/pipeline/virtual/parser.cpp     | 251 ++++++++++++++\n src/libcamera/pipeline/virtual/parser.h       |  44 +++\n .../virtual/test_pattern_generator.cpp        | 140 ++++++++\n .../pipeline/virtual/test_pattern_generator.h |  57 ++++\n src/libcamera/pipeline/virtual/utils.h        |  17 +\n src/libcamera/pipeline/virtual/virtual.cpp    | 317 ++++++++++++++++++\n src/libcamera/pipeline/virtual/virtual.h      | 107 ++++++\n src/libcamera/pipeline_handler.cpp            |  11 +-\n src/libcamera/software_isp/software_isp.cpp   |  20 +-\n src/meson.build                               |  19 ++\n 21 files changed, 1392 insertions(+), 42 deletions(-)\n create mode 100644 src/libcamera/pipeline/virtual/README.md\n create mode 100644 src/libcamera/pipeline/virtual/data/virtual.yaml\n create mode 100644 src/libcamera/pipeline/virtual/frame_generator.h\n create mode 100644 src/libcamera/pipeline/virtual/image_frame_generator.cpp\n create mode 100644 src/libcamera/pipeline/virtual/image_frame_generator.h\n create mode 100644 src/libcamera/pipeline/virtual/meson.build\n create mode 100644 src/libcamera/pipeline/virtual/parser.cpp\n create mode 100644 src/libcamera/pipeline/virtual/parser.h\n create mode 100644 src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n create mode 100644 src/libcamera/pipeline/virtual/test_pattern_generator.h\n create mode 100644 src/libcamera/pipeline/virtual/utils.h\n create mode 100644 src/libcamera/pipeline/virtual/virtual.cpp\n create mode 100644 src/libcamera/pipeline/virtual/virtual.h"}