[{"id":30652,"web_url":"https://patchwork.libcamera.org/comment/30652/","msgid":"<20240807085037.GC21319@pendragon.ideasonboard.com>","date":"2024-08-07T08:50:37","subject":"Re: [PATCH v1 0/2] Raspberrypi: Add support for IMX585","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Wed, Aug 07, 2024 at 09:03:42AM +0100, Naushir Patuck wrote:\n> Hi,\n> \n> This patch series, authored by Will Wang at https://github.com/raspberrypi/libcamera/pull/161,\n> adds support for the IMX585 sensor.\n> \n> I've made some minor formatting edits to the patches and commit messages, and\n> added the relevant sensor properties on top of his original patches.\n> \n> The accompanying Pi 5 support for this sensor will be added to our downstream\n> tree for now, and will be merged upstream together with the rest of the Pi 5\n> changes.\n\nlibcamera requires support for new devices in the ernel to be reasonably\non its way to upstream. This usually means that patches must be posted\nto appropriate public lists for review, in a state deemed fit for\nupstreaming.\n\n> will whang (2):\n> libcamera: formats: Adding Support for Y12P\n> ipa: rpi: Adding IMX585 + IMX585-mono support\n> \n> src/ipa/rpi/cam_helper/cam_helper_imx585.cpp | 75 ++++\n> src/ipa/rpi/cam_helper/meson.build | 1 +\n> src/ipa/rpi/vc4/data/imx585.json | 320 ++++++++++++++++++\n> src/ipa/rpi/vc4/data/imx585_mono.json | 180 ++++++++++\n> src/ipa/rpi/vc4/data/meson.build | 2 +\n> src/libcamera/bayer_format.cpp | 2 +\n> src/libcamera/formats.cpp | 10 +\n> src/libcamera/formats.yaml | 3 +\n> .../sensor/camera_sensor_properties.cpp | 4 +\n> src/libcamera/v4l2_pixelformat.cpp | 2 +\n> 10 files changed, 599 insertions(+)\n> create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx585.cpp\n> create mode 100644 src/ipa/rpi/vc4/data/imx585.json\n> create mode 100644 src/ipa/rpi/vc4/data/imx585_mono.json","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3682BE173\n\tfor ;\n\tWed, 7 Aug 2024 08:51:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF92E633AC;\n\tWed, 7 Aug 2024 10:51:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2775A63382\n\tfor ;\n\tWed, 7 Aug 2024 10:51:00 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3342F6AF;\n\tWed, 7 Aug 2024 10:50:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Kwt9qYAk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723020607;\n\tbh=ywjdfiBckCO7aVzXU8XryBhghEhDYw6YdcM1pZJ2KpI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Kwt9qYAkHmDcbG/e7bllQeEgkxacNurfMpa3KrwwcVtD+CcyUdSWIDv0z37yjArsY\n\tgTEnFGlr1wkIoM6vMsMrG7SRinJPFS3XntIoATrD6Zd86W7V2gm+qm1VKhopJxku+8\n\tYchLvjy4yR8EXQATDjhrdrOlYpMDg9YYzyu8br78=","Date":"Wed, 7 Aug 2024 11:50:37 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 0/2] Raspberrypi: Add support for IMX585","Message-ID":"<20240807085037.GC21319@pendragon.ideasonboard.com>","References":"<20240807080344.12780-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240807080344.12780-1-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30653,"web_url":"https://patchwork.libcamera.org/comment/30653/","msgid":"","date":"2024-08-07T09:00:26","subject":"Re: [PATCH v1 0/2] Raspberrypi: Add support for IMX585","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Wed, 7 Aug 2024 at 09:51, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> On Wed, Aug 07, 2024 at 09:03:42AM +0100, Naushir Patuck wrote:\n> > Hi,\n> >\n> > This patch series, authored by Will Wang at https://github.com/raspberrypi/libcamera/pull/161,\n> > adds support for the IMX585 sensor.\n> >\n> > I've made some minor formatting edits to the patches and commit messages, and\n> > added the relevant sensor properties on top of his original patches.\n> >\n> > The accompanying Pi 5 support for this sensor will be added to our downstream\n> > tree for now, and will be merged upstream together with the rest of the Pi 5\n> > changes.\n>\n> libcamera requires support for new devices in the ernel to be reasonably\n> on its way to upstream. This usually means that patches must be posted\n> to appropriate public lists for review, in a state deemed fit for\n> upstreaming.\n\nApologies, this is my mistake/confusion. Kieran did point this out in\nthe above PR. We needed to push IMX283 which is already available\nupstream, not IMX585!\n\nI will prepare a new series shortly.\n\nRegards,\nNaush\n\n>\n> > will whang (2):\n> > libcamera: formats: Adding Support for Y12P\n> > ipa: rpi: Adding IMX585 + IMX585-mono support\n> >\n> > src/ipa/rpi/cam_helper/cam_helper_imx585.cpp | 75 ++++\n> > src/ipa/rpi/cam_helper/meson.build | 1 +\n> > src/ipa/rpi/vc4/data/imx585.json | 320 ++++++++++++++++++\n> > src/ipa/rpi/vc4/data/imx585_mono.json | 180 ++++++++++\n> > src/ipa/rpi/vc4/data/meson.build | 2 +\n> > src/libcamera/bayer_format.cpp | 2 +\n> > src/libcamera/formats.cpp | 10 +\n> > src/libcamera/formats.yaml | 3 +\n> > .../sensor/camera_sensor_properties.cpp | 4 +\n> > src/libcamera/v4l2_pixelformat.cpp | 2 +\n> > 10 files changed, 599 insertions(+)\n> > create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx585.cpp\n> > create mode 100644 src/ipa/rpi/vc4/data/imx585.json\n> > create mode 100644 src/ipa/rpi/vc4/data/imx585_mono.json\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9054DC323E\n\tfor ;\n\tWed, 7 Aug 2024 09:01:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8746F61946;\n\tWed, 7 Aug 2024 11:00:59 +0200 (CEST)","from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com\n\t[IPv6:2607:f8b0:4864:20::1136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2F4E61946\n\tfor ;\n\tWed, 7 Aug 2024 11:00:56 +0200 (CEST)","by mail-yw1-x1136.google.com with SMTP id\n\t00721157ae682-64b417e1511so13014677b3.3\n\tfor ;\n\tWed, 07 Aug 2024 02:00:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Rbsd/lgD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1723021255; x=1723626055;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=pP8Oi1lJ3XGHHGNyOqPkFjWSI3ZZApPLJaHRxO39qp4=;\n\tb=Rbsd/lgDt4BeByb1dAzW4bkFmeq/glN3waEFAGVj9e8G1n3VR85AxnDrDQUewO3c/b\n\thFu7xQrDt8nCubl3v+SsBZzrG42CXfyukHwkNLATvaLYgy6UBc10gZnH1n3/vGJSZAXF\n\taCMFXIgSKd7Zw46G/1NDmCLdYy2iL0xOqyWjaMlzRkBF2wZwmsnLF/GQtJcp3tWuJhyE\n\t5me0i2oXod9ziwa3xzvkCzr+0rARYo7Lw6h3u837RrQDcUa9h8UvsBSdlGIpIrhoaYA4\n\tJXhhRyxKIeRzzuim5yBcunz8Bi0/VLgbxAZp+Y1e+F4DsgdDPGvzAbiFoeG/472EmGSp\n\tCn6Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1723021255; x=1723626055;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=pP8Oi1lJ3XGHHGNyOqPkFjWSI3ZZApPLJaHRxO39qp4=;\n\tb=g8lBghU91GXGDLYbTD52vpluh6mlQAlm0TsaW033s7dKD22ldNwpzDwdKZKqeRRfcK\n\t3edksD9PUzc7LOrBaQv19SoNbfB3s+eKS49JfHm0zNfvlZDoQnbXdcpP8B9cNoE7SYiC\n\t0lZZKdNCr67O5fKwmHo97zXYJPwhFUMgQt/w7GXp5sS5IDCqyfESdt6Q8FeJIR+hiNwr\n\tdlIIWSK0HyE/VRJowksVlxfKLzty2JLUW1XjzexpEow7STkB2HTLgNApzz6jgOhrtTgv\n\tZ1F8UtCZY7RwdzRIMRxilmwUNn3lOvkklo8q/4V0TayOTEBZawgwRJCMpxNx+brm8ALV\n\tW/hw==","X-Gm-Message-State":"AOJu0Yzn+SPfignarViPPiMSoayewv6Na6piSZlEYXHEKXfz52wbXcCP\n\ty9jofc4TCmoJHWQtZ41j/wF7WaIy7+lg5/6R4Ol1+bq7ftwS0ev0wdEMGnf+jM2ytOx5RHvkrCd\n\tFOjkYMo7otwnSndMBZJ6/4rhYMWDYKKgCu0F+yQ==","X-Google-Smtp-Source":"AGHT+IGnfgPjCDK7y76LOg7fnJ9j9yIY+g8Hnmy17vdtmJ9pX8XkHzLkNFtLoXLJo8brP4zliI7KM/+r8j4tgi9lpzU=","X-Received":"by 2002:a81:6e8b:0:b0:62f:37c9:77bc with SMTP id\n\t00721157ae682-6895a1e4c43mr205728867b3.0.1723021255196;\n\tWed, 07 Aug 2024 02:00:55 -0700 (PDT)","MIME-Version":"1.0","References":"<20240807080344.12780-1-naush@raspberrypi.com>\n\t<20240807085037.GC21319@pendragon.ideasonboard.com>","In-Reply-To":"<20240807085037.GC21319@pendragon.ideasonboard.com>","From":"Naushir Patuck ","Date":"Wed, 7 Aug 2024 10:00:26 +0100","Message-ID":"","Subject":"Re: [PATCH v1 0/2] Raspberrypi: Add support for IMX585","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]