[{"id":30527,"web_url":"https://patchwork.libcamera.org/comment/30527/","msgid":"<87ikwla9vd.fsf@redhat.com>","date":"2024-07-31T14:56:06","subject":"Re: [PATCH v2 0/4] libcamera: Address soft ISP file seal TODO item","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> Hello,\n>\n> This small series addresses one TODO item of the soft ISP, namely shrink\n> and grow sealing of the memfd underlying SharedMem objects.\n>\n> Patch 1/4 starts by sharing the memfd handling code between the\n> DmaBufAllocator and SharedMem classes by moving it to a new MemFd helper\n> class. Patch 2/4 then applies a suggestion from Nicolas to improve code\n> readability. Patch 3/4 addresses the TODO item, and patch 4/4 finally\n> drops it from the TODO file.\n>\n> Could someone test this with the soft ISP to make sure I haven't broken\n> anything ?\n\nTested-by: Milan Zamazal \n\n> Laurent Pinchart (4):\n> libcamera: base: Add MemFd helper class\n> libcamera: base: memfd: Handle uClibc compatibility with function\n> wrapper\n> libcamera: shared_mem_object: Prevent memfd from shrinking or growing\n> libcamera: software_isp: Remove file seal TODO item\n>\n> include/libcamera/base/memfd.h | 34 ++++++++\n> include/libcamera/base/meson.build | 1 +\n> src/libcamera/base/memfd.cpp | 123 ++++++++++++++++++++++++++++\n> src/libcamera/base/meson.build | 1 +\n> src/libcamera/dma_buf_allocator.cpp | 46 +----------\n> src/libcamera/shared_mem_object.cpp | 22 ++---\n> src/libcamera/software_isp/TODO | 19 -----\n> 7 files changed, 169 insertions(+), 77 deletions(-)\n> create mode 100644 include/libcamera/base/memfd.h\n> create mode 100644 src/libcamera/base/memfd.cpp\n>\n>\n> base-commit: 98b01768397f982bd177b55e9bc67002b645b4d0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03252BDC71\n\tfor ;\n\tWed, 31 Jul 2024 14:56:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F14363374;\n\tWed, 31 Jul 2024 16:56:14 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD5876198E\n\tfor ;\n\tWed, 31 Jul 2024 16:56:12 +0200 (CEST)","from mail-ej1-f72.google.com (mail-ej1-f72.google.com\n\t[209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-52-YvU_JeLnO3-wyzl0z2eweg-1; Wed, 31 Jul 2024 10:56:09 -0400","by mail-ej1-f72.google.com with SMTP id\n\ta640c23a62f3a-a7ab4817f34so506185766b.2\n\tfor ;\n\tWed, 31 Jul 2024 07:56:09 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a7acadb97e0sm780598466b.210.2024.07.31.07.56.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 31 Jul 2024 07:56:07 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"GFvBAsJF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1722437771;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=tQK8LpOctg4CDONlxxsDGluwgP40HLbnYDtcA5Fo9rA=;\n\tb=GFvBAsJFh67OKuR0Ow/wrdr/wGT3jXWcu+6IvaoKhPUD9DDuokoZvPbHd7mthFdLaGzROC\n\tDh2Xa/b1XqRrNaw3LNMJ5hIXF9EPsuJuQf+s8caDWrWg8WbY/sGFnM8Ba/xjcOycrlVQ1N\n\tJMAEk89cLPV4voyjosBu0n5X1kJGQnk=","X-MC-Unique":"YvU_JeLnO3-wyzl0z2eweg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1722437768; x=1723042568;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=tQK8LpOctg4CDONlxxsDGluwgP40HLbnYDtcA5Fo9rA=;\n\tb=Y8L5zOVZmyRX33Rfl2SuQ5Xl6QyIos0UMwVetrfHXPcbUtEid1lkEs6Y2NOfw+uYLr\n\tQ35LRD+HJPsj/cKrEGPj9qf+Tb1fgq5siXKlH/VtXYb50ip0tTrsAzzCJ3pWR+M2VA4X\n\tujsdBsGGbRD/raZiXr6zvb9c/ud8XSeWe7GmVCf9QM3XmqVAXNnLflFtxHPjG4qpfezf\n\t8Dy5+sYT/8q+SPyVppDXtzOP1hCsd93L5oHm80GI628q/i82h0zBJz6RcjHo6h8BG8h1\n\tdNkF3m4gk92zs+wAMO0TvS++Dq84YyzorajVSfkrk1edn6JqXuJo6cJuCgbCzlzUoEEb\n\tBNig==","X-Gm-Message-State":"AOJu0YxCR//Y/kUoKpCB9jgIUCKeJI/SBto9kmKuYC0m9OfmnaceZB8Q\n\teK09pZo+6BmZvFhcFpmUXKTe14WLMPdiPsQowbX8eMNoqjdkO5Hv1fqUg9tt+iDohy7mNh0UDmv\n\tfTKa/Gd/evuP760O/eyvbWcz5idFPyYb6XA901e+Q4/OcZd9DVHBQ3p8x2ceDP8D1E86WynHTj5\n\tCyYEqJ1ou/b+uyhD2OBaPiUNa2hq5a3EP1/al2gCYVMA7Gepg4p2DPPF0=","X-Received":["by 2002:a17:907:9802:b0:a7a:c106:364f with SMTP id\n\ta640c23a62f3a-a7d4016615bmr983102266b.43.1722437768341; \n\tWed, 31 Jul 2024 07:56:08 -0700 (PDT)","by 2002:a17:907:9802:b0:a7a:c106:364f with SMTP id\n\ta640c23a62f3a-a7d4016615bmr983100566b.43.1722437767861; \n\tWed, 31 Jul 2024 07:56:07 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGS8cBydnWMoMIXOqdoHeXg5Jsje/wI+x/NjnbkMbCEVI8YzpE6jSpYC8U/clYyOUydZbOBHQ==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 0/4] libcamera: Address soft ISP file seal TODO item","In-Reply-To":"<20240731135936.2105-1-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Wed, 31 Jul 2024 16:59:32 +0300\")","References":"<20240731135936.2105-1-laurent.pinchart@ideasonboard.com>","Date":"Wed, 31 Jul 2024 16:56:06 +0200","Message-ID":"<87ikwla9vd.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30530,"web_url":"https://patchwork.libcamera.org/comment/30530/","msgid":"<7f16ea24-b33b-4cc3-a1ae-b122118e596c@redhat.com>","date":"2024-07-31T18:58:32","subject":"Re: [PATCH v2 0/4] libcamera: Address soft ISP file seal TODO item","submitter":{"id":102,"url":"https://patchwork.libcamera.org/api/people/102/","name":"Hans de Goede","email":"hdegoede@redhat.com"},"content":"Hi,\n\nOn 7/31/24 3:59 PM, Laurent Pinchart wrote:\n> Hello,\n> \n> This small series addresses one TODO item of the soft ISP, namely shrink\n> and grow sealing of the memfd underlying SharedMem objects.\n> \n> Patch 1/4 starts by sharing the memfd handling code between the\n> DmaBufAllocator and SharedMem classes by moving it to a new MemFd helper\n> class. Patch 2/4 then applies a suggestion from Nicolas to improve code\n> readability. Patch 3/4 addresses the TODO item, and patch 4/4 finally\n> drops it from the TODO file.\n> \n> Could someone test this with the soft ISP to make sure I haven't broken\n> anything ?\n\nI have given this a test on an IPU6 system and everything still works:\n\nTested-by: Hans de Goede \n\nRegards,\n\nHans\n\n\n\n\n> \n> Laurent Pinchart (4):\n> libcamera: base: Add MemFd helper class\n> libcamera: base: memfd: Handle uClibc compatibility with function\n> wrapper\n> libcamera: shared_mem_object: Prevent memfd from shrinking or growing\n> libcamera: software_isp: Remove file seal TODO item\n> \n> include/libcamera/base/memfd.h | 34 ++++++++\n> include/libcamera/base/meson.build | 1 +\n> src/libcamera/base/memfd.cpp | 123 ++++++++++++++++++++++++++++\n> src/libcamera/base/meson.build | 1 +\n> src/libcamera/dma_buf_allocator.cpp | 46 +----------\n> src/libcamera/shared_mem_object.cpp | 22 ++---\n> src/libcamera/software_isp/TODO | 19 -----\n> 7 files changed, 169 insertions(+), 77 deletions(-)\n> create mode 100644 include/libcamera/base/memfd.h\n> create mode 100644 src/libcamera/base/memfd.cpp\n> \n> \n> base-commit: 98b01768397f982bd177b55e9bc67002b645b4d0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F7CABDC71\n\tfor ;\n\tWed, 31 Jul 2024 18:58:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F81063374;\n\tWed, 31 Jul 2024 20:58:42 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6B3B6198E\n\tfor ;\n\tWed, 31 Jul 2024 20:58:40 +0200 (CEST)","from mail-ed1-f69.google.com (mail-ed1-f69.google.com\n\t[209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-647-RYhe7HLGPhSYUF2gwAF0gQ-1; Wed, 31 Jul 2024 14:58:35 -0400","by mail-ed1-f69.google.com with SMTP id\n\t4fb4d7f45d1cf-5a534faa028so5840195a12.0\n\tfor ;\n\tWed, 31 Jul 2024 11:58:35 -0700 (PDT)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-5b2d0b878b2sm4504222a12.85.2024.07.31.11.58.33\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 31 Jul 2024 11:58:33 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"QVBFDIC6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1722452319;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=KkF7nZ+1R79Tnca5SGKYJujLPsq6SamxWc397s37ER4=;\n\tb=QVBFDIC6GgeFrxo4+S0uUUHdYdAWW3w4uqDy0JBCorJP3MgrHAIed9j5Uc3gMM6OnvJe1p\n\talJYwK5KzJYVl92M+o1Av1ohFjt8RzVarvyiAdVKVwnSk6dnpr9zTMwS03gUXrFirRQArw\n\tIxaF/2pE/MOQZVTXeM9FwNAK661yoXw=","X-MC-Unique":"RYhe7HLGPhSYUF2gwAF0gQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1722452314; x=1723057114;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=KkF7nZ+1R79Tnca5SGKYJujLPsq6SamxWc397s37ER4=;\n\tb=EozW2rzANJXqdeqq7ICvt9iUR0qkWQK3BInhS9cgcb37zbwHtTBCZi/bn2JFT/FSvH\n\tDmlN+l4z/8oggpz6AVHeW/VCZ1EBESjjjnlJgN2gztThn1ROpGk7BNW7Dw01znXuMp2Z\n\tJo/kdWWuuyP/gcV/gBQ9ONfSp0IvnWMzWKO5DXCRBIq//OEX8hfHR/rXCrlpaPDfQ9Yv\n\tbxx5Q+z5dPqGRUuxprqgyMBSn1uJCgaAfTC3XjAWu5O9W1TI0smnQazbQMIUOZQedUT5\n\t5RfuvwQCD6egg+dzuc9p69T4ybZhVLk4r5SWc1b8WNmKSDGVpE04d73TtJ1xgmSX9H+e\n\tpaJg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWlzgpA+fZ2dMYPhlVo6Z8KhasCiHdLgkJS+7vq5D2+U5qvaqO4YvAT8bMUfEV7G43Bg0jpA1usb5V3DIT6c2VFFRelM5HRemd0zOeiUeHVHoBdyg==","X-Gm-Message-State":"AOJu0YzRMMzPvhlnsBa8g2ybAgEn35CGVGQPwdE8V2ti43Q0GpY/XOk0\n\ttEFLDRyZjGmbWn6GMKHwKeM4L6otE/CddV0NyXvPUpweFgb3IWmjGtlmm8+ANfz6PlBJeFwLsMO\n\tSeB1MOeP6zC750/2sltp8bk4NuCFPT62lVewrc5Ri9IejUCTsZBAzWIHIL9o2BuGU1lLzunCywD\n\toC9f19jA==","X-Received":["by 2002:a05:6402:4303:b0:5a0:c69e:56a with SMTP id\n\t4fb4d7f45d1cf-5b02000c81fmr11673670a12.3.1722452314217; \n\tWed, 31 Jul 2024 11:58:34 -0700 (PDT)","by 2002:a05:6402:4303:b0:5a0:c69e:56a with SMTP id\n\t4fb4d7f45d1cf-5b02000c81fmr11673656a12.3.1722452313824; \n\tWed, 31 Jul 2024 11:58:33 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGb//0dPr3ELLJRdpUP8Hn+8ZVA8p8TjSS+Hlbbvcq41vAToh4RKXW0jqvddjOn830mfkPiOg==","Message-ID":"<7f16ea24-b33b-4cc3-a1ae-b122118e596c@redhat.com>","Date":"Wed, 31 Jul 2024 20:58:32 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 0/4] libcamera: Address soft ISP file seal TODO item","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240731135936.2105-1-laurent.pinchart@ideasonboard.com>","From":"Hans de Goede ","In-Reply-To":"<20240731135936.2105-1-laurent.pinchart@ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US, nl","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]